Re: BUG: unable to handle kernel NULL pointer dereference, i915_gem_object_move_to_active

2010-05-06 Thread Andrew Morton
(cc dri-devel) On Wed, 5 May 2010 00:22:16 +0200 Nils Radtke l...@think-future.de wrote: Hi, It happens quite often that X crashes for unknown reasons but this time there it's left us a note, this BUG: BUG: unable to handle kernel NULL pointer dereference at 01e4 IP: [c134ddbc]

Re: DRM Error on Acer Aspire One

2010-05-11 Thread Andrew Morton
On Wed, 12 May 2010 08:22:49 +1000 Dave Airlie airl...@gmail.com wrote: On Wed, May 12, 2010 at 5:57 AM, Chris Wilson ch...@chris-wilson.co.uk wrote: On Tue, 11 May 2010 12:10:01 -0700, Andrew Morton a...@linux-foundation.org wrote: On Tue, 11 May 2010 19:52:31 +0100 Chris Wilson ch

Re: [Bug 16148] page allocation failure. order:1, mode:0x50d0

2010-06-15 Thread Andrew Morton
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). (switching back to email, actually) On Sun, 13 Jun 2010 13:01:57 GMT bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=16148 Mikko C. mikko@gmail.com

Re: Report for 2.6.35-rc3-00262-g984bc96

2010-07-06 Thread Andrew Morton
On Thu, 1 Jul 2010 09:40:52 +0200 Nico Schottelius nico-linux-2010-07...@schottelius.org wrote: Good morning! A short report on what's broken in 2.6.35-rc3-00262-g984bc96 with the Lenovo X201: So you see two post-2.6.34 regressions? == xrandr == After using xrandr several times in

Re: [Bugme-new] [Bug 16488] New: [i915] Framebuffer ID error after suspend/hibernate leading to X crash

2010-08-02 Thread Andrew Morton
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Sun, 1 Aug 2010 08:55:49 GMT bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=16488 Innocuous-looking one-liner is said to have made Milan's X server

Re: regression in 2.6.35.4 'load is to heavy (video subsystem?)'

2010-09-21 Thread Andrew Morton
On Mon, 30 Aug 2010 10:02:36 +0200 Karsten Mehrhoff kaw...@gmx.de wrote: Using the same .config from 2.6.35.3 to compile 2.5.36.4 results in a heavy load with 2.6.35.4. A regression within -stable is rather bad. Example: Difference between 2.6.35.1/2/3 and 2.6.35.4 while watching some

Re: idr_remove called for id=0 which is not allocated

2010-09-22 Thread Andrew Morton
On Wed, 22 Sep 2010 23:10:10 +0200 Alessandro Guido a...@alessandroguido.name wrote: I have this traces in my logs (full dmesg attached). idr_remove called for id=0 which is not allocated. Pid: 1136, comm: Xorg Not tainted 2.6.36-rc5-49-gc79bd89 #1 Call Trace: [c1379e16] ?

Re: DRM-related kmalloc-32 memory leak in 2.6.35

2010-09-27 Thread Andrew Morton
On Wed, 25 Aug 2010 15:59:09 -0500 Matt Mackall m...@selenic.com wrote: On Tue, 2010-08-24 at 10:37 -0500, Christoph Lameter wrote: On Tue, 24 Aug 2010, Matt Mackall wrote: kmalloc-321113344 1113344 32 1281 : tunables00 0 : slabdata 8698 8698 0

Re: [PATCH] drm: Prune GEM vma entries

2010-09-27 Thread Andrew Morton
That was quick, thanks. On Mon, 27 Sep 2010 21:08:36 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: Hook the GEM vm open/close ops into the generic drm vm open/close so that the vma entries are created and destroy appropriately. Please update the changelog to indicate that it fixes a

Re: [PATCH RESEND] drm: include missing types header to drm_mode.h

2010-10-22 Thread Andrew Morton
On Fri, 22 Oct 2010 10:13:19 -0300 Davidlohr Bueso d...@gnu.org wrote: drm: include missing types header to drm_mode.h Signed-off-by: Davidlohr Bueso d...@gnu.org --- include/drm/drm_mode.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/drm/drm_mode.h

Re: [PATCH 1/5] Backlight: Add backlight type

2010-11-19 Thread Andrew Morton
On Fri, 19 Nov 2010 10:53:52 -0500 Matthew Garrett m...@redhat.com wrote: There may be multiple ways of controlling the backlight on a given machine. Allow drivers to expose the type of interface they are providing, making it possible for userspace to make appropriate policy decisions. ...

Re: [PATCH 1/5] Backlight: Add backlight type

2010-11-19 Thread Andrew Morton
On Fri, 19 Nov 2010 20:25:59 + Matthew Garrett mj...@srcf.ucam.org wrote: On Fri, Nov 19, 2010 at 12:05:23PM -0800, Andrew Morton wrote: On Fri, 19 Nov 2010 10:53:52 -0500 Matthew Garrett m...@redhat.com wrote: There may be multiple ways of controlling the backlight on a given

Re: [PATCH 1/4] drm: fix headers to include linux/types.h

2010-12-01 Thread Andrew Morton
On Wed, 1 Dec 2010 17:54:18 +0100 Julien Cristau jcris...@debian.org wrote: On Wed, Dec 1, 2010 at 17:10:42 +0200, Alexander Shishkin wrote: For headers that get exported to userland and make use of u32 style type names, it is advised to include linux/types.h. This fixes 5

Re: [PATCH 3/5] radeon: Expose backlight class device for legacy LVDS encoder

2011-01-19 Thread Andrew Morton
On Fri, 14 Jan 2011 14:24:23 -0500 Matthew Garrett m...@redhat.com wrote: From: Michel D__nzer mic...@daenzer.net Allows e.g. power management daemons to control the backlight level. Inspired by the corresponding code in radeonfb. (Updated to add backlight type and make the connector the

Re: [PATCH] change acquire/release_console_sem() to console_lock/unlock()

2011-01-20 Thread Andrew Morton
On Thu, 20 Jan 2011 17:55:02 +0100 torbenh torb...@gmx.de wrote: On Thu, Jan 20, 2011 at 08:34:48AM -0800, Greg KH wrote: On Thu, Jan 20, 2011 at 04:58:13PM +0100, Torben Hohn wrote: the -rt patches change the console_semaphore to console_mutex. so a quite large chunk of the patches

Re: [Intel-gfx] [PATCH 2/5] i915: Add native backlight control

2011-01-20 Thread Andrew Morton
On Fri, 21 Jan 2011 00:43:59 + Matthew Garrett mj...@srcf.ucam.org wrote: On Thu, Jan 20, 2011 at 03:13:49PM -0800, Andrew Morton wrote: On Fri, 21 Jan 2011 00:43:46 +0330 Ali Gholami Rudi aliqr...@gmail.com wrote: Ali Gholami Rudi aliqr...@gmail.com wrote: I tried to apply

Re: [Intel-gfx] [PATCH 2/5] i915: Add native backlight control

2011-01-20 Thread Andrew Morton
On Fri, 21 Jan 2011 06:36:54 +0100 Sedat Dilek sedat.di...@googlemail.com wrote: ( Original posting from [1] ) I have the backlight-type patchset for months in my patch-series (and maintained them if necessary against daily linux-next). Also the last series from 14-Jan-2011 (see 1-5 patch

Re: [PATCH] change acquire/release_console_sem() to console_lock/unlock()

2011-01-21 Thread Andrew Morton
On Fri, 21 Jan 2011 09:10:06 +0100 Geert Uytterhoeven ge...@linux-m68k.org wrote: include/linux/mutex.h: /* * NOTE: mutex_trylock() follows the spin_trylock() convention, * not the down_trylock() convention! * * Returns 1 if the mutex has been acquired successfully, and 0 on

Re: [2.6.38-rc6] G965: i915 Hangcheck timer elapsed... GPU hung (not reproducible)

2011-03-02 Thread Andrew Morton
(cc dri-devel) A post-2.6.37 regression. On Sun, 27 Feb 2011 10:10:41 +0100 Paolo Ornati orn...@gmail.com wrote: Today I got this while starting a video in SMplayer (MPlayer) with 2.6.38-rc6-00113-g4662db4: [ 830.880014] [drm:i915_hangcheck_elapsed] *ERROR* Hangcheck timer elapsed...

Re: 2.6.37.2 : Font corruption and [drm:i915_gem_object_unbind] *ERROR* Attempting to unbind pinned buffer

2011-03-02 Thread Andrew Morton
(cc dri-devel) On Mon, 28 Feb 2011 12:26:08 +0100 Paul Rolland r...@as2917.net wrote: Hello, I'm using 2.6.37.2 and I'm getting loads of this error in my messages, while at the same time I can observe font display corruption in a GTK application (Claws-Mail) while running X, compiz and

Re: + drivers-base-platformc-dont-mark-platform_device_register_resndata-as-__init_or_module.patch added to -mm tree

2011-05-19 Thread Andrew Morton
On Thu, 19 May 2011 08:21:36 +0200 Uwe Kleine-König u.kleine-koe...@pengutronix.de wrote: I'm not sure that the things that radeon_cp_init does are sane. Some more details here might help someone fix it. Maybe add a comment that it is the only known stopper to make

Re: [PATCH] drm: avoid switching to text console if there is no panic timeout

2011-11-10 Thread Andrew Morton
Cc: Dave Airlie airl...@redhat.com Cc: Andrew Morton a...@linux-foundation.org Cc: dri-devel@lists.freedesktop.org Acked-by: David Rientjes rient...@google.com Dave, where do we stand on this? I haven't seen it hit Linus' tree and I don't see it in git

Re: 3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Andrew Morton
References : https://lkml.org/lkml/2011/11/12/11 Andrea's patch already fixes this issue, which was reported first by Jiri Slaby. https://lkml.org/lkml/2011/11/11/93 I remember Andrew Morton taking this patch in his -mm tree. But it is not in mainline yet. So can we consider this closed

Re: [PATCH] mm: extend prefault helpers to fault in more than PAGE_SIZE

2012-02-23 Thread Andrew Morton
On Thu, 16 Feb 2012 13:01:36 +0100 Daniel Vetter daniel.vet...@ffwll.ch wrote: drm/i915 wants to read/write more than one page in its fastpath and hence needs to prefault more than PAGE_SIZE bytes. I've checked the callsites and they all already clamp size when calling fault_in_pages_* to

Re: [PATCH] mm: extend prefault helpers to fault in more than PAGE_SIZE

2012-02-24 Thread Andrew Morton
On Fri, 24 Feb 2012 14:34:31 +0100 Daniel Vetter dan...@ffwll.ch wrote: --- a/include/linux/pagemap.h +++ b/include/linux/pagemap.h @@ -408,6 +408,7 @@ extern void add_page_wait_queue(struct page *page, wait_queue_t *waiter); static inline int fault_in_pages_writeable(char __user

Re: [PATCH] mm: extend prefault helpers to fault in more than PAGE_SIZE

2012-02-29 Thread Andrew Morton
* to the same as for the subsequent __copy_to|from_user and hence don't rely on the implicit clamping to PAGE_SIZE. Also kill a copypasted spurious space in both functions while at it. v2: As suggested by Andrew Morton, add a multipage parameter to both functions to avoid the additional branch

Re: [PATCH] mm: extend prefault helpers to fault in more than PAGE_SIZE

2012-02-29 Thread Andrew Morton
On Thu, 1 Mar 2012 00:14:53 +0100 Daniel Vetter dan...@ffwll.ch wrote: I'll redo this patch by adding _multipage versions of these 2 functions for i915. OK, but I hope for i915 doesn't mean private to! Put 'em in pagemap.h, for maintenance reasons and because they are generic. Making them

Re: [PATCH] mm: extend prefault helpers to fault in more than PAGE_SIZE

2012-03-01 Thread Andrew Morton
On Thu, 1 Mar 2012 20:22:59 +0100 Daniel Vetter daniel.vet...@ffwll.ch wrote: drm/i915 wants to read/write more than one page in its fastpath and hence needs to prefault more than PAGE_SIZE bytes. Add new functions in filemap.h to make that possible. Also kill a copypasted spurious space

Re: [PATCH v3] scatterlist: add sg_alloc_table_from_pages function

2012-05-17 Thread Andrew Morton
On Tue, 08 May 2012 11:50:33 +0200 Tomasz Stanislawski t.stanisl...@samsung.com wrote: This patch adds a new constructor for an sg table. The table is constructed from an array of struct pages. All contiguous chunks of the pages are merged into a single sg nodes. A user may provide an offset

Re: [PATCH v3] scatterlist: add sg_alloc_table_from_pages function

2012-05-22 Thread Andrew Morton
On Mon, 21 May 2012 16:01:50 +0200 Tomasz Stanislawski t.stanisl...@samsung.com wrote: +int sg_alloc_table_from_pages(struct sg_table *sgt, + struct page **pages, unsigned int n_pages, + unsigned long offset, unsigned long size, + gfp_t gfp_mask) I guess a 32-bit n_pages is OK. A

Re: [PATCH] backlight: initialize struct backlight_properties properly

2012-05-22 Thread Andrew Morton
On Mon, 21 May 2012 09:24:35 +0200 Corentin Chary corentin.ch...@gmail.com wrote: In all these files, the .power field was never correctly initialized. ... --- a/drivers/gpu/drm/i915/intel_panel.c +++ b/drivers/gpu/drm/i915/intel_panel.c @@ -342,6 +342,7 @@ int

Re: linux-next: Tree for Nov 14 (gpu/drm/i915)

2012-11-14 Thread Andrew Morton
On Wed, 14 Nov 2012 11:41:49 -0800 Randy Dunlap rdun...@infradead.org wrote: On 11/13/2012 09:30 PM, Stephen Rothwell wrote: Hi all, News: next-20121115 (i.e. tomorrow) will be the last release until next-20121126 (which should be just be after -rc7, I guess - assuming that Linus

Re: [git pull] fbcon locking fixes.

2013-01-24 Thread Andrew Morton
On Fri, 25 Jan 2013 00:42:37 + (GMT) Dave Airlie airl...@linux.ie wrote: These patches have been sailing around long enough, waiting for a maintainer to reappear, so I've decided enough is enough, lockdep is kinda useful to have. Thanks to Daniel for annoying me enough :-) Me too, but

[PATCH v2 1/2] mm: fix cache mode of dax pmd mappings

2016-09-08 Thread Andrew Morton
) does > not. So, teach track_pfn_insert() and untrack_pfn() how to handle > tracking without a vma, and arrange for devm_memremap_pages() to > establish the write-back-cache reservation in the memtype tree. Acked-by: Andrew Morton I'll grab [2/2].

[PATCH v4 00/13] Support non-lru page migration

2016-04-27 Thread Andrew Morton
On Wed, 27 Apr 2016 16:48:13 +0900 Minchan Kim wrote: > Recently, I got many reports about perfermance degradation in embedded > system(Android mobile phone, webOS TV and so on) and easy fork fail. > > The problem was fragmentation caused by zram and GPU driver mainly. > With memory pressure,

[PATCH v7 00/12] Support non-lru page migration

2016-06-01 Thread Andrew Morton
On Wed, 1 Jun 2016 08:21:09 +0900 Minchan Kim wrote: > Recently, I got many reports about perfermance degradation in embedded > system(Android mobile phone, webOS TV and so on) and easy fork fail. > > The problem was fragmentation caused by zram and GPU driver mainly. > With memory pressure,

[PATCH] tree-wide: replace config_enabled() with IS_ENABLED()

2016-06-07 Thread Andrew Morton
On Mon, 6 Jun 2016 21:20:56 +0900 Masahiro Yamada wrote: > The use of config_enabled() against config options is ambiguous. > In practical terms, config_enabled() is equivalent to IS_BUILTIN(), > but the author might have used it for the meaning of IS_ENABLED(). > Using IS_ENABLED(),

[RFC 00/10] implement alternative and much simpler id allocator

2016-12-09 Thread Andrew Morton
On Thu, 8 Dec 2016 02:22:55 +0100 Rasmus Villemoes wrote: > TL;DR: these patches save 250 KB of memory, with more low-hanging > fruit ready to pick. > > While browsing through the lib/idr.c code, I noticed that the code at > the end of ida_get_new_above() probably doesn't work as intended:

[PATCH] fbdev: remove current maintainer

2016-12-15 Thread Andrew Morton
On Thu, 8 Dec 2016 10:34:12 +0200 Tomi Valkeinen wrote: > Remove Tomi Valkeinen from fbdev maintainer and mark fbdev as orphan. > > ... > > I just don't have time to even pretend I maintain fbdev, so mark it as Orphan. > > Anyone want to pick fbdev maintainership? I'll keep an eye on the

[PATCH] fbdev: remove current maintainer

2016-12-19 Thread Andrew Morton
On Mon, 19 Dec 2016 14:34:12 +0100 Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Thursday, December 15, 2016 12:12:52 PM Andrew Morton wrote: > > On Thu, 8 Dec 2016 10:34:12 +0200 Tomi Valkeinen > > wrote: > > > > > Remove Tomi Valkeinen from fb

[PATCH 28/83] mm: Change timing of notification to IOMMUs about a page to be invalidated

2014-07-10 Thread Andrew Morton
On Fri, 11 Jul 2014 00:53:26 +0300 Oded Gabbay wrote: > From: Andrew Lewycky > > This patch changes the location of the mmu_notifier_invalidate_page function > call inside try_to_unmap_one. The mmu_notifier_invalidate_page function > call tells the IOMMU that a pgae should be invalidated. > >

[PATCH] list: Fix order of arguments for hlist_add_after(_rcu)

2014-06-07 Thread Andrew Morton
On Fri, 6 Jun 2014 10:22:51 -0700 "Paul E. McKenney" wrote: > On Fri, Jun 06, 2014 at 03:56:52PM +, David Laight wrote: > > From: Behalf Of Ken Helias > > > All other add functions for lists have the new item as first argument and > > > the > > > position where it is added as second

[Bug 87891] New: kernel BUG at mm/slab.c:2625!

2014-11-11 Thread Andrew Morton
ing to go BUG when the code could easily warn and fix it up. And it's quite infuriating to go BUG because one of the bits was set, but not tell us which bit it was! Could the slab guys please review this? From: Andrew Morton <a...@linux-foundation.org> Subject: slab: improve checking for in

[Bug 87891] New: kernel BUG at mm/slab.c:2625!

2014-11-11 Thread Andrew Morton
On Tue, 11 Nov 2014 18:36:28 -0600 (CST) Christoph Lameter wrote: > On Tue, 11 Nov 2014, Andrew Morton wrote: > > > There's no point in doing > > > > #define GFP_SLAB_BUG_MASK (__GFP_DMA32|__GFP_HIGHMEM|~__GFP_BITS_MASK) > > > > because __GFP_

[Bug 87891] New: kernel BUG at mm/slab.c:2625!

2014-11-11 Thread Andrew Morton
On Wed, 12 Nov 2014 09:44:19 +0900 Joonsoo Kim wrote: > > > > And it's quite infuriating to go BUG when the code could easily warn > > and fix it up. > > If user wants memory on HIGHMEM, it can be easily fixed by following > change because all memory is compatible for HIGHMEM. But, if user

[Bug 87891] New: kernel BUG at mm/slab.c:2625!

2014-11-11 Thread Andrew Morton
On Wed, 12 Nov 2014 00:54:01 + Luke Dashjr wrote: > On Wednesday, November 12, 2014 12:49:13 AM Andrew Morton wrote: > > But anyway - Luke, please attach your .config to > > https://bugzilla.kernel.org/show_bug.cgi?id=87891? > > Done: https://bugzilla.kernel.org/att

[Bug 87891] New: kernel BUG at mm/slab.c:2625!

2014-11-11 Thread Andrew Morton
On Wed, 12 Nov 2014 10:22:45 +0900 Joonsoo Kim wrote: > On Tue, Nov 11, 2014 at 05:02:43PM -0800, Andrew Morton wrote: > > On Wed, 12 Nov 2014 00:54:01 + Luke Dashjr wrote: > > > > > On Wednesday, November 12, 2014 12:49:13 AM Andrew Morton wrote: > > > &

[Bug 87891] New: kernel BUG at mm/slab.c:2625!

2014-11-11 Thread Andrew Morton
On Wed, 12 Nov 2014 03:47:03 +0200 "Kirill A. Shutemov" wrote: > On Wed, Nov 12, 2014 at 03:22:41AM +0200, Kirill A. Shutemov wrote: > > On Tue, Nov 11, 2014 at 04:49:13PM -0800, Andrew Morton wrote: > > > On Tue, 11 Nov 2014 18:36:28 -0600 (CST) Christoph L

[Bug 87891] New: kernel BUG at mm/slab.c:2625!

2014-11-11 Thread Andrew Morton
On Wed, 12 Nov 2014 13:08:55 +0900 Tetsuo Handa wrote: > Andrew Morton wrote: > > Poor ttm guys - this is a bit of a trap we set for them. > > Commit a91576d7916f6cce (\"drm/ttm: Pass GFP flags in order to avoid > deadlock.\") > changed to use sc-&

[PATCH] mm: extend prefault helpers to fault in more than PAGE_SIZE

2012-03-01 Thread Andrew Morton
On Thu, 1 Mar 2012 20:22:59 +0100 Daniel Vetter wrote: > drm/i915 wants to read/write more than one page in its fastpath > and hence needs to prefault more than PAGE_SIZE bytes. > > Add new functions in filemap.h to make that possible. > > Also kill a copy spurious space in both functions

[PATCH v3] scatterlist: add sg_alloc_table_from_pages function

2012-05-22 Thread Andrew Morton
On Mon, 21 May 2012 16:01:50 +0200 Tomasz Stanislawski wrote: > >> +int sg_alloc_table_from_pages(struct sg_table *sgt, > >> + struct page **pages, unsigned int n_pages, > >> + unsigned long offset, unsigned long size, > >> + gfp_t gfp_mask) > > > > I guess a 32-bit n_pages is OK. A 16TB IO

[PATCH] backlight: initialize struct backlight_properties properly

2012-05-22 Thread Andrew Morton
On Mon, 21 May 2012 09:24:35 +0200 Corentin Chary wrote: > In all these files, the .power field was never correctly initialized. > > ... > > --- a/drivers/gpu/drm/i915/intel_panel.c > +++ b/drivers/gpu/drm/i915/intel_panel.c > @@ -342,6 +342,7 @@ int intel_panel_setup_backlight(struct

linux-next: Tree for Nov 14 (gpu/drm/i915)

2012-11-14 Thread Andrew Morton
On Wed, 14 Nov 2012 11:41:49 -0800 Randy Dunlap wrote: > On 11/13/2012 09:30 PM, Stephen Rothwell wrote: > > > Hi all, > > > > News: next-20121115 (i.e. tomorrow) will be the last release until > > next-20121126 (which should be just be after -rc7, I guess - assuming > > that Linus does not

[Bug 64521] New: BUG kmalloc-4096 (Tainted: G W ): Poison overwritten

2013-11-06 Thread Andrew Morton
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Wed, 06 Nov 2013 19:12:29 + bugzilla-daemon at bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=64521 > > Bug ID: 64521 >Summary: BUG

[git pull] fbcon locking fixes.

2013-01-24 Thread Andrew Morton
On Fri, 25 Jan 2013 00:42:37 + (GMT) Dave Airlie wrote: > These patches have been sailing around long enough, waiting for a maintainer > to reappear, so I've decided enough is enough, lockdep is kinda useful to > have. > > Thanks to Daniel for annoying me enough :-) Me too, but the

[PATCH 2/9] mm: Provide new get_vaddr_frames() helper

2015-05-28 Thread Andrew Morton
On Wed, 13 May 2015 15:08:08 +0200 Jan Kara wrote: > Provide new function get_vaddr_frames(). This function maps virtual > addresses from given start and fills given array with page frame numbers of > the corresponding pages. If given start belongs to a normal vma, the function > grabs

[PATCH 2/9] mm: Provide new get_vaddr_frames() helper

2015-06-02 Thread Andrew Morton
On Tue, 2 Jun 2015 17:23:00 +0200 Jan Kara wrote: > > That's a lump of new code which many kernels won't be needing. Can we > > put all this in a new .c file and select it within drivers/media > > Kconfig? > So the attached patch should do what you had in mind. OK? lgtm. >

drivers/gpu/drm/i915/i915_gem_gtt.c

2015-05-22 Thread Andrew Morton
I'm not sure what's happened to the drm code in linux-next - it's exploding all over the place. Did someone turn on -Werror without doing anywhere near enough testing? Anyway, I don't know how to fix this i386 build error: drivers/gpu/drm/i915/i915_gem_gtt.c: In function 'gen8_ppgtt_init':

[Intel-gfx] drivers/gpu/drm/i915/i915_gem_gtt.c

2015-05-23 Thread Andrew Morton
On Sat, 23 May 2015 14:30:09 +0100 Damien Lespiau wrote: > On Fri, May 22, 2015 at 02:17:32PM -0700, Andrew Morton wrote: > > I'm not sure what's happened to the drm code in linux-next - it's > > exploding all over the place. Did someone turn on -Werror without > > doing

[PATCH] mm: extend prefault helpers to fault in more than PAGE_SIZE

2012-02-23 Thread Andrew Morton
On Thu, 16 Feb 2012 13:01:36 +0100 Daniel Vetter wrote: > drm/i915 wants to read/write more than one page in its fastpath > and hence needs to prefault more than PAGE_SIZE bytes. > > I've checked the callsites and they all already clamp size when > calling fault_in_pages_* to the same as for

[PATCH] mm: extend prefault helpers to fault in more than PAGE_SIZE

2012-02-24 Thread Andrew Morton
On Fri, 24 Feb 2012 14:34:31 +0100 Daniel Vetter wrote: > > > --- a/include/linux/pagemap.h > > > +++ b/include/linux/pagemap.h > > > @@ -408,6 +408,7 @@ extern void add_page_wait_queue(struct page *page, > > > wait_queue_t *waiter); > > > static inline int fault_in_pages_writeable(char __user

[PATCH] mm: extend prefault helpers to fault in more than PAGE_SIZE

2012-02-29 Thread Andrew Morton
s_* to the same as for the subsequent > __copy_to|from_user and hence don't rely on the implicit clamping > to PAGE_SIZE. > > Also kill a copy spurious space in both functions while at it. > > v2: As suggested by Andrew Morton, add a multipage parameter to both > functions to avoid the

[PATCH] mm: extend prefault helpers to fault in more than PAGE_SIZE

2012-02-29 Thread Andrew Morton
On Thu, 1 Mar 2012 00:14:53 +0100 Daniel Vetter wrote: > I'll redo this patch by adding _multipage versions of these 2 functions > for i915. OK, but I hope "for i915" doesn't mean "private to"! Put 'em in pagemap.h, for maintenance reasons and because they are generic. Making them inline is a

[PATCH 3/5] radeon: Expose backlight class device for legacy LVDS encoder

2011-01-19 Thread Andrew Morton
On Fri, 14 Jan 2011 14:24:23 -0500 Matthew Garrett wrote: > From: Michel D__nzer > > Allows e.g. power management daemons to control the backlight level. Inspired > by the corresponding code in radeonfb. > > (Updated to add backlight type and make the connector the parent device - mjg) >

[PATCH 1/5] Backlight: Add backlight type

2010-11-19 Thread Andrew Morton
On Fri, 19 Nov 2010 10:53:52 -0500 Matthew Garrett wrote: > There may be multiple ways of controlling the backlight on a given machine. > Allow drivers to expose the type of interface they are providing, making > it possible for userspace to make appropriate policy decisions. > > ... > > 60

[PATCH 1/5] Backlight: Add backlight type

2010-11-19 Thread Andrew Morton
On Fri, 19 Nov 2010 20:25:59 + Matthew Garrett wrote: > On Fri, Nov 19, 2010 at 12:05:23PM -0800, Andrew Morton wrote: > > On Fri, 19 Nov 2010 10:53:52 -0500 > > Matthew Garrett wrote: > > > > > There may be multiple ways of controlling the backlight on a giv

[PATCH RESEND] drm: include missing types header to drm_mode.h

2010-10-22 Thread Andrew Morton
On Fri, 22 Oct 2010 10:13:19 -0300 Davidlohr Bueso wrote: > drm: include missing types header to drm_mode.h > > Signed-off-by: Davidlohr Bueso > --- > include/drm/drm_mode.h |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/drm/drm_mode.h

regression in 2.6.35.4 'load is to heavy (video subsystem?)'

2010-09-21 Thread Andrew Morton
On Mon, 30 Aug 2010 10:02:36 +0200 Karsten Mehrhoff wrote: > Using the same .config from 2.6.35.3 to compile 2.5.36.4 results in a > heavy load with 2.6.35.4. A regression within -stable is rather bad. > Example: > > Difference between 2.6.35.1/2/3 and 2.6.35.4 while watching some videos: >

idr_remove called for id=0 which is not allocated

2010-09-22 Thread Andrew Morton
On Wed, 22 Sep 2010 23:10:10 +0200 Alessandro Guido wrote: > I have this traces in my logs (full dmesg attached). > > idr_remove called for id=0 which is not allocated. > Pid: 1136, comm: Xorg Not tainted 2.6.36-rc5-49-gc79bd89 #1 > Call Trace: > [] ? printk+0x18/0x1a > []

DRM-related kmalloc-32 memory leak in 2.6.35

2010-09-27 Thread Andrew Morton
On Wed, 25 Aug 2010 15:59:09 -0500 Matt Mackall wrote: > On Tue, 2010-08-24 at 10:37 -0500, Christoph Lameter wrote: > > On Tue, 24 Aug 2010, Matt Mackall wrote: > > > > > kmalloc-321113344 1113344 32 1281 : tunables00 > > > 0 : slabdata 8698 8698 0 > > > > > >

[PATCH] drm: Prune GEM vma entries

2010-09-27 Thread Andrew Morton
That was quick, thanks. On Mon, 27 Sep 2010 21:08:36 +0100 Chris Wilson wrote: > Hook the GEM vm open/close ops into the generic drm vm open/close so > that the vma entries are created and destroy appropriately. Please update the changelog to indicate that it fixes a memory leak. >

[Bugme-new] [Bug 16488] New: [i915] Framebuffer ID error after suspend/hibernate leading to X crash

2010-08-02 Thread Andrew Morton
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Sun, 1 Aug 2010 08:55:49 GMT bugzilla-daemon at bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=16488 Innocuous-looking one-liner is said to have made Milan's X server

[PATCH 1/4] drm: fix headers to include linux/types.h

2010-12-01 Thread Andrew Morton
On Wed, 1 Dec 2010 17:54:18 +0100 Julien Cristau wrote: > On Wed, Dec 1, 2010 at 17:10:42 +0200, Alexander Shishkin wrote: > > > For headers that get exported to userland and make use of u32 style > > type names, it is advised to include linux/types.h. > > > > This fixes 5 headers_check

VERY slow scrolling on radeon graphics card: debugging a timing issue?

2010-12-22 Thread Andrew Morton
(cc dri-devel) On Mon, 20 Dec 2010 23:58:21 +0300 Michael Tokarev wrote: > Hello. > > A weird problem here, and I'm looking for help in > an attempt to solve it. > > Ever since KMS went into kernel and I tried turning > it on, the scrolling speed on the resulting "text" > console (with kms it

Report for 2.6.35-rc3-00262-g984bc96

2010-07-06 Thread Andrew Morton
On Thu, 1 Jul 2010 09:40:52 +0200 Nico Schottelius wrote: > Good morning! > > A short report on what's broken in 2.6.35-rc3-00262-g984bc96 with > the Lenovo X201: So you see two post-2.6.34 regressions? > == xrandr == > > After using xrandr several times in xorg, the screen gets > "fancy":

2.6.35-rc4 Graphics performance issue and freeing invalid memtype messages on boot.

2010-07-08 Thread Andrew Morton
(Rafael, Maciej: two probably-separate post-2.6.34 regressions here) On Tue, 06 Jul 2010 22:22:17 +1000 Andrew Hendry wrote: > > Some extra messages when booting with -rc4. Didn't get them in -rc3. > [1.387013] swapper:1 freeing invalid memtype bf788000-bf789000 > [1.387409] swapper:1

[Bug 16148] New: page allocation failure. order:1, mode:0x50d0

2010-06-10 Thread Andrew Morton
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Mon, 7 Jun 2010 17:32:04 GMT bugzilla-daemon at bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=16148 > >Summary: page allocation failure. order:1,

[Bug 16148] New: page allocation failure. order:1, mode:0x50d0

2010-06-11 Thread Andrew Morton
On Fri, 11 Jun 2010 10:46:07 +0200 Thomas Hellstrom wrote: > >>> > >>> > >> David, I have a vague feeling that we've been round this loop before.. > >> > >> Why does agp_alloc_page_array() use __GFP_NORETRY? It's pretty unusual > >> and it's what caused this spew. > >> > >> There's

[Bug 16148] New: page allocation failure. order:1, mode:0x50d0

2010-06-11 Thread Andrew Morton
On Fri, 11 Jun 2010 22:22:28 +0200 Thomas Hellstrom wrote: > >>> cc'ing Thomas, who added this, I expect we could drop the NORETRY or > >>> just add NOWARN. Though an order 1 page alloc failure isn't a pretty > >>> sight, not sure how a vmalloc fallback could save us. > >>> > >>> > >>> >

[Bug 16148] page allocation failure. order:1, mode:0x50d0

2010-06-15 Thread Andrew Morton
(switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). (switching back to email, actually) On Sun, 13 Jun 2010 13:01:57 GMT bugzilla-daemon at bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=16148 > > > Mikko C. changed: > >

BUG: unable to handle kernel NULL pointer dereference, i915_gem_object_move_to_active

2010-05-06 Thread Andrew Morton
(cc dri-devel) On Wed, 5 May 2010 00:22:16 +0200 Nils Radtke wrote: > Hi, > > It happens quite often that X crashes for unknown reasons but this time > there it's left us a note, this BUG: > > BUG: unable to handle kernel NULL pointer dereference at 01e4 > IP: []

BUG: unable to handle kernel NULL ptr Xorg, scheduling while atomic: Xorg/drm

2010-05-06 Thread Andrew Morton
(cc dri-devel) On Wed, 5 May 2010 00:51:38 +0200 Nils Radtke wrote: > Hi, > > Some more kernel NULL ptr deref, a lot of scheduling while atomic > (probably due to first bug occurred) and again this "last sysfs file" > from wireless. ath5k is a real source of trouble here: > > - resume

DRM Error on Acer Aspire One

2010-05-11 Thread Andrew Morton
On Tue, 11 May 2010 17:10:53 +0100 Chris Wilson wrote: > On Tue, 11 May 2010 20:30:07 +0530, Jaswinder Singh Rajput gmail.com> wrote: > > Hello, > > > > With latest git kernel, I am getting following DRM error and not > > getting XWindows : > > [snip] > > Hmm, there are still patches for

DRM Error on Acer Aspire One

2010-05-11 Thread Andrew Morton
On Tue, 11 May 2010 19:19:26 +0100 Chris Wilson wrote: > On Tue, 11 May 2010 10:48:18 -0400, Andrew Morton linux-foundation.org> wrote: > > > > On Tue, 11 May 2010 17:10:53 +0100 Chris Wilson > chris-wilson.co.uk> wrote: > > > > > On Tue, 11 May 2010

[PATCH] drm/i915: Record error batch buffers using iomem

2010-05-11 Thread Andrew Morton
On Tue, 11 May 2010 19:22:14 +0100 Chris Wilson wrote: > + reloc_offset = src_priv->gtt_offset; > for (page = 0; page < page_count; page++) { > - void *s, *d = kmalloc(PAGE_SIZE, GFP_ATOMIC); > + void __iomem *s; > + void *d; > + > + d =

DRM Error on Acer Aspire One

2010-05-11 Thread Andrew Morton
On Tue, 11 May 2010 19:52:31 +0100 Chris Wilson wrote: > On Tue, 11 May 2010 11:35:55 -0400, Andrew Morton linux-foundation.org> wrote: > > No, io_mapping_map_atomic_wc() cannot be used from [soft]irq context: > > it hardwires use of KM_USER0. I suggest that io

DRM Error on Acer Aspire One

2010-05-11 Thread Andrew Morton
On Wed, 12 May 2010 08:22:49 +1000 Dave Airlie wrote: > On Wed, May 12, 2010 at 5:57 AM, Chris Wilson > wrote: > > On Tue, 11 May 2010 12:10:01 -0700, Andrew Morton > linux-foundation.org> wrote: > >> On Tue, 11 May 2010 19:52:31 +0100 > >> Chris Wilson wr

DRM Error on Acer Aspire One

2010-05-11 Thread Andrew Morton
On Wed, 12 May 2010 08:51:05 +1000 Dave Airlie wrote: > On Wed, May 12, 2010 at 8:32 AM, Andrew Morton > wrote: > > On Wed, 12 May 2010 08:22:49 +1000 > > Dave Airlie wrote: > > > >> On Wed, May 12, 2010 at 5:57 AM, Chris Wilson >> chris-wilson.co.uk&g

DRM Error on Acer Aspire One

2010-05-11 Thread Andrew Morton
On Wed, 12 May 2010 09:17:09 +1000 Dave Airlie wrote: > >> >> and > >> >> this codepath is called from non-irq contexts just as much as irq > >> >> contexts. > >> > > >> > That's fine. __As long as we do a local_irq_disable(), KM_IRQ0 can be > >> > used from both irq- and non-irq contexts. __All

[2.6.38-rc6] G965: i915 Hangcheck timer elapsed... GPU hung (not reproducible)

2011-03-02 Thread Andrew Morton
(cc dri-devel) A post-2.6.37 regression. On Sun, 27 Feb 2011 10:10:41 +0100 Paolo Ornati wrote: > Today I got this while starting a video in SMplayer (MPlayer) with > 2.6.38-rc6-00113-g4662db4: > > [ 830.880014] [drm:i915_hangcheck_elapsed] *ERROR* Hangcheck timer > elapsed... GPU hung > [

2.6.37.2 : Font corruption and [drm:i915_gem_object_unbind] *ERROR* Attempting to unbind pinned buffer

2011-03-02 Thread Andrew Morton
(cc dri-devel) On Mon, 28 Feb 2011 12:26:08 +0100 Paul Rolland wrote: > Hello, > > I'm using 2.6.37.2 and I'm getting loads of this error in my messages, > while at the same time I can observe font display corruption in a GTK > application (Claws-Mail) while running X, compiz and this app. >

+ drivers-base-platformc-dont-mark-platform_device_register_resndata-as-__init_or_module.patch added to -mm tree

2011-05-19 Thread Andrew Morton
On Thu, 19 May 2011 08:21:36 +0200 Uwe Kleine-K?nig wrote: > I'm not sure that the things that radeon_cp_init does are sane. Some more details here might help someone fix it. > Maybe > add a comment that it is the only known stopper to make > platform_device_register_resndata __init_or_module

[PATCH] drm: avoid switching to text console if there is no panic timeout

2011-11-10 Thread Andrew Morton
mmit message and modified to short-circuit panic_timeout < 0 > > > > instead of testing panic_timeout >= 0. -Mandeep ] > > > > Signed-off-by: Mandeep Singh Baines > > > > Cc: Dave Airlie > > > > Cc: Andrew Morton > > > > C

3.2-rc2+: Reported regressions from 3.0 and 3.1

2011-11-21 Thread Andrew Morton
> References : https://lkml.org/lkml/2011/11/12/11 > > > > Andrea's patch already fixes this issue, which was reported first by > Jiri Slaby. https://lkml.org/lkml/2011/11/11/93 > I remember Andrew Morton taking this patch in his -mm tree. But it is > not in mainl

Re: [PATCH] fix double ;;s in code

2018-02-20 Thread Andrew Morton
On Tue, 20 Feb 2018 10:03:56 +0200 Jani Nikula wrote: > On Mon, 19 Feb 2018, Pavel Machek wrote: > > On Mon 2018-02-19 16:41:35, Daniel Vetter wrote: > >> Yeah, pls split this into one patch per area, with a suitable patch > >> subject prefix. Look at

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-20 Thread Andrew Morton
On Mon, 16 Jul 2018 13:50:58 +0200 Michal Hocko wrote: > From: Michal Hocko > > There are several blockable mmu notifiers which might sleep in > mmu_notifier_invalidate_range_start and that is a problem for the > oom_reaper because it needs to guarantee a forward progress so it cannot > depend

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-20 Thread Andrew Morton
On Tue, 17 Jul 2018 10:12:01 +0200 Michal Hocko wrote: > > Any suggestions regarding how the driver developers can test this code > > path? I don't think we presently have a way to fake an oom-killing > > event? Perhaps we should add such a thing, given the problems we're > > having with that

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-16 Thread Andrew Morton
On Mon, 16 Jul 2018 13:50:58 +0200 Michal Hocko wrote: > From: Michal Hocko > > There are several blockable mmu notifiers which might sleep in > mmu_notifier_invalidate_range_start and that is a problem for the > oom_reaper because it needs to guarantee a forward progress so it cannot > depend

Re: [PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-24 Thread Andrew Morton
On Tue, 24 Jul 2018 16:17:47 +0200 Michal Hocko wrote: > On Fri 20-07-18 17:09:02, Andrew Morton wrote: > [...] > > - Undocumented return value. > > > > - comment "failed to reap part..." is misleading - sounds like it's > > referring to somethin

Re: [PATCH] kernel.h: Add for_each_if()

2018-07-09 Thread Andrew Morton
On Mon, 9 Jul 2018 18:25:09 +0200 Daniel Vetter wrote: > To avoid compilers complainig about ambigious else blocks when putting > an if condition into a for_each macro one needs to invert the > condition and add a dummy else. We have a nice little convenience > macro for that in drm headers,

  1   2   >