follow close brace '}'
CHECK: Comparison to NULL could be written
"link->preferred_training_settings.fec_enable"
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 32 +--
1 file changed, 16 insertions(+), 16 deletions(-)
diff --
This patchset solves some coding style issues on dc_link for readability
and cleaning up warnings. Change suggested by checkpatch.pl.
Melissa Wen (2):
drm/amd/display: dc_link: code clean up on enable_link_dp function
drm/amd/display: dc_link: code clean up on detect_dp function
drivers
Removes codestyle issues on detect_dp function as suggested by
checkpatch.pl.
CHECK: Lines should not end with a '('
WARNING: Missing a blank line after declarations
WARNING: line over 80 characters
CHECK: Alignment should match open parenthesis
Signed-off-by: Melissa Wen
---
drivers/gpu/drm
follow close brace '}'
CHECK: Comparison to NULL could be written
"link->preferred_training_settings.fec_enable"
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 29 +--
1 file changed, 14 insertions(+), 15 deletions(-)
diff --
This patchset solves some coding style issues on dc_link for readability
and cleaning up warnings. Change suggested by checkpatch.pl.
Changes in v2:
- Apply patches to the right amdgpu repository.
- Remove unnecessary {} added in the previous version.
Melissa Wen (2):
drm/amd/display: dc_link
Removes codestyle issues on detect_dp function as suggested by
checkpatch.pl.
CHECK: Lines should not end with a '('
WARNING: Missing a blank line after declarations
WARNING: line over 80 characters
CHECK: Alignment should match open parenthesis
Signed-off-by: Melissa Wen
---
drivers/gpu/drm
The dpp2_get_optimal_number_of_taps function is never used. Removing just for
code cleaning up.
Signed-off-by: Melissa Wen
---
.../gpu/drm/amd/display/dc/dcn20/dcn20_dpp.c | 78 ---
1 file changed, 78 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_dpp.c
when you send patches to amdgpu, use
> the following repository:
>
> git://people.freedesktop.org/~agd5f/linux
>
> Could you prepare a V2?
Yes.
Thanks for reviewing my patches.
Soon, I will send a V2 with the changes suggested by you.
>
> Thanks!
>
> On 02/26, Melissa
am still stuck.
The last thing that I noted is that syzkaller stopped providing a C program of
this bug for crashes after the beginning of the year (I also don't know if it
is something important).
Thanks in advance,
Melissa Wen
___
dri-devel mailing
Solve comments alignment problems on dc_link file
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 25 +++
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
b/drivers/gpu/drm/amd/display
These patches address many code style issues on dc_link for readability
and cleaning up warnings. Change suggested by checkpatch.pl.
Some issues remain and need some minor code refactoring for proper handling.
Melissa Wen (4):
drm/amd/display: cleanup codestyle type BLOCK_COMMENT_STYLE
parenthesis
CHECK: Lines should not end with a '('
WARNING: please, no space before tabs
WARNING: Comparisons should place the constant on the right side of the test
WARNING: braces {} are not necessary for single statement blocks
CHECK: Please don't use multiple blank lines
Signed-off-by: Melissa Wen
->dpcd_caps.sink_count.bits.SINK_COUNT'
CHECK: Unnecessary parentheses around
WARNING: Missing a blank line after declarations
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 130 +-
1 file changed, 62 insertions(+), 68 deletions(-)
diff --
: Comparison to NULL could be written
CHECK: Logical continuations should be on the previous line
CHECK: Blank lines aren't necessary after an open brace '{'
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 94 ++-
1 file changed, 50 insertions(+), 44 deletions
operation to extract the RGB
values from each pixel and ignores the alpha channel as expected.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_composer.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vkms/vkms_composer.c
b/drivers/gpu/drm/vkms
This patch proposes a change in the behavior of the cursor to enable it as
soon as the vkms module is added. Enabling the cursor by default appears
to be an expected and more friendly behavior, especially when running IGT
tests.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_drv.c | 2
dev_alloc.
>
> v3: Only deref vkms_device after checking it (Melissa)
Thanks :)
>
> Cc: Melissa Wen
> Signed-off-by: Daniel Vetter
> Cc: Rodrigo Siqueira
> Cc: Haneen Mohammed
> Cc: Daniel Vetter
> ---
> drivers/gpu/drm/vkms/vkms_drv.c | 56 +++
);
> -out_free:
> - kfree(vgem_device);
> + platform_device_unregister(pdev);
> return ret;
> }
>
> static void __exit vgem_exit(void)
> {
> + struct platform_device *pdev = vgem_device->platform;
> +
Well, there has never been a check for a null vgem_device
On 09/09, Daniel Vetter wrote:
> On Wed, Sep 9, 2020 at 1:01 PM Melissa Wen wrote:
> >
> > Hi Daniel,
> >
> > looks good to me, just a few things inline.
> >
> > On 09/04, Daniel Vetter wrote:
> > > This means we also need to slightly restru
Add myself as maintainer of VKMS driver
Signed-off-by: Melissa Wen
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 01fb9ee6b951..d4277824a01c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5640,6 +5640,7 @@ F:drivers/gpu/drm/udl
-sizeof(u32));
> +
> + for (y = y_src; y < y_src + h_src; ++y) {
> + for (x = x_src; x < x_src + w_src; ++x) {
> + pixel = get_pixel_from_buffer(x, y, vaddr, composer);
> +
tch is preparation work for making vkms able to support new
> features.
>
> Tested-by: Melissa Wen
> Signed-off-by: Rodrigo Siqueira
> ---
> drivers/gpu/drm/vkms/vkms_composer.c | 49
> 1 file changed, 29 insertions(+), 20 deletions(-)
Hi Daniel,
Thanks for this work.
This change works smoothly to me. However, there is a check in the vkms_exit
that doesn't look very good. Please, see inline comment.
On 09/04, Daniel Vetter wrote:
> This means we also need to slightly restructure the exit code, so that
> final cleanup of the
] https://patchwork.freedesktop.org/series/81177/
Cc: Daniel Vetter
Cc: Rodrigo Siqueira
Cc: Haneen Mohammed
Signed-off-by: Melissa Wen
---
Documentation/gpu/vkms.rst | 99 --
1 file changed, 53 insertions(+), 46 deletions(-)
diff --git a/Documentation/gpu
e Ripard
> Cc: Thomas Zimmermann
> Cc: David Airlie
> Cc: Daniel Vetter
> Cc: Rodrigo Siqueira
> Cc: Melissa Wen
> Cc: Haneen Mohammed
> ---
> drivers/gpu/drm/Kconfig | 1 +
> drivers/gpu/drm/vkms/Makefile | 1 -
> drivers/gpu/drm/vkms/vkm
On 10/10, Daniel Vetter wrote:
> The only thing we support is xrgb.
>
> Signed-off-by: Daniel Vetter
> Cc: Rodrigo Siqueira
> Cc: Melissa Wen
> Cc: Haneen Mohammed
> Cc: Daniel Vetter
> ---
> drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
> 1 file chang
On 10/15, Daniel Vetter wrote:
> On Mon, Oct 12, 2020 at 09:59:22AM -0300, Melissa Wen wrote:
> > On 10/10, Daniel Vetter wrote:
> > > The only thing we support is xrgb.
> > >
> > > Signed-off-by: Daniel Vetter
> > > Cc: Rodrigo Siqueira
>
first.
I consider that including in the msg that, with this patch, both fbdev
test cases [info and mmap] are passing would be interesting for future
debugs.
>
> Signed-off-by: Daniel Vetter
> Cc: Rodrigo Siqueira
> Cc: Melissa Wen
> Cc: Haneen Mohammed
> Cc: Daniel Vetter
On 10/16, Daniel Vetter wrote:
> On Fri, Oct 16, 2020 at 12:38 PM Simon Ser wrote:
> >
> > > The only thing we support is xrgb.
> > >
> > > Signed-off-by: Daniel Vetter
> > > Cc: Rodrigo Siqueira
> > > Cc: Melissa W
On 10/16, Daniel Vetter wrote:
> On Fri, Oct 16, 2020 at 7:02 PM Melissa Wen wrote:
> >
> > On 10/16, Daniel Vetter wrote:
> > > On Fri, Oct 16, 2020 at 12:38 PM Simon Ser wrote:
> > > >
> > > > > The only thing we support is xrgb888
] https://patchwork.freedesktop.org/series/81177/
v2:
- Link to syzbot dashboard
Cc: Daniel Vetter
Cc: Rodrigo Siqueira
Cc: Haneen Mohammed
Signed-off-by: Melissa Wen
Acked-by: Daniel Vetter
---
Documentation/gpu/vkms.rst | 99 --
1 file changed, 53
On 08/24, Rodrigo Siqueira wrote:
> This patch implements the necessary functions to add writeback support
> for vkms. This feature is useful for testing compositors if you don't
> have hardware with writeback support.
>
> Change in V4 (Emil and Melissa):
> - Move signal completion above
,
that I pointed out inline. Please, check it.
- kms_flip and kms_pipe_crc_basic works as expected (was not affected).
Best regards,
Melissa Wen
On 08/24, Rodrigo Siqueira wrote:
> This is the V5 version of a series that introduces the writeback support
> to VKMS. The first two p
On Tue, Aug 25, 2020 at 12:45 PM Melissa Wen wrote:
>
> On 08/24, Rodrigo Siqueira wrote:
> > This patch implements the necessary functions to add writeback support
> > for vkms. This feature is useful for testing compositors if you don't
> > have hardware with writeback
On 08/24, Rodrigo Siqueira wrote:
> The compute_crc() function is responsible for calculating the
> framebuffer CRC value; due to the XRGB format, this function has to
> ignore the alpha channel during the CRC computation. Therefore,
> compute_crc() set zero to the alpha channel directly in the
imary_composer, cursor_composer);
> + if (ret) {
> + if (ret == -EINVAL)
> + kfree(vaddr_out);
> + return;
> + }
> +
> + crc32 = compute_crc(vaddr_out, primary_composer);
>
>
Hi Rodrigo,
Thanks for the review!
I just sent a v2 applying your suggestions.
Best Regards,
Melissa Wen
Melissa Wen
On Tue, Aug 25, 2020 at 12:04 AM Rodrigo Siqueira
wrote:
>
> Hi Melissa,
>
> First of all, thanks a lot for your patch!
>
> Follows my inline comments.
>
functions
- const for the read-only variable argb_src
- replaces variable names
- drops unnecessary comment
--
Cc: Daniel Vetter
Cc: Rodrigo Siqueira
Cc: Haneen Mohammed
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_composer.c | 55
1 file changed, 39
this patch considers premultiplied alpha colors to
compose vaddr_src with vaddr_dst.
This change removes the following cursor-alpha-transparent warning:
Suspicious CRC: All values are 0.
Cc: Daniel Vetter
Cc: Rodrigo Siqueira
Cc: Haneen Mohammed
Signed-off-by: Melissa Wen
---
drivers/gpu/drm
triggers this warning and why this
approach is reasonable, as VKMS has fake clocks.
>
> Cc: Daniel Vetter
> Cc: Rodrigo Siqueira
> Cc: Haneen Mohammed
> Cc: Melissa Wen
>
> Signed-off-by: Sidong Yang
> ---
> drivers/gpu/drm/vkms/vkms_crtc.c | 5 +
> 1 file cha
On 09/29, Daniel Vetter wrote:
> - debugfs cleanup has moved forward thanks to the cleanup Wambui has
> done
>
> Cc: Wambui Karuga
> Cc: Greg Kroah-Hartman
> Cc: Melissa Wen
> Signed-off-by: Daniel Vetter
> ---
> Documentation/gpu/todo.rst | 3 ---
>
fine.
Reviewed-by: Melissa Wen
> ---
> drivers/gpu/drm/vkms/vkms_drv.c | 8
> drivers/gpu/drm/vkms/vkms_gem.c | 13 +
> 2 files changed, 13 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
&
l to convert.
>
> Signed-off-by: Thomas Zimmermann
Thanks here again.
This drv file is little tumultuous to me.
I mean, I took a while to sort functions in my head.
However, finally, I got it, and the change looks good.
Reviewed-by: Melissa Wen
> ---
> drivers/gpu/
This patch adds a check for the vgem_device before handling it.
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vgem/vgem_drv.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c
index cb884c890065
the flush steps: it increases counter to hold a vblank reference (get),
but there isn't a op to decreased it and release vblanks (put).
Cc: Daniel Vetter
Cc: Rodrigo Siqueira
Cc: Haneen Mohammed
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_crtc.c | 1 +
1 file changed, 1 insertion
On 07/22, dan...@ffwll.ch wrote:
> On Wed, Jul 22, 2020 at 08:04:11AM -0300, Melissa Wen wrote:
> > This patch adds a missing drm_crtc_vblank_put op to the pair
> > drm_crtc_vblank_get/put (inc/decrement counter to guarantee vblanks).
> >
> > It clears the
Melissa Wen
On Sat, Jul 25, 2020 at 3:12 PM Daniel Vetter wrote:
>
> On Sat, Jul 25, 2020 at 7:45 PM Melissa Wen wrote:
> >
> > On 07/25, Daniel Vetter wrote:
> > > On Sat, Jul 25, 2020 at 5:12 AM Sidong Yang wrote:
> > > >
> > > > On Wed, Ju
-by: Daniel Vetter
Signed-off-by: Daniel Vetter
Signed-off-by: Melissa Wen
---
drivers/gpu/drm/vkms/vkms_composer.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/vkms/vkms_composer.c
b/drivers/gpu/drm/vkms/vkms_composer.c
index 4af2f19480f4..1161eaa383f1 100644
On Wed, Jul 29, 2020 at 12:22 PM Sidong Yang wrote:
>
> This patch modifies function call sequence in commit tail. This is for
> the problem that raised when kms_cursor_crc test is tested repeatedly.
> In second test, there is an bug that crtc commit doesn't start vblank events.
> Because there
uses refcount to ensure that vblanks happen when
enabling composer and while crc capture is needed.
Cc: Rodrigo Siqueira
Cc: Haneen Mohammed
Co-debugged-by: Sidong Yang
Signed-off-by: Sidong Yang
Signed-off-by: Melissa Wen
Reviewed-by: Daniel Vetter
---
v2:
- extract a vkms_set_composer
On 07/29, Daniel Vetter wrote:
> On Wed, Jul 29, 2020 at 9:09 PM Melissa Wen wrote:
> >
> > Melissa Wen
> >
> > On Sat, Jul 25, 2020 at 3:12 PM Daniel Vetter wrote:
> > >
> > > On Sat, Jul 25, 2020 at 7:45 PM Melissa Wen wrote:
> > > >
On 07/31, Sidong Yang wrote:
> On Fri, Jul 31, 2020 at 11:08:34AM +0200, dan...@ffwll.ch wrote:
> > On Thu, Jul 30, 2020 at 07:09:25AM -0300, Melissa Wen wrote:
> > > On 07/29, Daniel Vetter wrote:
> > > > On Wed, Jul 29, 2020 at 9:09 PM Melissa Wen
> > > &
On 08/04, dan...@ffwll.ch wrote:
> On Sat, Aug 01, 2020 at 03:49:29PM -0300, Melissa Wen wrote:
> > VKMS needs vblank interrupts enabled to capture CRC. When vblank is
> > disabled, tests like kms_cursor_crc and kms_pipe_crc_basic getting stuck
> > waiting for a capture that
refcount to ensure that vblanks happen when
enabling composer and while crc capture is needed.
Cc: Rodrigo Siqueira
Cc: Haneen Mohammed
Co-developed-by: Sidong Yang
Signed-off-by: Sidong Yang
Co-developed-by: Daniel Vetter
Signed-off-by: Daniel Vetter
Signed-off-by: Melissa Wen
---
drivers
This change expands the coverage for the IGT kms_cursor_crc test, where
the size varies between 64 and 512 for a square cursor. With this, in
addition to the cursor 64x64, this patch enables the test of cursors with
sizes: 128x128, 256x256, and 512x512.
Signed-off-by: Melissa Wen
---
drivers
On 07/13, Daniel Vetter wrote:
> On Fri, Jul 10, 2020 at 02:05:33PM -0300, Melissa Wen wrote:
> > On 07/02, Daniel Vetter wrote:
> > > On Wed, Jul 01, 2020 at 03:31:34PM +, Sidong Yang wrote:
> > > > there is an error when igt test is run continuously.
&
On Tue, Jul 14, 2020 at 7:20 AM Melissa Wen wrote:
>
> On 07/13, Daniel Vetter wrote:
> > On Fri, Jul 10, 2020 at 02:05:33PM -0300, Melissa Wen wrote:
> > > On 07/02, Daniel Vetter wrote:
> > > > On Wed, Jul 01, 2020 at 03:31:34PM +, Sidong Yang wrote:
>
, could you test this patch and review
> it? Remember to add your Tested-by when you finish.
>
Hi,
I've applied the patch series, ran some tests on vkms, and found no
issues. I mean, things have remained stable.
Tested-by: Melissa Wen
> Thanks
>
> On 07/07, Daniel Vetter wrote:
&g
Hi,
On 07/14, Daniel Vetter wrote:
> On Tue, Jul 14, 2020 at 11:57 AM Melissa Wen wrote:
> >
> > On 07/12, Rodrigo Siqueira wrote:
> > > Hi,
> > >
> > > Everything looks fine to me, I just noticed that the amdgpu patches did
> > > not apply
On 07/14, Daniel Vetter wrote:
> On Tue, Jul 14, 2020 at 07:39:42AM -0300, Melissa Wen wrote:
> > On Tue, Jul 14, 2020 at 7:20 AM Melissa Wen wrote:
> > >
> > > On 07/13, Daniel Vetter wrote:
> > > > On Fri, Jul 10, 2020 at 02:05:33PM -0300, Melissa Wen w
On 07/15, Sidong Yang wrote:
> On Wed, Jul 15, 2020 at 10:17:56AM +0200, Daniel Vetter wrote:
> > On Tue, Jul 14, 2020 at 9:01 PM Melissa Wen wrote:
> > >
> > > On 07/14, Daniel Vetter wrote:
> > > > On Tue, Jul 14, 2020 at 07:39:42AM -0300, Melissa Wen wro
On 07/02, Daniel Vetter wrote:
> On Wed, Jul 01, 2020 at 03:31:34PM +, Sidong Yang wrote:
> > there is an error when igt test is run continuously.
> > vkms_atomic_commit_tail()
> > need to call drm_atomic_helper_wait_for_vblanks() for give up ownership of
> > vblank events. without this code,
On 07/25, Daniel Vetter wrote:
> On Sat, Jul 25, 2020 at 5:12 AM Sidong Yang wrote:
> >
> > On Wed, Jul 22, 2020 at 05:17:05PM +0200, Daniel Vetter wrote:
> > > On Wed, Jul 22, 2020 at 4:06 PM Melissa Wen wrote:
> > > >
> > > > On 07/22, dan..
On 07/25, Daniel Vetter wrote:
> On Sat, Jul 25, 2020 at 7:45 PM Melissa Wen wrote:
> >
> > On 07/25, Daniel Vetter wrote:
> > > On Sat, Jul 25, 2020 at 5:12 AM Sidong Yang wrote:
> > > >
> > > > On Wed, Jul 22, 2020 at 05:17:05PM +0200, Daniel V
> No, this very first warning continues (only once) :(
> From here (drm_crtc_vblank_on):
> if (atomic_read(>refcount) != 0 || drm_vblank_offdelay == 0)
> drm_WARN_ON(dev, drm_vblank_enable(dev, pipe));
Sorry, not sure when this warning is triggered.
>
> > But I'm still
On Sat, Jul 25, 2020 at 4:19 PM Melissa Wen wrote:
>
> > No, this very first warning continues (only once) :(
> > From here (drm_crtc_vblank_on):
> > if (atomic_read(>refcount) != 0 || drm_vblank_offdelay == 0)
> > drm_WARN_ON(dev, drm_vblank
Hi all,
I traced the subtests' execution to figure out what happens (or not) in
a clean run and a blocked run, and this led me to suspect the
vkms_crtc_atomic_flush function. Examining the code and considering the
DRM doc, it seemed to me that a drm_crtc_vblank_get call was missing a
The previous memset operation was not correctly zeroing the alpha
channel to compute the crc, and as a result, the IGT subtest
kms_cursor_crc/pipe-A-cursor-alpha-transparent fails.
Fixes: db7f419c06d7c ("drm/vkms: Compute CRC with Cursor Plane")
Signed-off-by: Melissa Wen
---
drive
init writeback connector\n");
> + if (vkmsdev->config->writeback) {
> + writeback = vkms_enable_writeback_connector(vkmsdev);
> + if (writeback)
> + DRM_ERROR("Failed to init writeback connector\n");
> + }
Thanks,
Reviewed-by: Melissa Wen
>
> drm_mode_config_reset(dev);
>
> --
> 2.25.1
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
_device {
> struct drm_device drm;
> struct platform_device *platform;
> struct vkms_output output;
> + const struct vkms_config *config;
> };
>
> #define drm_crtc_to_vkms_output(target) \
> @@ -124,3 +131,4 @@ void vkms_set_composer(struct vkms_
Hi Sumera,
Thanks for documenting.
You forgot to bring Daniel's ack; however, as I also reviewed and lgtm,
Reviewed-by: Melissa Wen
> To disable the driver, use ::
>
>sudo modprobe -r vkms
> --
> 2.25.1
>
___
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 01/05, Sumera Priyadarsini wrote:
> Currently, data for the device instance is held by vkms_device.
> Add a separate type, vkms_config to contain configuration details
> for the device and various modes to be later used by configfs.
> This config data stays constant once the device is created.
On 12/09, Daniel Vetter wrote:
> On Wed, Dec 9, 2020 at 12:33 PM Sumera Priyadarsini
> wrote:
> >
> > On Wed, Dec 9, 2020 at 6:24 AM Daniel Vetter wrote:
> > >
> > > On Wed, Dec 09, 2020 at 02:07:35AM +0530, Sumera Priyadarsini wrote:
> > > > Update the vkms documentation to contain steps to:
>
On 12/09, Daniel Vetter wrote:
> On Thu, Dec 10, 2020 at 12:34:53AM +0530, Sumera Priyadarsini wrote:
> > Update the vkms documentation to contain steps to:
> >
> > - setup the vkms driver
> > - run tests using igt
> >
> > Signed-off-by: Sumera Priyadarsini
> > ___
> > Changes in v2:
> > -
Hi Sumera,
Thanks for the doc improvements.
Please see some complimentary comments below.
On 12/03, Daniel Vetter wrote:
> On Thu, Dec 3, 2020 at 8:13 PM Sumera Priyadarsini
> wrote:
> >
> > Update the vkms documentation to contain steps to:
> >
> > - setup the vkms driver
> > - run tests
gt; > Fix this by adding the missing null check.
> >
> > Addresses-Coverity: ("Dereference null return value")
> > Fixes: 2df7af93fdad ("drm/vkms: Add vkms_config type")
> > Signed-off-by: Colin Ian King
>
> Good catch, thank you!
>
> Reviewe
Hi Sumera,
Thanks for your patch.
Please see some comments below.
On 01/02, Sumera Priyadarsini wrote:
> Currently, data for the device instance is held by vkms_device.
> Add a separate type, vkms_config to contain configuration details
> for the device and various modes to be later used by
On 01/12, Sumera Priyadarsini wrote:
> This patchset aims to lay down some prep work before configfs can be
> implemented for the vkms driver. The first patch in the series adds a
> new type vkms_config to track device configuration. The second and third
> patch add module testing support for
t; To: dri-devel@lists.freedesktop.org
> Signed-off-by: Juan A. Suarez Romero
Hi Juan,
I've checked it (+ mesa MR) on glxgears, and lgtm.
+ some basic tests from igt, by default.
Acked-by: Melissa Wen
> ---
> drivers/gpu/drm/v3d/Makefile | 1 +
> drivers/gpu/d
our patch.
Changes lgtm.
However commit message needs small improvements. Besides typo, it would
be good to make the subject clearer in terms of its purpose (creating
a debugfs file to get/track vkms config data).
Please, address these minor things and add my r-b.
Reviewed-by: Melissa Wen
>
/394614/
- overlay plane: this feature was added by
https://patchwork.freedesktop.org/patch/430941/
---
v2:
- add task to enable multiple overlay planes (Simon)
Signed-off-by: Melissa Wen
---
Documentation/gpu/vkms.rst | 38 ++
1 file changed, 26 insertions
On 06/25, Thomas Zimmermann wrote:
> The field drm_device.irq_enabled is only used by legacy drivers
> with userspace modesetting. Don't set it in vkms.
>
> Signed-off-by: Thomas Zimmermann
> Reviewed-by: Laurent Pinchart
I've also checked here, lgtm.
Reviewed-
On 07/06, Thomas Zimmermann wrote:
> Hi
>
> Am 05.07.21 um 23:29 schrieb Melissa Wen:
> > On 07/05, Daniel Vetter wrote:
> > > On Mon, Jul 05, 2021 at 12:05:28PM +0200, Thomas Zimmermann wrote:
> > > > Hi
> > > >
> > > > Am 05.07.21 um
On 07/05, Daniel Vetter wrote:
> On Mon, Jul 05, 2021 at 12:05:28PM +0200, Thomas Zimmermann wrote:
> > Hi
> >
> > Am 05.07.21 um 11:27 schrieb Daniel Vetter:
> > > On Mon, Jul 05, 2021 at 09:46:29AM +0200, Thomas Zimmermann wrote:
> > > > Vkms copies each plane's framebuffer into the output
On 07/08, Beatriz Martins de Carvalho wrote:
> Creating a vkms_config_debufs file in vkms_drv.c to get/track vkms config
> data, for the long-term plan of making vkms configurable and have multiple
> different instances.
>
> Reviewed-by: Melissa Wen
> Signed-off-by: Beatriz M
On 04/25, Simon Ser wrote:
> On Saturday, April 24th, 2021 at 3:57 PM, Melissa Wen
> wrote:
>
> > -- Real overlay planes, not just cursor.
>
> Maybe we should mention "multiple overlay planes" as a good task?
Sure. I'll include it.
Thanks for taking a loo
/394614/
- overlay plane: this feature was added by
https://patchwork.freedesktop.org/patch/430941/
Cc: Daniel Vetter
Cc: Rodrigo Siqueira
Cc: Sumera Priyadarsini
Signed-off-by: Melissa Wen
---
Documentation/gpu/vkms.rst | 36
1 file changed, 24 insertions
On 04/26, Pekka Paalanen wrote:
> On Sat, 24 Apr 2021 05:26:10 -0300
> Melissa Wen wrote:
>
> > Add support to overlay plane, in addition to primary and cursor
> > planes. In this approach, the plane composition still requires an
> > active primary plane and planes
On 04/26, Daniel Vetter wrote:
> On Mon, Apr 26, 2021 at 11:03:15AM +0300, Pekka Paalanen wrote:
> > On Sat, 24 Apr 2021 05:25:31 -0300
> > Melissa Wen wrote:
> >
> > > Add support for composing XRGB888 planes in addition to the ARGB
> > > format.
On 04/27, Pekka Paalanen wrote:
> On Mon, 26 Apr 2021 14:31:28 -0300
> Melissa Wen wrote:
>
> > On 04/26, Daniel Vetter wrote:
> > > On Mon, Apr 26, 2021 at 11:03:15AM +0300, Pekka Paalanen wrote:
> > > > On Sat, 24 Apr 2021 05:25:31 -0300
> > > &
series format
v4:
- use better names for functions of plane composition (Daniel)
- clear alpha channel (0xff) after blend color values by pixel
- improve comments on blend ops to reflect the current state
- describe in the commit message future improvements for plane composition
Melissa Wen (4
By using drmm_universal_plane_alloc instead of
drm_universal_plane_init, we let the DRM infrastructure handles
resource allocation and cleanup. We can also get rid of some
code repetitions for plane cleanup, improving code maintainability
in vkms.
Signed-off-by: Melissa Wen
Reviewed-by: Daniel
Generalize variables and function names used for planes composition
(from cursor to plane), since we will reuse the operations for both
cursor and overlay types.
No functional change.
v4:
- use better names for functions of plane composition (Daniel)
Signed-off-by: Melissa Wen
Reviewed
) after blend color values by pixel
- improve comments on blend ops to reflect the current state
- describe in the commit message future improvements for plane composition
Signed-off-by: Melissa Wen
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/vkms/vkms_composer.c | 56
sfully:
- kms_plane_cursor:
- pipe-A-[overlay, primary, viewport]-size-[64, 128, 256]
- kms_atomic:
- plane-overlay-legacy
and preserves the successful execution of kms_cursor_crc,
kms_writeback and kms_flip
Signed-off-by: Melissa Wen
Reviewed-by: Daniel Vetter
---
drivers/gpu/drm/vkms/vkms_composer.
On 03/25, Dmitry Vyukov wrote:
> On Wed, Mar 24, 2021 at 11:00 PM Melissa Wen wrote:
> >
> > On 03/20, Dmitry Vyukov wrote:
> > > vkms_vblank_simulate() uses WARN_ON for timing-dependent condition
> > > (timer overrun). This is a mis-use of WARN_ON, WARN_ON mu
+4fc21a003c8332eb0...@syzkaller.appspotmail.com
> Cc: Rodrigo Siqueira
> Cc: Melissa Wen
> Cc: Haneen Mohammed
> Cc: Daniel Vetter
> Cc: David Airlie
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-ker...@vger.kernel.org
> Change-Id: I7f01c288092bc7e472ec63af198f93ce3d8c49f7
On 02/22, Daniel Vetter wrote:
> On Sat, Feb 20, 2021 at 11:42:12AM -0300, Melissa Wen wrote:
> > Add support to overlay plane, in addition to primary and cursor
> > planes. In this approach, the plane composition still requires an
> > active primary plane and planes are c
On 02/22, Daniel Vetter wrote:
> On Sat, Feb 20, 2021 at 11:38:50AM -0300, Melissa Wen wrote:
> > Initialize CRTC only with primary plane (without cursor) as a preparation
> > to init overlay plane before cursor plane and keep cursor on the top.
> >
> > Signed-off-by:
On 02/23, Daniel Vetter wrote:
> On Tue, Feb 23, 2021 at 11:21 AM Melissa Wen wrote:
> >
> > On 02/22, Daniel Vetter wrote:
> > > On Sat, Feb 20, 2021 at 11:42:12AM -0300, Melissa Wen wrote:
> > > > Add support to overlay plane, in addition to primary and cur
1 - 100 of 677 matches
Mail list logo
