Re: A review of dm-writeboost

2013-10-19 Thread Akira Hayakawa
Dave, # -EIO retuned corrupts XFS I turned up lockdep, frame pointer, xfs debug and also changed to 3.12.0-rc5 from rc1. What's changed is that the problem we discussed in previous mails *never* reproduce. However, if I turn off the lockdep only it hangs up by setting blockup to 1 and then to 0

Re: [PATCH RESENT] staging: r8188eu: Move writeN buffer off stack

2013-10-19 Thread Dan Carpenter
On Fri, Oct 18, 2013 at 04:39:04PM -0500, Larry Finger wrote: The driver places a 254-byte buffer on the stack when writing long output. To reduce stack usage, a buffer of the required length is acquired using kmemdup(). The patch is badly whitespace dammaged. regards, dan carpenter

[PATCHv4 00/16] staging: usbip: Add kernel support for client ACLs

2013-10-19 Thread Dominik Paulus
Hi, sorry for the messed-up error checking. We fixed some of the style nitpicks and hopefully all of the mistakes you pointed out (thank you for that!). Regards, Dominik and Tobias ___ devel mailing list de...@linuxdriverproject.org

[PATCHv4 04/16] staging: usbip: Add ACL support to usbip bind

2013-10-19 Thread Dominik Paulus
Add the command line argument -a (--allow) to usbip bind to specify networks allowed to attach to the device and code to store the ACLs in sysfs. Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de Signed-off-by: Dominik Paulus dominik.pau...@fau.de Signed-off-by: Tobias Polzer

[PATCHv4 15/16] staging: usbip: Update documentation

2013-10-19 Thread Dominik Paulus
From: Tobias Polzer tobias.pol...@fau.de README was updated and cleaned. It now contains just one example, which was updated to use encryption. Also, the new crypto behaviour is documented. The usbip port command has been removed from the README, as it isn't supported by newer userland versions.

[PATCHv4 05/16] staging: usbip: Add support for ACLs in usbipd

2013-10-19 Thread Dominik Paulus
Interpret the ACLs stored in sysfs in usbipd and reject clients not matching one of the ACLs. Signed-off-by: Kurt Kanzenbach ly80t...@cip.cs.fau.de Signed-off-by: Dominik Paulus dominik.pau...@fau.de Signed-off-by: Tobias Polzer tobias.pol...@fau.de ---

[PATCHv4 13/16] staging: usbip: Wrap kernel_sendmsg()/recvmsg()

2013-10-19 Thread Dominik Paulus
This adds two simple wrappers around kernel_sendmsg() and kernel_recvmsg() that can be extended to perform additional cryptographic operations on the data before sending it. Signed-off-by: Dominik Paulus dominik.pau...@fau.de Signed-off-by: Tobias Polzer tobias.pol...@fau.de ---

[PATCHv4 06/16] staging: usbip: Add proper error reporting

2013-10-19 Thread Dominik Paulus
This patch adds new error codes and features extended error reporting in op_common packets. Signed-off-by: Dominik Paulus dominik.pau...@fau.de Signed-off-by: Tobias Polzer tobias.pol...@fau.de --- drivers/staging/usbip/userspace/src/usbip_attach.c | 4 +-

[PATCHv4 12/16] staging: usbip: Pass session keys to the kernel

2013-10-19 Thread Dominik Paulus
This extends the userspace code to write the generated session keys to sysfs in hexadecimal encoding after establishing the connection. The kernel code is modified to parse the session keys. Signed-off-by: Dominik Paulus dominik.pau...@fau.de Signed-off-by: Tobias Polzer tobias.pol...@fau.de ---

[PATCHv4 09/16] staging: usbip: Separate protocol/program version

2013-10-19 Thread Dominik Paulus
Not all new program versions necessarily introduce non-backwards-compatible protocol changes. We thus move the definition of the protocol version from configure.ac to usbip_network.h, where it logically belongs to. Signed-off-by: Dominik Paulus dominik.pau...@fau.de Signed-off-by: Tobias Polzer

[PATCHv4 14/16] staging: usbip: Add encryption support to kernel

2013-10-19 Thread Dominik Paulus
This adds code performing the actual encryption and authentication operations in the usbip kernel code. The whole data stream may now be encrypted and authenticated with AES-GCM and symmetric 128 bit keys. Signed-off-by: Dominik Paulus dominik.pau...@fau.de Signed-off-by: Tobias Polzer

[PATCHv4 07/16] staging: usbip: Handle usbip being started as user

2013-10-19 Thread Dominik Paulus
usbip now prints an error message when started as user and requiring root access. Also, some debug messages are changed to error messages so the command line utilities now print less confusing (and more verbose) error messages when not used correctly. Signed-off-by: Dominik Paulus

[PATCHv4 02/16] staging: usbip: Add kernel support for client ACLs

2013-10-19 Thread Dominik Paulus
This patch adds the possibility to stored ACLs for allowed clients for each stub device in sysfs. It adds a new sysfs entry called usbip_acl for each stub device, containing a list of CIDR masks of allowed clients. This file will be used by usbip and usbipd to store the ACL. Signed-off-by: Kurt

[PATCHv4 10/16] staging: usbip: TLS for all userspace communication

2013-10-19 Thread Dominik Paulus
This patch extends the TLS support to cover all communication in userspace. The TLS connection is released shortly before the socket is passed to the kernel. This requires for additional connection state to be passed between functions. We thus replaced the sockfd by a struct containing the TLS

[PATCHv4 16/16] staging: usbip: Increment version number to 1.2.1

2013-10-19 Thread Dominik Paulus
Also increment the kernel module version number to match the userspace version, as compatibility with old userspace utilities is now at least partially broken. Signed-off-by: Dominik Paulus dominik.pau...@fau.de Signed-off-by: Tobias Polzer tobias.pol...@fau.de ---

[PATCH] staging: lustre: libcfs: Remove new typedef in bitmap.h

2013-10-19 Thread Lisa Nguyen
Fix cfs_bitmap_t struct and function parameters to eliminate the Do not add new typedefs warning generated by checkpatch.pl and meet kernel coding style. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- .../staging/lustre/include/linux/libcfs/bitmap.h | 22 +++--- 1 file

Re: [PATCH] staging: lustre: libcfs: Remove new typedef in bitmap.h

2013-10-19 Thread Greg KH
On Sat, Oct 19, 2013 at 08:28:21AM -0700, Lisa Nguyen wrote: Fix cfs_bitmap_t struct and function parameters to eliminate the Do not add new typedefs warning generated by checkpatch.pl and meet kernel coding style. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com ---

Re: [PATCH 1/4] staging: xillybus: Remember device pointer for use with dev_* functions

2013-10-19 Thread Greg KH
On Sat, Oct 19, 2013 at 01:02:25AM +0300, Eli Billauer wrote: This is necessary so that xillybus_core uses the correct device pointer for PCIe devices in diagnostic message calls (dev_err, dev_warn and dev_info) Signed-off-by: Eli Billauer eli.billa...@gmail.com Nice job with these patches,

Re: [PATCH 00/11] staging: comedi: s626: more cleanups

2013-10-19 Thread Greg Kroah-Hartman
On Fri, Oct 18, 2013 at 02:40:48PM +0100, Ian Abbott wrote: Tidy up the s626 driver a bit more. In particular, the handling of encoder setup values is a bit hard to follow with lots of bit-shifting and masking, particularly when converting between the standardized setup values and the 'CRA'

Re: [PATCH v2] Staging: zram: Fix variable dereferenced before check

2013-10-19 Thread Greg KH
On Sat, Oct 19, 2013 at 10:01:42PM +0530, Rashika Kheria wrote: This patch fixes the following Smatch warning in zram_drv.c- ~/git/kernels/linux/drivers/staging/zram/zram_drv.c:663 reset_store() warn: variable dereferenced before check 'bdev' (see line 652)

[PATCH v2] staging: lustre: libcfs: Remove new typedef in bitmap.h

2013-10-19 Thread Lisa Nguyen
Fix cfs_bitmap struct, function parameters, and variable declarations to eliminate the Do not add new typedefs warning generated by checkpatch.pl and meet kernel coding style. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- Changes since v2: - Original patch had struct cfs_bitmap_t. Struct

Re: [PATCH v2] staging: lustre: libcfs: Remove new typedef in bitmap.h

2013-10-19 Thread Greg KH
On Sat, Oct 19, 2013 at 02:06:42PM -0700, Lisa Nguyen wrote: Fix cfs_bitmap struct, function parameters, and variable declarations to eliminate the Do not add new typedefs warning generated by checkpatch.pl and meet kernel coding style. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com ---

[PATCH v3] staging: lustre: libcfs: Remove new typedef in bitmap.h

2013-10-19 Thread Lisa Nguyen
Fix cfs_bitmap struct, function parameters, and variable declarations to resolve the Do not add new typedefs warning generated by checkpatch.pl in bitmap.h and meet kernel coding style. Signed-off-by: Lisa Nguyen l...@xenapiadmin.com --- Changes since v3: - Combining the previous two patch

Re: [PATCH v3] staging: lustre: libcfs: Remove new typedef in bitmap.h

2013-10-19 Thread Dan Carpenter
Your patch is great, but actually, are any of the functions in this header used? `grep cfs_bitmap drivers/staging/lustre/ -Rl` only shows this header file. Perhaps we can delete the whole thing? regards, dan carpenter ___ devel mailing list

Re: [PATCH 06/35] staging: comedi: adl_pci9118: sample types are unsigned

2013-10-19 Thread Ian Abbott
On 18/10/13 18:00, Hartley Sweeten wrote: On Wednesday, October 16, 2013 6:40 AM, Ian Abbott wrote: Sample values in comedi are generally represented as unsigned values. Change the `ao_data[]` and `dmabuf_virt[]` members of `struct pci9118_private` and various local variables dealing with

Re: [PATCH 06/35] staging: comedi: adl_pci9118: sample types are unsigned

2013-10-19 Thread Ian Abbott
On 18/10/13 18:24, Hartley Sweeten wrote: On Wednesday, October 16, 2013 6:40 AM, Ian Abbott wrote: Sample values in comedi are generally represented as unsigned values. Change the `ao_data[]` and `dmabuf_virt[]` members of `struct pci9118_private` and various local variables dealing with

Re: [PATCH 00/11] staging: comedi: s626: more cleanups

2013-10-19 Thread Ian Abbott
On 19/10/13 21:48, Greg Kroah-Hartman wrote: On Fri, Oct 18, 2013 at 02:40:48PM +0100, Ian Abbott wrote: Tidy up the s626 driver a bit more. In particular, the handling of encoder setup values is a bit hard to follow with lots of bit-shifting and masking, particularly when converting between

Re: [PATCH v2 1/3] imx-drm: Add mx6 hdmi transmitter support

2013-10-19 Thread Russell King - ARM Linux
On Wed, Oct 16, 2013 at 11:31:07AM -0700, Greg Kroah-Hartman wrote: On Wed, Oct 16, 2013 at 07:07:35PM +0100, Russell King - ARM Linux wrote: Sorry, but I don't think imx-drm is driving the hardware correctly, and I know that Greg wants it moved out of drivers/staging, but frankly it seems

Re: [PATCH v3] staging: lustre: libcfs: Remove new typedef in bitmap.h

2013-10-19 Thread Lisa Nguyen
On Sat, Oct 19, 2013 at 2:39 PM, Dan Carpenter dan.carpen...@oracle.com wrote: Your patch is great, but actually, are any of the functions in this header used? `grep cfs_bitmap drivers/staging/lustre/ -Rl` only shows this header file. Perhaps we can delete the whole thing? regards, dan