Hello Rashika,
On Fri, Oct 25, 2013 at 7:10 PM, Minchan Kim minc...@kernel.org wrote:
Hello Rashika,
First of all, thanks for looking this!
On Tue, Oct 22, 2013 at 07:00:57PM +0530, Rashika Kheria wrote:
This patch fixes the following Smatch warning in zram_drv.c-
On Fri, Oct 25, 2013 at 05:07:18PM +0800, Wei Yongjun wrote:
From: Wei Yongjun yongjun_...@trendmicro.com.cn
In case of error, the function platform_device_register_simple() returns
ERR_PTR() and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Remove user-defined BOOLEAN data type with C bool data
type.
Signed-off-by: Lisa Nguyen l...@xenapiadmin.com
---
drivers/staging/bcm/Adapter.h | 118 +++---
drivers/staging/bcm/CmHost.c | 6 +-
drivers/staging/bcm/CmHost.h | 2 +-
On Mon, Oct 28, 2013 at 12:12:17PM +0800, rucsoftsec wrote:
Please do not send HTML email, the mailing lists delete it.
I am so sorry! I made something wrong when genenrating the patch. I will do it
again soon later.
Your other patches are also incorrect, sorry.
By the way, the bug is found
Remove unnecessary spaces before semicolons to meet kernel
coding style.
Signed-off-by: Lisa Nguyen l...@xenapiadmin.com
---
drivers/staging/media/davinci_vpfe/dm365_ipipe.c| 2 +-
drivers/staging/media/davinci_vpfe/dm365_ipipe_hw.c | 4 ++--
drivers/staging/media/davinci_vpfe/dm365_isif.c
Rewrite the return statement in vpfe_video.c to eliminate the
use of a ternary operator. This will prevent the checkpatch.pl
script from generating a warning saying to remove () from
this particular return statement.
Signed-off-by: Lisa Nguyen l...@xenapiadmin.com
---
On Mon, Oct 28, 2013 at 06:26:49PM -0200, Fabio Estevam wrote:
From: Fabio Estevam fabio.este...@freescale.com
This is based on the initial work done by Sascha Hauer and Tony Prisk.
It looks like you've also taken some of the suggestions I've made too -
like the voltage drive and symbol
On Mon, Oct 28, 2013 at 3:11 PM, Greg KH gre...@linuxfoundation.org wrote:
On Mon, Oct 28, 2013 at 10:51:38PM +0100, Andi Shyti wrote:
- return (ret == 0) ? ret : -ETIMEDOUT ;
+ if (ret == 0)
+ return ret;
+ else
+ return -ETIMEDOUT;
I actually like more the
Hi Greg,
If you write it like this:
return !ret ? ret : -ETIMEDOUT;
checkpatch shouldn't complain.
No, but I will.
That's horrid code, please be specific and readable, no one should ever
use ?: syntax except within function parameters.
why then don't we define it in the
This patch replaces LARGE_INTEGER with u64
in Adapter.h
Signed-off-by: Kevin McKinney klmckinn...@gmail.com
---
drivers/staging/bcm/Adapter.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index
This patch replaces B_UINT16 with u16
in Adapter.h
Signed-off-by: Kevin McKinney klmckinn...@gmail.com
---
drivers/staging/bcm/Adapter.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index a5dab86..01788d3
This patch replaces UINT32 with u32
in Adapter.h
Signed-off-by: Kevin McKinney klmckinn...@gmail.com
---
drivers/staging/bcm/Adapter.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
index
This patch replaces PVOID with void *
in Adapter.h
Signed-off-by: Kevin McKinney klmckinn...@gmail.com
---
drivers/staging/bcm/Adapter.h | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
This patch removes a space before semicolon as
specified by checkpatch.pl.
Signed-off-by: Kevin McKinney klmckinn...@gmail.com
---
drivers/staging/bcm/Adapter.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/Adapter.h b/drivers/staging/bcm/Adapter.h
This patch replace UCHAR with u8
in Adapter.h
Signed-off-by: Kevin McKinney klmckinn...@gmail.com
---
drivers/staging/bcm/Adapter.h | 82 -
1 file changed, 41 insertions(+), 41 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h
This patch removes typedef for _U_IP_ADDRESS, and
changes the name of the struct to bcm_ip_address. In
addition, any calls to struct U_IP_ADDRESS are
changed to call directly.
Signed-off-by: Kevin McKinney klmckinn...@gmail.com
---
drivers/staging/bcm/Adapter.h |8
1 file changed, 4
These patches fix several issues in Adapter.h
Kevin McKinney (11):
Staging: bcm: Fix WARNING: space prohibited before semicolon.
Staging: bcm: Remove typedef for _U_IP_ADDRESS and call directly.
Staging: bcm: Replace USHORT with unsigned short in Adapter.h
Staging: bcm: Replaces UCHAR
This patch replaces UINT with unsigned
int in Adapter.h
Signed-off-by: Kevin McKinney klmckinn...@gmail.com
---
drivers/staging/bcm/Adapter.h | 84 -
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a/drivers/staging/bcm/Adapter.h
18 matches
Mail list logo
