The function interval_erase_color() in lustre/ldlm/interval_tree.c is
too long and can be refactored. Most of the statements are same for if
and else conditions.I am passing a new variable n based on which the
differences are
recognised.
This fixes the following checkpatch.pl warning in
This patch fixes the following checkpatch.pl warning in
lustre/ldlm/interval_tree.c
ERROR: return is not a function, parentheses are not required
Signed-off-by: Monam Agarwal monamagarwal...@gmail.com
---
drivers/staging/lustre/lustre/ldlm/interval_tree.c |4 ++--
1 file changed, 2
This patch fixes the following checkpatch.pl warning in
lustre/ldlm/interval_tree.c
ERROR: return is not a function, parentheses are not required
Signed-off-by: Monam Agarwal monamagarwal...@gmail.com
---
Changes since version 1:
* Incoorect signed-off-by line
Changes since version 2:
* Forgot
On Sat, Jan 11, 2014 at 04:30:33PM +0530, Monam Agarwal wrote:
The function interval_erase_color() in lustre/ldlm/interval_tree.c is
too long and can be refactored. Most of the statements are same for if
and else conditions. I am passing a new variable n based on which the
differences are
I took n as a flag to decide whether parent-in_left == node is true
or not in the called function.
Should I use some other name for the flag.
On Sat, Jan 11, 2014 at 4:49 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Sat, Jan 11, 2014 at 04:30:33PM +0530, Monam Agarwal wrote:
The
On Fri, Jan 10, 2014 at 11:23:37PM +, Russell King - ARM Linux wrote:
We do this in DT by providing a superdevice node which specifies
the components, eg:
imx-drm {
compatible = fsl,drm;
crtcs = ipu1;
connectors = hdmi;
};
Saschas
On Sat, Jan 11, 2014 at 04:56:44PM +0530, Monam Agarwal wrote:
I took n as a flag to decide whether parent-in_left == node is true
or not in the called function.
So n stands for node?
Should I use some other name for the flag.
Yes.
regards,
dan carpenter
On Sat, Jan 11, 2014 at 12:31:19PM +0100, Robert Schwebel wrote:
On Fri, Jan 10, 2014 at 11:23:37PM +, Russell King - ARM Linux wrote:
We do this in DT by providing a superdevice node which specifies
the components, eg:
imx-drm {
compatible = fsl,drm;
This fixes the following checkpatch.pl warning in
lustre/ldlm/ldlm_extent.c
WARNING: unnecessary whitespace before a quoted newline
Signed-off-by: Monam Agarwal monamagarwal...@gmail.com
---
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
The patch fixes the following checkpatch.pl error in
lustre/ldlm/ldlm_extent.c
ERROR: trailing statements should be on next line
Signed-off-by: Monam Agarwal monamagarwal...@gmail.com
---
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
On Sat, Jan 11, 2014 at 5:09 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Sat, Jan 11, 2014 at 04:56:44PM +0530, Monam Agarwal wrote:
I took n as a flag to decide whether parent-in_left == node is true
or not in the called function.
So n stands for node?
Should I use some other name
This fixes the following checkpatch error in lustre/ldlm/ldlm_flock.c
ERROR: return is not a function, parentheses are not required
Signed-off-by: Monam Agarwal monamagarwal...@gmail.com
---
drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |8
1 file changed, 4 insertions(+), 4
This patch fixes the following checkpatch.pl warning in
lustre/ldlm/ldlm_flock.c
WARNING: line over 80 characters in the file
Signed-off-by: Monam Agarwal monamagarwal...@gmail.com
---
drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
his patch fixes the following type of checkpatch.pl errors in
lustre/ldlm/ldlm_flock.c
ERROR: trailing statements should be on next line
Signed-off-by: Monam Agarwal monamagarwal...@gmail.com
---
drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |4 ++--
1 file changed, 2 insertions(+), 2
---
drivers/staging/comedi/drivers/das1800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das1800.c
b/drivers/staging/comedi/drivers/das1800.c
index 1880038..8fb87df 100644
--- a/drivers/staging/comedi/drivers/das1800.c
+++
---
drivers/staging/comedi/drivers/das6402.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das6402.c
b/drivers/staging/comedi/drivers/das6402.c
index fb25cb8..37ae356 100644
--- a/drivers/staging/comedi/drivers/das6402.c
+++
On Sat, 2014-01-11 at 17:11 +0530, Monam Agarwal wrote:
This fixes the following checkpatch.pl warning in
lustre/ldlm/ldlm_extent.c
WARNING: unnecessary whitespace before a quoted newline
I rather doubt this was the checkpatch message here.
Please make sure your commit message and subject
This introduces fls in lustre/ldlm/ldlm_extent.c
to find the last set bit.
It also fixes the following checkpatch.pl warning in
lustre/ldlm/ldlm_extent.c
WARNING: space prohibited before semicolon.
The patch also fixes the following checkpatch.pl error in
lustre/ldlm/ldlm_extent.c
ERROR:
The patch fixes the following checkpatch.pl error in
lustre/ldlm/ldlm_flock.c
ERROR: return is not a function, parentheses are not required
Signed-off-by: Monam Agarwal monamagarwal...@gmail.com
---
drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |8
1 file changed, 4
On Sun, 2014-01-12 at 01:02 +0530, Monam Agarwal wrote:
This introduces fls in lustre/ldlm/ldlm_extent.c
to find the last set bit.
[]
Signed-off-by: Monam Agarwal monamagarwal...@gmail.com
---
Changes since v1:
*Incorrect commit message
*Use of fls function
[]
diff --git
This patch fixes the following checkpatch.pl warning in
lustre/ldlm/ldlm_flock.c
WARNING: quoted string split across lines
Signed-off-by: Monam Agarwal monamagarwal...@gmail.com
---
drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
The patch fixes the following checkpatch.pl error in
lustre/ldlm/ldlm_flock.c
WARNING: line over 80 characters in the file
Signed-off-by: Monam Agarwal monamagarwal...@gmail.com
---
drivers/staging/lustre/lustre/ldlm/ldlm_flock.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
This introduces fls in lustre/ldlm/ldlm_extent.c
to find the last set bit.
Signed-off-by: Monam Agarwal monamagarwal...@gmail.com
---
Changes since v1:
* Incorrect commit message
* Use of fls function
Changes since v2:
* Removal of extra variable
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c
On Sun, Jan 12, 2014 at 01:31:41AM +0530, Monam Agarwal wrote:
The patch fixes the following checkpatch.pl error in
lustre/ldlm/ldlm_flock.c
ERROR: return is not a function, parentheses are not required
Signed-off-by: Monam Agarwal monamagarwal...@gmail.com
I'm totally confused here. You
On Thu, Jan 09, 2014 at 09:37:09PM +0100, Tim Jester-Pfadt wrote:
This patchset fixes all occurrences of the space required after ','
space required around '=' aswell as foo * bar related checkpatch.pl
errors in
rtl8188eu.
The patchset does not fix the remaining 80 character limit
On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote:
This driver downloads Xilinx FPGA firmware using gpio pins.
It loads Xilinx FPGA bitstream format firmware image and
program the Xilinx FPGA using SelectMAP (parallel) mode.
Signed-off-by: Insop Song insop.s...@gainspeed.com
This
On Sat, Jan 11, 2014 at 12:51:28PM -0800, Greg KH wrote:
On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote:
This driver downloads Xilinx FPGA firmware using gpio pins.
It loads Xilinx FPGA bitstream format firmware image and
program the Xilinx FPGA using SelectMAP (parallel) mode.
On Sat, Jan 11, 2014 at 12:51 PM, Greg KH gre...@linuxfoundation.org wrote:
On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote:
This driver downloads Xilinx FPGA firmware using gpio pins.
It loads Xilinx FPGA bitstream format firmware image and
program the Xilinx FPGA using SelectMAP
Fix a memory leak in the wpa_ioctl() error handling path so that 'param' is
also freed correctly in case of an unsupported ioctl.
Detected by Coverity: CID 144380.
Signed-off-by: Christian Engelmayer cenge...@gmx.at
---
drivers/staging/vt6655/wpactl.c | 4 ++--
1 file changed, 2 insertions(+), 2
This patch fixes all spaces required after ',' and around '=' aswell as '=='
checkpatch.pl errors for rtl8188eu.
Signed-off-by: Tim Jester-Pfadt t...@gmx.de
---
drivers/staging/rtl8188eu/include/Hal8188EPwrSeq.h | 2 +-
drivers/staging/rtl8188eu/include/odm.h| 2 +-
This patch fixes all foo * bar, foo*bar, foo* bar checkpatch.pl errors for
rtl8188eu.
Signed-off-by: Tim Jester-Pfadt t...@gmx.de
---
drivers/staging/rtl8188eu/include/rtl8188e_hal.h | 2 +-
drivers/staging/rtl8188eu/include/rtl8188e_recv.h | 6 +++---
On Sat, Jan 11, 2014 at 1:05 PM, Greg KH gre...@linuxfoundation.org wrote:
On Sat, Jan 11, 2014 at 12:51:28PM -0800, Greg KH wrote:
On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote:
This driver downloads Xilinx FPGA firmware using gpio pins.
It loads Xilinx FPGA bitstream format
On Sat, Jan 11, 2014 at 03:56:48PM -0800, Insop Song wrote:
On Sat, Jan 11, 2014 at 1:05 PM, Greg KH gre...@linuxfoundation.org wrote:
On Sat, Jan 11, 2014 at 12:51:28PM -0800, Greg KH wrote:
On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote:
This driver downloads Xilinx FPGA
On Sat, Jan 11, 2014 at 02:16:05PM -0800, Insop Song wrote:
On Sat, Jan 11, 2014 at 12:51 PM, Greg KH gre...@linuxfoundation.org wrote:
On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote:
This driver downloads Xilinx FPGA firmware using gpio pins.
It loads Xilinx FPGA bitstream
On Sat, Jan 11, 2014 at 4:10 PM, Greg KH gre...@linuxfoundation.org wrote:
On Sat, Jan 11, 2014 at 03:56:48PM -0800, Insop Song wrote:
On Sat, Jan 11, 2014 at 1:05 PM, Greg KH gre...@linuxfoundation.org wrote:
On Sat, Jan 11, 2014 at 12:51:28PM -0800, Greg KH wrote:
On Thu, Jan 09, 2014 at
On Sat, Jan 11, 2014 at 4:09 PM, Greg KH gre...@linuxfoundation.org wrote:
On Sat, Jan 11, 2014 at 02:16:05PM -0800, Insop Song wrote:
On Sat, Jan 11, 2014 at 12:51 PM, Greg KH gre...@linuxfoundation.org wrote:
On Thu, Jan 09, 2014 at 11:48:04AM -0800, Insop Song wrote:
This driver downloads
Handle the 0xE1 prefix.
Signed-off-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/input/serio/hyperv-keyboard.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/input/serio/hyperv-keyboard.c
b/drivers/input/serio/hyperv-keyboard.c
index 3a83c3c..6132619
37 matches
Mail list logo
