Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-02-07 Thread Daniel Vetter
I've chatted a bit with Hans Verkuil about this topic at fosdem and apparently both v4l and alsa have something like this already in their helper libraries. Adding more people as fyi in case they want to switch to the new driver core stuff from Russell. -Daniel On Thu, Jan 2, 2014 at 10:27 PM,

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 10:04:30AM +0100, Daniel Vetter wrote: I've chatted a bit with Hans Verkuil about this topic at fosdem and apparently both v4l and alsa have something like this already in their helper libraries. Adding more people as fyi in case they want to switch to the new driver

Re: [patch 2/2] staging: r8188eu: overflow in rtw_p2p_get_go_device_address()

2014-02-07 Thread walter harms
Am 03.02.2014 23:38, schrieb Dan Carpenter: The go_devadd_str[] array is two characters too small to hold the address so we corrupt memory. I've changed the user space API slightly and I don't have a way to test if this breaks anything. In the original code we truncated away the last

Re: [PATCH RESEND 3/3] staging: et131x: fix make W=1 build warning

2014-02-07 Thread Mark Einon
On Fri, Feb 07, 2014 at 07:12:50PM +0800, Zhao, Gang wrote: Mark, could you look at this patch? It has not been acked. Sure, in time, I'm making my way through them. Unfortunately kernel programming is not my day job, and gets done in my spare time (which is a bit limited at present). I aim to

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-02-07 Thread Jean-Francois Moine
On Fri, 7 Feb 2014 09:46:56 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Feb 07, 2014 at 10:04:30AM +0100, Daniel Vetter wrote: I've chatted a bit with Hans Verkuil about this topic at fosdem and apparently both v4l and alsa have something like this already in their

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 12:57:21PM +0100, Jean-Francois Moine wrote: I started to use your code (which works fine, thanks), and it avoids a lot of problems, especially, about probe_defer in a DT context. I was wondering if your componentised mechanism could be extended to the devices defined

Re: [PATCH 33/48] staging: comedi: das1800: use comedi_timeout()

2014-02-07 Thread Ian Abbott
On 2014-02-06 23:49, H Hartley Sweeten wrote: Use comedi_timeout() to wait for the analog input end-of-conversion. Use break to exit the loop so that the common path can be used to unlock the spinlock. I don't think you can rely on jiffies being updated while holding the spin-lock with

[PATCH 4/6] staging: lustre: Fix typo in sec_gss.c

2014-02-07 Thread Masanari Iida
This patch fixed spelling typo in comments wihtin sec_gss.c Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/lustre/lustre/ptlrpc/gss/sec_gss.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git

[PATCH 6/6] staging: lustre: Fix typo in lustre/ptlrpc

2014-02-07 Thread Masanari Iida
This patch fixed spelling typo in lustre/ptlrpc. Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/lustre/lustre/ptlrpc/events.c | 2 +- drivers/staging/lustre/lustre/ptlrpc/import.c | 4 ++-- drivers/staging/lustre/lustre/ptlrpc/layout.c | 2 +-

Re: [PATCH 35/48] staging: comedi: dt2814: use comedi_timeout()

2014-02-07 Thread Ian Abbott
On 2014-02-06 23:49, H Hartley Sweeten wrote: Use comedi_timeout() to wait for the analog input end-of-conversion. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com Cc: Ian Abbott abbo...@mev.co.uk Cc: Greg Kroah-Hartman gre...@linuxfoundation.org ---

[PATCH 5/6] staging: lustre: Fix typo in lustre/ptlrpc/gss

2014-02-07 Thread Masanari Iida
This patch fixed spelling typo in comments within lustre/ptlrpc/gss. Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/lustre/lustre/ptlrpc/gss/gss_cli_upcall.c | 2 +- drivers/staging/lustre/lustre/ptlrpc/gss/gss_keyring.c| 2 +-

[PATCH 1/6] staging: lustre: Fix typo in client.c

2014-02-07 Thread Masanari Iida
This patch fixed spelling typo found in client.c Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/lustre/lustre/ptlrpc/client.c | 32 +-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/client.c

Re: [PATCH 43/48] staging: comedi: pcl818: use comedi_timeout()

2014-02-07 Thread Ian Abbott
On 2014-02-06 23:49, H Hartley Sweeten wrote: Use comedi_timeout() to wait for the analog input end-of-conversion. The interrupt routine also uses the timeout check to make sure data is actually available. Using NULL here for the 'insn' is safe since nothing uses it. Interrupt routine,

Re: [PATCH 47/48] staging: comedi: move (*insn_{read, write}) timeout debug message to core

2014-02-07 Thread Ian Abbott
On 2014-02-06 23:49, H Hartley Sweeten wrote: All the comedi drivers that now use comedi_timeout() return a standard errno when a timeout occurs. Remove all the private debug messages and have the core output the dev_dbg() message. Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com

Re: [PATCH RESEND 3/3] staging: et131x: fix make W=1 build warning

2014-02-07 Thread Greg Kroah-Hartman
On Fri, Feb 07, 2014 at 07:12:50PM +0800, Zhao, Gang wrote: Mark, could you look at this patch? It has not been acked. 1 day after sending this you are asking for review? Please realize that people are busy and have other things to do. If after a week or so there is no response, is it ok to

[PATCH RFC 2/2] drivers/base: declare phandle DT nodes as components

2014-02-07 Thread Jean-Francois Moine
At system startup time, some devices depends on the availability of some other devices before starting. The infrastructure for componentised subsystems permits to handle this dependence, each driver defining its own role. This patch does an automatic creation of the lowest components in case of

[PATCH RFC 1/2] drivers/base: permit base components to omit the bind/unbind ops

2014-02-07 Thread Jean-Francois Moine
Some simple components don't need to do any specific action on bind to / unbind from a master component. This patch permits such components to omit the bind/unbind operations. Signed-off-by: Jean-Francois Moine moin...@free.fr --- drivers/base/component.c | 9 +++-- 1 file changed, 7

[PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-07 Thread Jean-Francois Moine
This patch series tries to simplify the code of simple devices in case they are part of componentised subsystems, are declared in a DT, and are not using the component bin/unbind functions. Jean-Francois Moine (2): drivers/base: permit base components to omit the bind/unbind ops drivers/base:

[PATCH v3 2/2] drivers/base: declare phandle DT nodes as components

2014-02-07 Thread Jean-Francois Moine
At system startup time, some devices depends on the availability of some other devices before starting. The infrastructure for componentised subsystems permits to handle this dependence, each driver defining its own role. This patch does an automatic creation of the lowest components in case of

[PATCH v3 0/2] *** SUBJECT HERE ***

2014-02-07 Thread Jean-Francois Moine
*** BLURB HERE *** Jean-Francois Moine (2): drivers/base: permit base components to omit the bind/unbind ops drivers/base: declare phandle DT nodes as components drivers/base/component.c | 21 +++-- drivers/base/core.c | 18 ++ include/linux/of.h |

Re: [PATCH RFC 1/2] drivers/base: permit base components to omit the bind/unbind ops

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 04:55:00PM +0100, Jean-Francois Moine wrote: Some simple components don't need to do any specific action on bind to / unbind from a master component. This patch permits such components to omit the bind/unbind operations. Signed-off-by: Jean-Francois Moine

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 06:11:08PM +0100, Jean-Francois Moine wrote: This patch series tries to simplify the code of simple devices in case they are part of componentised subsystems, are declared in a DT, and are not using the component bin/unbind functions. I wonder - I said earlier today

Re: [PATCH RFC 2/2] drivers/base: declare phandle DT nodes as components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 05:53:27PM +0100, Jean-Francois Moine wrote: At system startup time, some devices depends on the availability of some other devices before starting. The infrastructure for componentised subsystems permits to handle this dependence, each driver defining its own role.

Re: [PATCH] staging: ced1401: fix coding style in ced_ioc.c (resend)

2014-02-07 Thread Greg KH
On Wed, Jan 15, 2014 at 10:37:13PM +0100, Pol Eyschen wrote: Fixed checkpatch.pl issues and removed redundant comment in ced_ioc.cs Signed-off-by: Pol Eyschen poleysc...@gmail.com --- drivers/staging/ced1401/ced_ioc.c | 483 + 1 file changed, 271

RE: [PATCH 41/48] staging: comedi: pcl812: use comedi_timeout()

2014-02-07 Thread Hartley Sweeten
On Friday, February 07, 2014 8:34 AM, Ian Abbott wrote: On 2014-02-06 23:49, H Hartley Sweeten wrote: Use comedi_timeout() to wait for the analog input end-of-conversion. Combine the logic for the pcl812 and acl812 end-of-conversion in the helper function to simplify the driver. The

Re: [PATCH RESEND 3/3] staging: et131x: fix make W=1 build warning

2014-02-07 Thread Greg Kroah-Hartman
On Thu, Feb 06, 2014 at 12:10:36AM +0800, Zhao, Gang wrote: fix make W=1 warning: drivers/staging/et131x/et131x.c: In function ‘et1310_setup_device_for_multicast’: drivers/staging/et131x/et131x.c:1052:6: warning: variable ‘pm_csr’ set but not used [-Wunused-but-set-variable] u32 pm_csr;

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-07 Thread Jean-Francois Moine
On Fri, 7 Feb 2014 17:33:26 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Feb 07, 2014 at 06:11:08PM +0100, Jean-Francois Moine wrote: This patch series tries to simplify the code of simple devices in case they are part of componentised subsystems, are declared in a

Re: [PATCH 5/5] drivers:staging:dgnc:dpacompat.h- removed checkpatch.pl reported warnings

2014-02-07 Thread Greg KH
On Thu, Jan 30, 2014 at 07:14:02PM +0530, Avinash kumar wrote: drivers:staging:dgnc:dpacompat.h- removed following checkpatch.pl reported warnings sccc@ubuntu:~/lk/rc/linux$ ./scripts/checkpatch.pl --terse --file drivers/staging/dgnc/dpacompat.h drivers/staging/dgnc/dpacompat.h:109:

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 07:42:04PM +0100, Jean-Francois Moine wrote: On Fri, 7 Feb 2014 17:33:26 + Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Fri, Feb 07, 2014 at 06:11:08PM +0100, Jean-Francois Moine wrote: This patch series tries to simplify the code of simple devices

[PATCH 2/6] staging: lustre: Fix typo in service.c

2014-02-07 Thread Masanari Iida
This patch fixed spelling typo founx in service.c Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/lustre/lustre/ptlrpc/service.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/service.c

RE: Drivers/hv

2014-02-07 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Wednesday, January 29, 2014 1:16 PM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com Subject: Re: Drivers/hv On

Re: Drivers/hv

2014-02-07 Thread Greg KH
On Fri, Feb 07, 2014 at 07:06:00PM +, KY Srinivasan wrote: -Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Wednesday, January 29, 2014 1:16 PM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;

RE: Drivers/hv

2014-02-07 Thread KY Srinivasan
-Original Message- From: Greg KH [mailto:gre...@linuxfoundation.org] Sent: Friday, February 07, 2014 11:12 AM To: KY Srinivasan Cc: linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; jasow...@redhat.com Subject: Re: Drivers/hv On

Re: [PATCH 01/48] staging: comedi: introduce comedi_timeout()

2014-02-07 Thread Ian Abbott
On 2014-02-06 23:48, H Hartley Sweeten wrote: Introduce a comedi core helper function to handle the boilerplate needed by the drivers to wait for a condition to occur. Typically this condition is the analog input/output end-of-conversion used with the comedi (*insn_read) and (*insn_write)

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 06:11:08PM +0100, Jean-Francois Moine wrote: This patch series tries to simplify the code of simple devices in case they are part of componentised subsystems, are declared in a DT, and are not using the component bin/unbind functions. Here's my changes to the TDA998x

Re: [PATCH v3 0/3] Add modules for realtek USB card reader

2014-02-07 Thread Greg Kroah-Hartman
On Thu, Feb 06, 2014 at 10:35:04PM +0800, rogera...@realtek.com wrote: From: Roger Tseng rogera...@realtek.com This patchset adds modules to support Realtek USB vendor specific class flash card reader: one base module in MFD subsystem and two host modules in both mmc and memstick subsystems.

Re: [PATCH V4 1/1] Drivers: hv: Implement the file copy service

2014-02-07 Thread Greg KH
On Tue, Jan 21, 2014 at 05:43:53PM -0800, K. Y. Srinivasan wrote: +/* + * Create a char device that can support read/write for passing + * the payload. + */ +static struct cdev fcopy_cdev; +static struct class *cl; +static struct device *sysfs_dev; Why not just be a misc device, you only

Re: [PATCH V2 1/1] Drivers: hv: vmbus: Extract the mmio information from DSDT

2014-02-07 Thread Greg KH
On Wed, Jan 29, 2014 at 06:14:39PM -0800, K. Y. Srinivasan wrote: On Gen2 firmware, Hyper-V does not emulate the PCI bus. However, the MMIO information is packaged up in DSDT. Extract this information and export it for use by the synthetic framebuffer driver. This is the only driver that needs

[PATCH] staging: r8188eu: Fix missing header

2014-02-07 Thread Larry Finger
Commit 2397c6e0927675d983b34a03401affdb64818d07 entitled staging: r8188eu: Remove wrappers around vmalloc and vzalloc and commit: 03bd6aea7ba610a1a19f840c373624b8b0adde0d entitled staging: r8188eu: Remove wrappers around vfree failed to add the header file needed to provide vzalloc and vfree.

Re: [PATCH] staging: r8188eu: Fix missing header

2014-02-07 Thread Greg KH
On Fri, Feb 07, 2014 at 05:12:10PM -0600, Larry Finger wrote: Commit 2397c6e0927675d983b34a03401affdb64818d07 entitled staging: r8188eu: Remove wrappers around vmalloc and vzalloc and commit: 03bd6aea7ba610a1a19f840c373624b8b0adde0d entitled staging: r8188eu: Remove wrappers around vfree

Re: [PATCH] staging: r8188eu: Fix missing header

2014-02-07 Thread Larry Finger
On 02/07/2014 06:04 PM, Greg KH wrote: On Fri, Feb 07, 2014 at 05:12:10PM -0600, Larry Finger wrote: Commit 2397c6e0927675d983b34a03401affdb64818d07 entitled staging: r8188eu: Remove wrappers around vmalloc and vzalloc and commit: 03bd6aea7ba610a1a19f840c373624b8b0adde0d entitled staging:

Re: [PATCH RFC 0/2] drivers/base: simplify simple DT-based components

2014-02-07 Thread Russell King - ARM Linux
On Fri, Feb 07, 2014 at 06:59:11PM +, Russell King - ARM Linux wrote: Sorry. Deferred probe does work, it's been tested with imx-drm, not only from the master component but also the sub-components. There's no problem here. Here's the proof that it also works with the Cubox, and armada

[PATCH V2] staging: r8188eu: Fix missing header

2014-02-07 Thread Larry Finger
Commit 2397c6e0927675d983b34a03401affdb64818d07 entitled staging: r8188eu: Remove wrappers around vmalloc and vzalloc and commit: 03bd6aea7ba610a1a19f840c373624b8b0adde0d entitled staging: r8188eu: Remove wrappers around vfree failed to add the header file needed to provide vzalloc and vfree.

[PATCH 2/2] staging: android: remove unused constant, BINDER_SET_IDLE_PRIORITY

2014-02-07 Thread SeongJae Park
Remove constant BINDER_SET_IDLE_PRIORITY because it is not used from anywhere. Signed-off-by: SeongJae Park sj38.p...@gmail.com --- drivers/staging/android/binder.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/android/binder.h

[PATCH 1/2] staging: android: binder: use whitespace consistently

2014-02-07 Thread SeongJae Park
Whitespace between #define keyword and BINDER_* constants are space in some point and tab in some point. Using space or tab is just writer's choice. But, let's use them more consistently. Signed-off-by: SeongJae Park sj38.p...@gmail.com --- drivers/staging/android/binder.h | 10 +- 1

[PATCH] Staging: comedi: fix memory leak in comedi_bond.c

2014-02-07 Thread Chase Southwood
We allocate bdev and then krealloc the devs pointer in order to add bdev at the end of the devpriv-devs array list. But if for some reason this krealloc fails, we need to free bdev before returning an error otherwise this memory is leaked. Signed-off-by: Chase Southwood chase.southw...@yahoo.com