On Mon, Feb 10, 2014 at 10:59:14AM +0900, Daeseok Youn wrote:
@@ -1376,14 +1376,14 @@ static int ion_debug_heap_show(struct seq_file *s,
void *unused)
}
}
mutex_unlock(dev-buffer_lock);
- seq_printf(s, \n);
+
On Sun, Feb 09, 2014 at 07:05:24PM -0800, Surendra Patil wrote:
Fixed MACRO,Extern and parentheses Coding style warnings and errors - listed
only few
bpctl_mod.c:120: WARNING: externs should be avoided in .c files
bpctl_mod.c:121: WARNING: externs should be avoided in .c files
Thanks for reviewing.
Yes, I just followed by reports of checkpatch.pl.
But I don't understand why I can use of seq_puts() in the middle of
seq_printf() calls.
I have been trying to search why that is not good but I didn't find
anything about that.
And I saw patches which were already merged
This patch removes an unnecessary local variable defined
in the function imx_drm_driver_unload() so as to fix the
following build warning.
drivers/staging/imx-drm/imx-drm-core.c: \
In function ‘imx_drm_driver_unload’:
drivers/staging/imx-drm/imx-drm-core.c:87:25: \
warning: unused variable
On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote:
This patch removes an unnecessary local variable defined
in the function imx_drm_driver_unload() so as to fix the
following build warning.
drivers/staging/imx-drm/imx-drm-core.c: \
In function ‘imx_drm_driver_unload’:
On Mon, Feb 10, 2014 at 06:42:57PM +0800, Liu Ying wrote:
On 02/10/2014 06:29 PM, Russell King - ARM Linux wrote:
On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote:
This patch removes an unnecessary local variable defined
in the function imx_drm_driver_unload() so as to fix the
On Mon, Feb 10, 2014 at 07:23:46PM +0900, DaeSeok Youn wrote:
Thanks for reviewing.
Yes, I just followed by reports of checkpatch.pl.
But I don't understand why I can use of seq_puts() in the middle of
seq_printf() calls.
I have been trying to search why that is not good but I didn't find
On 02/10/2014 06:29 PM, Russell King - ARM Linux wrote:
On Mon, Feb 10, 2014 at 06:29:45PM +0800, Liu Ying wrote:
This patch removes an unnecessary local variable defined
in the function imx_drm_driver_unload() so as to fix the
following build warning.
drivers/staging/imx-drm/imx-drm-core.c:
OK. I will re-send this patch except replacing seq_printf() with seq_puts().
Your review helped me a lot.
Thanks.
Daeseok Youn.
2014-02-10 19:52 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com:
On Mon, Feb 10, 2014 at 07:23:46PM +0900, DaeSeok Youn wrote:
Thanks for reviewing.
Yes, I just
From: Roger Tseng rogera...@realtek.com
Realtek USB card reader provides a channel to transfer command or data to
flash
memory cards. This driver exports host instances for mmc and memstick
subsystems
and handles basic works.
Signed-off-by: Roger Tseng rogera...@realtek.com
---
On Fri, 7 Feb 2014 09:15:40 +
Mark Einon mark.ei...@gmail.com wrote:
On Wed, Feb 05, 2014 at 09:56:41PM +0800, Zhao, Gang wrote:
@@ -2124,7 +2124,11 @@ static int et131x_rx_dma_memory_alloc(struct
et131x_adapter *adapter)
/* Alloc memory for the lookup table */
We have the drm_device available, so rather than storing it and then
using the stored version, us the one we already have available to us.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-drm-core.c | 16
1 file changed, 8 insertions(+), 8
Rather than manually writing each register sequentially, we can use a
loop to reduce the amount of code.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-hdmi.c | 40 +-
1 file changed, 14 insertions(+), 26 deletions(-)
There's no point in using the clk API for this; we end up having to
violate the layering this provides.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/ipu-v3/ipu-di.c | 328 ++--
1 file changed, 105 insertions(+), 223 deletions(-)
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-hdmi.c | 49 +-
1 file changed, 22 insertions(+), 27 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-hdmi.c
b/drivers/staging/imx-drm/imx-hdmi.c
index
Many of the variables for the audio clock regenerator (CTS/N) were not
initialised in any way. The pixel rate which was being used also
wasn't being adjusted at all when the display mode is modified.
Get rid of the seaprate 'pixel_clk_rate', and use the stored pixel
clock rate instead. Pass
Rather than having large if() and switch() statements, provide a table
to look up the register settings for various clock rates.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-hdmi.c | 250 ++---
1 file changed, 95
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-hdmi.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-hdmi.c
b/drivers/staging/imx-drm/imx-hdmi.c
index f3a1f5e2e492..107e73788030 100644
The DI clock selection was very rudimentary: it would statically use
either the IPU internal clock or the DI external clock depending on
which encoder was being used. In the case of HDMI, it would always
use the IPU clock.
Moreover, using the IPU clock resulted in fractional divisors, which
are
There are a load of read-modify-write patterns to change bitfields in
various registers in this driver; provide a helper to perform this
manipulation.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-hdmi.c | 182 +
1
The DRM core indexes vblank by number, so there's little point
maintaining a list, and have to scan the list to find the appropriate
structure. Instead, use an array of pointers to the CRTCs.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-drm-core.c | 57
The encoder format passed into imx_drm_crtc_panel_format*() is the
encoder format used for DRM in most cases; the HDMI encoder sets
this to none, but this is incorrect, it should be TMDS.
Since this is the case, we can pass the drm_encoder structure
directly into this function and use the
Provide a common connector mode validation function, which can be used
to limit the available modes according to other components in the
system.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-drm-core.c | 7 +++
drivers/staging/imx-drm/imx-drm.h
Convert imx-hdmi to be a component device; it will bind and unbind
at the appropriate moment in the main DRM driver's functions.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-hdmi.c | 41 +++---
1 file changed, 29
Delay publishing sysfs connector entries until all components have
initialised. This reduces the probability of generating false hotplug
events when we're uncertain whether the driver can fully initialise.
This also pulls that code out of the individual imx-drm connector
drivers.
Signed-off-by:
Provide a helper function to parse possible crtcs before the encoder
is registered. The crtc mask is derived from the position of the
CRTCs registered in the drm_device.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-drm-core.c | 66
Now that our bind function is only ever called during the main DRM
driver -load callback, we don't need to have the imx_drm_connector or
imx_drm_encoder abstractions anymore. So let's get rid of it, and move
the DRM connector and encoder setup into the connector support files.
Signed-off-by:
Provide two helper functions to assist with cleaning up imx-drm
connectors and encoders.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-drm-core.c | 13 +
drivers/staging/imx-drm/imx-drm.h | 3 +++
2 files changed, 16 insertions(+)
diff
Use the componentised device support for imx-drm. This requires all
the sub-components and the master device to register with the component
device support.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
arch/arm/boot/dts/imx51-babbage.dts| 10 ++-
Now that we know when the components of the imx-drm subsystem will be
initialised, we can move the fbdev helper initialisation and teardown
into imx-drm-core. This gives us the required ordering that DRM wants
in both driver load and unload methods.
We can also stop exporting the
imx-fb.c doesn't need to be separate from imx-drm-core.c - all it is
doing is setting up the minimum and maximum sizes of the scanout
buffers, and setting up the mode_config function pointers. Move the
contents into imx-drm-core.c and kill this file.
Signed-off-by: Russell King
Add core imx-drm support for hotplug connector support. We need to
setup the poll helper after we've setup the connectors; the helper
scans the connectors to determine their capabilities.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-drm-core.c | 21
The core imx_drm_connector and imx_drm_encoder code is no longer
required - the connectors and encoders are all using the component
support, so we can remove this.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-drm-core.c | 371
This mutex doesn't protect anything anymore; get rid of it.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/imx-drm/imx-drm-core.c | 26 +++---
1 file changed, 3 insertions(+), 23 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-drm-core.c
Add hotplug support. We have to make the interrupt handler threaded so
we can call drm_helper_hpd_irq_event(). Keeping in mind that we will
want to share the interrupt with other HDMI interface drivers (eg, audio
and CEC) put the groundwork in now for that, rather than just using
IRQF_ONESHOT.
Since we're now operating like a conventional DRM driver, doing all
the initialisation within the driver's -load callback, we don't
need to mess around with the mode groups - we can rely on the one
in the DRM platform code.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
On 2014-02-08 05:02, Chase Southwood wrote:
We allocate bdev and then krealloc the devs pointer in order to add bdev
at the end of the devpriv-devs array list. But if for some reason this
krealloc fails, we need to free bdev before returning an error otherwise
this memory is leaked.
On Mon, Feb 10, 2014 at 01:53:08PM +0100, Thierry Reding wrote:
On Fri, Feb 07, 2014 at 04:55:00PM +0100, Jean-Francois Moine wrote:
Some simple components don't need to do any specific action on
bind to / unbind from a master component.
This patch permits such components to omit the
Hello.
On 10-02-2014 5:07, Haiyang Zhang wrote:
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
Reviewed-by: K. Y. Srinivasan k...@microsoft.com
---
drivers/net/hyperv/netvsc_drv.c | 24 +++-
1 files changed, 15 insertions(+), 9 deletions(-)
diff --git
Hi Paul,
Thank you for the patch.
On Sunday 09 February 2014 16:09:37 Paul Bolle wrote:
Commit d632dfefd36f ([media] v4l: omap4iss: Add support for OMAP4
camera interface - Build system) added a Kconfig entry for
VIDEO_OMAP4_DEBUG. But nothing uses that symbol.
This entry was apparently
On Mon, 2014-02-10 at 14:56 +0900, Daeseok Youn wrote:
Hello.
diff --git a/drivers/staging/android/ion/ion_priv.h
b/drivers/staging/android/ion/ion_priv.h
[]
- struct sg_table *(*map_dma) (struct ion_heap *heap,
+ struct sg_table * (*map_dma)(struct ion_heap *heap,
The message
On Mon, 10 Feb 2014 13:12:33 +
Russell King - ARM Linux li...@arm.linux.org.uk wrote:
I've NAK'd these patches already - I believe they're based on a
mis-understanding of how this should be used. I believe Jean-Francois
has only looked at the core, rather than looking at the imx-drm
Laurent,
On Mon, 2014-02-10 at 15:13 +0100, Laurent Pinchart wrote:
On Sunday 09 February 2014 16:09:37 Paul Bolle wrote:
Commit d632dfefd36f ([media] v4l: omap4iss: Add support for OMAP4
camera interface - Build system) added a Kconfig entry for
VIDEO_OMAP4_DEBUG. But nothing uses that
On Mon, Feb 10, 2014 at 03:35:51PM +0100, Jean-Francois Moine wrote:
On Mon, 10 Feb 2014 13:12:33 +
Russell King - ARM Linux li...@arm.linux.org.uk wrote:
I've NAK'd these patches already - I believe they're based on a
mis-understanding of how this should be used. I believe
Am Montag, den 10.02.2014, 12:28 + schrieb Russell King - ARM Linux:
This is the latest revision of my series cleaning up imx-drm and
hopefully getting it ready to be moved out of drivers/staging.
This series is updated to v3.14-rc2.
Since the last round of patches were posted, the
On Mon, Feb 10, 2014 at 04:12:19PM +0100, Philipp Zabel wrote:
Am Montag, den 10.02.2014, 12:28 + schrieb Russell King - ARM Linux:
This is the latest revision of my series cleaning up imx-drm and
hopefully getting it ready to be moved out of drivers/staging.
This series is updated to
Hi Paul,
On Monday 10 February 2014 16:13:51 Paul Bolle wrote:
On Mon, 2014-02-10 at 15:13 +0100, Laurent Pinchart wrote:
On Sunday 09 February 2014 16:09:37 Paul Bolle wrote:
Commit d632dfefd36f ([media] v4l: omap4iss: Add support for OMAP4
camera interface - Build system) added a
On Mon, 10 Feb 2014 15:18:21 +
Russell King - ARM Linux li...@arm.linux.org.uk wrote:
Now, mind explaining what v4l2 style device tree bindings means? I've
no idea since I'm relatively new to DT.
Documentation/devicetree/bindings/media/video-interfaces.txt
For the Cubox, I have:
On Mon, Jan 06, 2014 at 03:52:01PM +0100, Philipp Zabel wrote:
@@ -438,24 +453,21 @@ int imx_drm_encoder_parse_of(struct drm_device *drm,
struct drm_encoder *encoder, struct device_node *np)
{
struct imx_drm_device *imxdrm = drm-dev_private;
+ struct device_node *ep, *last_ep
Without this patch, the cat /sys/class/net/ethN/operstate shows
unknown, and ethtool ethN shows Link detected: yes, when VM
boots up with or without vNIC connected.
This patch fixed the problem.
Signed-off-by: Haiyang Zhang haiya...@microsoft.com
Reviewed-by: K. Y. Srinivasan k...@microsoft.com
-Original Message-
From: Sergei Shtylyov [mailto:sergei.shtyl...@cogentembedded.com]
Sent: Monday, February 10, 2014 8:29 AM
To: Haiyang Zhang; da...@davemloft.net; net...@vger.kernel.org
Cc: KY Srinivasan; o...@aepfle.de; jasow...@redhat.com; linux-
ker...@vger.kernel.org;
On Mon, Feb 10, 2014 at 06:37:26PM +0100, Philipp Zabel wrote:
I'd like all of them to go through, too. If you don't want to have the DT
changes integrated, I'd appreciate if you could have a look at my
patches on top of your series and possibly append them to your
series or let me
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmad.c | 21 ++---
1 file
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das08.c | 26 ++
1 file
Use comedi_timeout() to wait for the analog input end-of-conversion.
Since this is the sample skeleton driver, add comments about how the
callback function works with comedi_timeout().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Use comedi_timeout() to wait for the analog input and output end-of-
conversions.
This prevents a deadlock condition that could occur by providing a
timeout in case the end-of-conversion does not happen.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das16m1.c | 27 +++
1
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/mf6x4.c | 23 ++-
1 file
Introduce a comedi core helper function to handle the boilerplate
needed by the drivers to busy- wait for a condition to occur.
Typically this condition is the analog input/output end-of-conversion
used with the comedi (*insn_read) and (*insn_write) operations.
To use this function, the drivers
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_labpc.c | 21 +
1 file
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci9118.c | 34 ++--
Use comedi_timeout() to wait for the analog output end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci6208.c | 22 ++
1
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl711.c | 21 ++---
1 file
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt2811.c | 23 ---
1 file
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 44 +---
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ii_pci20kc.c | 20 +---
1 file
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/mpc624.c | 28
1
Many of the comedi drivers implement a timeout loop of some sort in the
analog input (*insn_read) or analog output (*insn_write) functions. Some
of these are just crazy loop this many times for some status to change.
There are a couple that could actually deadlock the system if the status
does not
Use comedi_timeout() to wait for the analog input end-of-conversion.
This also fixes a possible bug where invalid data is returned if the
conversion did not complete.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/multiq3.c | 38
Use comedi_timeout() to wait for the analog output end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt2815.c | 39
Use comedi_timeout() to wait for the analog input end-of-conversion.
This prevents a deadlock condition that could occur by providing a
timeout in case the end-of-conversion does not happen.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adl_pci9111.c | 36 +++-
Use comedi_timeout() to wait for the analog input and output end-of-
conversions.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcmmio.c | 42
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/das16.c | 19 +--
1 file
Use comedi_timeout() to wait for the analog input end-of-conversion.
Change the errno returned for an overrun from -EIO to -EOVERFLOW.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_daq_700.c | 53 ++---
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/adv_pci1710.c | 38 +---
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 42
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/me_daq.c | 35 ++---
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/cb_das16_cs.c | 26 ++
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/s526.c | 32
1
Use comedi_timeout() to wait for the analog input and output end-of-
conversion.
Use break to exit the loop when a timeout occurs during the analog
input read so that common code can be used to disable the device.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Use comedi_timeout() to wait for the analog input and output end-of-
conversions.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/rtd520.c | 84
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/amplc_pci230.c | 32 +++
Use comedi_timeout() to wait for the analog input end-of-conversion.
Change the errno returned when the conversion overflows from -ETIME
to -EOVERFLOW.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl816.c | 45 -
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/dt2814.c | 29 +++--
1
Use comedi_timeout() to wait for the analog input end-of-conversion.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/comedi/drivers/pcl818.c | 35 +++--
The wait_for() macro in this driver is a bit nasty. It effects control flow
which according to the CodingStyle is a _very_ bad idea.
The mux_busy() and ad_done() macros are also bad since they rely on a local
variable having a specific name.
Remove these macros and use comedi_timeout() to wait
Use comedi_timeout() to wait for the analog input pipe full, scanning,
amd end-of-conversion status. The status to check it passed as the
'context' to comedi_timeout().
Use comedi_timeout() to wait for the analog output end-of-conversion.
This also fixes a possible bug where invalid data is
Do not call kfree() till timer function is finished.
[This was found using grep. Compilation tested only]
Signed-off-by: Kirill Tkhai tk...@yandex.ru
CC: Joe Perches j...@perches.com
CC: Greg Kroah-Hartman gre...@linuxfoundation.org
---
drivers/staging/sbe-2t3e3/module.c | 2 +-
1 file changed,
On Mon, Feb 10, 2014 at 12:18:42PM +0300, Dan Carpenter wrote:
On Sun, Feb 09, 2014 at 07:05:24PM -0800, Surendra Patil wrote:
Fixed MACRO,Extern and parentheses Coding style warnings and errors -
listed only few
bpctl_mod.c:120: WARNING: externs should be avoided in .c files
-Original Message-
From: Haiyang Zhang [mailto:haiya...@microsoft.com]
Sent: Monday, January 13, 2014 7:21 PM
To: florianschandi...@gmx.de; a...@linux-foundation.org; linux-
fb...@vger.kernel.org
Cc: Haiyang Zhang; KY Srinivasan; o...@aepfle.de; jasow...@redhat.com;
On Mon, Feb 10, 2014 at 04:26:31PM +, Russell King - ARM Linux wrote:
[...]
Why is this loop soo complicated? Why do you need to mess around with
this last_ep stuff - you don't actually end up using it.
The last_ep dance is necessary because v4l2_of_get_next_endpoint(node,prev)
does not
The trigger sources were already validataed in the (*do_cmdtest) before the
(*do_cmd) is called. Remove the unnecessary checks in pcl812_ai_cmd().
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
---
The trigger sources were already validataed in the (*do_cmdtest) before the
(*do_cmd) is called. Refactor the code in das800_ai_do_cmd() to use if/else
instead of the switch since the default cases can never be reached.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
Currently the (*do_cmdtest) indicates that TRIG_TIMER is a valid scan_begin_src
but later this source is tested as -EINVAL. To simplify the code a bit just
remove the TRIG_TIMER source.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg
The trigger sources were already validataed in the (*do_cmdtest) before the
(*do_cmd) is called. Refactor the code in pci9111_ai_do_cmd() to use if/else
instead of the switch since the default cases can never be reached.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott
This driver has a (*do_cmdtest) function for analog input async command
support but the (*do_cmd) function just returns -EINVAL.
Remove the incomplete async command support.
Signed-off-by: H Hartley Sweeten hswee...@visionengravers.com
Cc: Ian Abbott abbo...@mev.co.uk
Cc: Greg Kroah-Hartman
1 - 100 of 106 matches
Mail list logo
