Re: [RFC PATCH 0/5] Move IPUv3 core out of staging, add CSI support

2014-02-26 Thread Dan Carpenter
Please fix the following static checker complaints before moving out of staging: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157) drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error:

Re: [PATCH RFC only] staging: dgap: fix OOPS on open of port

2014-02-26 Thread Dan Carpenter
On Tue, Feb 25, 2014 at 02:35:39PM -0500, Mark Hounschell wrote: On 02/25/2014 01:40 PM, Mark Hounschell wrote: +struct dgap_port { +struct tty_port port; +}; Do you really need a wrapping structure here? I may be incorrect, but I think so. I will investigate this further

[PATCH] staging: lustre: make functions as static

2014-02-26 Thread Daeseok Youn
These functions are only referenced in this file scope so it can be marked static. And remove space between function name and open parenthesis. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 94 ++-- 1 file changed,

Re: [PATCH] staging: lustre: make functions as static

2014-02-26 Thread Dan Carpenter
On Wed, Feb 26, 2014 at 06:17:59PM +0900, Daeseok Youn wrote: These functions are only referenced in this file scope so it can be marked static. And remove space between function name and open parenthesis. If it's on the same line as a static change then it's fine, otherwise it should go in

Re: [PATCH v4 2/2] hyperv-fb: kick off efifb early

2014-02-26 Thread Gerd Hoffmann
Hi, diff --git a/drivers/video/hyperv_fb.c b/drivers/video/hyperv_fb.c index b7b3dd0..1b11886 100644 --- a/drivers/video/hyperv_fb.c +++ b/drivers/video/hyperv_fb.c @@ -683,6 +683,7 @@ static int hvfb_getmem(struct fb_info *info) info-apertures-ranges[0].base =

Re: [RFC PATCH 0/5] Move IPUv3 core out of staging, add CSI support

2014-02-26 Thread Russell King - ARM Linux
On Wed, Feb 26, 2014 at 11:39:03AM +0300, Dan Carpenter wrote: Please fix the following static checker complaints before moving out of staging: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157) Note that

[PATCH v5 0/2] hyperv-fb: add support for generation 2 virtual machines

2014-02-26 Thread Gerd Hoffmann
Hi, This patch series adds support for uefi-based gen2 virtual machines to the hyperv-fb driver. It depends on a few vmbus changes which are staged in Greg's char-misc tree (and linux-next). Patch #1 implements gen2 vm support for hyperv-fb. Patch #2 unregisters efifb early to make sure the

[PATCH v5 1/2] hyperv-fb: add support for generation 2 virtual machines.

2014-02-26 Thread Gerd Hoffmann
UEFI-based generation 2 virtual machines support vmbus devices only. There is no pci bus. Thus they use a different mechanism for the graphics framebuffer: Instead of using the vga pci bar a chunk of memory muct be allocated from the hyperv mmio region declared using APCI. This patch implements

[PATCH v5 2/2] hyperv-fb: kick off efifb early

2014-02-26 Thread Gerd Hoffmann
Remove firmware framebuffer before initializing hyperv-fb. Needed on gen2 virtual machines. Letting register_framebuffer handle the switchover results in efifb still being active while hyperv graphics are initialized, which in turn can make the linux kernel hang. Signed-off-by: Gerd Hoffmann

Re: [PATCH] staging: lustre: make functions as static

2014-02-26 Thread DaeSeok Youn
Actually , I saw some code like this file which is seperate line between return value and function name. So I didn't make one line of them. Ok, I will make another patch after merge this one. Thanks. Daeseok Youn. 2014-02-26 18:20 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com: On Wed, Feb

Re: [PATCH] staging: lustre: make functions as static

2014-02-26 Thread DaeSeok Youn
Oh.. sorry. Ok, I will seperate this patch as you said. Thanks. Daeseok Youn. 2014-02-26 20:31 GMT+09:00, Dan Carpenter dan.carpen...@oracle.com: On Wed, Feb 26, 2014 at 08:11:40PM +0900, DaeSeok Youn wrote: Actually , I saw some code like this file which is seperate line between return value

Re: [PATCH] staging: dgap: fix kernel oops on port open

2014-02-26 Thread Dan Carpenter
On Wed, Feb 26, 2014 at 08:41:38AM -0500, Mark Hounschell wrote: -static void dgap_sysfs_create(struct board_t *brd) +static int dgap_tty_register_ports(struct board_t *brd) { struct channel_t *ch; - int j = 0; + int i; + + brd-SerialPorts = kcalloc(brd-nasync,

Re: [PATCH] staging: dgap: fix kernel oops on port open

2014-02-26 Thread Mark Hounschell
On 02/26/2014 09:01 AM, Dan Carpenter wrote: On Wed, Feb 26, 2014 at 08:41:38AM -0500, Mark Hounschell wrote: -static void dgap_sysfs_create(struct board_t *brd) +static int dgap_tty_register_ports(struct board_t *brd) { struct channel_t *ch; - int j = 0; + int i; + +

[PATCH v2] staging: dgap: fix kernel oops on port open

2014-02-26 Thread Mark Hounschell
This patch addresses the follow error message followed by a kernel oops: dgap: driver does not set tty-port. This will crash the kernel later. Fix the driver It also renames the main function this patch addresses because its name is misleading. Signed-off-by: Mark Hounschell ma...@compro.net

Re: [PATCH v2] staging: dgap: fix kernel oops on port open

2014-02-26 Thread Dan Carpenter
On Wed, Feb 26, 2014 at 10:18:26AM -0500, Mark Hounschell wrote: This patch addresses the follow error message followed by a kernel oops: dgap: driver does not set tty-port. This will crash the kernel later. Fix the driver It also renames the main function this patch addresses because

RE: [PATCH v5 2/2] hyperv-fb: kick off efifb early

2014-02-26 Thread Haiyang Zhang
-Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Wednesday, February 26, 2014 5:51 AM To: linux-fb...@vger.kernel.org Cc: linux-ker...@vger.kernel.org; gre...@linuxfoundation.org; KY Srinivasan; Abhishek Gupta (LIS); Haiyang Zhang; jasow...@redhat.com;

[PATCHv8][ 2/7] staging: imx-drm: Add RGB666 support for parallel display.

2014-02-26 Thread Denis Carikli
Cc: Eric Bénard e...@eukrea.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Shawn Guo shawn@linaro.org Cc: de...@driverdev.osuosl.org Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Denis Carikli de...@eukrea.com --- ChangeLog v7-v8: - Shrinked even more the Cc list.

[PATCHv8][ 4/7] staging: imx-drm: Use de-active and pixelclk-active display-timings.

2014-02-26 Thread Denis Carikli
If de-active and/or pixelclk-active properties were set in the display-timings DT node, they were not used. Instead the data-enable and the pixel data clock polarity were hardcoded. This change is needed for making the eukrea-cpuimx51 QVGA display work. Cc: Eric Bénard e...@eukrea.com Cc:

[PATCHv8][ 5/7] staging: imx-drm: parallel display: add regulator support.

2014-02-26 Thread Denis Carikli
Cc: Alexander Shiyan shc_w...@mail.ru Cc: Eric Bénard e...@eukrea.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: driverdev-devel@linuxdriverproject.org Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Denis Carikli de...@eukrea.com --- ChangeLog v7-v8: - Shrinked even more the Cc

[PATCHv8][ 3/7] staging: imx-drm: Correct BGR666 and the board's dts that use them.

2014-02-26 Thread Denis Carikli
The current BGR666 is not consistent with the other color mapings like BGR24. BGR666 should be in the same byte order than BGR24. Cc: Eric Bénard e...@eukrea.com Cc: Greg Kroah-Hartman gre...@linuxfoundation.org Cc: Shawn Guo shawn@linaro.org Cc: de...@driverdev.osuosl.org Cc:

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-02-26 Thread Guennadi Liakhovetski
Hi Russell (I suspect this my email will be rejected by ALKML too like other my recent emails, but at least other MLs will pick it up and individual CCs too, so, if replying, maybe it would be good to keep my entire reply, all the more that it's going to be very short) On Thu, 2 Jan 2014,

[PATCH 4/6] imx-drm: parallel-display: Check 'dmfc' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warnings: drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) drivers/staging/imx-drm/parallel-display.c:73

[PATCH 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157) Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by:

[PATCH 2/6] imx-drm: imx-ldb: Check 'mode' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) Reported-by: Dan Carpenter dan.carpen...@oracle.com

[PATCH 6/6] imx-drm: imx-drm-core: Staticize imx_drm_find_crtc()

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol 'imx_drm_find_crtc' was not declared. Should it be static? Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Fabio Estevam

[PATCH 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is theory and not real life, but 16 is based on theory as well.

[PATCH 5/6] imx-drm: ipuv3-plane: Use %pad to print 'dma_addr_t'

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat] Use %pad to print 'dma_addr_t'. Reported-by: Dan

Re: [PATCH 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-26 Thread Dan Carpenter
On Wed, Feb 26, 2014 at 06:44:34PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157)

Re: [PATCH 4/6] imx-drm: parallel-display: Check 'dmfc' pointer first

2014-02-26 Thread Dan Carpenter
On Wed, Feb 26, 2014 at 06:44:37PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warnings: drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create

[PATCH v2 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157) Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by:

[PATCH v2 2/6] imx-drm: imx-ldb: Check 'mode' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) Reported-by: Dan Carpenter dan.carpen...@oracle.com

[PATCH v2 4/6] imx-drm: parallel-display: Check 'mode' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warnings: drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) drivers/staging/imx-drm/parallel-display.c:73

[PATCH v2 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is theory and not real life, but 16 is based on theory as well.

[PATCH v2 6/6] imx-drm: imx-drm-core: Staticize imx_drm_find_crtc()

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol 'imx_drm_find_crtc' was not declared. Should it be static? Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Fabio Estevam

[PATCH v2 5/6] imx-drm: ipuv3-plane: Use %pad to print 'dma_addr_t'

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/ipuv3-plane.c:75:2: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t' [-Wformat] Use %pad to print 'dma_addr_t'. Reported-by: Dan

Re: [PATCH RFC 26/46] drivers/base: provide an infrastructure for componentised subsystems

2014-02-26 Thread Russell King - ARM Linux
On Wed, Feb 26, 2014 at 10:00:25PM +0100, Guennadi Liakhovetski wrote: Hi Russell (I suspect this my email will be rejected by ALKML too like other my recent emails, but at least other MLs will pick it up and individual CCs too, so, if replying, maybe it would be good to keep my entire

Re: [PATCH 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Russell King - ARM Linux
On Wed, Feb 26, 2014 at 06:44:36PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is

URGENT CLAIM IS MANDATORY.

2014-02-26 Thread DR.DAVID GAK
URGENT CLAIM IS MANDATORY. M T N global Net-work Online raffle-draw Promotions. Head Office: Cotonou Benin, 6701 eminent Road apapa Cotonou, Benin republic, (dr.david...@netglo.net ( office contact ) I am Dr.David Gak the International online cor-donator. We wish you success in our M T N

[PATCH v3 4/6] imx-drm: parallel-display: Check 'mode' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warnings: drivers/staging/imx-drm/parallel-display.c:64 imx_pd_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) drivers/staging/imx-drm/parallel-display.c:73

[PATCH v3 6/6] imx-drm: imx-drm-core: Staticize imx_drm_find_crtc()

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol 'imx_drm_find_crtc' was not declared. Should it be static? Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Fabio Estevam

[PATCH v3 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is theory and not real life, but 16 is based on theory as well. Reported-by: Dan

Re: [PATCH v3 3/6] imx-drm: imx-ldb: Fix array length

2014-02-26 Thread Russell King - ARM Linux
On Wed, Feb 26, 2014 at 07:44:33PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is theory

[PATCH v2] staging: lustre: make functions as static

2014-02-26 Thread Daeseok Youn
These functions are only referenced in this file scope so it can be marked static. And remove space between function name and open parenthesis. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c| 70 ++-- 1 file changed,

[PATCH v4 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157) Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by:

[PATCH v4 2/6] imx-drm: imx-ldb: Check 'mode' pointer first

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:109 imx_ldb_connector_get_modes() error: potential null dereference 'mode'. (drm_mode_create returns null) Reported-by: Dan Carpenter dan.carpen...@oracle.com

[PATCH v4 3/6] imx-drm: imx-ldb: Use snprintf()

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Use snprintf() in order to fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length: 18 probably 18 is theory and not real life, but 16 is based on theory

[PATCH v4 6/6] imx-drm: imx-drm-core: Staticize imx_drm_find_crtc()

2014-02-26 Thread Fabio Estevam
From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/imx-drm-core.c:89:21: warning: symbol 'imx_drm_find_crtc' was not declared. Should it be static? Reported-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Fabio Estevam