[PATCH 1/2] staging: bcm: Remove unneeded set a variable

2014-02-27 Thread Daeseok Youn
bClassificationSucceed is initialized with false, do not need to set false again. Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/bcm/Qos.c |3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c index

[PATCH 2/2] staging: bcm: fix checkpatch error 'assignment in if condition'

2014-02-27 Thread Daeseok Youn
clean up checkpatch errors and bClassificationSucceed is set to TRUE proper location. If protocal is not TCP or UDP, when it checks protocal, bClassificationSucceed must be set to TRUE. Also the end of do-while(0) loop, bClassificationSucceed is set to TRUE. Signed-off-by: Daeseok Youn

Re: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-27 Thread Tomi Valkeinen
On 25/02/14 16:23, Philipp Zabel wrote: +Freescale i.MX DRM master device + + +The freescale i.MX DRM master device is a virtual device needed to list all +IPU or other display interface nodes that comprise the graphics subsystem. + +Required properties: +-

[PATCH] staging: rtl8188eu: Fix typo in rtl8188eu/core

2014-02-27 Thread Masanari Iida
Fix spelling typo in comments and printk within rtl8188eu/core Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/rtl8188eu/core/rtw_ap.c| 14 +- drivers/staging/rtl8188eu/core/rtw_br_ext.c| 6 ++--- drivers/staging/rtl8188eu/core/rtw_debug.c | 2 +-

[PATCH] staging: usbip: Fix format string mismatch in usbip_vhci_attach_device2

2014-02-27 Thread Masanari Iida
Argument type of sockfd is set as int, but format string is set as unsigned int. Fix the mismatch. Signed-off-by: Masanari Iida standby2...@gmail.com --- drivers/staging/usbip/userspace/libsrc/vhci_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-27 Thread Philipp Zabel
Am Donnerstag, den 27.02.2014, 13:06 +0200 schrieb Tomi Valkeinen: On 25/02/14 16:23, Philipp Zabel wrote: +Freescale i.MX DRM master device + + +The freescale i.MX DRM master device is a virtual device needed to list all +IPU or other display interface

Re: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-27 Thread Russell King - ARM Linux
On Thu, Feb 27, 2014 at 02:06:25PM +0100, Philipp Zabel wrote: For the i.MX6 display subsystem there is no clear single master device, and the physical configuration changes across the SoC family. The i.MX6Q/i.MX6D SoCs have two separate display controller devices IPU1 and IPU2, with two

[PATCH 1/1] Memory leak in usbip_exported_device_new

2014-02-27 Thread xypron . glpk
From: Heinrich Schuchardt xypron.g...@gmx.de Memory was leaked and a device not closed. Signed-off-by: Heinrich Schuchardt xypron.g...@gmx.de --- drivers/staging/usbip/userspace/libsrc/usbip_host_driver.c |3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-27 Thread Tomi Valkeinen
On 27/02/14 13:56, Russell King - ARM Linux wrote: Is there even need for such a master device? You can find all the connected display devices from any single display device, by just following the endpoint links. Please read up on what has been discussed over previous years:

Re: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-27 Thread Russell King - ARM Linux
On Thu, Feb 27, 2014 at 03:16:03PM +0200, Tomi Valkeinen wrote: On 27/02/14 13:56, Russell King - ARM Linux wrote: Is there even need for such a master device? You can find all the connected display devices from any single display device, by just following the endpoint links. Please

Re: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-27 Thread Tomi Valkeinen
On 27/02/14 15:00, Russell King - ARM Linux wrote: On Thu, Feb 27, 2014 at 02:06:25PM +0100, Philipp Zabel wrote: For the i.MX6 display subsystem there is no clear single master device, and the physical configuration changes across the SoC family. The i.MX6Q/i.MX6D SoCs have two separate

Re: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-27 Thread Tomi Valkeinen
On 27/02/14 15:43, Russell King - ARM Linux wrote: That may be - but the problem with CDF solving this problem is that it's wrong. It's fixing what is in actual fact a *generic* problem in a much too specific way. To put it another way, it's forcing everyone to fix the same problem in their

[PATCH] Staging: speakup: buffers: Fixed a return value coding style issue.

2014-02-27 Thread Reza Snowdon
Fixed a coding style issue. Signed-off-by: Reza Snowdon r...@mage.me.uk --- drivers/staging/speakup/buffers.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/buffers.c b/drivers/staging/speakup/buffers.c index 382973e..8d7caa7 100644 ---

Re: [PATCH] Staging: speakup: buffers: Fixed a return value coding style issue.

2014-02-27 Thread Greg KH
On Thu, Feb 27, 2014 at 04:26:42PM +, Reza Snowdon wrote: Fixed a coding style issue. Signed-off-by: Reza Snowdon r...@mage.me.uk --- drivers/staging/speakup/buffers.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/buffers.c

Re: [PATCH] Staging: speakup: buffers: Fixed a return value coding style issue.

2014-02-27 Thread Dan Carpenter
On Thu, Feb 27, 2014 at 04:26:42PM +, Reza Snowdon wrote: Fixed a coding style issue. Signed-off-by: Reza Snowdon r...@mage.me.uk --- drivers/staging/speakup/buffers.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/speakup/buffers.c

Re: [PATCH] Staging: speakup: buffers: Fixed a return value coding style issue.

2014-02-27 Thread r...@mage.me.uk
When checking buffers.c with checkpatch.pl it throws the following error: drivers/staging/speakup/buffers.c:58: ERROR: return is not a function, parentheses are not required I watched one of your talks, it's very informative and concise:

Re: [PATCH v2] staging: dgap: fix kernel oops on port open

2014-02-27 Thread Mark Hounschell
On 02/26/2014 10:30 AM, Dan Carpenter wrote: On Wed, Feb 26, 2014 at 10:18:26AM -0500, Mark Hounschell wrote: This patch addresses the follow error message followed by a kernel oops: dgap: driver does not set tty-port. This will crash the kernel later. Fix the driver It also renames the

Re: [PATCH 3/3] gpu: ipu-v3: Move i.MX IPUv3 core driver out of staging

2014-02-27 Thread Greg Kroah-Hartman
On Tue, Feb 25, 2014 at 01:09:57PM +0100, Philipp Zabel wrote: Am Dienstag, den 25.02.2014, 12:43 +0100 schrieb Philipp Zabel: The i.MX Image Processing Unit (IPU) contains a number of image processing blocks that sit right in the middle between DRM and V4L2. Some of the modules, such as

Re: [PATCH 0/3] Move IPUv3 core out of staging

2014-02-27 Thread Greg Kroah-Hartman
On Tue, Feb 25, 2014 at 12:43:40PM +0100, Philipp Zabel wrote: Hi, this series has two small cleanups for the IPUv3 core driver and then moves it from drivers/staging/imx-drm/ipu-v3 to drivers/gpu. In this directory there is already the host1x driver, which serves a similar purpose. I've

Re: [PATCH 3/3] gpu: ipu-v3: Move i.MX IPUv3 core driver out of staging

2014-02-27 Thread Uwe Kleine-König
On Thu, Feb 27, 2014 at 12:41:36PM -0800, Greg Kroah-Hartman wrote: On Tue, Feb 25, 2014 at 01:09:57PM +0100, Philipp Zabel wrote: Am Dienstag, den 25.02.2014, 12:43 +0100 schrieb Philipp Zabel: The i.MX Image Processing Unit (IPU) contains a number of image processing blocks that sit

Re: [PATCH v2] staging: dgap: fix kernel oops on port open

2014-02-27 Thread Greg Kroah-Hartman
On Thu, Feb 27, 2014 at 03:39:08PM -0500, Mark Hounschell wrote: On 02/26/2014 10:30 AM, Dan Carpenter wrote: On Wed, Feb 26, 2014 at 10:18:26AM -0500, Mark Hounschell wrote: This patch addresses the follow error message followed by a kernel oops: dgap: driver does not set tty-port.

Re: [PATCH v2] staging: dgap: fix kernel oops on port open

2014-02-27 Thread Dan Carpenter
On Thu, Feb 27, 2014 at 03:39:08PM -0500, Mark Hounschell wrote: On 02/26/2014 10:30 AM, Dan Carpenter wrote: On Wed, Feb 26, 2014 at 10:18:26AM -0500, Mark Hounschell wrote: This patch addresses the follow error message followed by a kernel oops: dgap: driver does not set tty-port.

Re: [PATCH v4 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-27 Thread Greg KH
On Wed, Feb 26, 2014 at 08:53:39PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Fix the following static checker warning: drivers/staging/imx-drm/ipu-v3/ipu-dmfc.c:164 ipu_dmfc_setup_channel() warn: variable dereferenced before check 'dmfc' (see line 157)

Re: [PATCH v4 3/6] imx-drm: imx-ldb: Use snprintf()

2014-02-27 Thread Greg KH
On Wed, Feb 26, 2014 at 08:53:41PM -0300, Fabio Estevam wrote: From: Fabio Estevam fabio.este...@freescale.com Use snprintf() in order to fix the following static checker warning: drivers/staging/imx-drm/imx-ldb.c:340 imx_ldb_get_clk() error: format string overflow. buf_size: 16 length:

Re: [PATCH v4 3/6] imx-drm: imx-ldb: Use snprintf()

2014-02-27 Thread Russell King - ARM Linux
On Thu, Feb 27, 2014 at 02:54:43PM -0800, Greg KH wrote: On Wed, Feb 26, 2014 at 08:53:41PM -0300, Fabio Estevam wrote: diff --git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c index abf8517..daa54df 100644 --- a/drivers/staging/imx-drm/imx-ldb.c +++

[PATCH 0/3] staging/usbip: add new uapi header usbip.h

2014-02-27 Thread Shuah Khan
usbip userspace has duplicated enum definition to report usbip device status maintained by the kernel. Adding an usbip uapi header file will define the kernel - userspace interface for this device status. Shuah Khan (3): staging/usbip: add uapi header to export usbip kernel interfaces

[PATCH 1/3] staging/usbip: add uapi header to export usbip kernel interfaces

2014-02-27 Thread Shuah Khan
usbip userspace has duplicated enum definition to report usbip device status maintained by the kernel. Adding an usbip uapi header file will define the kernel - userspace interface for this device status. Signed-off-by: Shuah Khan shuah...@samsung.com --- include/uapi/linux/Kbuild |1 +

[PATCH] staging: cxt1e1: remove unused variable

2014-02-27 Thread Daeseok Youn
Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/hwprobe.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/cxt1e1/hwprobe.c b/drivers/staging/cxt1e1/hwprobe.c index 02b4f8f..07de83f 100644 ---

[PATCH] staging: sb105x: b_pci_mp.c: fix for non-member access

2014-02-27 Thread Kumar Amit Mehta
'struct tty_struct’ has no member named ‘low_latency’ Signed-off-by: Kumar Amit Mehta gmate.a...@gmail.com --- drivers/staging/sb105x/sb_pci_mp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/sb105x/sb_pci_mp.c b/drivers/staging/sb105x/sb_pci_mp.c index

RE: [patch 25/26] x86: hyperv: Cleanup the irq mess

2014-02-27 Thread KY Srinivasan
-Original Message- From: Thomas Gleixner [mailto:t...@linutronix.de] Sent: Tuesday, February 25, 2014 11:10 AM To: KY Srinivasan Cc: LKML; Ingo Molnar; Peter Zijlstra; x86; Greg Kroah-Hartman; linuxdrivers Subject: RE: [patch 25/26] x86: hyperv: Cleanup the irq mess On Tue, 25

[PATCH RESEND] x86, hyperv: bypass the timer_irq_works() check

2014-02-27 Thread Jason Wang
This patch bypass the timer_irq_works() check for hyperv guest since: - It was guaranteed to work. - timer_irq_works() may fail sometime due to the lpj calibration were inaccurate in a hyperv guest or a buggy host. In the future, we should get the tsc frequency from hypervisor and use preset

Re: [PATCH v4 3/6] imx-drm: imx-ldb: Use snprintf()

2014-02-27 Thread Greg KH
On Thu, Feb 27, 2014 at 11:44:38PM +, Russell King - ARM Linux wrote: On Thu, Feb 27, 2014 at 02:54:43PM -0800, Greg KH wrote: On Wed, Feb 26, 2014 at 08:53:41PM -0300, Fabio Estevam wrote: diff --git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c index

Re: [PATCH v4 3/6] imx-drm: imx-ldb: Use snprintf()

2014-02-27 Thread Dan Carpenter
On Thu, Feb 27, 2014 at 11:44:38PM +, Russell King - ARM Linux wrote: On Thu, Feb 27, 2014 at 02:54:43PM -0800, Greg KH wrote: On Wed, Feb 26, 2014 at 08:53:41PM -0300, Fabio Estevam wrote: diff --git a/drivers/staging/imx-drm/imx-ldb.c b/drivers/staging/imx-drm/imx-ldb.c index

Re: [PATCH v4 1/6] imx-drm: ipu-dmfc: Check 'dmfc' pointer first

2014-02-27 Thread Dan Carpenter
On Thu, Feb 27, 2014 at 11:54:23PM +, Russell King - ARM Linux wrote: On Thu, Feb 27, 2014 at 02:52:34PM -0800, Greg KH wrote: How can dmfc ever be NULL? You control what values you pass to it, why check it again? Indeed. This is actually a case where the static checker warning is

[PATCH 1/5] staging: cxt1e1: remove space between function name and parenthesis

2014-02-27 Thread Daeseok Youn
clean up checkpatch.pl warnings: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/hwprobe.c | 120 +++--- 1 file changed, 60 insertions(+), 60 deletions(-)

[PATCH 2/5] staging: cxt1e1: Fix no spaces at the start of a line in hwprobe.c

2014-02-27 Thread Daeseok Youn
clean up checkpatch.pl warnings: WARNING: please no spaces at the start of a line in Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/hwprobe.c | 585 +++--- 1 file changed, 293 insertions(+), 292 deletions(-) diff --git

[PATCH 3/5] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

2014-02-27 Thread Daeseok Youn
clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/hwprobe.c | 45 -- 1 file changed, 28 insertions(+), 17 deletions(-) diff --git

[PATCH 4/5] staging: cxt1e1: fix checkpatch error 'assignment in if condition'

2014-02-27 Thread Daeseok Youn
checkpatch.pl error: ERROR: do not use assignment in if condition Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/hwprobe.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/cxt1e1/hwprobe.c

[PATCH 5/5] staging: cxt1e1: fix checkpatch errors with open brace '{'

2014-02-27 Thread Daeseok Youn
clean up checkpatch.pl error: ERROR: that open brace { should be on the previous line Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/hwprobe.c | 62 +++--- 1 file changed, 25 insertions(+), 37 deletions(-) diff --git

Re: [PATCH 3/5] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

2014-02-27 Thread Dan Carpenter
On Fri, Feb 28, 2014 at 04:12:22PM +0900, Daeseok Youn wrote: clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Patch is white space dammaged and doesn't apply. regards, dan carpenter ___ devel mailing list

[PATCH] Staging: comedi: addi-data: remove unnecessary variable initializations in hwdrv_apci035.c

2014-02-27 Thread Chase Southwood
Nearly every variable in hwdrv_apci035.c is initialized to 0 when it is declared, and then set to some other value before ever being used. As such, we can remove all of these initializations. They are accomplishing nothing. Signed-off-by: Chase Southwood chase.southw...@yahoo.com ---

[PATCH 1/2] Staging: comedi: addi-data: fix lines that are over 80 characters

2014-02-27 Thread Chase Southwood
hwdrv_apci1564.c had numerous lines over the column limit. This patch splits all such lines to bring them in compliance with coding style. Signed-off-by: Chase Southwood chase.south...@yahoo.com --- .../comedi/drivers/addi-data/hwdrv_apci1564.c | 50 -- 1 file changed,

[PATCH 2/2] Staging: comedi: addi-data: remove unnecessary variable initializations in hwdrv_apci1564.c

2014-02-27 Thread Chase Southwood
A handful of variables here were being initialized to 0 upon declaration, however they are always then set to another value before their first use, so initialization here is useless and we can remove it. Signed-off-by: Chase Southwood chase.southw...@yahoo.com ---

Re: [PATCH 3/5] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

2014-02-27 Thread DaeSeok Youn
OK. sorry. I will send again. Thanks. Daeseok Youn 2014-02-28 16:28 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: On Fri, Feb 28, 2014 at 04:12:22PM +0900, Daeseok Youn wrote: clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Patch is white space dammaged and

[PATCH] Staging: comedi: add timeouts to while loops in s626.c

2014-02-27 Thread Chase Southwood
Smatch located a handful of while loops testing readl calls in s626.c. Since these while loops depend on readl succeeding, it's safer to make sure they time out eventually. Signed-off-by: Chase Southwood chase.southw...@yahoo.com --- Ian and/or Hartley, I'd love your comments on this. It seems

[PATCH 3/5 v2] Staging: cxt1e1: Fix line length over 80 characters in hwprobe.c

2014-02-27 Thread Daeseok Youn
clean up checkpatch.pl warnings: WARNING: Line length over 80 characters Signed-off-by: Daeseok Youn daeseok.y...@gmail.com --- drivers/staging/cxt1e1/hwprobe.c | 45 -- 1 file changed, 28 insertions(+), 17 deletions(-) diff --git

Re: [RFC PATCH v4 3/8] staging: imx-drm: Document updated imx-drm device tree bindings

2014-02-27 Thread Tomi Valkeinen
On 27/02/14 18:54, Philipp Zabel wrote: - One IPU enabled, one disabled: nothing special here, just set the other IPU to status=disabled in the DT data. The driver for the enabled IPU would register the required DRM entities. that should work. Let the enabled IPU create the imx-drm platform

Re: [PATCH 1/2] Staging: comedi: addi-data: fix lines that are over 80 characters

2014-02-27 Thread Dan Carpenter
On Fri, Feb 28, 2014 at 01:31:20AM -0600, Chase Southwood wrote: hwdrv_apci1564.c had numerous lines over the column limit. This patch splits all such lines to bring them in compliance with coding style. Signed-off-by: Chase Southwood chase.south...@yahoo.com ---

Re: [PATCH 1/2] Staging: comedi: addi-data: fix lines that are over 80 characters

2014-02-27 Thread Dan Carpenter
On Fri, Feb 28, 2014 at 10:52:32AM +0300, Dan Carpenter wrote: On Fri, Feb 28, 2014 at 01:31:20AM -0600, Chase Southwood wrote: hwdrv_apci1564.c had numerous lines over the column limit. This patch splits all such lines to bring them in compliance with coding style. Signed-off-by: Chase