Re: [PATCH] Staging: comedi: check the return value of kobject_set_name

2014-06-09 Thread Ian Abbott
On 2014-06-07 14:56, Anton Protopopov wrote: Added a check of the return value of the kobject_set_name function. Signed-off-by: Anton Protopopov a.s.protopo...@gmail.com --- drivers/staging/comedi/comedi_fops.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) Reviewed-by: Ian

Re: [PATCH 2/2] Staging: speakup: ERROR: Fix macro parenthesis.

2014-06-09 Thread Choi
I made a stupid mistake, and I'm sorry. https://lkml.org/lkml/2014/6/8/53 2014-06-09 2:58 GMT+09:00 Dan Carpenter dan.carpen...@oracle.com: It looks like this patch is adding blank lines not parenthesis like the subject says. regards, dan carpenter On Sun, Jun 08, 2014 at 11:12:57PM +0900,

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-06-09 Thread Lars-Peter Clausen
On 06/09/2014 01:18 AM, Ben Dooks wrote: On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote: On 05/30/2014 07:33 PM, David Daney wrote: On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM, abdoulaye berthe berthe...@gmail.com wrote: ---

[PATCH 03/76] staging: rtl8723au: rtw_mlme.c: Convert rtw_get_wps_ie23a() to cfg80211_find_vendor_ie()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c

[PATCH 10/76] staging: rtl8723au: Declare rtw_get_wpa{2, }_cipher_suite() static

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 12 ++-- drivers/staging/rtl8723au/include/ieee80211.h | 2 -- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git

[PATCH 06/76] staging: rtl8723au: Remove obsolete rtw_get_wps_ie23a()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 44 -- drivers/staging/rtl8723au/include/ieee80211.h | 1 - 2 files changed, 45 deletions(-) diff --git

[PATCH 32/76] staging: rtl8723au: rtw_check_bcn_info23a(): Use ether_addr_equal() to check BSSID

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c

[PATCH 07/76] staging: rtl8723au: rtw_get_bcn_info23a(): Use cfg80211_* to obtain crypto info

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 29 +- 1 file changed, 14 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ieee80211.c

[PATCH 20/76] staging: rtl8723au: Reference correct firmwarefiles with MODULE_FIRMWARE()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Add missing firmware references, and request the correct one. Reported-by: Larry Finger larry.fin...@lwfinger.net Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/os_intfs.c | 4 +++- 1 file changed, 3

[PATCH 38/76] staging: rtl8723au: Allocate struct wlan_bssid_ex in collect_bss_info()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c| 52 drivers/staging/rtl8723au/include/rtw_mlme_ext.h | 3 -- 2 files changed, 25 insertions(+), 30 deletions(-) diff

[PATCH 05/76] staging: rtl8723au: rtw_ap.c: Convert from rtw_get_wps_ie23a() to cfg80211_find_vendor_ie()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Some of this is hackish, but so was the original code. This needs to be cleaned up eventually. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 25 - 1 file changed, 16

[PATCH 17/76] staging: rtl8723au: issue_auth(): Convert to using struct ieee80211_mgmt

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This reduces the dependency of rtw_set_fixed_ie23a() which is scheduled to go away. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 101 +++--- 1 file changed, 44

[PATCH 26/76] staging: rtl8723au: ioctl_cfg80211.c: Use struct ieee80211_mgmt to build mgmt frame

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 30 --- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

[PATCH 30/76] staging: rtl8723au: Remove unused #defines WEP_KEY_LEN and MGMT_QUEUE_NUM

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/ieee80211.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/rtl8723au/include/ieee80211.h b/drivers/staging/rtl8723au/include/ieee80211.h

[PATCH 15/76] staging: rtl8723au: Be consistent in how htpriv.ht_option is checked

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c| 6 +++--- drivers/staging/rtl8723au/core/rtw_mlme.c | 2 +- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 6 +++---

[PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Greg, Thanks for pushing my other changes to Linus. This set goes on top of the set I sent you on 2014/05/31 and the fix from 2014/06/03. If you prefer I go back and submit it all as one large set, let me know. This set contains a number of fixes,

[PATCH 40/76] staging: rtl8723au: free_scanqueue(): Use _rtw_free_network23a()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Use _rtw_free_network23() so elements are freed in one place. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 13/76] staging: rtl8723au: Remove WMM_ defines

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Only one is used, and only describes the size of an array defined in a local function. Use sizeof() in the local function to deobfuscate it. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 7 ---

[PATCH 09/76] staging: rtl8723au: Remove obsolete rtw_get_sec_ie23a()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 75 -- drivers/staging/rtl8723au/include/ieee80211.h | 2 - 2 files changed, 77 deletions(-) diff --git

[PATCH 36/76] staging: rtl8723au: rtw_survey_event_cb23a(): Use the correct types for the received arguments

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c

[PATCH 12/76] staging: rtl8723au: OnAssocRsp23a(): Use cfg80211_* to parse IEs

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 66 +++ 1 file changed, 37 insertions(+), 29 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 14/76] staging: rtl8723au: Make struct ht_priv.ht_option a bool

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Match the return type of rtw_restructure_ht_ie23a() accordingly Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c| 4 ++-- drivers/staging/rtl8723au/include/rtw_ht.h | 2 +-

[PATCH 11/76] staging: rtl8723au: Make WMM_param_handler23a() and HT_caps_handler23a() take a const u8 *

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 4 ++-- drivers/staging/rtl8723au/include/rtw_mlme_ext.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 02/76] staging: rtl8723au: rtw_mlme_ext.c: Convert rtw_get_wps_ie23a() to cfg80211_find_vendor_ie()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 15 +- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 40 +++--- drivers/staging/rtl8723au/include/ieee80211.h | 4

[PATCH 04/76] staging: rtl8723au: ioctl_cfg80211.c: Convert rtw_get_wps_ie23a() to cfg80211_find_vendor_ie()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Given that the IE len is stored in a u8, there is no point having a 512 buffer to store it, nor check if the size exceeds this size. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/ieee80211.h | 2 +-

[PATCH 37/76] staging: rtl8723au: Do not embed struct wlan_bssid_ex in struct survey_event

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Instead allocate it separately and reference it from survey_event. This will allow for us to pass it on later without having to copy it. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 5 -

[PATCH 23/76] staging: rtl8723au: issue_action_BSSCoexistPacket(): Use struct ieee80211_mgmt

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This gets rid of the rtw_set_fixed_ie23a() usage here. Note that this abuses ieee80211_mgmt.u.action.u.chan_switch for now, since the correct defines are currently missing, and this one matches. Need to fix up the definitions in ieee80211.h and

[PATCH 27/76] staging: rtl8723au: issue_action_BA23a(): Use struct ieee80211_mgmt to build action frames

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 149 +- 1 file changed, 74 insertions(+), 75 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 08/76] staging: rtl8723au: rtw_wlan_util.c: Use cfg80211_* to determine crypto

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c

[PATCH 19/76] staging: rtl8723au: Request correct firmware file for A-cut parts

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com The filename requested by the driver didn't match what we had sitting in /lib/firmware/ Reported-by: Ben Hutchings b...@decadent.org.uk Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 +- 1

[PATCH 42/76] staging: rtl8723au: OnAuth23a(): Use ether_addr_copy()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 25/76] staging: rtl8723au: Let cfg80211 handle public action management frames

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com The driver shouldn't be dealing with public action management frames. Let these go directly to the cfg80211 layer which can defer them to userland if needed. Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[PATCH 24/76] staging: rtl8723au: Do not xmit BSS Coexistence management action frames

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com The driver should not be issuing BSS Coexistence management action frames when scanning. This isn't required by the spec, and if needed, these should come from wpa_s instead. Recommended by Johannes Berg. Signed-off-by: Jes Sorensen

[PATCH 43/76] staging: rtl8723au: Get rid of IW_ESSID_MAX_SIZE

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 3 ++- drivers/staging/rtl8723au/include/ieee80211.h | 2 -- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 2 +- 3 files changed, 3

[PATCH 22/76] staging: rtl8723au: issue_action_spct_ch_switch23a(): Use struct ieee80211_mgmt

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 32 +++ 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 39/76] staging: rtl8723au: collect_bss_info(): Don't memset() what we just kzalloc()'d

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 21/76] staging: rtl8723au: _issue_deauth(): Use struct ieee80211_mgmt to build frame

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 27 ++- 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 29/76] staging: rtl8723au: Remove duplicate defines of IEEE80211_HT_PARAM_CHA_SEC_*

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 10 -- drivers/staging/rtl8723au/include/ieee80211.h | 5 - 2 files changed, 4 insertions(+), 11 deletions(-) diff --git

[PATCH 31/76] staging: rtl8723au: Remove some unused 80211 header parsing macros

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/ieee80211.h | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/staging/rtl8723au/include/ieee80211.h

[PATCH 28/76] staging: rtl8723au: Remove obsolete rtw_set_fixed_ie23a()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ieee80211.c | 8 drivers/staging/rtl8723au/include/ieee80211.h | 1 - 2 files changed, 9 deletions(-) diff --git

[PATCH 18/76] staging: rtl8723au: issue_assocrsp(): Use struct ieee80211_mgmt instead of rtw_set_fixed_ie23a()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 33 +++ 1 file changed, 13 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 01/76] staging: rtl8723au: rtw_get_wps_ie23a(): Remove unused dest pointer wps_ie

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ap.c | 7 +-- drivers/staging/rtl8723au/core/rtw_ieee80211.c| 7 +-- drivers/staging/rtl8723au/core/rtw_mlme.c | 2 +-

[PATCH 41/76] staging: rtl8723au: rtw_stadel_event_callback23a(): Remove superfluous memset()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index

[PATCH 54/76] staging: rtl8723au: rtw_do_join23a(): Use correct error return values

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Don't mix true/fail with _SUCCESS/_FAIL as return value Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 55/76] staging: rtl8723au: Minor debug message fixup

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c

[PATCH 68/76] staging: rtl8723au: Move rtw_do_join23a() to rtw_mlme.c and declare it static

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c| 33 drivers/staging/rtl8723au/core/rtw_mlme.c | 38 +--

Re: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-06-09 Thread Andrzej Hajda
On 06/09/2014 01:29 PM, Lars-Peter Clausen wrote: On 06/09/2014 01:18 AM, Ben Dooks wrote: On Fri, May 30, 2014 at 08:16:59PM +0200, Lars-Peter Clausen wrote: On 05/30/2014 07:33 PM, David Daney wrote: On 05/30/2014 04:39 AM, Geert Uytterhoeven wrote: On Fri, May 30, 2014 at 1:30 PM,

[PATCH 56/76] staging: rtl8723au: Don't prepend debug console messages with 'ERROR '

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/include/rtw_debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/include/rtw_debug.h

[PATCH 50/76] staging: rtl8723au: cfg80211_rtw_connect(): Simplify ssid preparation

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Since we just matched sme-{ssid,ssid_len} to pnetwork-network.Ssid.{ssid,ssid_len} we can simplify the copy and move it to just before the call to rtw_set_ssid(). Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[PATCH 52/76] staging: rtl8723au: rtw_set_ssid(): This is never called with _FW_UNDER_LINKING

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

[PATCH 76/76] staging: rtl8723au: rtw_cfg80211_set_wpa_ie(): Avoid pointless memcpy

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com There is no point copying a buffer, just to scan it and then free it again. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 21 +++-- 1 file changed, 7 insertions(+), 14

[PATCH 60/76] staging: rtl8723au: rtw_surveydone_event_callback23a(): Remove superfluous memset()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c b/drivers/staging/rtl8723au/core/rtw_mlme.c index

RE: [PATCH 2/2] gpio: gpiolib: set gpiochip_remove retval to void

2014-06-09 Thread David Laight
From: Of Andrzej Hajda ... You can't error out on module unload, although that's not really relevant here. gpiochip_remove() is typically called when the device that registered the GPIO chip is unbound. And despite some remove() callbacks having a return type of int you can not abort the

[PATCH 58/76] staging: rtl8723au: Introduce rtw_do_join_network()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 2 -- drivers/staging/rtl8723au/core/rtw_mlme.c | 46 -- drivers/staging/rtl8723au/include/rtw_mlme.h | 2 ++ 3

[PATCH 66/76] staging: rtl8723au: rtw_set_ssid(): Use rtw_do_join_network()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com We already have the wlan_network we wish to join, hence it's pointless to go back to the scanned_queue and pull it out of there, before running the join logic. Signed-off-by: Jes Sorensen jes.soren...@redhat.com ---

[PATCH 73/76] staging: rtl8723au: Don't run regular scans in the driver, the stack handles that

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/Makefile| 1 - drivers/staging/rtl8723au/core/rtw_ioctl_set.c| 78 --- drivers/staging/rtl8723au/core/rtw_mlme.c | 21

[PATCH 64/76] staging: rtl8723au: rtw_surveydone_event_callback23a(): We always set _FW_UNDER_LINKING

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c

[PATCH 69/76] staging: rtl8723au: rtw_get_cur_max_rate23a(): Remove duplicate fwstate checks

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ioctl_set.c

[PATCH 45/76] staging: rtl8723au: cfg80211_rtw_connect(): Check correct return value from rtw_set_802_11_ssid23a()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

[PATCH 16/76] staging: rtl8723au: Make struct htpriv.ampdu_enable a bool

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Be consistent in parsing it's value Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 5 ++--- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8723au/include/rtw_ht.h| 2

[PATCH 53/76] staging: rtl8723au: rtw_cfg80211_add_wep(): Use WLAN_KEY_LEN_*

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c

[PATCH 71/76] staging: rtl8723au: Move rtw_get_cur_max_rate23a() to ioctl_cfg80211.c

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This function has only one caller, so move it home and declare it static Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c| 63 ---

[PATCH 59/76] staging: rtl8723au: rtw_do_join23a(): Use __func__ to get function name in debug messages

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_ioctl_set.c

[PATCH 34/76] staging: rtl8723au: rtw_check_bcn_info23a(): Don't search for WPA/WPA2 info twice

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_wlan_util.c | 63 ++ 1 file changed, 25 insertions(+), 38 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c

[PATCH 46/76] staging: rtl8723au: Fold rtw_set_802_11_authentication_mode23a() into cfg80211_rtw_connect()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c| 24 --- drivers/staging/rtl8723au/include/rtw_ioctl_set.h | 2 -- drivers/staging/rtl8723au/os_dep/ioctl_cfg80211.c | 10

[PATCH 75/76] staging: rtl8723au: Move FillH2CCmd() prototype to rtl8723a_cmd.h where it really belongs

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com As an added bonus, remove the now obsolete rtw_ioctl_set.h Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 1 - .../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 1 -

[PATCH 63/76] staging: rtl8723au: to_join will no be true if _FW_LINKED is set

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c

[PATCH 44/76] staging: rtl8723au: Make rtw_is_same_ibss23a() return bool

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 44 -- drivers/staging/rtl8723au/core/rtw_mlme.c | 6 ++-- drivers/staging/rtl8723au/include/rtw_mlme.h | 4 +-- 3

[PATCH 65/76] staging: rtl8723au: rtw_select_and_join_from_scanned_queue23a() never returns 2

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme.c

[PATCH 74/76] staging: rtl8723au: Quiet unused variable warning when building with CONFIG_8723AU_AP_MODE=n

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c

[PATCH 61/76] staging: rtl8723au: Consolidate duplicate adhoc joining code into rtw_do_join_adhoc()

2014-06-09 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- drivers/staging/rtl8723au/core/rtw_ioctl_set.c | 40 +-- drivers/staging/rtl8723au/core/rtw_mlme.c | 93 ++ drivers/staging/rtl8723au/include/rtw_mlme.h | 1

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

2014-06-09 Thread Fabio Estevam
On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Please check the status in /sys/class/drm/card0-HDMI-A-1/status. This should report the current state of the hotplug detection. /sys/class/drm/card0-HDMI-A-1/status returns the correct state for HDMI cable

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

2014-06-09 Thread Shawn Guo
On Mon, Jun 09, 2014 at 11:29:28AM -0300, Fabio Estevam wrote: On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Please check the status in /sys/class/drm/card0-HDMI-A-1/status. This should report the current state of the hotplug detection.

[patch] VME: remove duplicate CA91CX42_DCTL_VDW_M define

2014-06-09 Thread Dan Carpenter
The CA91CX42_DCTL_VDW_M define is cut and pasted twice so we can delete the second instance. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/vme/bridges/vme_ca91cx42.h b/drivers/vme/bridges/vme_ca91cx42.h index 02a7c79..d46b12d 100644 ---

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

2014-06-09 Thread Greg KH
On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Greg, Thanks for pushing my other changes to Linus. This set goes on top of the set I sent you on 2014/05/31 and the fix from 2014/06/03. If you prefer I go back and submit

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

2014-06-09 Thread Fabio Estevam
On Mon, Jun 9, 2014 at 11:33 AM, Shawn Guo shawn@freescale.com wrote: On Mon, Jun 09, 2014 at 11:29:28AM -0300, Fabio Estevam wrote: On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Please check the status in /sys/class/drm/card0-HDMI-A-1/status.

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

2014-06-09 Thread Jes Sorensen
Greg KH gre...@linuxfoundation.org writes: On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Greg, Thanks for pushing my other changes to Linus. This set goes on top of the set I sent you on 2014/05/31 and the fix from

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

2014-06-09 Thread Greg KH
On Mon, Jun 09, 2014 at 05:39:54PM +0200, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Greg, Thanks for pushing my other changes to Linus. This set

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

2014-06-09 Thread Jes Sorensen
Greg KH gre...@linuxfoundation.org writes: On Mon, Jun 09, 2014 at 05:39:54PM +0200, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: I don't feel comfortable justifying that to Linus or anyone about how important it is to get into 3.16-final, sorry. So, can you split this

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

2014-06-09 Thread Larry Finger
On 06/09/2014 10:39 AM, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Greg, Thanks for pushing my other changes to Linus. This set goes on top of the set I

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

2014-06-09 Thread Greg KH
On Mon, Jun 09, 2014 at 05:51:24PM +0200, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: On Mon, Jun 09, 2014 at 05:39:54PM +0200, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: I don't feel comfortable justifying that to Linus or anyone about how

Re: [PATCH 00/76] staging-next: rtl8723au: More fixes for 3.16

2014-06-09 Thread Greg KH
On Mon, Jun 09, 2014 at 10:54:46AM -0500, Larry Finger wrote: On 06/09/2014 10:39 AM, Jes Sorensen wrote: Greg KH gre...@linuxfoundation.org writes: On Mon, Jun 09, 2014 at 03:15:52PM +0200, jes.soren...@redhat.com wrote: From: Jes Sorensen jes.soren...@redhat.com Greg, Thanks for

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

2014-06-09 Thread Russell King - ARM Linux
On Mon, Jun 09, 2014 at 11:29:28AM -0300, Fabio Estevam wrote: On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Please check the status in /sys/class/drm/card0-HDMI-A-1/status. This should report the current state of the hotplug detection.

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

2014-06-09 Thread Fabio Estevam
On Mon, Jun 9, 2014 at 2:49 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Mon, Jun 09, 2014 at 11:29:28AM -0300, Fabio Estevam wrote: On Mon, Jun 9, 2014 at 11:06 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Please check the status in

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

2014-06-09 Thread Fabio Estevam
On Mon, Jun 9, 2014 at 3:15 PM, Fabio Estevam feste...@gmail.com wrote: I wonder if the problem is that HDMI and LVDS are interfering with each other wrt the required pixel clock, and LVDS is winning. If we have HDMI enabled, many HDMI sinks will only work if we set one of their supported

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

2014-06-09 Thread Fabio Estevam
On Mon, Jun 9, 2014 at 3:38 PM, Fabio Estevam feste...@gmail.com wrote: On Mon, Jun 9, 2014 at 3:15 PM, Fabio Estevam feste...@gmail.com wrote: I wonder if the problem is that HDMI and LVDS are interfering with each other wrt the required pixel clock, and LVDS is winning. If we have HDMI

Re: [PATCH] imx-drm: imx-hdmi: fix hdmi hotplug detection initial state

2014-06-09 Thread Russell King - ARM Linux
On Mon, Jun 09, 2014 at 03:15:16PM -0300, Fabio Estevam wrote: With HDMI cable connected (no image is seen on HDMI, only on lvds cable): imx-drm display-subsystem.11: bound 12.hdmi (ops hdmi_ops) imx-hdmi 12.hdmi: EVENT=plugin imx-hdmi 12.hdmi: Non-CEA mode used in HDMI imx-hdmi