Use to_platform_device() instead of open-coding it.
Signed-off-by: Geliang Tang
---
drivers/staging/fbtft/fbtft_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fbtft_device.c
b/drivers/staging/fbtft/fbtft_device.c
index
Greg KH [2015-12-26 19:12]:
> I need a "full" name here, not a "short" name, sorry, before I can do
> anything with this patch.
I don't know if that is the case here, but:
You know, of course, that there are societies in this world where only
one name is used?
--
Hilsen Harald
> >
> > Signed-off-by: Figo Zhang
>
> As you ignored my instructions to you, I'm going to just ignore this patch,
> sorry. Now discarded.
>
I am no at intel kernel group (SSG OTC), I am at CCG CCE. I will involve the
intel open source guys if they like to help.
Hi
1) Return value of this function does not used;
2) wilc_parse_network_info has no reasons to return an error;
3) kfree does not free memory if argument is NULL.
Signed-off-by: Ivan Safonov
---
drivers/staging/wilc1000/coreconfigurator.c | 27 +--
[if your patch is applied to the wrong git tree, please drop us a note to help
improving the system]
Hi Joshua,
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.4-rc6 next-20151223]
url:
From: Hari Prasath Gujulan Elango
Replace multiple if..else if..statements with simple table lookup in two
functions.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/most/mostcore/core.c | 41 +---
1
Hi Willy,
I'm helping Greg do a bit of cleanup in the staging tree, I noticed that
panel driver is maybe ready to be moved to drivers/misc. Are there any
TODO tasks left to do? I already sent checkpatch clean-up patches.
Thanks,
Ksenija
___
devel
On Mon, Dec 28, 2015 at 04:33:27PM +0200, Andrey Utkin wrote:
> After some iterations of checkpatch.pl, on a new developed driver
> (tw5864), now I have the following:
>
> $ grep 'WARNING\|ERROR' /src/checkpatch.tw5864 | sort | uniq -c
> 31 ERROR: do not use C99 // comments
> 147
On Mon, Dec 28, 2015 at 12:32:39PM +0100, Ksenija Stanojević wrote:
> Hi Willy,
>
> I'm helping Greg do a bit of cleanup in the staging tree, I noticed that
> panel driver is maybe ready to be moved to drivers/misc. Are there any
> TODO tasks left to do? I already sent checkpatch clean-up
After some iterations of checkpatch.pl, on a new developed driver
(tw5864), now I have the following:
$ grep 'WARNING\|ERROR' /src/checkpatch.tw5864 | sort | uniq -c
31 ERROR: do not use C99 // comments
147 WARNING: Block comments use a trailing */ on a separate line
144 WARNING:
Hi Dan,
Thanks for your review, I'm adding a few extra comments below.
On Mon, Dec 28, 2015 at 06:27:36PM +0300, Dan Carpenter wrote:
> On Mon, Dec 28, 2015 at 12:32:39PM +0100, Ksenija Stanojevi?? wrote:
> > Hi Willy,
> >
> > I'm helping Greg do a bit of cleanup in the staging tree, I noticed
ethtool_ops has attributes in sub struct ethtool_coalesce that
correspond to the parameters intagg_delay and dynamic_intagg. It is
preferable to set these properties with ethtool rather than
module_param, so create these attributes in adapter and set them using
ethtool_coalesce's rx_coalesce_usecs
> However, it appears that the same process, dTi-lm, is still chosen for oom
> kill
> because lowmem_deathpending_timeout has expired.
>
> So this looks like a problem if the constantly chosen process cannot exit.
> It would have been helpful to have the stack of pid 27289 in the log to see
>
Cordial greeting message from Eva Zahra, I am seeking for your help,I will
be very glad if you do assist me to relocate a sum of (US$4 Million
Dollars)into your Bank account in your country for the benefit of both of
us i want to use this money for investment. I will give you more details
as
From: Shraddha Barke
Remove explicit NULL comparison and write it in its simpler form.
Signed-off-by: Shraddha Barke
---
drivers/staging/goldfish/goldfish_audio.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
From: Shraddha Barke
Fix the checkpatch warning "No space is necessary after cast"
Signed-off-by: Shraddha Barke
---
drivers/staging/gdm72xx/netlink_k.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Cordial greeting message from Eva Zahra, I am seeking for your help,I will
be very glad if you do assist me to relocate a sum of (US$4 Million
Dollars)into your Bank account in your country for the benefit of both of
us i want to use this money for investment. I will give you more details
as
> > Android System UI hang when run heavy monkey stress test.
>
> What changed from v1 of this patch? Please describe that below the ---
> line.
V2,I just modify my comments.
>
> >
> > Signed-off-by: Figo
>
> I need a "full" name here, not a "short" name, sorry,
Use to_delayed_work() instead of open-coding it.
Signed-off-by: Geliang Tang
---
drivers/staging/rtl8192e/rtllib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib.h
b/drivers/staging/rtl8192e/rtllib.h
index
1) Return value of this function does not used;
2) wilc_parse_network_info has no reasons to return an error;
3) kfree does not free memory if argument is NULL.
Signed-off-by: Ivan Safonov
---
drivers/staging/wilc1000/coreconfigurator.c | 27 +--
Hi,
Is it useful to clean staging/dgnc, since it supports the same adapters
that those of serial/jsm ?
best regards,
salah triki
___
devel mailing list
de...@linuxdriverproject.org
Use to_delayed_work() instead of open-coding it.
Signed-off-by: Geliang Tang
---
drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 6 +++---
drivers/staging/rtl8192u/r8192U_core.c | 3 +--
drivers/staging/rtl8192u/r8192U_dm.c | 4
From: Shraddha Barke
Fix checkpatch warning of adding space around + in accordance with
kernel coding style.
Signed-off-by: Shraddha Barke
---
drivers/staging/goldfish/goldfish_audio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Fix checkpatch.pl warnings in panel.c
Signed-off-by: Ksenija Stanojevic
Ksenija Stanojevic (2):
Staging: panel: Fix line over 80 characters
Staging: panel: Remove space
drivers/staging/panel/panel.c | 8 +---
1 file changed, 5 insertions(+), 3
Em Mon, 28 Dec 2015 07:33:32 -0800
Greg KH escreveu:
> On Mon, Dec 28, 2015 at 04:33:27PM +0200, Andrey Utkin wrote:
> > After some iterations of checkpatch.pl, on a new developed driver
> > (tw5864), now I have the following:
> >
> > $ grep 'WARNING\|ERROR'
25 matches
Mail list logo