Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-13 Thread Edward Lipinsky
On Thu, Oct 13, 2016 at 05:39:22PM +0300, Mike Rapoport wrote: > On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote: > > > > Thanks, that makes sense. I tried deleting the if statement and printk() > > from ddk750_help.c, and adding the following in lynxfb_pci_probe() after > >

Re: [staging:staging-next 761/1248] drivers/staging/lustre/lustre/osc/osc_request.c:1045:5-24: WARNING: Unsigned expression compared with zero: cli -> cl_avail_grant < 0

2016-10-13 Thread James Simmons
> cli->cl_avail_grant has type unsigned long, so the code in line 1039-1045 > will have to be handled in some other way. > > julia Thank you Julia for reporting this. I have created a patch that is being tested right now. I will post it shortly. > -- Forwarded message -- >

Re: [PATCH 32/41] staging: lustre: llite: restart short read/write for normal IO

2016-10-13 Thread James Simmons
> On Wed, Oct 12, 2016 at 12:22:35AM +0100, James Simmons wrote: > > > > > On Sun, Oct 02, 2016 at 10:28:28PM -0400, James Simmons wrote: > > > > From: Bobi Jam > > > > > > > > If normal IO got short read/write, we'd restart the IO from where > > > > we've accomplished

Re: [patch] Staging: lustre: indent an if statement

2016-10-13 Thread James Simmons
> This if statement wasn't intended. Acked-by: James Simmons > Signed-off-by: Dan Carpenter > > diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c > b/drivers/staging/lustre/lustre/obdclass/cl_object.c > index 3199dd4..a102c36

Re: [bug report] staging: lustre: create striped directory

2016-10-13 Thread James Simmons
> On Tue, Oct 11, 2016 at 04:14:11PM +, Wang, Di wrote: > > Hello, > > > > On 10/11/16, 4:37 AM, "Dan Carpenter" wrote: > > > > >Hello wang di, > > > > > >The patch 2de353860782: "staging: lustre: create striped directory" > > >from Aug 16, 2016, leads to the

[PATCH] Tools: hv: recover after hv_vss_daemon freeze times out

2016-10-13 Thread Michael Gissing
If a FIFREEZE operation run by the hv_vss_daemon takes longer than the VSS_USERSPACE_TIMEOUT set in the hv_snapshot module, instead of exiting after a write failure, try to recover by reopening the hv_vss device and performing the initial handshake again. Exiting causes all subsequent VSS

my subject

2016-10-13 Thread WESTERN UNION MONEY TRANSFER
Good Day Beneficiary I write to inform you that we have been given the mandate to transfer your full compensation payment of $1,800,000.00 USD via western union by this government. We tried to give you the Western Union Instructions through phone, but we could not locate your numbers in our

[PATCH v2] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue

2016-10-13 Thread Nadim Almas
Fixed coding style issue Signed-off-by: Nadim Almas --- Changes in v2: -Comment is taken from below line. drivers/staging/ks7010/eap_packet.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/eap_packet.h

Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue

2016-10-13 Thread Greg KH
Note, the mailing lists reject html email, please fix up your client. On Fri, Oct 14, 2016 at 12:34:30AM +0530, Nadim Almas wrote: > But i have seen in some place where comments are below the line > like in > here from "drivers/staging/ks7010/eap_packet.h" >  line number 100 > > >  struct

Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue

2016-10-13 Thread Joe Perches
On Thu, 2016-10-13 at 09:05 -0700, Nadim Almas wrote: > Fixed coding style issue > > Signed-off-by: Nadim Almas > --- > drivers/staging/ks7010/eap_packet.h | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ks7010/eap_packet.h >

Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-13 Thread Zach Brown
On Thu, Oct 13, 2016 at 10:46:34AM -0400, David Miller wrote: > From: Zach Brown > Date: Tue, 11 Oct 2016 15:26:20 -0500 > > > From: Josh Cartwright > > > > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will > > create a set of led

[PATCH 2/2] staging: ks7010: Fixes warning :do not add new typedefs

2016-10-13 Thread Sabitha George
Fixes checkpatch.pl warning: do not add new typedefs in ks_wlan_net.c Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks_wlan_net.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_net.c

[PATCH 1/2] staging: ks7010: Replace __attribute__(aligned(x)) with __aligned(x)

2016-10-13 Thread Sabitha George
Fixes checkpatch.pl warning: __aligned(size) is preferred over __attribute__((aligned(size)) in ks7010_sdio.h Signed-off-by: Sabitha George --- drivers/staging/ks7010/ks7010_sdio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2016-10-13 Thread Joe Perches
On Thu, 2016-10-13 at 18:49 +0200, Greg KH wrote: > On Thu, Oct 13, 2016 at 09:37:23AM -0700, Joe Perches wrote: > > On Thu, 2016-10-13 at 16:57 +0200, Greg KH wrote: > > > On Thu, Oct 13, 2016 at 05:23:45PM +0300, Mikhail Golubev wrote: > > > > On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH

Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2016-10-13 Thread Greg KH
On Thu, Oct 13, 2016 at 09:37:23AM -0700, Joe Perches wrote: > On Thu, 2016-10-13 at 16:57 +0200, Greg KH wrote: > > On Thu, Oct 13, 2016 at 05:23:45PM +0300, Mikhail Golubev wrote: > > > On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH wrote: > > > > On Thu, Oct 13, 2016 at 02:50:18PM +0300,

Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-13 Thread Andrew Lunn
> Do you have suggestions on how to better handle the choice of the array size > and the speeds? phydev->supported lists the speeds this phy supports. Andrew ___ devel mailing list de...@linuxdriverproject.org

Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2016-10-13 Thread Joe Perches
On Thu, 2016-10-13 at 16:57 +0200, Greg KH wrote: > On Thu, Oct 13, 2016 at 05:23:45PM +0300, Mikhail Golubev wrote: > > On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH wrote: > > > On Thu, Oct 13, 2016 at 02:50:18PM +0300, Mikhail Golubev wrote: > > > > Function definitions arguments should

Re: [PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue

2016-10-13 Thread Greg KH
On Thu, Oct 13, 2016 at 09:05:57AM -0700, Nadim Almas wrote: > Fixed coding style issue > > Signed-off-by: Nadim Almas > --- > drivers/staging/ks7010/eap_packet.h | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git

[PATCH] Staging:ks7010:eap_packet: fixed 80 character line limit coding style issue

2016-10-13 Thread Nadim Almas
Fixed coding style issue Signed-off-by: Nadim Almas --- drivers/staging/ks7010/eap_packet.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ks7010/eap_packet.h b/drivers/staging/ks7010/eap_packet.h index df7f760..90432ff 100644 ---

Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-13 Thread David Miller
From: Zach Brown Date: Thu, 13 Oct 2016 10:42:46 -0500 > Do you have suggestions on how to better handle the choice of the array size > and the speeds? All of the speed values are simply the rate in bits per second. There is therefore no reason you can't just print the raw

Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2016-10-13 Thread Greg KH
On Thu, Oct 13, 2016 at 05:23:45PM +0300, Mikhail Golubev wrote: > On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH wrote: > > On Thu, Oct 13, 2016 at 02:50:18PM +0300, Mikhail Golubev wrote: > > > Function definitions arguments should also have an identifier name as > > > reported by

Re: [PATCH v4 3/3] net: phy: leds: add support for led triggers on phy link state change

2016-10-13 Thread David Miller
From: Zach Brown Date: Tue, 11 Oct 2016 15:26:20 -0500 > From: Josh Cartwright > > Create an option CONFIG_LED_TRIGGER_PHY (default n), which will > create a set of led triggers for each instantiated PHY device. There is > one LED trigger per

Re: [PATCH] staging: sm750fb: Fix printk() style warning

2016-10-13 Thread Mike Rapoport
On Mon, Oct 10, 2016 at 07:31:46AM -0700, Edward Lipinsky wrote: > > Thanks, that makes sense. I tried deleting the if statement and printk() > from ddk750_help.c, and adding the following in lynxfb_pci_probe() after > calling hw_sm750_map() and checking for errors: > > if (sm750_dev->revid ==

Re: Re: [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2016-10-13 Thread Mikhail Golubev
On Thu, Oct 13, 2016 at 02:06:02PM +0200, Greg KH wrote: > On Thu, Oct 13, 2016 at 02:50:18PM +0300, Mikhail Golubev wrote: > > Function definitions arguments should also have an identifier name as > > reported by checkpatch.pl. > > Please wrap your changelog comments at 72 columns. > > > > >

[PATCH] [media] s5p_cec: Mark runtime suspend/resume as __maybe_unused

2016-10-13 Thread Geert Uytterhoeven
If CONFIG_PM_SLEEP=n: drivers/staging/media/s5p-cec/s5p_cec.c:235: warning: ‘s5p_cec_runtime_suspend’ defined but not used drivers/staging/media/s5p-cec/s5p_cec.c:243: warning: ‘s5p_cec_runtime_resume’ defined but not used Mark these functions as__maybe_unused to fix this without

Re: [PATCH 1/2] Staging: greybus: gpio: Use gbphy_dev->dev instead of bundle->dev

2016-10-13 Thread Rui Miguel Silva
Hi Viresh, On Wed, Oct 12, 2016 at 08:02:21AM +0530, Viresh Kumar wrote: Some of the print messages are using the incorrect device pointer, fix them. Signed-off-by: Viresh Kumar Reviewed-by: Rui Miguel Silva Thanks, Rui ---

[patch v2] staging: android: ion: Fix error handling in ion_query_heaps()

2016-10-13 Thread Dan Carpenter
If the copy_to_user() fails we should unlock and return directly without updating "cnt". Also the return value should be -EFAULT instead of the number of bytes remaining. Fixes: 02b23803c6af ("staging: android: ion: Add ioctl to query available heaps") Signed-off-by: Dan Carpenter

Re: [PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2016-10-13 Thread Greg KH
On Thu, Oct 13, 2016 at 02:50:18PM +0300, Mikhail Golubev wrote: > Function definitions arguments should also have an identifier name as > reported by checkpatch.pl. Please wrap your changelog comments at 72 columns. > > Signed-off-by: Mikhail Golubev > --- >

[PATCH] staging:vt6656:baseband.h: fix function definition argument without identifier name issue

2016-10-13 Thread Mikhail Golubev
Function definitions arguments should also have an identifier name as reported by checkpatch.pl. Signed-off-by: Mikhail Golubev --- drivers/staging/vt6656/baseband.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git

Re: [RFC PATCH v1 00/28] x86: Secure Encrypted Virtualization (AMD)

2016-10-13 Thread Paolo Bonzini
On 23/08/2016 01:23, Brijesh Singh wrote: > TODO: > - send qemu/seabios RFC's on respective mailing list > - integrate the psp driver with CCP driver (they share the PCI id's) > - add SEV guest migration command support > - add SEV snapshotting command support > - determine how to do ioremap of

Re: [RFC PATCH v1 24/28] KVM: SVM: add SEV_LAUNCH_FINISH command

2016-10-13 Thread Paolo Bonzini
On 23/08/2016 01:28, Brijesh Singh wrote: > + > + /* Iterate through each vcpus and set SEV KVM_SEV_FEATURE bit in > + * KVM_CPUID_FEATURE to indicate that SEV is enabled on this vcpu > + */ > + kvm_for_each_vcpu(i, vcpu, kvm) > + svm_cpuid_update(vcpu); > + Do you

Re: [RFC PATCH v1 22/28] KVM: SVM: add SEV launch start command

2016-10-13 Thread Paolo Bonzini
On 23/08/2016 01:28, Brijesh Singh wrote: > +static int sev_launch_start(struct kvm *kvm, > + struct kvm_sev_launch_start __user *arg, > + int *psp_ret) > +{ > + int ret, asid; > + struct kvm_sev_launch_start params; > + struct

Re: [RFC PATCH v1 21/28] KVM: introduce KVM_SEV_ISSUE_CMD ioctl

2016-10-13 Thread Paolo Bonzini
On 23/08/2016 01:28, Brijesh Singh wrote: > The ioctl will be used by qemu to issue the Secure Encrypted > Virtualization (SEV) guest commands to transition a guest into > into SEV-enabled mode. > > a typical usage: > > struct kvm_sev_launch_start start; > struct kvm_sev_issue_cmd data; > >

Re: [RFC PATCH v1 20/28] KVM: SVM: prepare for SEV guest management API support

2016-10-13 Thread Paolo Bonzini
On 23/08/2016 01:28, Brijesh Singh wrote: > The patch adds initial support required for Secure Encrypted > Virtualization (SEV) guest management API's. > > ASID management: > - Reserve asid range for SEV guest, SEV asid range is obtained >through CPUID Fn8000_001f[ECX]. A non-SEV guest can

Re: [V2] rtlwifi: Fix regression caused by commit d86e64768859

2016-10-13 Thread Kalle Valo
Larry Finger wrote: > In commit d86e64768859 ("rtlwifi: rtl818x: constify local structures"), > the configuration struct for most of the drivers was changed to be > constant. The problem is that five of the modified drivers need to be > able to update the firmware name

Re: [RFC PATCH v1 19/28] KVM: SVM: prepare to reserve asid for SEV guest

2016-10-13 Thread Paolo Bonzini
On 23/08/2016 01:27, Brijesh Singh wrote: > In current implementation, asid allocation starts from 1, this patch > adds a min_asid variable in svm_vcpu structure to allow starting asid > from something other than 1. > > Signed-off-by: Brijesh Singh > --- >

[patch] Staging: lustre: indent an if statement

2016-10-13 Thread Dan Carpenter
This if statement wasn't intended. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/lustre/lustre/obdclass/cl_object.c b/drivers/staging/lustre/lustre/obdclass/cl_object.c index 3199dd4..a102c36 100644 --- a/drivers/staging/lustre/lustre/obdclass/cl_object.c

Re: [PATCH] Staging:greybus:arche-apb-ctrl: fixed some coding style issue

2016-10-13 Thread Greg KH
On Thu, Oct 13, 2016 at 06:00:45AM +0200, Alexander Alemayhu wrote: > On Wed, Oct 12, 2016 at 04:45:54PM +0200, Greg KH wrote: > > > > You can subscribe to the driverdev mailing list to see what othes are > > working on, and you can follow my staging-testing kernel branch in the > > staging.git