Re: How should I use kernel-defined i2c structs in this driver

2016-05-26 Thread Antti Palosaari
On 05/26/2016 04:59 PM, Andrey Utkin wrote: Could anybody please give a hint - which kernel-defined i2c objects, and how many of them, I need to define and use to substitute these driver-defined functions i2c_read(), i2c_write() ?

Re: [PATCH] Fixed all coding style issues for drivers/staging/media/lirc/

2014-10-02 Thread Antti Palosaari
On 10/02/2014 07:45 PM, Joe Perches wrote: On Thu, 2014-10-02 at 10:29 -0300, Mauro Carvalho Chehab wrote: Em Wed, 01 Oct 2014 21:40:02 -0700 Amber Thrall amber.rose.thr...@gmail.com escreveu: Fixed various coding style issues, including strings over 80 characters long and many deprecated

Re: [PATCH 1/1] staging: media: msi3101: sdr-msi3101.c - replace with time_before_eq()

2014-06-29 Thread Antti Palosaari
Moikka! That is already fixed by someone else and patch is somewhere Mauro or Hans queue. regards Antti On 06/29/2014 08:20 AM, Anil Belur wrote: From: Anil Belur ask...@gmail.com - this fix replaces jiffies interval comparision with safer function to avoid any overflow and wrap around ?

Re: [PATCH v2] staging/media/rtl2832u_sdr: fix coding style problems by adding blank lines

2014-06-15 Thread Antti Palosaari
Acked-by: Antti Palosaari cr...@iki.fi Reviewed-by: Antti Palosaari cr...@iki.fi Mauro, pick that from patchwork to 3.16. I am not going to PULL request it. Antti On 06/03/2014 03:38 AM, Ovidiu Toader wrote: This minor patch fixes all WARNING:SPACING style warnings in rtl2832_sdr.c The new

Re: [PATCH] msi3103: Use time_before_eq()

2014-06-15 Thread Antti Palosaari
Acked-by: Antti Palosaari cr...@iki.fi Reviewed-by: Antti Palosaari cr...@iki.fi Mauro, pick that from patchwork to 3.16. I am not going to PULL request it. regards Antti On 05/25/2014 03:39 PM, Manuel Schölling wrote: To be future-proof and for better readability the time comparisons

Re: [PATCH] staging: media: as102: replace custom dprintk() with dev_dbg()

2014-05-17 Thread Antti Palosaari
you forget to remove debug parameter itself. Antti On 05/17/2014 04:16 PM, Martin Kepplinger wrote: don't reinvent dev_dbg(). use the common kernel coding style. Signed-off-by: Martin Kepplinger mart...@posteo.de --- this applies to next-20140516. drivers/staging/media/as102/as102_drv.c |

Re: [PATCHv2] staging: media: as102: replace custom dprintk() with dev_dbg()

2014-05-17 Thread Antti Palosaari
On 05/17/2014 07:05 PM, Martin Kepplinger wrote: don't reinvent dev_dbg(). remove dprintk() in as102_drv.c. use the common kernel coding style. Signed-off-by: Martin Kepplinger mart...@posteo.de Reviewed-by: Antti Palosaari cr...@iki.fi --- this applies to next-20140516. any more