[PATCH v3 3/7] staging: unisys: cleanup rc -1 in create_visor_device()

Get rid of the rc = -1 initialization. Return a meaningful error on failure in the function, or, the rc from a called function if it fails. Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: Put the goto back in. v3: sent the wrong version of the patch by mistake. --- d

[PATCH v2 3/7] staging: unisys: cleanup goto in create_visor_device()

Get rid of the rc = -1 initialization. Return a meaningful error on failure in the function, or, the rc from a called function if it fails. Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: Put the goto back in. --- drivers/staging/unisys/visorbus/visorbus_main.

[PATCH 5/7] staging: unisys: remove pointless init of rc in chipset_device_create()

The value of rc is set by calling a function, so there's no need to initialize it to -1, or anything at all. Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/visorbus_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 3/7] staging: unisys: cleanup goto in create_visor_device()

Get rid of the rc = -1 initialization, and remove the goto mess entirely. Return a meaningful error on failure in the function, or the rc from a called function if it fails. Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/visorbus_main.

[PATCH 1/7] staging: unisys: fix return value for visorbus pci probe

Instead of returning -1, return -ENODEV when there is no probe function found for the device. Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/visorbus_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/

[PATCH 7/7] staging: unisys: return meaningful error for visorchipset_init()

The other error paths return meaningful error codes, except for the one when registering a device, which just returned -1. Let's return ENODEV when it fails to register instead. Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/visorchipset.c | 2

[PATCH 0/7] staging: unisys: goto/rc = -1 cleanup series

This series cleans up all the places where rc = -1 was being done, either as initialization, or to return an error value. In some places, it can just be removed, but other places it was better to cleaning up goto statements and eliminate the -1 at the same time. Benjamin Romer (7): staging

[PATCH 2/7] staging: unisys: remove goto in get_vbus_header_info

Remove the rc, the = -1, and all the goto mess here and just return directly with a meaningful error number. The caller only cares about success/failure right now, that needs to be addressed in a later patch series. Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/s

[PATCH 6/7] staging: unisys: clean up initiate_chipset_device_pause_resume()

-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/visorbus_main.c | 42 + 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c b/drivers/staging/unisys/visorbus/visorbus_main.c

[PATCH 4/7] staging: unisys: get rid of goto in create_bus_instance()

Remove the unnecessary rc and goto messiness, and just handle freeing the memory before returning an error in the one place where that needs to happen. Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/visorbus_main.c | 16

[PATCH v3 10/14] staging: unisys: fix comments in visorbus_main.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following types of check patch warnings: Block comments use a trailing */ on a separate line Comment alignments Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Be

[PATCH v3 12/14] staging: unisys: fix comments in visornic_main.c

; Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: the patch was rebased. v3: the patch was rebased. --- drivers/staging/unisys/visornic/visornic_main.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic

[PATCH v3 05/14] staging: unisys: fix comments in visorchipset

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes all the Block comments by using a trailing */ on a separate line Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: the patch was reba

[PATCH v3 07/14] staging: unisys: fix comparison to NULL in visorchipset.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following type of check patch warnings: Comparison to NULL could be written Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: the pat

[PATCH v3 06/14] staging: unisys: fix spacing in visorchipset.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following checkpatch warning: spaces preferred around that ‘*’ or ‘|’ Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: the pat

[PATCH v3 02/14] staging: unisys: fix comments for controlvmchannel.h

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch simply fixes all trailing */ by modifying the comments structures while trying to reduce the total number of lines Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.r

[PATCH v3 09/14] staging: unisys: fix spaces after cast visorchipset.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes checkpatch's no space is necessary after a cast Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: the patch was rebased. v3: the

[PATCH v3 11/14] staging: unisys: fix block comments in ultrainputreport.h

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following types of check patch warnings: Block comments use * on subsequent lines Block comments use a trailing */ on a separate line Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Be

[PATCH v3 14/14] staging: unisys: remove unnecessary goto

parser_param_start() had a goto Away, which went to nothing but a return statement. Remove the goto, the CamelCased label, and just return directly. Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: the patch was rebased. v3: the patch was rebased. --- drivers/staging/

[PATCH v3 03/14] staging: unisys: Fix NULL comparison vbusdeviceinfo.h

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patches resolves the NULL comparison checkpatch warnings Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: the patch was rebased. v3: the

[PATCH v3 08/14] staging: unisys: fix blank lines in visorchipset.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> this patch removes the following checkpatch warnings: please use a blank line after … Please don’t use multiple blank lines Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer

[PATCH v3 01/14] staging: unisys: Fix guestlinuxdebug.h comments

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch simply cleans up all checkpatch comment issues Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: the patch was rebased. v3: the patch was reb

[PATCH v3 04/14] staging: unisys: fix trailing comment in vbusdeviceinfo.h

From: Erik Arfvidson <erik.arfvid...@unisys.com> Fixes checkpatch trailing */ comment in vbusdeviceinfo.h Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: the patch was rebased. v3: the patch was reb

[PATCH v3 13/14] staging: unisys: fix else statement in visornic_main.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following types of check patch warnings: else is not generally useful after a break or return Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unis

[PATCH v3 00/14] staging: unisys: cleanup series

was acceptable as is. - Two patches were modified to move a fix to a NULL comparison into the correct patch. Benjamin Romer (1): staging: unisys: remove unnecessary goto Erik Arfvidson (13): staging: unisys: Fix guestlinuxdebug.h comments staging: unisys: fix comments for controlvmchannel.h

[PATCH 13/16] staging: unisys: fix else statement in visornic_main.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following types of check patch warnings: else is not generally useful after a break or return Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.co

[PATCH 11/16] staging: unisys: fix block comments in ultrainputreport.h

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following types of check patch warnings: Block comments use * on subsequent lines Block comments use a trailing */ on a separate line Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Be

[PATCH 02/16] staging: unisys: fix comments for controlvmchannel.h

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch simply fixes all trailing */ by modifying the comments structures while trying to reduce the total number of lines Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.r

[PATCH 16/16] staging: unisys: fix parenthesis in toolaction_show()

Fix the only fixable parenthesis alignment issue in visorchipset.c. The rest are unworkable because of the length of the symbol names used. Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- 1 file changed, 2 insertions

[PATCH 05/16] staging: unisys: fix comments in visorchipset

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes all the Block comments by using a trailing */ on a separate line Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/stagi

[PATCH 08/16] staging: unisys: fix blank lines in visorchipset.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> this patch removes the following checkpatch warnings: please use a blank line after … Please don’t use multiple blank lines Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer

[PATCH 14/16] staging: unisys: fix alignment in visornic_main.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following types of check patch warnings: Alignment should match open parenthesis Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- driv

[PATCH 07/16] staging: unisys: fix comparison to NULL in visorchipset.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following type of check patch warnings: Comparison to NULL could be written Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- driv

[PATCH 10/16] staging: unisys: fix comments in visorbus_main.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following types of check patch warnings: Block comments use a trailing */ on a separate line Comment alignments Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Be

[PATCH 06/16] staging: unisys: fix spacing in visorchipset.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following checkpatch warning: spaces preferred around that ‘*’ or ‘|’ Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/stagi

[PATCH 15/16] staging: unisys: remove unnecessary goto

parser_param_start() had a goto Away, which went to nothing but a return statement. Remove the goto, the CamelCased label, and just return directly. Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/visorchipset.c | 6 ++ 1 file chan

[PATCH 01/16] staging: unisys: Fix guestlinuxdebug.h comments

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch simply cleans up all checkpatch comment issues Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/include/gues

[PATCH 12/16] staging: unisys: fix comments in visornic_main.c

; Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visornic/visornic_main.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c inde

[PATCH 00/16] staging: unisys: cleanup series

This patch series cleans up all the remaining issues reported by checkpatch.pl that can be fixed. The series was rebased against the current contents of staging-next. Benjamin Romer (2): staging: unisys: remove unnecessary goto staging: unisys: fix parenthesis in toolaction_show() Erik

[PATCH 09/16] staging: unisys: fix spaces after cast visorchipset.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes checkpatch's no space is necessary after a cast Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/visorchips

[PATCH 03/16] staging: unisys: Fix NULL comparison vbusdeviceinfo.h

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patches resolves the NULL comparison checkpatch warnings Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/vbusdevice

[PATCH 04/16] staging: unisys: fix trailing comment in vbusdeviceinfo.h

From: Erik Arfvidson <erik.arfvid...@unisys.com> Fixes checkpatch trailing */ comment in vbusdeviceinfo.h Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/vbusdeviceinfo

[PATCH] staging: unisys: Only process up to budget amount of responses

From: David Kershner <david.kersh...@unisys.com> >From napi documentation you should only process the amount your budget allows, if you go over it just wait for the next napi poll to continue. Signed-off-by: David Kershner <david.kersh...@unisys.com> Signed-off-by: Benjamin Rom

[PATCH] staging: unisys: fix parenthesis in toolaction_show()

Fix the only fixable parenthesis alignment issue in visorchipset.c. The rest are unworkable because of the length of the symbol names used. Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/visorchipset.c | 4 ++-- 1 file changed, 2 insertions

[PATCH] staging: unisys: remove unnecessary goto

parser_param_start() had a goto Away, which went to nothing but a return statement. Remove the goto, the CamelCased label, and just return directly. Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/visorchipset.c | 6 ++ 1 file chan

[PATCH 02/15] staging: unisys: fix comments for controlvmchannel.h

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch simply fixes all trailing */ by modifying the comments structures while trying to reduce the total number of lines Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.r

[PATCH 11/15] staging: unisys: fix block comments in ultrainputreport.h

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following types of check patch warnings: Block comments use * on subsequent lines Block comments use a trailing */ on a separate line Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Be

[PATCH 06/15] staging: unisys: fix spacing in visorchipset.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following checkpatch warning: spaces preferred around that ‘*’ or ‘|’ Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/stagi

[PATCH 13/15] staging: unisys: fix else statement in visornic_main.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following types of check patch warnings: else is not generally useful after a break or return Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.co

[PATCH 01/15] staging: unisys: Fix guestlinuxdebug.h comments

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch simply cleans up all checkpatch comment issues Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/include/gues

[PATCH 00/15] staging: unisys: checkpatch cleanup series

This set of patches cleans up all remaining checkpatch formatting warnings in the Unisys driver series. Erik Arfvidson (15): staging: unisys: Fix guestlinuxdebug.h comments staging: unisys: fix comments for controlvmchannel.h staging: unisys: Fix NULL comparison vbusdeviceinfo.h staging:

[PATCH 03/15] staging: unisys: Fix NULL comparison vbusdeviceinfo.h

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patches resolves the NULL comparison checkpatch warnings Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/vbusdevice

[PATCH 09/15] staging: unisys: fix spaces after cast visorchipset.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes checkpatch's no space is necessary after a cast Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/visorchips

[PATCH 04/15] staging: unisys: fix trailing comment in vbusdeviceinfo.h

From: Erik Arfvidson <erik.arfvid...@unisys.com> Fixes checkpatch trailing */ comment in vbusdeviceinfo.h Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/vbusdeviceinfo

[PATCH 07/15] staging: unisys: fix comparison to NULL in visorchipset.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following type of check patch warnings: Comparison to NULL could be written Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- driv

[PATCH 08/15] staging: unisys: fix blank lines in visorchipset.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> this patch removes the following checkpatch warnings: please use a blank line after … Please don’t use multiple blank lines Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer

[PATCH 15/15] staging: unisys: fix blank line in visornic_main.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following type of check patch warning: Blank lines aren't necessary before a close brace '}' Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.co

[PATCH 05/15] staging: unisys: fix comments in visorchipset

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes all the Block comments by using a trailing */ on a separate line Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/stagi

[PATCH 12/15] staging: unisys: fix comments in visornic_main.c

; Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visornic/visornic_main.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/visornic_main.c inde

[PATCH 14/15] staging: unisys: fix alignment in visornic_main.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following types of check patch warnings: Alignment should match open parenthesis Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- driv

[PATCH 10/15] staging: unisys: fix comments in visorbus_main.c

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following types of check patch warnings: Block comments use a trailing */ on a separate line Comment alignments Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Be

[PATCH] staging: unisys: better config switch comments

We should provide more information in the Kconfig help for visorbus and visorinput. Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/Kconfig | 7 ++- drivers/staging/unisys/visorinput/Kconfig | 7 ++- 2 files changed, 12 insertions

[PATCH 08/14] staging: unisys: Add channel feature access functions

From: David Kershner <david.kersh...@unisys.com> Need access functions to set channel polling Signed-off-by: David Kershner <david.kersh...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/visorbus_main.c | 55 ++

[PATCH 05/14] staging: unisys: visorinput: use spinlock for channel_interrupt() locking

we're accessing it in visorinput_channel_interrupt(). Signed-off-by: David Kershner <david.kersh...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorinput/visorinput.c | 26 ++ 1 file changed, 18 insertions(+), 8

[PATCH 00/14] staging: unisys: add channel interrupt support

This patch series adds a centralized infrastructure and device support for channel interrupts sent to s-Par virtual devices. With these changes, the visorhba device is ~80% faster than with only polling, and visornic receives a speedup of over 3500% (from ~9Mb/s to between 360Mb/s and 390Mb/s).

[PATCH 03/14] staging: unisys: visorhba: Convert visorhba to use visorbus channel interrupts.

es from the create message. Signed-off-by: David Kershner <david.kersh...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorhba/visorhba_main.c | 114 +++- 1 file changed, 52 insertions(+), 62 deletions(-) diff -

[PATCH 01/14] staging: unisys: Change poll rate to 2 ms for work

From: David Kershner <david.kersh...@unisys.com> Use ms_to_jiffies for the periodic work queue instead of raw jiffies. Signed-off-by: David Kershner <david.kersh...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visorbus/v

[PATCH 06/14] staging: unisys: Only process up to budget amount of responses

From: David Kershner <david.kersh...@unisys.com> >From napi documentation you should only process the amount your budget allows, if you go over it just wait for the next napi poll to continue. Signed-off-by: David Kershner <david.kersh...@unisys.com> Signed-off-by: Benjamin Rom

[PATCH 02/14] staging: unisys: set client state

From: David Kershner <david.kersh...@unisys.com> Every channel has an s-Par channel state associated with it. This patch correctly sets of the channels. Signed-off-by: David Kershner <david.kersh...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- driv

[PATCH 04/14] staging: unisys: Convert visornic to use visorbus channel interrupt code

; Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/visornic/visornic_main.c | 59 + 1 file changed, 21 insertions(+), 38 deletions(-) diff --git a/drivers/staging/unisys/visornic/visornic_main.c b/drivers/staging/unisys/visornic/vis

[PATCH 10/14] staging: unisys: Capture data from device create to register interrupt.

David Kershner <david.kersh...@unisys.com> Signed-off-by: Tim Sell <timothy.s...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/include/visorbus.h | 5 + drivers/staging/unisys/visorbus/visorbus_main.c | 118 +

[PATCH 13/14] staging: unisys: Remove semaphores around channel interrupts.

From: David Kershner <david.kersh...@unisys.com> We can remove the semaphore from around the interrupt callback in dev_periodic_work(). Signed-off-by: David Kershner <david.kersh...@unisys.com> Signed-off-by: Tim Sell <timothy.s...@unisys.com> Signed-off-by: Benjamin

[PATCH 14/14] staging: unisys: Allow for unregistering of interrupts.

rshner <david.kersh...@unisys.com> Signed-off-by: Tim Sell <timothy.s...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/include/visorbus.h | 2 + drivers/staging/unisys/visorbus/visorbus_main.c | 65 ++--- 2 file

[PATCH 07/14] staging: unisys: Add support to update Features bits in channel queues

From: David Kershner <david.kersh...@unisys.com> Add support to visorbus to update the features in the channel queues. Signal queues features is the memory location to disable/enable signal queue interrupts. Signed-off-by: David Kershner <david.kersh...@unisys.com> Signed-off-by: Be

[PATCH 09/14] staging: unisys: Re-enable interrupts after we have done the work

d when the driver decides that it is done processing its queue. Visorinput, visorhba, and visornic were all updated to call the new function. Signed-off-by: David Kershner <david.kersh...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/include/vi

[PATCH 12/14] staging: unisys: Don't set polling mode in visorhba_probe

From: David Kershner <david.kersh...@unisys.com> Visorbus handles interrupt states for the drivers now, don't need to handle it in the driver. Signed-off-by: David Kershner <david.kersh...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/stagi

[PATCH 11/14] staging: unisys: Don't go into POLLING mode in visornic_probe.

From: David Kershner <david.kersh...@unisys.com> Since visorbus now supports s-Par interrupts it will handle the polling/interrupt mode for us. Signed-off-by: David Kershner <david.kersh...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/stagi

[PATCH 02/14] staging: unisys: iochannel.h remove redundant comments

From: Erik Arfvidson <erik.arfvid...@unisys.com> iochannel cleanup redudant comments in function declarations. Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/includ

[PATCH 08/14] staging: unisys: Fix visorchannel.c block comments

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the last checkpatch warning about: Block comments use a trailing */ on a separate line Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- driv

[PATCH 01/14] staging: unisys: iochannel fix block comments

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes warning messages from checkpatch.pl specifically: WARNING: Block comments use a trailing */ on a separate lines Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.r

[PATCH 11/14] staging: unisys: Fix periodic_work.c parenthesis alignment

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes checkpatch.pl message: CHECK: Alignment should match open parenthesis Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/stagi

[PATCH 09/14] staging: unisys: Fix vmcallerinterface.h block comments

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes all the checkpatch Block comments use a trailing */ while keeping comments clean. Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- driv

[PATCH 14/14] staging: unisys: fix ultrainputreport.h block comment warnings

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes the following types of check patch warnings: Block comments use * on subsequent lines Block comments use a trailing */ on a separate line Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Be

[PATCH 12/14] staging: unisys: controlvmcompletionstatus.h fix block comments

rfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- .../unisys/visorbus/controlvmcompletionstatus.h| 24 ++ 1 file changed, 16 insertions(+), 8 deletions(-) diff --git a/drivers/staging/unisys/visorbus/controlvmcompletionstatus.h b/dri

[PATCH 04/14] staging: unisys: iochannel fix trailing */

From: Erik Arfvidson <erik.arfvid...@unisys.com> Fixed last warning message from checkpatch.pl by removing the wordiness of the comment Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/stag

[PATCH 00/14] staging: unisys: checkpatch cleanup series

This series takes care of checkpatch.pl issues found recently, as the current version now inspects comment formatting. In addition, some spacing and alignment issues are corrected. Erik Arfvidson (14): staging: unisys: iochannel fix block comments staging: unisys: iochannel.h remove redundant

[PATCH 10/14] staging: unisys: Fix channel.h Block comments

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes all the checkpatch.pl block commments that use a trailing */ in channel.h Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/stag

[PATCH 13/14] staging: unisys: fix vbuschannel.h comments

From: Erik Arfvidson <erik.arfvid...@unisys.com> Fixes trailling */ from vbuschannel.h and alignment issue on the same comment block Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/stagi

[PATCH 05/14] staging: unisys: visorbus.h fix block comment

From: Erik Arfvidson <erik.arfvid...@unisys.com> This fixes last checkpatch warning: WARNING: Block comments use a trailing */ on a separate line Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- driv

[PATCH 07/14] staging: unisys: Fix guestlinuxdebug.h comments

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch simply cleans up all checkpatch warnings and fixes styling Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging/unisys/include/gues

[PATCH 03/14] staging: unisys: iochannel fix spacing around operators

From: Erik Arfvidson <erik.arfvid...@unisys.com> This patch fixes check warning from checkpatch.pl in the macro definition CHECK: spaces preferred around that '+' (ctx:VxV) Signed-off-by: Erik Arfvidson <erik.arfvid...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.r

[PATCH v2 0/7] staging: unisys: visorinput fixes and enhancements

This patch series fixes visorinput to remove the dependency on FB and add dependency to INPUT, cleans up some formatting issues found with checkpatch.pl, and adds the capability to change screen resolutions without breaking mouse functionality. This is a resubmission of the series. Tim Sell (7):

[PATCH v2 7/7] staging: unisys: visorinput: add INPUT to dependent driver list

From: Tim Sell <timothy.s...@unisys.com> This was an obvious omission, as visorinput is an input-class driver. Signed-off-by: Tim Sell <timothy.s...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: the patch was resubmitted. --- drivers/staging

[PATCH v2 3/7] staging: unisys: visorinput: ensure proper locking wrt creation & ints

yboard() or register_client_mouse()), after which we may quickly find ourselves in visorinput_open(), where we enable interrupts, and hence may call visorinput_channel_interrupt(). Signed-off-by: Tim Sell <timothy.s...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com>

[PATCH v2 2/7] staging: unisys: visorinput: remove need for 'depends on FB'

m> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: the patch was resubmitted. --- drivers/staging/unisys/visorinput/Kconfig | 2 +- drivers/staging/unisys/visorinput/visorinput.c | 63 +- 2 files changed, 52 insertions(+), 13 deletions(-) di

[PATCH v2 4/7] staging: unisys: visorinput: respond to resolution changes on-the-fly

within visorinput_channel_interrupt(). We need to use a workqueue to do it asynchronously. Signed-off-by: Tim Sell <timothy.s...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: the patch was resubmitted. --- drivers/staging/unisys/visorinput/visorinput.c | 71 +++

[PATCH v2 6/7] staging: unisys: visorinput: add useful dev_dbg() and dev_info() messages

From: Tim Sell <timothy.s...@unisys.com> The dev_info() messages at init time are particularly useful for mapping visor devices to input devices. Signed-off-by: Tim Sell <timothy.s...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: the pat

[PATCH v2 1/7] staging: unisys: visorinput: use kref ref-counting for device data struct

From: Tim Sell <timothy.s...@unisys.com> This is NOT technically required for the code as it stands now, but will be needed for subsequent patches. Signed-off-by: Tim Sell <timothy.s...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- v2: reso

[PATCH v2 5/7] staging: unisys: visorinput: sanity check resolution changes

From: Tim Sell <timothy.s...@unisys.com> This commit sanity checks so that if a change resolution request is ever received for a non-mouse device, that an error message will be logged and the message will be ignored. Signed-off-by: Tim Sell <timothy.s...@unisys.com> Signed-off-by: Be

[PATCH 3/9] staging: unisys: visorinput: use kref ref-counting for device data struct

From: Tim Sell <timothy.s...@unisys.com> This is NOT technically required for the code as it stands now, but will be needed for subsequent patches. Signed-off-by: Tim Sell <timothy.s...@unisys.com> Signed-off-by: Benjamin Romer <benjamin.ro...@unisys.com> --- drivers/staging

  1   2   3   4   5   6   7   8   9   10   >