Re: [PATCH 3/6] staging: vboxvideo: Fixup some #ifdef-s

2018-10-22 Thread Emil Velikov
On Mon, 22 Oct 2018 at 15:58, Hans de Goede wrote: > > Add #ifdef CONFIG_PM_SLEEP around the suspend/hibernate functions. > > Remove unnecessary #ifdef CONFIG_COMPAT, the .compat_ioctl member is > always available and if CONFIG_COMPAT is not set then drm_compat_ioctl > is defined to NULL. > >

Re: [PATCHv3 17/22] staging: android: ion: Collapse internal header files

2017-04-08 Thread Emil Velikov
Hi Laura, Couple of trivial nitpicks below. On 3 April 2017 at 19:57, Laura Abbott wrote: > --- a/drivers/staging/android/ion/ion.h > +++ b/drivers/staging/android/ion/ion.h > @@ -1,5 +1,5 @@ > /* > - * drivers/staging/android/ion/ion.h > + *

Re: [RFC PATCH 06/12] staging: android: ion: Remove crufty cache support

2017-03-06 Thread Emil Velikov
On 6 March 2017 at 10:29, Daniel Vetter wrote: > On Fri, Mar 03, 2017 at 10:46:03AM -0800, Laura Abbott wrote: >> On 03/03/2017 08:39 AM, Laurent Pinchart wrote: >> > Hi Daniel, >> > >> > On Friday 03 Mar 2017 10:56:54 Daniel Vetter wrote: >> >> On Thu, Mar 02, 2017 at 01:44:38PM

Re: [PATCH 7/7] staging/android: remove sync framework TODO

2016-06-22 Thread Emil Velikov
Hi Gustavo, On 20 June 2016 at 16:53, Gustavo Padovan wrote: > - - port libsync tests to kselftest I believe the tests haven't landed yet right, so this should stay right ? -Emil ___ devel mailing list

Re: [PATCH] MAINTAINERS: add entry for the Sync File Framework

2016-05-12 Thread Emil Velikov
Hi Gustavo, On 11 May 2016 at 14:45, Gustavo Padovan wrote: > From: Gustavo Padovan > > Add Gustavo as maintainer for the Sync File Framework. Sumit is > co-maintainer as he maintains drivers/dma-buf/. It also uses Sumit's > tree as base. >

Re: [RFC PATCH v1 1/9] selftest: sync: basic tests for sw_sync framework

2016-04-07 Thread Emil Velikov
On 4 April 2016 at 05:12, Emilio López <emilio.lo...@collabora.co.uk> wrote: > Hi, > > El 28/03/16 a las 10:48, Emil Velikov escribió: > >>>>> These tests are based on the libsync test suite from Android. >>>>> This commit lays the ground f

Re: [RFC PATCH v1 1/9] selftest: sync: basic tests for sw_sync framework

2016-03-28 Thread Emil Velikov
On 28 March 2016 at 13:20, Emilio López <emilio.lo...@collabora.co.uk> wrote: > Hi, > > El 28/03/16 a las 08:56, Emil Velikov escribió: >> >> Hi Emilio, >> >> On 9 March 2016 at 15:28, Emilio López <emilio.lo...@collabora.co.uk> >> wrote: >

Re: [PATCH 3/3] drm: bridge: anx78xx: Add anx78xx bridge driver support.

2016-03-28 Thread Emil Velikov
Hi all, On 24 March 2016 at 11:28, Dan Carpenter wrote: > On Thu, Mar 24, 2016 at 11:41:46AM +0100, Enric Balletbo i Serra wrote: >> + /* Map slave addresses of ANX7814 */ >> + for (i = 0; i < I2C_NUM_ADDRESSES; i++) { >> + anx78xx->i2c_dummy[i] =

Re: [RFC PATCH v1 1/9] selftest: sync: basic tests for sw_sync framework

2016-03-28 Thread Emil Velikov
Hi Emilio, On 9 March 2016 at 15:28, Emilio López wrote: > These tests are based on the libsync test suite from Android. > This commit lays the ground for future tests, as well as includes > tests for a variety of basic allocation commands. > > Signed-off-by:

Re: [PATCH] staging/android: add flags member to sync ioctl structs

2016-03-05 Thread Emil Velikov
Hi Greg, Allow me to chip in as well. On 3 March 2016 at 16:17, Greg Kroah-Hartman wrote: > On Thu, Mar 03, 2016 at 11:37:17AM -0300, Gustavo Padovan wrote: >> From: Gustavo Padovan >> >> Play safe and add flags member to all

Re: [PATCH v5 5/5] staging/android: add flags member to sync ioctl structs

2016-03-02 Thread Emil Velikov
On 1 March 2016 at 13:13, Gustavo Padovan wrote: > From: Gustavo Padovan > > Play safe and add flags member to all structs. So we don't need to > break API or create new IOCTL in the future if new features that requires > flags arises. > >

Re: [PATCH] staging/android: refactor SYNC_IOC_FILE_INFO

2016-02-29 Thread Emil Velikov
Hi Gustavo, On 27 February 2016 at 15:25, Gustavo Padovan <gustavo.pado...@collabora.co.uk> wrote: > Hi Emil, > > 2016-02-27 Emil Velikov <emil.l.veli...@gmail.com>: > >> Hi Gustavo, >> >> On 26 February 2016 at 21:00, Gustavo Padovan <gust...@p

Re: [PATCH v4 5/5] staging/android: add flags member to sync ioctl structs

2016-02-28 Thread Emil Velikov
On 27 February 2016 at 15:27, Gustavo Padovan <gustavo.pado...@collabora.co.uk> wrote: > Hi Emil, > > 2016-02-27 Emil Velikov <emil.l.veli...@gmail.com>: > >> Hi Gustavo, >> >> On 26 February 2016 at 18:31, Gustavo Padovan <gust...@padovan.org>

Re: [PATCH v4 5/5] staging/android: add flags member to sync ioctl structs

2016-02-26 Thread Emil Velikov
Hi Gustavo, On 26 February 2016 at 18:31, Gustavo Padovan wrote: > From: Gustavo Padovan > > Play safe and add flags member to all structs. So we don't need to > break API or create new IOCTL in the future if new features that requires >

Re: [PATCH] staging/android: refactor SYNC_IOC_FILE_INFO

2016-02-26 Thread Emil Velikov
Hi Gustavo, On 26 February 2016 at 21:00, Gustavo Padovan wrote: > From: Gustavo Padovan > > Change SYNC_IOC_FILE_INFO behaviour to avoid future API breaks and > optimize buffer allocation. In the new approach the ioctl needs to be called >

Re: [PATCH v2 06/11] staging/android: turn fence_info into a __u64 pointer

2016-02-02 Thread Emil Velikov
On 2 February 2016 at 15:23, Gustavo Padovan wrote: > From: Gustavo Padovan > > Making fence_info a pointer enables us to extend the struct in the future > without breaking the ABI. > > v2: use type __u64 for fence_info > > Signed-off-by:

Re: [PATCH 06/10] staging/android: turn fence_info into a __64 pointer

2016-01-30 Thread Emil Velikov
Hi Gustavo, s/__64/__u64/ in the commit message. On 29 January 2016 at 23:20, Gustavo Padovan wrote: > From: Gustavo Padovan > > Making fence_info a pointer enables us to extend the struct in the future > without breaking the ABI. > >

Re: [PATCH 09/10] staging/android: add flags member to sync ioctl structs

2016-01-30 Thread Emil Velikov
Hi Gustavo, > @@ -54,6 +59,7 @@ struct sync_file_info { > __u32 len; As mentioned previously - can we rework this variable to indicate the total length (or the number) of fence_info struct instances. It seems to be the more common approach afaict. Might also want to move it just above

Re: [PATCH v2 01/11] dma-buf/sync_file: de-stage sync_file

2016-01-27 Thread Emil Velikov
Hi Gustavo, On 27 January 2016 at 17:03, Gustavo Padovan wrote: > Hi Maarten, > > 2016-01-27 Maarten Lankhorst : > >> Hey, >> >> Op 27-01-16 om 14:30 schreef Gustavo Padovan: >> > From: Gustavo Padovan >> >

Re: [PATCH 2/3] drm: imx: Move imx-drm driver out of staging

2014-11-04 Thread Emil Velikov
Hi Philipp, Just a flyby question On 04/11/14 10:52, Philipp Zabel wrote: The imx-drm driver was put into staging mostly for the following reasons, all of which have been addressed or superseded: - convert the irq driver to use linear irq domains - work out the device tree bindings, this