Re: [PATCH] Documentation: process: Correct numbering

Hi Milan, On Tue, Dec 15, 2020 at 07:50:35PM +, Milan Lakhani wrote: > Renumber the steps in submit-checklist.rst as some numbers were skipped. > > Signed-off-by: Milan Lakhani Maybe you can also add: Fixes: 72deb455b5ec ("block: remove CONFIG_LBDAF") But I am confused about why you have

[PATCH] staging: rtl8723bs: reduce stack usage of rtw_cfg80211_unlink_bss

The build of xtensa allmodconfig gives warning of: In function 'rtw_cfg80211_unlink_bss': warning: the frame size of 1136 bytes is larger than 1024 bytes Instead of having 'select_network' structure as a variable use it as a pointer. Signed-off-by: Sudip Mukherjee --- drivers/staging/rtl8723bs

[PATCH] staging: sm750fb: add drm development branch details

...@lists.freedesktop.org Signed-off-by: Sudip Mukherjee <sudipm.mukher...@gmail.com> --- drivers/staging/sm750fb/TODO | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/TODO b/drivers/staging/sm750fb/TODO index f710ab1..aeb2df3 100644 --- a/drivers/staging/s

Re: [PATCH RESEND] staging: sm750fb: avoid conflicting vesafb

On Wed, Jul 12, 2017 at 08:06:24AM +0200, Greg Kroah-Hartman wrote: > On Tue, Jul 11, 2017 at 10:03:01PM +0100, Sudip Mukherjee wrote: > > Hi Greg, > > > > On Fri, Jun 30, 2017 at 09:57:43PM +0100, Sudip Mukherjee wrote: > > > From: Teddy Wang

Re: [PATCH RESEND] staging: sm750fb: avoid conflicting vesafb

Hi Greg, On Fri, Jun 30, 2017 at 09:57:43PM +0100, Sudip Mukherjee wrote: > From: Teddy Wang <teddy.w...@siliconmotion.com> > > If vesafb is enabled in the config then /dev/fb0 is created by vesa > and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to > effec

[PATCH RESEND] staging: sm750fb: avoid conflicting vesafb

: <sta...@vger.kernel.org> # v4.4+ Signed-off-by: Teddy Wang <teddy.w...@siliconmotion.com> Signed-off-by: Sudip Mukherjee <sudipm.mukher...@gmail.com> --- In the previous send, why #ifdef is used was asked. https://lkml.org/lkml/2017/6/25/57 Answered at: https://lkml.org/lkml/2017/6

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

On Sun, Jun 25, 2017 at 04:27:23PM +0200, Greg Kroah-Hartman wrote: > On Sun, Jun 25, 2017 at 02:54:29PM +0100, Sudip Mukherjee wrote: > > On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote: > > > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: &

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

On Sun, Jun 25, 2017 at 02:54:51PM +0200, Greg Kroah-Hartman wrote: > On Sun, Jun 25, 2017 at 01:43:34PM +0100, Sudip Mukherjee wrote: > > On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > > > From: Teddy Wang <teddy.w...@siliconmotion.com> > >

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

On Mon, Jun 19, 2017 at 09:32:57PM +0100, Sudip Mukherjee wrote: > From: Teddy Wang <teddy.w...@siliconmotion.com> > > If vesafb is enabled in the config then /dev/fb0 is created by vesa > and this sm750 driver gets fb1, fb2. But we need to be fb0 and fb1 to > effectively

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

On Tue, Jun 20, 2017 at 11:40:59PM +0300, Andy Shevchenko wrote: > On Tue, Jun 20, 2017 at 11:20 PM, Dan Carpenter > wrote: > > That's totally bogus. Just say you don't know. It's never a > > reguirement that people fix AMD drivers before they can review code... > >

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

Hi Dan, On Tue, Jun 20, 2017 at 11:20:55PM +0300, Dan Carpenter wrote: > That's totally bogus. Just say you don't know. It's never a > reguirement that people fix AMD drivers before they can review code... Yes, I don't know how drm drivers work, so I blindly follow what has been done there.

Re: [PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

On Mon, Jun 19, 2017 at 11:47:20PM +0300, Andy Shevchenko wrote: > On Mon, Jun 19, 2017 at 11:32 PM, Sudip Mukherjee > <sudipm.mukher...@gmail.com> wrote: > > > > +#ifdef CONFIG_X86 > > + primary = pdev->

[PATCH 1/2] staging: sm750fb: avoid conflicting vesafb

ed-off-by: Teddy Wang <teddy.w...@siliconmotion.com> Signed-off-by: Sudip Mukherjee <sudipm.mukher...@gmail.com> --- drivers/staging/sm750fb/sm750.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm7

[PATCH 2/2] staging: sm750fb: change default screen resolution

750fb: change default screen resolution") Signed-off-by: Sudip Mukherjee <sudipm.mukher...@gmail.com> --- drivers/staging/sm750fb/sm750.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c index 8199dbe

[PATCH] staging: sm750fb: change default screen resolution

Update the default screen resolution and also use 24bpp for a better screen performance. Tested-by: Teddy Wang <teddy.w...@siliconmotion.com> Signed-off-by: Sudip Mukherjee <sudipm.mukher...@gmail.com> --- drivers/staging/sm750fb/sm750.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH RESEND] staging: media: lirc: use new parport device model

From: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> Modify lirc_parallel driver to use the new parallel port device model. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- Resending after more than one year. Prevoius patch is at https://patchwork.kernel.org/p

Re: [PATCH] staging: sm750fb: update license

On Saturday 26 November 2016 11:02 AM, Greg Kroah-Hartman wrote: On Sat, Nov 26, 2016 at 09:07:42AM +, Sudip Mukherjee wrote: The driver was actually released with BSD license. It also gained GPL when it was submitted to be included in the kernel. Cc: Teddy Wang <tedd

[PATCH] staging: sm750fb: update license

The driver was actually released with BSD license. It also gained GPL when it was submitted to be included in the kernel. Cc: Teddy Wang <teddy.w...@siliconmotion.com> Cc: gzhou1 <guojian.z...@windriver.com> Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --

Re: [PATCH] staging/android: mark sync_timeline_create() static

On Sat, Sep 03, 2016 at 02:34:13PM +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/staging/android/sw_sync.c:56:23: warning: no previous prototype for > 'sync_timeline_create' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which

Re: [PATCH] staging: rtl8712: fixed comment style and space indent

On Fri, Sep 02, 2016 at 09:14:15PM +0800, Louie Lu wrote: > fixed comment style and space indent report from checkpatch > in rtl8712/rtl871x_ioctl_linux.c: > > * WARNING: Statements should start on a tabstop > * WARNING: Block comments use * on subsequent lines > * WARNING: suspect code indent

Re: [PATCH] staging:ks7010:Fix warning about coding style spacing issue around asterisk in ks_wlan_net.c

On Wed, Aug 31, 2016 at 08:20:10PM -0400, Nicholas Krause wrote: > This fixes warning around a asterisk used in ks_wlan_net.c > for the define statement used for this driver's transmit > queue timeout value as defined by the marco, TX_TIMEOUT. > Signed-off-by: Nicholas Krause

Re: [PATCH v2 1/1] drivers: staging: rtl8723au: hal: Remove pointless test

On Sun, Sep 04, 2016 at 01:01:20PM +0200, Matthias Beyer wrote: > This patch removes the pointless `else if` test. > > Signed-off-by: Matthias Beyer > Reported-by: David Binderman > --- looks like Greg has already applied your first patch.

[PATCH 2/2 RESEND] staging: ks7010: fix memory leak

If the firmware request failed we were just returning but we missed freeing the memory and releasing the MMC Host. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 1/2 RESEND] staging: ks7010: return on failure

Moreover, if it is still not claimed then mmc_host->claim_cnt will be 0 and mmc_release_host() will do "if (--host->claim_cnt)" and thus the condition will become true. Lets just return the value on allocation failure instead of trying to release the host before claiming it. Signed-off-by: Sudi

Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings.

On Thu, Aug 25, 2016 at 09:59:46PM +0800, Ming-Chia Chung wrote: > On Tue, Aug 23, 2016 at 12:01:36PM +0530, Sudip Mukherjee wrote: > > On Tue, Aug 23, 2016 at 08:19:46AM +0800, Ming-Chia Chung wrote: > > > On Mon, Aug 22, 2016 at 10:51:27PM +0530, Sudip Mukherjee wrote: >

Re: [PATCH] staging: android: ion: ion.c fix parenthesis alignment

On Wed, Aug 24, 2016 at 03:56:32AM +0700, Didik Setiawan wrote: > Fix checkpatch.pl warning about "Alignment should match open parenthesis". > --- you missed the Signed-off-by: line. regards sudip ___ devel mailing list de...@linuxdriverproject.org

[PATCH 2/2] staging: ks7010: fix memory leak

If the firmware request failed we were just returning but we missed freeing the memory and releasing the MMC Host. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 1/2] staging: ks7010: return on failure

Moreover, if it is still not claimed then mmc_host->claim_cnt will be 0 and mmc_release_host() will do "if (--host->claim_cnt)" and thus the condition will become true. Lets just return the value on allocation failure instead of trying to release the host before claiming it. Signed-off-by: Sudi

Re: [PATCH -next] staging: comedi: dt2811: fix non static symbol warnings

On Tue, Aug 23, 2016 at 03:02:21PM +, Wei Yongjun wrote: > From: Wei Yongjun > > drivers/staging/comedi/drivers/dt2811.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/dt2811.c >

[PATCH v2] staging: i4l: icn: use memdup_user

Its better to use memdup_user which does the same thing which this code has implemented. Also removed a related warning as we will be warned if allocation fails. Suggested-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> ---

Re: [PATCH] staging: i4l: icn: use memdup_user

On Tue, Aug 23, 2016 at 06:50:30AM -0400, Greg Kroah-Hartman wrote: > On Tue, Aug 23, 2016 at 03:57:34PM +0530, Sudip Mukherjee wrote: > > Its better to use memdup_user which does the same thing which this > > code has implemented. > > > > Suggested-by: Fengguang

[PATCH] staging: i4l: icn: use memdup_user

Its better to use memdup_user which does the same thing which this code has implemented. Suggested-by: Fengguang Wu <fengguang...@intel.com> Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/icn/icn.c | 16 +--- 1 file changed,

Re: [PATCH resend] staging:xgifb:remove unused code

On Tue, Aug 23, 2016 at 05:17:30PM +0800, Ding Xiang wrote: > The variable data is assigned but never used in rest code. > > Signed-off-by: Ding Xiang > --- The subject should have been [Patch v2] not resend. regards sudip ___

Re: [PATCH] staging:xgifb:remove unused code

On Tue, Aug 23, 2016 at 03:26:50PM +0800, dingxiang wrote: > The variable data is assigned but never used in rest code. > > Signed-off-by: Ding Xiang > --- Your name in Signed-off-by: and From: doesnot match. > drivers/staging/xgifb/vb_setmode.c | 1 - > 1 file changed,

Re: [PATCH] staging: i4l: icn: fix memdup_user.cocci warnings

ng its implementation > > This is a little bit restricted to reduce false positives > > > > Generated by: scripts/coccinelle/api/memdup_user.cocci > > > > CC: Sudip Mukherjee <sudipm.mukher...@gmail.com> > > Signed-off-by: Fengguang Wu <fengguang...@intel.com

Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings.

On Tue, Aug 23, 2016 at 08:19:46AM +0800, Ming-Chia Chung wrote: > On Mon, Aug 22, 2016 at 10:51:27PM +0530, Sudip Mukherjee wrote: > > On Tue, Aug 23, 2016 at 12:54:17AM +0800, MingChia Chung wrote: > > > This patch fixes a minor checkpatch warnings: > > > > >

Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings.

On Tue, Aug 23, 2016 at 12:54:17AM +0800, MingChia Chung wrote: > This patch fixes a minor checkpatch warnings: > > "WARNING: Block comments use a trailing */ on a separate line" > > Signed-off-by: Ming-Chia Chung > --- > drivers/staging/rts5208/rtsx.c | 42 >

[PATCH 5/5] staging: i4l: icn: fix incorrect type of arguments

-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/icn/icn.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c index 45623fa..fa705db 100644 --- a/d

[PATCH 4/5] staging: i4l: icn: remove blank lines

Blank lines are not needed after starting brace or before a closing brace. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/icn/icn.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c

[PATCH 3/5] staging: i4l: icn: space not needed after cast

No need provide a space after a typecast. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/icn/icn.c | 66 +-- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/d

[PATCH 2/5] staging: i4l: act2000: remove unused macro

The macro EVAL_PLCI and MAKE_PLCI are not being used. Remove them. But keep the comment preceding them as it contains information regarding message format. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/act2000/capi.h | 7 --- 1 file chan

[PATCH 1/5] staging: i4l: act2000: remove unused argument

The macro EVAL_NCCI was only being used in capi.c and the argument controller was not used. Remove the argument and at the same time remove the variable which now becomes unused. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/act2000/capi

[PATCH 6/6 v2] staging: i4l: icn: fix incorrect type of arguments

-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- Wrong Signed-off in v1. drivers/staging/i4l/icn/icn.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c index 6

[PATCH 5/6] staging: i4l: icn: remove blank lines

Blank lines are not needed after starting brace or before a closing brace. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/icn/icn.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c

[PATCH 3/6] staging: i4l: icn: space not needed after cast

No need provide a space after a typecast. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/icn/icn.c | 70 +-- 1 file changed, 35 insertions(+), 35 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/d

[PATCH 2/6] staging: i4l: icn: donot assign in if statement

It is not the kernel coding style to make assignments in the if statement and checkpatch was warning us about it. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/icn/icn.c | 33 ++--- 1 file changed, 22 insertions(

[PATCH 6/6] staging: i4l: icn: fix incorrect type of arguments

-by: Sudip Mukherjee <sudipm.mukher...@gmail.com> --- drivers/staging/i4l/icn/icn.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c index 6991259..5e3821b 100644 --- a/d

[PATCH 1/6] staging: i4l: icn: do not use return as a function

return is not a function so no need to use the parenthesis. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/icn/icn.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/stagi

[PATCH 4/6] staging: i4l: icn: remove braces

Braces are not required in a single statement block. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/icn/icn.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/i4l/icn/icn.c b/drivers/staging/i4l/icn/icn.c

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

On Monday 25 January 2016 10:42 PM, Mauro Carvalho Chehab wrote: Em Mon, 25 Jan 2016 22:32:31 +0530 Sudip Mukherjee <sudipm.mukher...@gmail.com> escreveu: On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote: Em Fri, 18 Dec 2015 18:35:29 +0530 Sudip Mukherjee <sudi

[PATCH 3/4] staging: i4l: act2000: remove blank line after brace

checkpatch complains about an extra blank line after an opening brace. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/act2000/act2000_isa.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/i4l/act2000/act2000_isa.c b/drivers/s

[PATCH 2/4] staging: i4l: act2000: do not assign in if

It is not the kernel coding style to assign values to some variable in if statement. Split them up into different statements. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/act2000/act2000_isa.c | 9 ++--- 1 file changed, 6 insertions(+), 3 del

[PATCH 4/4] staging: i4l: act2000: remove extra space

It is not kernel coding style to give an extra space after a cast. We get warned about it by checkpatch. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/act2000/act2000_isa.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff

[PATCH 1/4] staging: i4l: act2000: fix use of return

checkpatch warns that return is not a function and as such the brace after it is not required. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/i4l/act2000/act2000_isa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/stagi

[PATCH 1/2] staging: wilc1000: fix double unlock

The semaphore was being released twice, once at the beginning of the thread and then again when the thread is about to close. The semaphore is acquired immediately after creating the thread so we should be releasing it when the thread ends. Signed-off-by: Sudip Mukherjee <sudip.muk

[PATCH 2/2] staging: wilc1000: remove unused variables

These variables were havnig the pointer returned by wiphy_priv() but they were never used. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/wilc1000/linux_wlan.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/wilc1000/linux_

[PATCH] staging: android: ion: dummy: fix dereference of ERR_PTR

ion_device_create() can fail and if it fails then it returns the error value in ERR_PTR. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/android/ion/ion_dummy_driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/andro

[PATCH] staging: android: make function static

The only user of ion_handle_put() is within the file ion.c, so we can safely make it static. Just to be double sure, checked the function ion_handle_get() which is static. So we can make ion_handle_put() static. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/s

Re: [PATCH V3] staging: rtl8192u: check return value of read_nic_word_E

On Fri, Mar 04, 2016 at 11:40:29AM +0100, Salah Triki wrote: > The call of read_nic_word_E may fail, therefore its return value must be > checked. > > Signed-off-by: Salah Triki > --- > drivers/staging/rtl8192u/r8180_93cx6.c | 30 +-- >

Re: [PATCH 1/2] staging: dgnc: use pointer type of tty_struct

On Mon, Feb 29, 2016 at 11:15:51AM +0900, Daeseok Youn wrote: > From 70f8703b3bd73fa56f4ea91e98967b8925550aa6 Mon Sep 17 00:00:00 2001 > From: Daeseok Youn > Date: Thu, 25 Feb 2016 14:53:37 +0900 > Subject: [PATCH 1/2] staging: dgnc: use pointer type of tty_struct These

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

On Mon, Jan 25, 2016 at 03:12:57PM -0200, Mauro Carvalho Chehab wrote: > Em Mon, 25 Jan 2016 22:32:31 +0530 > Sudip Mukherjee <sudipm.mukher...@gmail.com> escreveu: > > > On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote: > > > Em Fri, 18 Dec 2

[PATCH 3/4] staging: dgnc: unregister pci driver

with the error: "Driver 'dgnc' is already registered." Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/dgnc/dgnc_driver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/driv

[PATCH 4/4] staging: dgnc: cleanup properly

dgnc_remove_driver_sysfiles() depending on the argument passed to it. Reported-by: Navy Cheng <nav...@126.com> Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- Hi Greg, If you remember this problem was reported by Navy Cheng on the kernelnewbies list but his report did not contain the ca

[PATCH 2/4] staging: dgnc: remove pci_unregister_driver

with the error code. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- drivers/staging/dgnc/dgnc_driver.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c

[PATCH 1/4] staging: dgnc: remove unneeded else

If pci_enable_device() fails then we can return directly. Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> --- I saw there is some pending dgnc patch in outreachy, so this series might not apply. This series is based on staging-testing. I will resend v2 if it fails. d

Re: [PATCH 04/30] staging: sm750fb: use PLL_CTRL_POWER defines for CRT_PLL_CTRL

On Wed, Feb 10, 2016 at 06:33:56PM +0200, Mike Rapoport wrote: > Use PLL_CTRL_POWER definitions for CRT_PLL_CTRL register access Can we? IIRC, we have two different PLL for two displays. One for the PANEL and the other for CRT. You have renamed PANEL_PLL_* to PLL_*, but can you mix up two

Re: [PATCH 03/30] staging: sm750fb: rename PANEL_PLL_CTRL_* fields to PLL_CTRL_*

On Wed, Feb 10, 2016 at 06:33:55PM +0200, Mike Rapoport wrote: > Several PLL control registers have the same layout and therefore the > field definitions may be shared for those registers. Renaming > definitions of PANEL_PLL_CTRL_* fields to more generic PLL_CTRL_* will > allow reusing these

Re: [PATCH v2] staging: unisys: use common return path

On Mon, Feb 08, 2016 at 10:46:57PM +0530, Sudip Mukherjee wrote: > On Sun, Feb 07, 2016 at 02:04:21PM -0800, Greg Kroah-Hartman wrote: > > On Tue, Dec 01, 2015 at 04:22:33PM +0530, Sudip Mukherjee wrote: > > > The success path and the error path both are first doing > >

Re: [PATCH v2 2/9] Staging: rts5208: rtsx_transport.c: Align to open parenthesis

On Mon, Feb 08, 2016 at 05:31:18PM -0800, Shaun Ren wrote: > This patch fixes the alignment issue reported by checkpatch.pl: > > CHECK: Alignment should match open parenthesis > > Signed-off-by: Shaun Ren > --- > drivers/staging/rts5208/rtsx_transport.c | 61 >

Re: [PATCH v2 7/9] Staging: rts5208: rtsx_transport.c: Remove unnecessary parentheses

On Mon, Feb 08, 2016 at 05:31:23PM -0800, Shaun Ren wrote: > This patch removes all unnecessary parentheses found by checkpatch.pl. > > Signed-off-by: Shaun Ren This will not apply anymore because of some other changes done by: 9a66d05d82db ("Staging: rts5208: fix check for

Re: [PATCH v3 13/14] staging: unisys: fix else statement in visornic_main.c

On Tue, Feb 09, 2016 at 10:16:12AM -0500, Ben Romer wrote: > On Mon, 2016-02-08 at 22:39 +0530, Sudip Mukherjee wrote: > > maybe this is better where you have single exit point and so only one > > spin_unlock_irqrestore(). > > > We discussed this before. I don't wan

Re: [PATCH 2/3] staging: most: return proper error

On Sun, Feb 07, 2016 at 02:14:56PM -0800, Greg Kroah-Hartman wrote: > On Sun, Nov 22, 2015 at 10:30:55PM +0530, Sudip Mukherjee wrote: > > We were returning ENOMEM on all types of errors. Lets return the actual > > error code. At the same time remove the label which became unused

Re: [PATCH v3 13/14] staging: unisys: fix else statement in visornic_main.c

On Mon, Feb 08, 2016 at 10:41:52AM -0500, Benjamin Romer wrote: > From: Erik Arfvidson > > This patch fixes the following types of check patch warnings: > else is not generally useful after a break or return > > Signed-off-by: Erik Arfvidson

[PATCH v2] staging: most: return error value

On error we were returning retval, but retval is not having the error value. We will get the error value using PTR_ERR. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- v2: sent after rebasing drivers/staging/most/aim-cdev/cdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 del

[PATCH v2] staging: most: return proper error

We were returning ENOMEM on all types of errors. Lets return the actual error code. At the same time remove the label which became unused as a result of this patch. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- v1 failed to apply due to some other changes. drivers/stagin

Re: [PATCH v2] staging: unisys: use common return path

On Sun, Feb 07, 2016 at 02:04:21PM -0800, Greg Kroah-Hartman wrote: > On Tue, Dec 01, 2015 at 04:22:33PM +0530, Sudip Mukherjee wrote: > > The success path and the error path both are first doing > > spin_unlock_irqrestore() before returning. Use that in the common path > > a

[PATCH] staging: wilc1000: fix build failure

drivers wowlan can be only used when CONFIG_PM is defined. Fixes: 73584a40d748 ("staging: wilc1000: add ops resuem/suspend/wakeup in cfg80211") Cc: Glen Lee <glen@atmel.com> Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- builds of next-20160205. I think I hav

Re: [PATCH] misc: Move panel driver out of staging

On Tue, Feb 02, 2016 at 08:23:20AM -0800, Greg KH wrote: > On Tue, Feb 02, 2016 at 03:38:21PM +0100, Ksenija Stanojevic wrote: > > Move panel driver from drivers/staging/panel to drivers/misc. > > > > Signed-off-by: Ksenija Stanojevic > > --- > >

Re: [PATCH 1/2] staging: xgifb: XGI_main_26.c fixed spacing to match coding style

On Sat, Jan 30, 2016 at 12:52:45PM -0800, Santosh Madiraju wrote: > From: madiraju You do not need this extra From: line here. Even if you need to give it for some reason then the name should match the name as given in your Signed-off-by: name. > > Removed

Re: [PATCH] Staging: gs_fpgaboot: fixed coding style issues in gs_fpgaboot.c

On Sun, Jan 31, 2016 at 09:06:31PM +0100, Ben Marsh wrote: > Signed-off-by: Ben Marsh > --- You have not given any commit message. Please mention which coding style issue you have fixed. On first look, you have done multiple types of changes. Please only do one type of change

Re: Move wlan-ng out of staging?

On Fri, Jan 29, 2016 at 05:00:16PM +0100, Xose Vazquez Perez wrote: > Ksenija wrote: > > > I'm helping Greg do a bit of cleanup in the staging tree, I noticed that > > wlan-ng driver is maybe ready to be moved out of staging. Are there > > any TODO tasks left to do beside checkpatch.pl clean-up?

Re: [PATCH 1/1] staging: coding style cleanups for staging/most/mostcore driver

On Fri, Jan 29, 2016 at 10:38:42PM +0530, Bijosh Thykkoottathil wrote: > From: Bijosh Thykkoottathil You do not need this From: line here. The email From: header is sufficient. > > Fixes following coading style issues reported by the check patch script. > - ERROR:

Re: Move wlan-ng out of staging?

On Mon, Jan 25, 2016 at 01:16:56PM +0100, Ksenija Stanojević wrote: > Hi All, > > I'm helping Greg do a bit of cleanup in the staging tree, I noticed that > wlan-ng driver is maybe ready to be moved out of staging. Are there > any TODO tasks left to do beside checkpatch.pl clean-up? I think the

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

On Mon, Jan 25, 2016 at 03:40:41PM +0300, Dan Carpenter wrote: > On Mon, Jan 25, 2016 at 03:13:21PM +0530, Sudip Mukherjee wrote: > > Apart from the mail which Ying Huang sent to me last week for another error > > (which actually turned out to be this one), i saw the first report by

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

On Mon, Jan 25, 2016 at 04:47:26AM -0800, Joe Perches wrote: > On Mon, 2016-01-25 at 12:16 +0300, Dan Carpenter wrote: > > Ugh...  Checkpatch told us to introduce bugs...  :(  We almost certainly > > would have missed this bug in review, but it wasn't sent to the list so > > I guess we'll never

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote: > Em Fri, 18 Dec 2015 18:35:29 +0530 > Sudip Mukherjee <sudipm.mukher...@gmail.com> escreveu: > > > Modify lirc_parallel driver to use the new parallel port device model. > > Did you or someone el

Re: [PATCH 5/5] staging: media: lirc: use new parport device model

On Monday 25 January 2016 10:42 PM, Mauro Carvalho Chehab wrote: Em Mon, 25 Jan 2016 22:32:31 +0530 Sudip Mukherjee <sudipm.mukher...@gmail.com> escreveu: On Mon, Jan 25, 2016 at 02:29:06PM -0200, Mauro Carvalho Chehab wrote: Em Fri, 18 Dec 2015 18:35:29 +0530 Sudip Mukherjee <sudi

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

On Mon, Jan 25, 2016 at 12:16:01PM +0300, Dan Carpenter wrote: > Ugh... Checkpatch told us to introduce bugs... :( We almost certainly > would have missed this bug in review, but it wasn't sent to the list so > I guess we'll never know. I can find the v1 of the patch in usb list.

Re: [PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

On Sat, Jan 23, 2016 at 02:49:20PM +0530, Sudip Mukherjee wrote: > This reverts commit ebd43516d3879f882a403836bba8bc5791f26a28. > > We should not be sleeping inside spin_lock. > > Fixes: ebd43516d387 ("Staging: panel: usleep_range is preferred over udelay") > Cc:

[PATCH] Revert "Staging: panel: usleep_range is preferred over udelay"

This reverts commit ebd43516d3879f882a403836bba8bc5791f26a28. We should not be sleeping inside spin_lock. Fixes: ebd43516d387 ("Staging: panel: usleep_range is preferred over udelay") Cc: Sirnam Swetha <theonly.ultim...@gmail.com> Signed-off-by: Sudip Mukherjee <su

Re: [PATCH 25/27] staging: wilc1000: fix coding style of kmalloc usage

On Thu, Jan 21, 2016 at 10:20:28AM +0900, Chaehyun Lim wrote: > This patch fixes coding style of kmalloc usage found by checkpatch. > CHECK: Prefer kmalloc(sizeof(*new_msg)...) over kmalloc(sizeof(struct > message)...) > > Signed-off-by: Chaehyun Lim > --- >

Re: [PATCH v2 1/7] staging/wilc1000: Introduce linux_spi_msg_init

On Mon, Jan 11, 2016 at 09:13:31PM +0100, Janosch Frank wrote: > Since all spi read and write functions were basically preparing the > same data, moving the preparation into a function decreased line count > a lot. > > This also resolves the following problems: > Zeroing the message ourselves is

Re: [PATCH 1/6] staging: wlan-ng: Fixed block comment coding style

On Sat, Jan 09, 2016 at 11:23:14AM +0530, Pranjal wrote: > > > On Saturday 09 January 2016 09:58 AM, Sudip Mukherjee wrote: > >On Sat, Jan 09, 2016 at 12:29:21AM +0530, Pranjal Bhor wrote: > >>Block comments now end with '*/' on a newline and all lines > &g

Re: [PATCH] staging/ion: Add support to get ion handle from dma buf

On Thu, Jan 07, 2016 at 11:57:34AM +0300, Dan Carpenter wrote: > Hm... Perhaps I should be CC'ing LKML more often. What's the rule on > this, should I just send bugfixes to LKML and whitespace changes to only > subsystem list? All my patches (whitespace, bugfix, build fail) always has CC to

Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters

On Wed, Dec 30, 2015 at 11:13:40AM +0100, Ksenija Stanojević wrote: > On Wed, Dec 30, 2015 at 6:01 AM, Sudip Mukherjee > <sudipm.mukher...@gmail.com> wrote: > > On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote: > >> Split comment in order to fit

Re: [PATCH 2/6] Staging: gdm72xx: Add space around that " "

On Sun, Dec 27, 2015 at 02:44:41AM +0530, shraddha.6...@gmail.com wrote: > From: Shraddha Barke > > Add missing space around that " " to follow linux kernel coding > style. Warning detected by checkpatch > > Signed-off-by: Shraddha Barke > ---

Re: [PATCH 1/2] Staging: panel: Fix line over 80 characters

On Sun, Dec 27, 2015 at 12:16:15PM +0100, Ksenija Stanojevic wrote: > Split comment in order to fit into 80 characters per line. > Found by checkpatch.pl > > Signed-off-by: Ksenija Stanojevic > --- Instead of multiline maybe this is better: diff --git

Re: [PATCH 21/28] staging: most: fix retrieval of buffer availability

On Tue, Dec 22, 2015 at 10:53:02AM +0100, Christian Gromm wrote: > This patch fixes the function channel_has_mbo that delivers the false > information in case two AIMs are using the same tx channel. > > Signed-off-by: Christian Gromm > --- > > diff --git

[PATCH 5/5] staging: media: lirc: use new parport device model

Modify lirc_parallel driver to use the new parallel port device model. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/media/lirc/lirc_parallel.c | 100 +++-- 1 file changed, 65 insertions(+), 35 deletions(-) diff --git a/drivers/staging

[PATCH 3/5] staging: media: lirc: space around operator

checkpatch complains about missing space around operators. Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- drivers/staging/media/lirc/lirc_parallel.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/medi

  1   2   3   4   5   6   7   8   9   10   >