Hi Andy,
Nice work on this patch series. Its getting better and better :).
On 14/11/14 03:27, Andy Yan wrote:
hdmi phy clock symbol and transmission termination value
can adjust platform specific to get the best SI
^Is this signal integrity?
Hi Andy
On 14/11/14 03:31, Andy Yan wrote:
Rockchip RK3288 hdmi is compatible with dw_hdmi
Signed-off-by: Andy Yan andy@rock-chips.com
---
Changes in v10:
- add more display mode support mpll configuration for rk3288
Changes in v9:
- move some phy configuration to platform
On 14/11/14 10:37, Andy Yan wrote:
On 2014年11月14日 18:23, Zubair Lutfullah Kakakhel wrote:
Hi Andy
On 14/11/14 03:31, Andy Yan wrote:
Rockchip RK3288 hdmi is compatible with dw_hdmi
Signed-off-by: Andy Yan andy@rock-chips.com
---
Changes in v10:
- add more display mode support
On 14/11/14 10:53, Andy Yan wrote:
Hi ZubairLK:
Thanks for your review.
On 2014年11月14日 18:19, Zubair Lutfullah Kakakhel wrote:
Hi Andy,
Nice work on this patch series. Its getting better and better :).
On 14/11/14 03:27, Andy Yan wrote:
hdmi phy clock symbol and transmission
On 14/11/14 11:08, Andy Yan wrote:
On 2014年11月14日 18:55, Zubair Lutfullah Kakakhel wrote:
On 14/11/14 10:53, Andy Yan wrote:
Hi ZubairLK:
Thanks for your review.
On 2014年11月14日 18:19, Zubair Lutfullah Kakakhel wrote:
Hi Andy,
Nice work on this patch series. Its getting better
On 14/11/14 11:13, Andy Yan wrote:
On 2014年11月14日 18:53, Zubair Lutfullah Kakakhel wrote:
On 14/11/14 10:37, Andy Yan wrote:
On 2014年11月14日 18:23, Zubair Lutfullah Kakakhel wrote:
Hi Andy
On 14/11/14 03:31, Andy Yan wrote:
Rockchip RK3288 hdmi is compatible with dw_hdmi
Signed-off
On 13/11/14 12:57, Andy Yan wrote:
rk3288 hdmi is compatible with Designware hdmi
this patch is depend on patch by Mark Yao Add drm
driver for Rockchip Socs
see https://lkml.org/lkml/2014/10/8/201
Signed-off-by: Andy Yan andy@rock-chips.com
Signed-off-by: Yakir Yang
Hi Andy,
This patch adds the reg-io-width binding.
Hence the binding patch should come before it.
On 11/11/14 12:53, Andy Yan wrote:
On rockchip rk3288, only word(32-bit) accesses are
permitted for hdmi registers. Byte width accesses (writeb,
readb) generate an imprecise external abort.
Hi Andy,
On 11/11/14 12:54, Andy Yan wrote:
From: Yakir Yang y...@rock-chips.com
keep the connector birdge in dw_hdmi.c, handle encoder in dw_hdmi-imx.c
Is there a reason for this separation? Keeping encoder in platform files?
If yes, then the commit message should explain that.
On 11/11/14 14:23, Lucas Stach wrote:
Am Dienstag, den 11.11.2014, 14:20 + schrieb Zubair Lutfullah
Kakakhel:
Hi Andy,
This patch adds the reg-io-width binding.
Hence the binding patch should come before it.
On 11/11/14 12:53, Andy Yan wrote:
On rockchip rk3288, only word(32-bit
Hi Andy,
Some minor comments inline.
On 11/11/14 12:54, Andy Yan wrote:
Signed-off-by: Andy Yan andy@rock-chips.com
---
Changes in v7: None
Changes in v6: None
Changes in v5: None
Changes in v4: None
Changes in v3: None
Changes in v2: None
On 11/11/14 14:46, Andy Yan wrote:
On 2014年11月11日 22:20, Zubair Lutfullah Kakakhel wrote:
Hi Andy,
This patch adds the reg-io-width binding.
Hence the binding patch should come before it.
do you mean that I should put dts binding patch
before this patch?
Yes. The patch adding
Nice work.
This patch should move the binding from
Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt
to the location instead of making a new file and leaving the old
one in place.
And use git format-patch -M to highlight any changes.
Regards
ZubairLK
On 08/11/14 05:32, Andy Yan
Hi Andy,
In 3.18 rc4, I cannot find checkpatch errors in imx-hdmi.c
Have these errors come during the previous 2 patches.
If yes, then these changes need to be squashed into the previous
patches. No patch should add a checkpatch error and then fix it in a later
patch.
Regards
ZubairLK
On
On 10/11/14 09:44, Andy Yan wrote:
Hi ZubairLK
On 2014年11月10日 17:17, Zubair Lutfullah Kakakhel wrote:
Nice work.
This patch should move the binding from
Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt
to the location instead of making a new file and leaving the old
one
Hi Andy,
A few comments inline.
On 08/11/14 05:28, Andy Yan wrote:
imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they
also have some lightly difference, such as phy pll configuration,
register width, 4K support, clk useage,
This one patch does too much to be reviewed easily.
One patch is supposed to modify/add one thing at a time in the kernel.
Separating platform specific code from imx-drm/imx-hdmi is one thing.
Adding support for multi-byte register access is something different.
i.e. Something like.
1/3 split
Hi,
On 04/11/14 13:39, Andy Yan wrote:
From: Andy yan andy@rock-chips.com
the original imx hdmi driver is under staging/imx-drm,
which depends on imx-drm, so move the imx hdmi drvier out
to drm/bridge and rename imx-hdmi to dw-hdmi
Change-Id: I5f417372f256aa26cd00a3cd0160741680afd39d
Hi Andy,
On 04/11/14 13:33, Andy Yan wrote:
imx6 and rockchip rk3288 and JZ4780 (Ingenic Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they
also have some lightly difference, such as phy pll configuration,
register width(imx hdmi register is one byte, but rk3288 is 4
19 matches
Mail list logo