On 10/28/2013 06:24 PM, Luka Perkov wrote:
Checking if MAC address is valid using is_valid_ether_addr() is already done in
of_get_mac_address().

Signed-off-by: Luka Perkov <l...@openwrt.org>

Acked-by: David Daney <david.da...@cavium.com>


---
  drivers/staging/octeon/ethernet.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/octeon/ethernet.c 
b/drivers/staging/octeon/ethernet.c
index c3a90e7..10300da 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -453,7 +453,7 @@ int cvm_oct_common_init(struct net_device *dev)
        if (priv->of_node)
                mac = of_get_mac_address(priv->of_node);

-       if (mac && is_valid_ether_addr(mac))
+       if (mac)
                memcpy(dev->dev_addr, mac, ETH_ALEN);
        else
                eth_hw_addr_random(dev);


_______________________________________________
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Reply via email to