Re: [PATCH 1/2] drivers:staging:silicom Fixed extern warnings reported by checkpatch

2014-02-12 Thread Dan Carpenter
On Tue, Feb 11, 2014 at 11:57:22PM -0800, Surendra Patil wrote: 1) Deleted bp_proc_create() declaration from bp_mod.h, because it is declared as static in bpctl_mod.c and not used anywhere. 2) checkpatch warns about WARNING: externs should be avoided in .c files because we have

[PATCH 1/2] drivers:staging:silicom Fixed extern warnings reported by checkpatch

2014-02-11 Thread Surendra Patil
1) Deleted bp_proc_create() declaration from bp_mod.h, because it is declared as static in bpctl_mod.c and not used anywhere. 2) checkpatch warns about WARNING: externs should be avoided in .c files because we have function declarations in bptcl_mod.c,These functions are not used anywhere