Re: [patch] iio: mxs-lradc: use helper functions to simplify the code

2013-09-06 Thread Dan Carpenter
On Fri, Sep 06, 2013 at 09:01:01AM +0200, Jürgen Beisert wrote: Oh, I did the same yesterday in preparation of the v2 of my patch series. I will send this new version out today. Ah fine. Then let's drop my version. regards, dan carpenter ___

Re: [patch] iio: mxs-lradc: use helper functions to simplify the code

2013-09-06 Thread Russell King - ARM Linux
On Thu, Sep 05, 2013 at 05:15:02PM -0300, Fabio Estevam wrote: Looks good, just one minor suggestion: On Thu, Sep 5, 2013 at 3:16 PM, Dan Carpenter dan.carpen...@oracle.com wrote: +static void lradc_reg_set(struct mxs_lradc *lradc, u32 val, size_t chan) +{ + writel(val,

Re: [patch] iio: mxs-lradc: use helper functions to simplify the code

2013-09-05 Thread Fabio Estevam
On Thu, Sep 5, 2013 at 3:16 PM, Dan Carpenter dan.carpen...@oracle.com wrote: I have introduced lradc_reg_set() and lradc_reg_clear(). It simplifies the callers and makes the lines shorter. Looks good, just one minor suggestion: Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff