[ http://jira.dspace.org/jira/browse/DS-27?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrea Bollini reopened DS-27: ------------------------------ Assignee: Claudia Jürgen SVN commit: http://dspace.svn.sourceforge.net/viewvc/dspace?view=rev&revision=3377 > NullPointerException possible in review.jsp - ID: 1571645 > --------------------------------------------------------- > > Key: DS-27 > URL: http://jira.dspace.org/jira/browse/DS-27 > Project: DSpace 1.x > Issue Type: Bug > Components: JSPUI > Environment: submission/ ingest > Reporter: Charles Kiplagat > Assignee: Claudia Jürgen > Fix For: 1.5.2 > > > In layoutSection, if inputType.equals("dropdown"), > Utils.addEntities is passed the result of > DCInput.getDisplayString(). getDisplayString is > documented to return null if the input stored-value is > not matched, which will cause addEntities to throw a > NPE. The code should probably look more like the > "qualdrop_value" case below it, i.e. change: > row.append(Utils.addEntities(displayVal)); > to: > if (displayVal != null) > { > row.append(Utils.addEntities(displayVal)); > } > I am still working the problem report, but I believe > that I've seen this NPE thrown in practice. In any > case the code in review.jsp does not gracefully handle > a documented return value. > BTW the doc comments for getDisplayString (and > getStoredString) don't seem to match the code. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.dspace.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira ------------------------------------------------------------------------------ This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Dspace-devel mailing list Dspace-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspace-devel