yes, private items should not be withdrawn. Probably it is sufficient to remove
the withdrawn / restore call from the make private method and merge my PR about
the fix for private items searcheable in discovery
(https://github.com/DSpace/DSpace/pull/183 ).
Anyway I plan to look to these issues next week if other can jump in first I
will be glad.
Andrea
Inviato da Tablet SamsungTim Donohue <tdono...@duraspace.org> ha scritto:Hi
Andrea,
A brief followup. I've verified the other bug you mentioned. So, I
logged two new JIRA tickets related to private items:
https://jira.duraspace.org/browse/DS-1711 (Private items should not be
withdrawn)
https://jira.duraspace.org/browse/DS-1712 (AuthorizeException when a
Non-admin marks item as "private")
Feel free to claim one (or more) of them if you plan to work on it. As
mentioned, I'd be glad to help do some testing, etc.
Others are more than welcome to chime in on these ideas or help with
fixes as well. There definitely seems to be a bit of cleanup to be done
here.
- Tim
On 10/17/2013 1:31 PM, Tim Donohue wrote:
> Hi Andrea,
>
> In my opinion, if we are going to have "private" items, they should NOT
> be withdrawn. It seems more reasonable that they should just be normal
> items where "discoverable=false" and "in_archive=true" (i.e. they are
> not withdrawn, instead they are just "hidden" from search/browse)
>
> I just entered another ticket related to both withdrawn & private items
> -- in either case they "reset" any special permissions/embargo on an
> Item. So, if you set an Embargo on an Item, and then temporarily make it
> "private" (e.g. maybe you realized there was a mistake somewhere and
> wanted time to fix it), as soon as you make the Item available again
> ("make public"), the previous embargo/special permissions are overridden
> and the Item is make immediately public. See:
> https://jira.duraspace.org/browse/DS-1710
>
> I'd also love to see these "private" items issues get cleaned up for 4.0.
>
> I'm not sure if I'll have much time to do coding. But, I'd gladly help
> with testing any fixes.
>
> - Tim
>
> On 10/17/2013 1:17 PM, Andrea Bollini wrote:
>> Tim, you are rigth there are major issues with the current
>> implementation.
>> If you do a submission as a normal user (not an administrator) and there
>> are no workflow you will get also an internal error (due to lack of
>> permission to perform the withdrawn).
>> As this is a bug I have that currently on my to do list for 4.0 after
>> the feature freeze.
>> Sorry to haven't share this info before(probably I should also fire a
>> jira issue for that...)
>> Andrea
>>
>>
>>
>>
>> Inviato da Tablet Samsung
>>
>> Tim Donohue <tdono...@duraspace.org> ha scritto:
>>
>> Hi all, I know we've had this discussion before, but all I seem to get
>> is more and more confused about what a "private" item is supposed to
>> mean. Andrea did a good job previously of trying to define the
>> differences here:
>> https://wiki.duraspace.org/display/~bollini/DSpace+Item+state+definitions
>> But,
>> we have an oddity in the implementation of "private" vs. "withdrawn"
>> item. Essentially *both* of these types of items are effectively
>> withdrawn items. Clicking "Make Private" does the following: 1. sets
>> 'discoverable=false' 2. withdraws the item from the archive
>> https://github.com/DSpace/DSpace/blob/master/dspace-xmlui/src/main/java/org/dspace/app/xmlui/aspect/administrative/FlowItemUtils.java#L329
>>
>> The odd thing is that withdrawing an item already makes it no longer
>> visible/findable (what is "discoverable=false" even adding?). So, why do
>> we have this new "make private" option anyways? It's also worth noting
>> that withdrawing an item removes it from the "in_archive" state, which
>> means the item is no longer being checked by things like the Checksum
>> checker (and can no longer be processed by things like Curation Tasks,
>> since they only operate on "in_archive" Items, as Collection.getItems()
>> only returns that)
>> https://github.com/DSpace/DSpace/blob/master/dspace-api/src/main/java/org/dspace/content/Item.java#L1866
>>
>> Conclusion: Private items are no longer "in_archive", and therefore are
>> not really being preserved/maintained in the same way as a normal item.
>> They are ignored by the Checksum Checker, by Curation Tasks, and likely
>> other things. Is it just me, or does this sound like a major bug in how
>> 'private' items are being handled? Or maybe I'm still just confused
>> here? - Tim -- Tim Donohue Technical Lead for DSpace & DSpaceDirect
>> DuraSpace.org | DSpace.org | DSpaceDirect.org
>> ------------------------------------------------------------------------------
>>
>> October Webinars: Code for Performance Free Intel webinars can help you
>> accelerate application performance. Explore tips for MPI, OpenMP,
>> advanced profiling, and more. Get the most from the latest Intel
>> processors and coprocessors. See abstracts and register >
>> http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
>>
>> _______________________________________________ Dspace-devel mailing
>> list Dspace-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/dspace-devel
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135031&iu=/4140/ostg.clktrk
_______________________________________________
Dspace-devel mailing list
Dspace-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dspace-devel
