Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-04-29 Thread Hans de Goede
Hi, On 22-04-19 12:20, Semyon Verchenko wrote: On 18.04.2019 18:12, Hans de Goede wrote: Hi Semyon, On 18-04-19 15:26, Semyon Verchenko wrote: On 18.04.2019 16:09, Hans de Goede wrote: Hi, On 09-04-19 17:31, Andy Shevchenko wrote: Ok. Семен Верченко, this means that we are going to

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-04-22 Thread Semyon Verchenko
On 18.04.2019 18:12, Hans de Goede wrote: Hi Semyon, On 18-04-19 15:26, Semyon Verchenko wrote: On 18.04.2019 16:09, Hans de Goede wrote: Hi, On 09-04-19 17:31, Andy Shevchenko wrote: Ok. Семен Верченко, this means that we are going to need DMI info from the board in question. I

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-04-18 Thread Semyon Verchenko
On 18.04.2019 16:09, Hans de Goede wrote: Hi, On 09-04-19 17:31, Andy Shevchenko wrote: On Mon, Apr 08, 2019 at 08:43:10PM +0200, Hans de Goede wrote: On 08-04-19 19:21, Andy Shevchenko wrote: On Thu, Apr 04, 2019 at 04:43:03PM +0200, Hans de Goede wrote: On 29-03-19 16:53, Hans de Goede

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-04-18 Thread Hans de Goede
Hi Semyon, On 18-04-19 15:26, Semyon Verchenko wrote: On 18.04.2019 16:09, Hans de Goede wrote: Hi, On 09-04-19 17:31, Andy Shevchenko wrote: Ok. Семен Верченко, this means that we are going to need DMI info from the board in question. I thought we already had that, but I now see that

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-04-18 Thread Hans de Goede
Hi, On 09-04-19 17:31, Andy Shevchenko wrote: On Mon, Apr 08, 2019 at 08:43:10PM +0200, Hans de Goede wrote: On 08-04-19 19:21, Andy Shevchenko wrote: On Thu, Apr 04, 2019 at 04:43:03PM +0200, Hans de Goede wrote: On 29-03-19 16:53, Hans de Goede wrote: On 3/29/19 2:59 PM, Семен Верченко

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-04-09 Thread Andy Shevchenko
On Mon, Apr 08, 2019 at 08:43:10PM +0200, Hans de Goede wrote: > On 08-04-19 19:21, Andy Shevchenko wrote: > > On Thu, Apr 04, 2019 at 04:43:03PM +0200, Hans de Goede wrote: > > > On 29-03-19 16:53, Hans de Goede wrote: > > > > On 3/29/19 2:59 PM, Семен Верченко wrote: > > > > > > Hmm, so 4

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-04-08 Thread Hans de Goede
Hi, On 08-04-19 19:21, Andy Shevchenko wrote: On Thu, Apr 04, 2019 at 04:43:03PM +0200, Hans de Goede wrote: On 29-03-19 16:53, Hans de Goede wrote: On 3/29/19 2:59 PM, Семен Верченко wrote: Hmm, so 4 ethernet cards and 4 enabled / marked as critical clocks. Supporting this through

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-04-08 Thread Andy Shevchenko
On Thu, Apr 04, 2019 at 04:43:03PM +0200, Hans de Goede wrote: > On 29-03-19 16:53, Hans de Goede wrote: > > On 3/29/19 2:59 PM, Семен Верченко wrote: > > Hmm, so 4 ethernet cards and 4 enabled / marked as critical clocks. > > > > Supporting this through get_clk is going to require a DMI table

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-04-04 Thread Hans de Goede
Hi, On 29-03-19 16:53, Hans de Goede wrote: Hi, On 3/29/19 2:59 PM, Семен Верченко wrote: On 29.03.2019 15:30, Hans de Goede wrote: Hi, On 3/28/19 4:49 PM, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 04:32:27PM +0100, Hans de Goede wrote: On 28-03-19 16:24, Andy Shevchenko wrote: On

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-29 Thread Семен Верченко
On 29.03.2019 15:30, Hans de Goede wrote: Hi, On 3/28/19 4:49 PM, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 04:32:27PM +0100, Hans de Goede wrote: On 28-03-19 16:24, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 04:01:37PM +0100, Hans de Goede wrote: On 28-03-19 15:58, Andy

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-29 Thread Hans de Goede
Hi, On 3/29/19 2:59 PM, Семен Верченко wrote: On 29.03.2019 15:30, Hans de Goede wrote: Hi, On 3/28/19 4:49 PM, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 04:32:27PM +0100, Hans de Goede wrote: On 28-03-19 16:24, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 04:01:37PM +0100, Hans de

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-29 Thread Hans de Goede
Hi Hisashi, On 3/29/19 5:46 AM, Hisashi T Fujinaka wrote: On Thu, 28 Mar 2019, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 04:32:27PM +0100, Hans de Goede wrote: On 28-03-19 16:24, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 04:01:37PM +0100, Hans de Goede wrote: On 28-03-19 15:58,

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-29 Thread Hans de Goede
Hi, On 3/28/19 4:49 PM, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 04:32:27PM +0100, Hans de Goede wrote: On 28-03-19 16:24, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 04:01:37PM +0100, Hans de Goede wrote: On 28-03-19 15:58, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 03:35:58PM

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-28 Thread Hisashi T Fujinaka
On Thu, 28 Mar 2019, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 04:32:27PM +0100, Hans de Goede wrote: On 28-03-19 16:24, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 04:01:37PM +0100, Hans de Goede wrote: On 28-03-19 15:58, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 03:35:58PM

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-28 Thread Andy Shevchenko
On Thu, Mar 28, 2019 at 04:32:27PM +0100, Hans de Goede wrote: > On 28-03-19 16:24, Andy Shevchenko wrote: > > On Thu, Mar 28, 2019 at 04:01:37PM +0100, Hans de Goede wrote: > > > On 28-03-19 15:58, Andy Shevchenko wrote: > > > > On Thu, Mar 28, 2019 at 03:35:58PM +0100, David Müller wrote: > > >

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-28 Thread Hans de Goede
Hi, On 28-03-19 16:24, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 04:01:37PM +0100, Hans de Goede wrote: On 28-03-19 15:58, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 03:35:58PM +0100, David Müller wrote: Andy Shevchenko wrote: On Wed, Mar 27, 2019 at 06:31:19PM +0100, David Müller

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-28 Thread Andy Shevchenko
On Thu, Mar 28, 2019 at 04:01:37PM +0100, Hans de Goede wrote: > On 28-03-19 15:58, Andy Shevchenko wrote: > > On Thu, Mar 28, 2019 at 03:35:58PM +0100, David Müller wrote: > > > Andy Shevchenko wrote: > > > > On Wed, Mar 27, 2019 at 06:31:19PM +0100, David Müller wrote: > > > > > The pmc_plt_clks

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-28 Thread Hans de Goede
Hi, On 27-03-19 17:47, Andy Shevchenko wrote: On Wed, Mar 27, 2019 at 05:02:31PM +0100, Hans de Goede wrote: Hi, On 3/25/19 9:12 PM, Fujinaka, Todd wrote: This is going to take a bit of time to see what we need to do. The attachments were stripped but I think just figuring out what they had

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-28 Thread Hans de Goede
Hi Andy, On 28-03-19 15:58, Andy Shevchenko wrote: On Thu, Mar 28, 2019 at 03:35:58PM +0100, David Müller wrote: Andy Shevchenko wrote: On Wed, Mar 27, 2019 at 06:31:19PM +0100, David Müller wrote: The pmc_plt_clks may also be used for external hardware purposes without the need for a driver

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-28 Thread Andy Shevchenko
On Thu, Mar 28, 2019 at 03:35:58PM +0100, David Müller wrote: > Andy Shevchenko wrote: > > On Wed, Mar 27, 2019 at 06:31:19PM +0100, David Müller wrote: > >> The pmc_plt_clks may also be used for external hardware purposes without > >> the need for a driver involved. So I'm afraid a fix similar to

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-28 Thread David Müller
Hello Andy Shevchenko wrote: > On Wed, Mar 27, 2019 at 06:31:19PM +0100, David Müller wrote: >> The pmc_plt_clks may also be used for external hardware purposes without >> the need for a driver involved. So I'm afraid a fix similar to the r8169 >> approach will not suit all needs. Please see >>

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-27 Thread Andy Shevchenko
On Wed, Mar 27, 2019 at 06:31:19PM +0100, David Müller wrote: > Andy Shevchenko wrote: > > On Wed, Mar 27, 2019 at 05:02:31PM +0100, Hans de Goede wrote: > > > I think that it might be better to restore the CLK_IS_CRITICAL workaround > > > for this, but then only on select boards, based on DMI

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-27 Thread Andy Shevchenko
semverche...@factor-ts.ru] > > Sent: Monday, March 25, 2019 6:25 AM > > To: hdego...@redhat.com; Kirsher, Jeffrey T ; > > e1000-de...@lists.sf.net > > Subject: [E1000-devel] igb driver with Intel Atom Bay Trail issue > > > > Dear Linux/igb maintainers, > > >

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-27 Thread David Müller
Hello Andy Shevchenko wrote: On Wed, Mar 27, 2019 at 05:02:31PM +0100, Hans de Goede wrote: I think that it might be better to restore the CLK_IS_CRITICAL workaround for this, but then only on select boards, based on DMI matching. I've added a bunch of relevant people / lists to the Cc.

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-27 Thread Hans de Goede
...@lists.sf.net Subject: [E1000-devel] igb driver with Intel Atom Bay Trail issue Dear Linux/igb maintainers, We've encountered problem with igb driver (both one that is distributed with Linux kernel and one which is downloadable from intel.com). After commit 648e921888ad ("clk: x86: Stop ma

Re: [E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-25 Thread Fujinaka, Todd
todd.fujin...@intel.com -Original Message- From: Semyon Verchenko [mailto:semverche...@factor-ts.ru] Sent: Monday, March 25, 2019 6:25 AM To: hdego...@redhat.com; Kirsher, Jeffrey T ; e1000-de...@lists.sf.net Subject: [E1000-devel] igb driver with Intel Atom Bay Trail issue Dear Linux

[E1000-devel] igb driver with Intel Atom Bay Trail issue

2019-03-25 Thread Semyon Verchenko
Dear Linux/igb maintainers, We've encountered problem with igb driver (both one that is distributed with Linux kernel and one which is downloadable from intel.com). After commit 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL") on machine with Intel(R) Atom(TM) CPU E3825 with