[elinks-dev] Re: [patch 1/5] Define separate structs for events passed

2006-08-05 Thread Kalle Olavi Niemitalo
Miciah Dashiel Butler Masters [EMAIL PROTECTED] writes: It looks messy, but I don't know whether there is a better approach. I'll need to think about it more. Of course, Jonas is the boss. There are three reasons to have separate data formats for the interlink protocol and for internal use in

[elinks-dev] [patch 01/11] terminal: Decode UTF-8 only from bytes, not from codes of special keys.

2006-08-05 Thread Kalle Olavi Niemitalo
terminal: Decode UTF-8 only from bytes, not from codes of special keys. --- commit ec5615acd7252563fc4745f14a7afbba049227fa tree 026faf147a0a62f70a1865795e270b9e76d48de4 parent 40e257bedd59c35b4a54c5e85e4391383ad6bf84 author Kalle Olavi Niemitalo [EMAIL PROTECTED] Sat, 05 Aug 2006 13:42:08 +0300

[elinks-dev] [patch 02/11] terminal: Do not call toupper with potentially out-of-range values.

2006-08-05 Thread Kalle Olavi Niemitalo
terminal: Do not call toupper with potentially out-of-range values. For instance, if Ctrl-F1 were pressed and src/terminal/kbd.c supported it, then toupper(KBD_F1) would be called, resulting in undefined behaviour. src/terminal/kbd.c does not support such combinations yet, but it is safest to fix

Re: [elinks-dev] Re: [patch 1/5] Define separate structs for events

2006-08-05 Thread Miciah Dashiel Butler Masters
On Sat, Aug 05, 2006 at 10:15:25AM +0300, Kalle Olavi Niemitalo wrote: Miciah Dashiel Butler Masters [EMAIL PROTECTED] writes: [...] What if we introduced a separate routine to convert term_event to interlink_event, so as to minimise change to handle_interlink_event? I don't see how that

[elinks-dev] Re: [patch 1/5] Define separate structs for events

2006-08-05 Thread Kalle Olavi Niemitalo
Miciah Dashiel Butler Masters [EMAIL PROTECTED] writes: How about a separate routine to convert from interlink_event to term_event? For EVENT_KBD, the conversion from interlink_event to term_event can be many-to-many if CONFIG_UTF_8 is not defined. I don't think it would be a good idea to