"M. Levinson" <[EMAIL PROTECTED]> writes: > 4. ./configure --with-python didn't work because the Python tests were > trying an incorrect library name and didn't produce all the necessary > compiler and linker flags.
Witek already fixed that as bug 768. Consequently, your patch does not apply cleanly to the current configure.in (now at commit 098fb87065e2c69f4f9ef65d16901e336a72b789). (I don't use Python myself, but I reported the bug because I had to check that the Python support still builds with the changes I'm making in another branch.) > (Also, they were setting CFLAGS where CPPFLAGS is probably > more appropriate.) Agreed! But, doesn't this require changing the Makefiles too? Here's the change I made in my branch.
build: Don't use $(AM_CFLAGS) anymore. Use $(CPPFLAGS) instead.
$(AM_CFLAGS) is one of the variables set by Automake, which ELinks no
longer uses. $(CPPFLAGS) should be used whenever the C preprocessor
is run, according to the GNU Coding Standards. (My build environment
does have an important -I option there.)
---
commit d7ca8ca29e6d5feffdf83e02ced22472c20fa81b
tree efa47c52d8b89f89cd42c2c8fdbe59d1a6408098
parent 0fee8f6e18d4f81c5222a20c08f8701f90adf87e
author Kalle Olavi Niemitalo <[EMAIL PROTECTED]> Sat, 01 Jul 2006 14:43:37 +0300
committer Kalle Olavi Niemitalo <[EMAIL PROTECTED]> Sat, 01 Jul 2006 14:43:37 +0300
Makefile.config.in | 2 +-
Makefile.lib | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.config.in b/Makefile.config.in
index 4ab2bf2..affb41b 100644
--- a/Makefile.config.in
+++ b/Makefile.config.in
@@ -168,7 +168,7 @@ LIBS = @LIBS@
INCLUDES = -I$(top_builddir) -I$(top_srcdir)/src
-COMPILE = $(CC) $(DEFS) $(INCLUDES) $(AM_CFLAGS) $(CFLAGS)
+COMPILE = $(CC) $(DEFS) $(INCLUDES) $(CPPFLAGS) $(CFLAGS)
MAKE_COLOR = @MAKE_COLOR@
diff --git a/Makefile.lib b/Makefile.lib
index c62ff1d..13d0905 100644
--- a/Makefile.lib
+++ b/Makefile.lib
@@ -51,7 +51,7 @@ quiet_cmd_ld_objs = " [$(LD_COLOR)L
cmd_link = $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $^ $(LIBS)
quiet_cmd_sparse = ' [SPARSE] $(RELPATH)$(2)'
- cmd_sparse = $(SPARSE) $(DEFS) $(INCLUDES) $(AM_CFLAGS) $(CFLAGS) $(SPARSE_FLAGS) $(2)
+ cmd_sparse = $(SPARSE) $(DEFS) $(INCLUDES) $(CPPFLAGS) $(CFLAGS) $(SPARSE_FLAGS) $(2)
# Recursive make
quiet_cmd_recmake = "[$(INFO_COLOR)MAKE $(3)$(END_COLOR)] $(RELPATH)$(2)"
pgpdZ5pifHp6M.pgp
Description: PGP signature
_______________________________________________ elinks-dev mailing list elinks-dev@linuxfromscratch.org http://linuxfromscratch.org/mailman/listinfo/elinks-dev
