[Orgmode] Re: Fontification of blocks

2011-02-09 Thread Dan Davison
Just quickly, one thing I noticed is that the begin/end lines were visible even inside folded trees. I.e., in a folded org file, containing many src blocks, I could see the coloured backgrounds poking out of the folded sections, extending to the right of the screen. [...] E.g. this file

[Orgmode] Re: Fontification of blocks

2011-02-08 Thread Dan Davison
Sébastien Vauban wxhgmqzgwmuf-genee64ty+gs+fvcfc7...@public.gmane.org writes: Hi Dan, Dan Davison wrote: Sébastien Vauban wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw-XMD5yJDbdMSQIYZ4X/+iSw@public.gmane.orgrg writes: Dan Davison wrote: Just quickly, one thing I noticed is that the begin/end

[Orgmode] Re: Fontification of blocks

2011-02-08 Thread Sébastien Vauban
Hi Dan, Dan Davison wrote: Sébastien Vauban wxhgmqzgwmuf-genee64ty+gs+fvcfc7...@public.gmane.org writes: Dan Davison wrote: Sébastien Vauban wxhgmqzgwmuf-geNee64TY+gS+FvcfC7Uqw-XMD5yJDbdMSQIYZ4X/+iSw@public.gmane.orgrg writes: Dan Davison wrote: Just quickly, one thing I noticed is

[Orgmode] Re: Fontification of blocks

2011-02-07 Thread Sébastien Vauban
Hi Dan, Dan Davison wrote: Sébastien Vauban wxhgmqzgwmuf-genee64ty+gs+fvcfc7...@public.gmane.org writes: Dan Davison wrote: Just quickly, one thing I noticed is that the begin/end lines were visible even inside folded trees. I.e., in a folded org file, containing many src blocks, I could

[Orgmode] Re: Fontification of blocks

2011-02-06 Thread Sébastien Vauban
Hi Eric, Eric Schulte wrote: This looks very nice, I am now able to turn fontification on and off as expected using your three new faces. Great. I've just committed your patch with one minor change (not having the block background face set by default). OK. I still think that it'd be better

[Orgmode] Re: Fontification of blocks

2011-02-04 Thread Sébastien Vauban
Hi, As spotted by Eric Fraga: Sébastien Vauban wrote: --- a/lisp/org-faces.el +++ b/lisp/org-faces.el @@ -1,6 +1,6 @@ ;;; org-faces.el --- Face definitions for Org-mode. -;; Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 +;; Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009,

Re: [Orgmode] Re: Fontification of blocks

2011-02-04 Thread Eric S Fraga
Sébastien Vauban wxhgmqzgw...@spammotel.com writes: [...] Corrected patch is attached to this post. which appears to work just fine! Thanks. -- : Eric S Fraga (GnuPG: 0xC89193D8FFFCF67D) in Emacs 24.0.50.1 : using Org-mode version 7.4 (release_7.4.311.ga9d2.dirty)

Re: [Orgmode] Re: Fontification of blocks

2011-02-04 Thread Eric Schulte
Hi Seb, This looks very nice, I am now able to turn fontification on and off as expected using your three new faces. I've just committed your patch with one minor change (not having the block background face set by default). Maybe it would be worth a worg post about how to use these faces with

Re: [Orgmode] Re: Fontification of blocks

2011-02-03 Thread Eric Schulte
Sébastien Vauban wxhgmqzgw...@spammotel.com writes: Hi Eric(s), Dan all, Sébastien Vauban wrote: Eric Schulte wrote: I think that adding a new block delimiter face which inherits from the org-meta face as you've suggested is the way to go. I would recommend however that rather than

[Orgmode] Re: Fontification of blocks

2011-02-03 Thread Sébastien Vauban
Hi Eric, Eric Schulte wrote: +(org-copy-face 'org-meta-line 'org-block-begin-line + Face used for the line delimiting the begin of source blocks.) + +(org-copy-face 'org-meta-line 'org-block-begin-line + Face used for the line delimiting the end of source blocks.) + +(defface

Re: [Orgmode] Re: Fontification of blocks

2011-02-03 Thread Eric S Fraga
Eric Schulte schulte.e...@gmail.com writes: [...] Hi Seb, Thanks for sharing this code. I couldn't help myself but to turn it into a patch as that has become my favorite way of reviewing new code. The resulting patch it attached. Seb's code worked for me but your patch doesn't

[Orgmode] Re: Fontification of blocks

2011-02-03 Thread Sébastien Vauban
Hi Eric(s), Here is the patch I intended to write: diff --git a/lisp/org-faces.el b/lisp/org-faces.el index c237a0e..2e9d2a3 100644 --- a/lisp/org-faces.el +++ b/lisp/org-faces.el @@ -1,6 +1,6 @@ ;;; org-faces.el --- Face definitions for Org-mode. -;; Copyright (C) 2004, 2005, 2006, 2007,

Re: [Orgmode] Re: Fontification of blocks

2011-02-02 Thread Eric S Fraga
Sébastien Vauban wxhgmqzgw...@spammotel.com writes: Hi Eric, Dan all, Eric Schulte wrote: I think that adding a new block delimiter face which inherits from the org-meta face as you've suggested is the way to go. [...] Here a proposition that goes in that direction -- not yet a real

[Orgmode] Re: Fontification of blocks

2011-02-02 Thread Dan Davison
Hi Seb, Just quickly, one thing I noticed is that the begin/end lines were visible even inside folded trees. I.e., in a folded org file, containing many src blocks, I could see the coloured backgrounds poking out of the folded sections, extending to the right of the screen. Do you see that?

[Orgmode] Re: Fontification of blocks

2011-02-02 Thread Sébastien Vauban
Hi Dan, Dan Davison wrote: Just quickly, one thing I noticed is that the begin/end lines were visible even inside folded trees. I.e., in a folded org file, containing many src blocks, I could see the coloured backgrounds poking out of the folded sections, extending to the right of the screen.

Re: [Orgmode] Re: Fontification of blocks

2011-02-02 Thread Eric S Fraga
Sébastien Vauban wxhgmqzgw...@spammotel.com writes: [...] Eric (Fraga), David (O'Toole) and Carsten, you should love the following... when in native fontification... You are correct: I do love it! I've tried it on a large document with many source code blocks and it seems to work very well

[Orgmode] Re: Fontification of blocks

2010-12-22 Thread Dan Davison
Sébastien Vauban wxhgmqzgw...@spammotel.com writes: Hi David, David O'Toole wrote: 2010/12/10 Sébastien Vauban wxhgmqzgw...@spammotel.com: In order to make the blocks stand out more clearly in the mix of prose, code and table results of many Babel Org files, I've added 2 new faces: -

[Orgmode] Re: Fontification of blocks

2010-12-22 Thread Sébastien Vauban
Hi Dan, Dan Davison wrote: Sébastien Vauban wxhgmqzgw...@spammotel.com writes: David O'Toole wrote: 2010/12/10 Sébastien Vauban wxhgmqzgw...@spammotel.com: In order to make the blocks stand out more clearly in the mix of prose, code and table results of many Babel Org files, I've added 2 new

Re: [Orgmode] Re: Fontification of blocks

2010-12-15 Thread Eric Schulte
Hi Seb, I was thinking that it would be nice to be able to try this out through setting a variable (as most org customizations are handled) which would activate/de-activate the extra fontification. I think that adding a new block delimiter face which inherits from the org-meta face as you've

[Orgmode] Re: Fontification of blocks

2010-12-13 Thread Sébastien Vauban
Hi Eric, Eric Schulte wrote: Sébastien Vauban wxhgmqzgw...@spammotel.com writes: In order to make the blocks stand out more clearly in the mix of prose, code and table results of many Babel Org files, I've added 2 new faces: - org-block-begin-line - org-block-end-line These apply to the

[Orgmode] Re: Fontification of blocks

2010-12-13 Thread Sébastien Vauban
Hi David, David O'Toole wrote: 2010/12/10 Sébastien Vauban wxhgmqzgw...@spammotel.com: In order to make the blocks stand out more clearly in the mix of prose, code and table results of many Babel Org files, I've added 2 new faces: - org-block-begin-line - org-block-end-line These apply to