Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

Leo Butler writes: > Attached is the updated patch. In addition, I have written three > regression tests that are attached in a separate patch. Thanks! Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=80615195c

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

On Sun, Mar 17 2024, Ihor Radchenko wrote: > Leo Butler writes: > I'd prefer to keep this information in the INFO channel. It will be more consistent. >> >> Apologies, I messed up the patch in the previous email. >> >> Attached is a patch that compiles cleanly and uses INFO. > >

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

Leo Butler writes: >>> I'd prefer to keep this information in the INFO channel. >>> It will be more consistent. > > Apologies, I messed up the patch in the previous email. > > Attached is a patch that compiles cleanly and uses INFO. Thanks! > + (frame (let ((selection > +

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

On Sat, Mar 16 2024, Leo Butler wrote: > On Fri, Mar 15 2024, Ihor Radchenko wrote: > >> Leo Butler writes: >> Leo, may you improve the patch to avoid defining `org-beamer-frame-environment' when it is not used in all the frames? >>> >>> "all the" should be "any of" in that last

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

On Fri, Mar 15 2024, Ihor Radchenko wrote: > Leo Butler writes: > >>> Leo, may you improve the patch to avoid defining >>> `org-beamer-frame-environment' when it is not used in all the frames? >> >> "all the" should be "any of" in that last sentence. > > Indeed. > >> How about the attached

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

Leo Butler writes: >> Leo, may you improve the patch to avoid defining >> `org-beamer-frame-environment' when it is not used in all the frames? > > "all the" should be "any of" in that last sentence. Indeed. > How about the attached patch? > ... > +(defvar org-beamer--frame-environment-used

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

On Wed, Mar 13 2024, Ihor Radchenko wrote: > Pedro Andres Aranda Gutierrez writes: > >> I really don't have anything to object to the original patch. I support the >> need to circumvent the "\begin-or-end{frame} inside frame" problem and >> using orgframe is a clean way of doing so. >> My only

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

Pedro Andres Aranda Gutierrez writes: > I really don't have anything to object to the original patch. I support the > need to circumvent the "\begin-or-end{frame} inside frame" problem and > using orgframe is a clean way of doing so. > My only concern is the _default_ value for

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

Hi Leo, I really don't have anything to object to the original patch. I support the need to circumvent the "\begin-or-end{frame} inside frame" problem and using orgframe is a clean way of doing so. My only concern is the _default_ value for `org-beamer-frame-environment'. If we set it to "frame",

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

On Tue, Mar 12 2024, Ihor Radchenko wrote: > Pedro Andres Aranda Gutierrez writes: > >> Jup, of course. If you look in org-lint.el, one of the cases that would >> trigger a message is when the frame environment uses "frame" directly and >> there is a \begin{frame} in the org. >> Line 1522

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

Pedro Andres Aranda Gutierrez writes: > Jup, of course. If you look in org-lint.el, one of the cases that would > trigger a message is when the frame environment uses "frame" directly and > there is a \begin{frame} in the org. > Line 1522 onwards in org-lint.el (1) Sure, but we should not

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

Jup, of course. If you look in org-lint.el, one of the cases that would trigger a message is when the frame environment uses "frame" directly and there is a \begin{frame} in the org. Line 1522 onwards in org-lint.el Best, /PA On Mon, 4 Mar 2024 at 12:06, Ihor Radchenko wrote: > Pedro Andres

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

Pedro Andres Aranda Gutierrez writes: > Org-lint will signal that… IHvHO that’s more than enough May you elaborate? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

Org-lint will signal that… IHvHO that’s more than enough Enviado desde mi iPhone > El 2 mar 2024, a las 13:18, Ihor Radchenko escribió: > > Pedro Andres Aranda Gutierrez writes: > >> My question to the list is what is more frequent: slides with an \end{frame} >> that needs to be appear in

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

Pedro Andres Aranda Gutierrez writes: > My question to the list is what is more frequent: slides with an \end{frame} > that needs to be appear in the slide > or slides w/o it. > This should guide the final call on the default value for > org-beamer-frame-environment. We may further constrain

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

Pedro Andres Aranda Gutierrez writes: > To continue... my first reaction to the bug was to > (setq org-beamer-frame-environment "frame") > to test. That resulted in > \newenvironment<>{frame}[1][]{\begin{frame}[environment=frame,#1]}{\end{frame}} > which is somehow weird and wrong. > > This is

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

Leo Butler writes: > Attached is an org file that appears to exercise the patch and show that > it is doing the right thing. Could you confirm this, please? Applied, onto main. https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=60ddec482 Fixed. (the bug is fixed, but we may still

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

Hi again, Or, if you feel more comfortable with (if (string= org-beamer-frame-environment "frame") "" ... ) My question to the list is what is more frequent: slides with an \end{frame} that needs to be appear in the slide or slides w/o it. This should guide the final call on the default

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

To continue... my first reaction to the bug was to (setq org-beamer-frame-environment "frame") to test. That resulted in \newenvironment<>{frame}[1][]{\begin{frame}[environment=frame,#1]}{\end{frame}} which is somehow weird and wrong. This is why I propose to wrap the code in an (unless (string=

Re: [BUG] Re: The orgframe construct in the Beamer exporter as a default needs a rethink

Hi Leo, Wouldn't it be wiser to combine you fix with mine. I still think that setting org-beamer-frame-environment to "frame" when you don't need the fix and not emitting the extra newenvironment code in that case makes the generated LaTeX easier to read. Whether the default value should be frame