Mike Kolesnik has posted comments on this change.
Change subject: engine: Add guestAgentNicHash property to VmDynamic
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10229
To unsubscribe,
Moti Asayag has posted comments on this change.
Change subject: engine: Add GetVmGuestAgentInterfacesByVmIdQuery
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10099
To
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Add GetVmGuestAgentInterfacesByVmIdQuery
..
engine: Add GetVmGuestAgentInterfacesByVmIdQuery
The patch adds a query for fetching the VM guest
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Update VmGuestAgentInterfaces
..
engine: Update VmGuestAgentInterfaces
This patch changes the objects that are returned from
GetAllVmStats and
Moti Asayag has posted comments on this change.
Change subject: engine: Update VmGuestAgentInterfaces
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10123
To unsubscribe, visit
Moti Asayag has posted comments on this change.
Change subject: core: Implement VmGuestAgentInterface.toString()
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10228
To
Moti Asayag has submitted this change and it was merged.
Change subject: core: Implement VmGuestAgentInterface.toString()
..
core: Implement VmGuestAgentInterface.toString()
Adds implementation of
Moti Asayag has posted comments on this change.
Change subject: engine: Add guestAgentNicHash property to VmDynamic
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10229
To
Moti Asayag has posted comments on this change.
Change subject: engine: Change property name to follow naming convention
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10230
To
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Change property name to follow naming convention
..
engine: Change property name to follow naming convention
Change-Id:
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Console button in Hosts tab enabled
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10303
To
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Add guestAgentNicHash property to VmDynamic
..
engine: Add guestAgentNicHash property to VmDynamic
The patch adds a property to VmDynamic named
Eyal Edri has posted comments on this change.
Change subject: pom.xml: update findbugs mvn plugin version to latest 2.5.2
..
Patch Set 1: Verified
Moti Asayag has posted comments on this change.
Change subject: core: Add event for MAC pool initialization error
..
Patch Set 11: (4 inline comments)
File
Kiril Nesenko has posted comments on this change.
Change subject: core : DB FK validation
..
Patch Set 5: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10248
To unsubscribe, visit
Mike Kolesnik has posted comments on this change.
Change subject: engine: Process netIfaces element reported by VDSM
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10231
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: core: Add event for MAC pool initialization error
..
Patch Set 11: (1 inline comment)
I agree with all Moti's comments (except for my comment about
Mike Kolesnik has posted comments on this change.
Change subject: engine: Save VM Guest Agent network devices
..
Patch Set 7: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10232
To unsubscribe, visit
Mike Kolesnik has posted comments on this change.
Change subject: engine: Add index to vm_guest_agent_interfaces
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10287
To unsubscribe, visit
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Process netIfaces element reported by VDSM
..
engine: Process netIfaces element reported by VDSM
The patch process netIfaces element which
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Save VM Guest Agent network devices
..
engine: Save VM Guest Agent network devices
The patch saves the VM Guest Agent network devices to the
Moti Asayag has posted comments on this change.
Change subject: engine: Add index to vm_guest_agent_interfaces
..
Patch Set 4: Verified
--
To view, visit http://gerrit.ovirt.org/10287
To unsubscribe, visit
Moti Asayag has submitted this change and it was merged.
Change subject: engine: Add index to vm_guest_agent_interfaces
..
engine: Add index to vm_guest_agent_interfaces
Add a patch to improve data selection from
Moti Asayag has posted comments on this change.
Change subject: webadmin: Split VM-VmIntererface sub tub
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10242
To unsubscribe,
Moti Asayag has submitted this change and it was merged.
Change subject: webadmin: Split VM-VmIntererface sub tub
..
webadmin: Split VM-VmIntererface sub tub
A split view of the VM's Network Interfaces sub-tab will present the
Yair Zaslavsky has posted comments on this change.
Change subject: core: Add event for MAC pool initialization error
..
Patch Set 11: (3 inline comments)
File
Roy Golan has posted comments on this change.
Change subject: core: remove 2 unused classes
..
Patch Set 1: I would prefer that you didn't submit this
the parent is not in use as well
AttachDetachTagToEntityCommandBase
--
To
Alexey Chub has uploaded a new change for review.
Change subject: webadmin: Show additional columns for events
..
webadmin: Show additional columns for events
Change-Id: I6b1b7d36e992002d1b66aa1525e97619c067ab3e
Signed-off-by:
Yair Zaslavsky has posted comments on this change.
Change subject: core: Add event for MAC pool initialization error
..
Patch Set 12:
Followed Moti's comments
--
To view, visit http://gerrit.ovirt.org/10197
To unsubscribe,
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: local storage - missing correlation ID
..
webadmin: local storage - missing correlation ID
Configure local storage:
added correlation ID for
Daniel Erez has uploaded a new change for review.
Change subject: core: log message on evaluateCorrelationId failure
..
core: log message on evaluateCorrelationId failure
Added a log message warning for evaluateCorrelationId()
Moti Asayag has posted comments on this change.
Change subject: core: Add event for MAC pool initialization error
..
Patch Set 12: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10197
To unsubscribe,
Moti Asayag has posted comments on this change.
Change subject: core: log message on evaluateCorrelationId failure
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10318
To unsubscribe,
Ofer Schreiber has posted comments on this change.
Change subject: DO NOT SUBMIT: packaging: Initial commit
..
Patch Set 3: (2 inline comments)
File
ofri masad has posted comments on this change.
Change subject: core: Fast init cache
..
Patch Set 5: (5 inline comments)
File backend/manager/dbscripts/create_functions.sql
Alex Lourie has posted comments on this change.
Change subject: packaging: add configurable prefix to rpm list
..
Patch Set 1: Looks good to me, but someone else must approve
Thank you very much!
--
To view, visit
Alissa Bonas has posted comments on this change.
Change subject: core: remove unused permissions classes
..
Patch Set 1:
Roy - ok, I removed the class you mentioned as well
--
To view, visit http://gerrit.ovirt.org/10284
To
Alex Lourie has posted comments on this change.
Change subject: packaging: upgrade: print yum transaction details
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10309
Roy Golan has posted comments on this change.
Change subject: core: remove unused permissions classes
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10284
To unsubscribe, visit
Alex Lourie has posted comments on this change.
Change subject: packaging: upgrade: rewrite rollbackAvailable
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10310
To
Alex Lourie has posted comments on this change.
Change subject: packaging: upgrade: support engine yum group
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10311
To
Arik Hadas has uploaded a new change for review.
Change subject: core: introduce InternalMigrateVmParameters
..
core: introduce InternalMigrateVmParameters
Introduce InternalMigrateVmParameters class that should be used when
Arik Hadas has posted comments on this change.
Change subject: core: introduce InternalMigrateVmParameters
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10319
To unsubscribe, visit
Arik Hadas has posted comments on this change.
Change subject: core: Refactor InternalMigrateVmCommand#canMigrateVm
..
Patch Set 1:
Agree that different parameters for the internal migration command is a good
idea. I pushed
Arik Hadas has posted comments on this change.
Change subject: core: Refactor InternalMigrateVmCommand#canMigrateVm
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10107
To unsubscribe, visit
Alissa Bonas has posted comments on this change.
Change subject: core: cleanup and in VdsDeploy
..
Patch Set 1: (1 inline comment)
File
Yair Zaslavsky has posted comments on this change.
Change subject: API: Adding support for external events
..
Patch Set 5:
Alexey - your git tool for some reason changed the commit msg.
No other changes besides that.
--
To
Alon Bar-Lev has posted comments on this change.
Change subject: core: cleanup and in VdsDeploy
..
Patch Set 2: Looks good to me, but someone else must approve
Thanks for for cleaning this up!
--
To view, visit
Doron Fediuck has posted comments on this change.
Change subject: core: Fast init cache
..
Patch Set 6: (6 inline comments)
File
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fast init cache
..
Patch Set 6: (1 inline comment)
File
Yair Zaslavsky has posted comments on this change.
Change subject: core: Fast init cache
..
Patch Set 6: (1 inline comment)
File
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Fix brick advanced details hang issue
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10273
To
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Fix brick advanced details hang issue
..
webadmin: Fix brick advanced details hang issue
Brick Advanced details query might fail when the
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Removed duplicate call to onSuccess in RunQuery
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10298
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Removed duplicate call to onSuccess in RunQuery
..
webadmin: Removed duplicate call to onSuccess in RunQuery
In case of handleFailure=true,
Alexey Chub has posted comments on this change.
Change subject: webadmin: local storage - missing correlation ID
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10317
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Fix volume option dialog hang issue
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10299
To
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Fix volume option dialog hang issue
..
webadmin: Fix volume option dialog hang issue
When there are no UP servers in the cluster, we
will not
Gilad Chaplik has posted comments on this change.
Change subject: core: missing translation in Quota ($VmName)
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9662
To unsubscribe,
Gilad Chaplik has posted comments on this change.
Change subject: core: Fast init cache
..
Patch Set 6: I would prefer that you didn't submit this
(12 inline comments)
some more comments to follow;
Vered Volansky has posted comments on this change.
Change subject: core: cleanup and in VdsDeploy
..
Patch Set 2: (2 inline comments)
Commit Message
Line 3: AuthorDate:
Daniel Erez has uploaded a new change for review.
Change subject: core: adding GetAllDisksByStorageDomainIdQuery
..
core: adding GetAllDisksByStorageDomainIdQuery
Adding a new query for getting DiskImages by StorageDomainId:
Daniel Erez has uploaded a new change for review.
Change subject: core: remove obsolete StorageDomainTemplateQuery
..
core: remove obsolete StorageDomainTemplateQuery
Cleanup - removing obsolete query:
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: Disks sub-tab under Storage main-tab
..
webadmin: Disks sub-tab under Storage main-tab
Adding 'Disks' sub-tab under Storage main-tab
(applicable for
Gilad Chaplik has posted comments on this change.
Change subject: core: Fast init cache
..
Patch Set 6:
what about GetQuotasConsumptionForCurrentUserQuery? still very heavy query. I'd
say that the quota cache won't help so
Eli Mesika has posted comments on this change.
Change subject: core: RFE: Allow plugins to add events into the...
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/10089
To unsubscribe, visit
Eli Mesika has posted comments on this change.
Change subject: webadmin: Show additional columns for events
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/10315
To unsubscribe, visit
Daniel Erez has uploaded a new change for review.
Change subject: webadmin: VmInterfaceListModelTable style modifications
..
webadmin: VmInterfaceListModelTable style modifications
Modified inner panels' margins in
Alona Kaplan has posted comments on this change.
Change subject: webadmin: VmSnapshotListModelTable style modifications
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10323
To unsubscribe,
Alona Kaplan has posted comments on this change.
Change subject: webadmin: VmInterfaceListModelTable style modifications
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10324
To
Doron Fediuck has posted comments on this change.
Change subject: core: Fast init cache
..
Patch Set 6: (4 inline comments)
File
Hello Alexey Chub,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/10325
to review the following change.
Change subject: webadmin:[RFE]: Support proxy management in GUI
..
webadmin:[RFE]: Support
Eli Mesika has posted comments on this change.
Change subject: core:[RFE]Improve power management proxy ...
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/9673
To unsubscribe, visit
Eli Mesika has posted comments on this change.
Change subject: API: [RFE] Add PM Proxy Preferences
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/9674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Eli Mesika has posted comments on this change.
Change subject: webadmin:[RFE]: Support proxy management in GUI
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10325
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: core: Fast init cache
..
Patch Set 6: (2 inline comments)
File backend/manager/dbscripts/quota_sp.sql
Line
Maor Lipchuk has posted comments on this change.
Change subject: webadmin: Disks sub-tab under Storage main-tab
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10322
To
Maor Lipchuk has posted comments on this change.
Change subject: core: adding GetAllDisksByStorageDomainIdQuery
..
Patch Set 1:
Logic looks good.
Please add a test for new query and new stored procedure.
--
To view, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: adding GetAllDisksByStorageDomainIdQuery
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
disk on multiple storage domains
Maor Lipchuk has posted comments on this change.
Change subject: core: adding GetAllDisksByStorageDomainIdQuery
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/10321
To unsubscribe, visit
Moti Asayag has posted comments on this change.
Change subject: core: adding NetworkLinkingSupported to vdc_options.
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9769
To unsubscribe,
Maor Lipchuk has posted comments on this change.
Change subject: core: adding GetAllDisksByStorageDomainIdQuery
..
Patch Set 1: (1 inline comment)
File
Moti Asayag has posted comments on this change.
Change subject: core,ui: add/update linking bll-error messages.
..
Patch Set 24: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9450
To unsubscribe, visit
Moti Asayag has posted comments on this change.
Change subject: core: add NetworkLinking support to RunVm command.
..
Patch Set 21: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9518
To unsubscribe,
Moti Asayag has posted comments on this change.
Change subject: core: HotPlugNicVDSCommand should send linkActive to the vdsm.
..
Patch Set 21: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9519
To
Gilad Chaplik has posted comments on this change.
Change subject: core: Fast init cache
..
Patch Set 6: (2 inline comments)
kind reminder for my previous question.
File
Tal Nisan has posted comments on this change.
Change subject: core:StorageHelper Cleanup, method name standard(1).
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10124
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: core: remove obsolete StorageDomainTemplateQuery
..
Patch Set 1: Looks good to me, approved
Daniel, please verify so this can be merged.
--
To view, visit
Moti Asayag has posted comments on this change.
Change subject: core: add NetworkLinking to ChangeVMClusterCommand
..
Patch Set 19: (2 inline comments)
File
Moti Asayag has posted comments on this change.
Change subject: core: add NetworkLinking to ChangeVMClusterCommand
..
Patch Set 19: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9576
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: core: adding GetAllDisksByStorageDomainIdQuery
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
1. Please add a test for the DAO
Maor Lipchuk has posted comments on this change.
Change subject: core: remove obsolete StorageDomainTemplateQuery
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10320
Allon Mureinik has posted comments on this change.
Change subject: core: remove unused permissions classes
..
Patch Set 2: Looks good to me, but someone else must approve
Looks good to me.
Alissa, please verify so this can be
Moti Asayag has posted comments on this change.
Change subject: core: allow editing VmInterface while the VM is running.
..
Patch Set 18: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9581
To
Allon Mureinik has posted comments on this change.
Change subject: core: cleanup and in VdsDeploy
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10290
To unsubscribe,
Moti Asayag has posted comments on this change.
Change subject: core: adding AbstractVmInterfaceCommand
..
Patch Set 16: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9667
To unsubscribe, visit
Michael Pasternak has posted comments on this change.
Change subject: core: adding GetAllDisksByStorageDomainIdQuery
..
Patch Set 1:
this query will server both up/api
--
To view, visit http://gerrit.ovirt.org/10321
To
ofri masad has posted comments on this change.
Change subject: core: Fast init cache
..
Patch Set 6: (11 inline comments)
Gilad, Current design uses Quartz to call the cache update every x minutes. the
factor helps us
Allon Mureinik has posted comments on this change.
Change subject: core: support multiple concurrent disks migration
..
Patch Set 3: Looks good to me, but someone else must approve
(1 inline comment)
Some minor comments about
Allon Mureinik has posted comments on this change.
Change subject: webadmin: correlate models to move multiple disks API
..
Patch Set 3: I would prefer that you didn't submit this
Please squash
--
To view, visit
1 - 100 of 207 matches
Mail list logo
