Gilad Chaplik has posted comments on this change.
Change subject: webadmin: KSM enabled checkbox alway start unchecked
..
Patch Set 1:
(1 comment)
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: KSM enabled checkbox alway start unchecked
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42410
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: KSM enabled checkbox alway start unchecked
..
Patch Set 2:
findbugs err is unrelated
--
To view, visit https://gerrit.ovirt.org/42410
To
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: KSM enabled checkbox alway start unchecked
..
webadmin: KSM enabled checkbox alway start unchecked
Problem: KSM enablement checkbox always
Gilad Chaplik has posted comments on this change.
Change subject: core:Added affinity Group collision validation.
..
Patch Set 8:
(12 comments)
minor comments, leaves the algorithm part to Martin :)
Gilad Chaplik has posted comments on this change.
Change subject: restapi: implement Quota REST-API
..
Patch Set 5:
(4 comments)
Gilad Chaplik has posted comments on this change.
Change subject: engine: Quota API engine fixups
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/39903
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: restapi: implement Quota REST-API
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/39904
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Add KSM awaremess for NUMA optimization
..
Patch Set 2: Code-Review+2
(1 comment)
Minor comment, you may alter it, verify and merge (no need for a
Gilad Chaplik has posted comments on this change.
Change subject: restapi: implement Quota REST-API
..
Patch Set 4:
(8 comments)
@Juan, thanks for quick review!
Gilad Chaplik has posted comments on this change.
Change subject: engine: Quota API engine fixups
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/39903
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: restapi: add quota mode to data center
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/39902
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: restapi: add quota mode to data center
..
Patch Set 2:
(1 comment)
Gilad Chaplik has posted comments on this change.
Change subject: restapi: implement Quota REST-API
..
Patch Set 1:
(34 comments)
Gilad Chaplik has posted comments on this change.
Change subject: restapi: add quota mode to data center
..
Patch Set 1:
(6 comments)
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Maintenence text and reason should be in the same line
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41107
To unsubscribe,
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Added range values to QoS error message - revisited
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40854
To unsubscribe,
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Added range values to QoS error message - revisited
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/40854
To unsubscribe,
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: edit nic shouldn't raise error in case the lables
weren't changed
..
Patch Set 32: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/37023
To
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: sr-iov validation of profile in vnic dialog
..
Patch Set 29:
(1 comment)
minor comment, can be addressed in a later patch.
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: sr-iov validation of profile in vnic dialog
..
Patch Set 29: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/36101
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: edit vfsConfig- persist vfs config changes
..
Patch Set 36: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/36421
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: restapi: adding 'passthrough' property to vnic profile
..
Patch Set 20: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39530
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: fluent UiAction
..
Patch Set 45:
Please add a UI infra maintainer..
--
To view, visit https://gerrit.ovirt.org/36848
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: blocking unlinking of passthrough vnic
..
Patch Set 20: Code-Review+2
(1 comment)
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: add validation to edit vfsConfig dialog
..
Patch Set 36: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/36842
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: add passthrough property to vnic profile
..
Patch Set 31: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/35946
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: edit vfsConfig- networks table
..
Patch Set 37: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/36355
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: edit vfsConfig- sync 'via label' according the the
labels
..
Patch Set 37: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/36497
To
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: edit vfsConfig- labels
..
Patch Set 37: Code-Review+2
all of Lior's comments are covered.
--
To view, visit https://gerrit.ovirt.org/36422
To
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: send vfs config update to the backend
..
Patch Set 35: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/36976
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: restapi: add quota mode to data center
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/39902
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: restapi: implement Quota REST-API
..
Patch Set 1:
@Juan, @Ori, still missing test, but this is pretty much it. please take a look
--
To view, visit
Gilad Chaplik has uploaded a new change for review.
Change subject: restapi: implement Quota REST-API
..
restapi: implement Quota REST-API
adding quota element to REST-API:
Quota is a subcollection of Data Center and consists
Gilad Chaplik has uploaded a new change for review.
Change subject: engine: Quota API engine fixups
..
engine: Quota API engine fixups
Since quota was added only via UI till now, some bugs were
masked and now smoked out:
- Set
Gilad Chaplik has uploaded a new change for review.
Change subject: restapi: add quota mode to data center
..
restapi: add quota mode to data center
Expose data center's quota mode (enable/disable/audit).
The enum was added to
Gilad Chaplik has posted comments on this change.
Change subject: engine: Add KSM awaremess for NUMA optimization
..
Patch Set 2:
(6 comments)
Gilad Chaplik has posted comments on this change.
Change subject: core: use single thread on update sla policies
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/39424
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: core: introduce Numa Placement entity
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38047
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: core: use NumaPlacement instead of weird Pairs
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38048
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: core: scheduling: VM Affinity Group filter and weight module
..
Patch Set 8:
(1 comment)
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: UI to set the volume snapshot configurations
..
Patch Set 16: Code-Review+2
Based on Kanagaraj's review and changes made since patch-set 13.
--
To
Gilad Chaplik has posted comments on this change.
Change subject: core: introduce Numa Placement entity
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/38047
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: core: introduce Numa Placement entity
..
Patch Set 5:
spotted it in the review of the next patch, there is something to consider,
since we are now not using
Gilad Chaplik has posted comments on this change.
Change subject: core: use NumaPlacement instead of weird Pairs
..
Patch Set 5:
(2 comments)
Gilad Chaplik has posted comments on this change.
Change subject: core: no need for a new TX when saving host numa stats
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38046
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: engine: Activate vm pinning at request time
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/38068
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Added range values to QoS error message.
..
Patch Set 4:
can you check why in u/s patch you added four AppErro file changes and here
just one.
--
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Added place holder for watchdog model.
..
Patch Set 11: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36688
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Fixed capitalization on New Cluster.
..
Patch Set 1:
3.1 is over/ back-port to 3.5 (and change target version to 3.5.2)
--
To view, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: topologhy - topology
..
Patch Set 1: Code-Review+2
thanks Einav :)
--
To view, visit http://gerrit.ovirt.org/37884
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: engine: Append Numa dynamic data to static data
..
Patch Set 2: Code-Review+1
Joining Roy's comments, please remove logging code. other than that, code looks
Gilad Chaplik has posted comments on this change.
Change subject: engine: Add error messages to user portal.
..
Patch Set 3: Code-Review+2
(1 comment)
minor comment
http://gerrit.ovirt.org/#/c/37280/3//COMMIT_MSG
Commit
Gilad Chaplik has posted comments on this change.
Change subject: build: ovirt-engine-3.5.1.1
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/37398
To unsubscribe, visit
Gilad Chaplik has abandoned this change.
Change subject: core: add everyone permission for Disk Profile
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/37392
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gilad Chaplik has uploaded a new change for review.
Change subject: core: add everyone permission for Disk Profile
..
core: add everyone permission for Disk Profile
When the system created a disk profile,
'everyone' permission
Gilad Chaplik has uploaded a new change for review.
Change subject: core: ovf_store isn't added
..
core: ovf_store isn't added
When disk is added and there is no active user- currently
only for ovf_store disk, disk profile
Gilad Chaplik has posted comments on this change.
Change subject: core: ovf_store isn't added
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gilad Chaplik has uploaded a new change for review.
Change subject: core: add everyone permission for Disk Profile
..
core: add everyone permission for Disk Profile
When the system created a disk profile,
'everyone' permission
Gilad Chaplik has posted comments on this change.
Change subject: core: add everyone permission for Disk Profile
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/37369
To unsubscribe, visit
Gilad Chaplik has uploaded a new change for review.
Change subject: core: add everyone permission for Disk Profile
..
core: add everyone permission for Disk Profile
When the system created a disk profile,
'everyone' permission
Gilad Chaplik has posted comments on this change.
Change subject: userportal,webadmin: Renamed NewTemplate* to EditTemplate*
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/37288
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: core: ovf_store isn't added
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37267
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: ovf_store isn't added
..
core: ovf_store isn't added
When disk is added and there is no active user- currently
only for ovf_store disk, disk
Gilad Chaplik has posted comments on this change.
Change subject: core: ovf_store isn't added
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37269
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gilad Chaplik has uploaded a new change for review.
Change subject: core: ovf_store isn't added
..
core: ovf_store isn't added
When disk is added and there is no active user- currently
only for ovf_store disk, disk profile
Gilad Chaplik has uploaded a new change for review.
Change subject: core: ovf_store isn't added
..
core: ovf_store isn't added
When disk is added and there is no active user- currently
only for ovf_store disk, disk profile
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Added place holder for watchdog model.
..
Patch Set 7:
(11 comments)
Gilad Chaplik has posted comments on this change.
Change subject: core: QoS name uniquness
..
Patch Set 12: Verified+1 Code-Review+2
rebased (and fixed upgrade script number)
--
To view, visit http://gerrit.ovirt.org/34154
Gilad Chaplik has submitted this change and it was merged.
Change subject: core: QoS name uniquness
..
core: QoS name uniquness
Prevent adding qos with the same name for same data center.
Also fixes state in which constraint
Gilad Chaplik has posted comments on this change.
Change subject: core: validate profile is not attached before removing it
..
Patch Set 12: Verified+1
findbugs failure isn't related
--
To view, visit
Gilad Chaplik has posted comments on this change.
Change subject: core: missing cluster policy validation
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/37191
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: core: missing cluster policy validation
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/37191
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: core: missing cluster policy validation
..
Patch Set 1:
(1 comment)
Gilad Chaplik has uploaded a new change for review.
Change subject: core: missing cluster policy validation
..
core: missing cluster policy validation
Regression made by recent AddVdsGroupCommand#canDoAction refactoring
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: display of template disk's disk profile
..
webadmin: display of template disk's disk profile
When a template disk is cloned, only one of the disk
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: display of template disk's disk profile
..
webadmin: display of template disk's disk profile
When a template disk is cloned, only one of the
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: display of template disk's disk profile
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37121
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: display of template disk's disk profile
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/37067/1//COMMIT_MSG
Commit Message:
Line 3:
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: fix permission button for cpu profiles
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/37077/1//COMMIT_MSG
Commit Message:
Line 4: Commit:
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: fix permission button for cpu profiles
..
webadmin: fix permission button for cpu profiles
fix remove button in permission sub tab in cpu
Gilad Chaplik has posted comments on this change.
Change subject: frontend: show cpu profile field for edit template
..
Patch Set 5: Verified+1
--
To view, visit http://gerrit.ovirt.org/33904
To unsubscribe, visit
Gilad Chaplik has submitted this change and it was merged.
Change subject: frontend: show cpu profile field for edit template
..
frontend: show cpu profile field for edit template
currently it's hidden since resouce allocation
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: display of template disk disk profile
..
webadmin: display of template disk disk profile
When a template disk is cloned, only one of the disk
Gilad Chaplik has uploaded a new change for review.
Change subject: webadmin: fix permission button for cpu profiles
..
webadmin: fix permission button for cpu profiles
Change-Id: Ib5e104c059b122cf21bfbbed00fab66162cdc5f6
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: display of template disk disk profile
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37067
To unsubscribe, visit
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: fix permission button for cpu profiles
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/37077
To unsubscribe, visit
Gilad Chaplik has uploaded a new change for review.
Change subject: core: Max memory for scheduling updates wrongly
..
core: Max memory for scheduling updates wrongly
The calc should include all running VMs.
Gilad Chaplik has posted comments on this change.
Change subject: core: Max memory for scheduling updates wrongly
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36970
To unsubscribe, visit
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Added range values to QoS error message.
..
webadmin: Added range values to QoS error message.
On the Data Center tab, When adding a QoS to
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Added range values to QoS error message.
..
Patch Set 10: Verified+1 Code-Review+2
rebased
--
To view, visit http://gerrit.ovirt.org/35093
To
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Storage QoS popup fixups
..
webadmin: Storage QoS popup fixups
The storage qos popup is now more intutive and explains
better how to use the
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Storage QoS popup fixups
..
Patch Set 10: Verified+1 Code-Review+2
rebased and verified.
--
To view, visit http://gerrit.ovirt.org/36115
To
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Fixed error message in new Storage QoS.
..
Patch Set 4: Verified+1 Code-Review+2
rebased
--
To view, visit http://gerrit.ovirt.org/35601
To
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Fixed error message in new Storage QoS.
..
webadmin: Fixed error message in new Storage QoS.
When giving some natural number value to each
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Fixed text wrapping in New Cluster.
..
Patch Set 3: Verified+1 Code-Review+2
--
To view, visit http://gerrit.ovirt.org/34241
To unsubscribe, visit
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Fixed text wrapping in New Cluster.
..
webadmin: Fixed text wrapping in New Cluster.
On Webadmin in Deutsch the text Optimize for speed is
Gilad Chaplik has posted comments on this change.
Change subject: webadmin: Added place holder for watchdog model.
..
Patch Set 4:
some issues:
* no-watchdog isn't in the drop-down.
* watch action isn't disable correctly (on
Gilad Chaplik has posted comments on this change.
Change subject: engine: back-compat for disk profiles
..
Patch Set 3:
(1 comment)
Gilad Chaplik has posted comments on this change.
Change subject: engine: back-compat for disk profiles
..
Patch Set 5: Verified+1 Code-Review+2
rebased
--
To view, visit http://gerrit.ovirt.org/36796
To unsubscribe, visit
1 - 100 of 5130 matches
Mail list logo
