Maor Lipchuk has posted comments on this change.
Change subject: core: register secrets on ConnectHostToStoragePoolServersCommand
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41564
To unsubscribe,
Maor Lipchuk has posted comments on this change.
Change subject: core: unregister secrets on deactivate Cinder storage domain
..
Patch Set 9:
(1 comment)
Maor Lipchuk has posted comments on this change.
Change subject: core: registerLibvirtSecrets on add and update secret
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41561
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Rename CindeBroker method
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/42482
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: unregister secrets on deactivate Cinder storage domain
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41560
To unsubscribe,
Maor Lipchuk has posted comments on this change.
Change subject: core: getAllByStoragePoolIdFilteredByActiveStorageDomains
..
Patch Set 10: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41563
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Introduce restore all cinder snapshots command.
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/42338
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Support restore for Cinder snapshot
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/42339
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Introduce restore from Cinder snapshot
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/42337
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Support restore for Cinder snapshot
..
Patch Set 3:
(2 comments)
Maor Lipchuk has posted comments on this change.
Change subject: core: Introduce restore all cinder snapshots command.
..
Patch Set 3:
(3 comments)
I moved the RestoreFromCinderSnapshot to another patch
Maor Lipchuk has abandoned this change.
Change subject: core: Add validation in ImagesHandler method
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/42473
To unsubscribe, visit https://gerrit.ovirt.org/settings
Maor Lipchuk has posted comments on this change.
Change subject: core: Introduce restore all cinder snapshots command.
..
Patch Set 3:
(4 comments)
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Rename CindeBroker method
..
core: Rename CindeBroker method
Rename Cinder broker method to make it more clear
Change-Id:
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add support for Refresh LUNs size
..
Patch Set 12:
(1 comment)
Maor Lipchuk has uploaded a new change for review.
Change subject: core: re-order CinderBroker imports.
..
core: re-order CinderBroker imports.
Re-order Cinder broker imports
Change-Id:
Maor Lipchuk has uploaded a new change for review.
Change subject: core: re-factor method of deleteVolume to CinderBroker
..
core: re-factor method of deleteVolume to CinderBroker
Use the delete volume and delete volume
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Change CinderBroker to use getImageId.
..
core: Change CinderBroker to use getImageId.
Use getImageId instead of getId since a volume in Cinder can be a
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Make remove Cinder disks call back to be generic.
..
core: Make remove Cinder disks call back to be generic.
1) Rename call back to be more general
2) Use
Maor Lipchuk has posted comments on this change.
Change subject: core: added volume types existence validation
..
Patch Set 5:
(2 comments)
Maor Lipchuk has posted comments on this change.
Change subject: core: added volume types existence validation
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41967
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Make remove Cinder disks call back to be generic.
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42454
To unsubscribe, visit
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Make remove Cinder disks call back to be generic.
..
core: Make remove Cinder disks call back to be generic.
1) Rename call back to be more
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Change CinderBroker to use getImageId.
..
core: Change CinderBroker to use getImageId.
Use getImageId instead of getId since a volume in Cinder
Maor Lipchuk has posted comments on this change.
Change subject: core: re-order CinderBroker imports.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42448
To unsubscribe, visit
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: re-order CinderBroker imports.
..
core: re-order CinderBroker imports.
Re-order Cinder broker imports
Change-Id:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: re-factor method of deleteVolume to CinderBroker
..
core: re-factor method of deleteVolume to CinderBroker
Use the delete volume and delete volume
Maor Lipchuk has posted comments on this change.
Change subject: core: Change CinderBroker to use getImageId.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42450
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: re-factor method of deleteVolume to CinderBroker
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42449
To unsubscribe, visit
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Add validation in ImagesHandler method
..
core: Add validation in ImagesHandler method
Check if number of decendends for image is not empty, if it is
Maor Lipchuk has posted comments on this change.
Change subject: core: VM configuration should not be validated in Export Domain
..
Patch Set 1:
(1 comment)
indeed, I hope we will have the time to re factor this command once
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: VM configuration should not be validated in Export Domain
..
core: VM configuration should not be validated in Export Domain
Validating a VM if
Maor Lipchuk has posted comments on this change.
Change subject: core: VM configuration should not be validated in Export Domain
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/42395
To unsubscribe,
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix disk storage type in OVF
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42374
To unsubscribe, visit
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Fix disk storage type in OVF
..
core: Fix disk storage type in OVF
Fix the read and the write in the snapshot's OVF.
Change-Id:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Fix disk storage type in OVF
..
core: Fix disk storage type in OVF
Fix the read and the write in the snapshot's OVF.
Change-Id:
Maor Lipchuk has uploaded a new change for review.
Change subject: core: VM configuration should not be validated in Export Domain
..
core: VM configuration should not be validated in Export Domain
Validating a VM if its disks
Maor Lipchuk has posted comments on this change.
Change subject: core: support cephx authentication on run vm
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41566
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: support cephx authentication on run vm
..
Patch Set 11:
(1 comment)
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add support for Refresh LUNs size
..
Patch Set 11:
(1 comment)
Consider to use seperate patches for REST code and engine code
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add support for Refresh LUNs size
..
Patch Set 11:
(9 comments)
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add support for Refresh LUNs size
..
Patch Set 11:
(7 comments)
Maor Lipchuk has posted comments on this change.
Change subject: core: Support preview for Cinder snapshot
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/42256
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: CloneCinderDisks - handle command statuses
..
Patch Set 1:
https://gerrit.ovirt.org/#/c/42314/ already solves the parent issue, do you
want me to abandon
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Set parent command for cloneCinderDisks,
..
core: Set parent command for cloneCinderDisks,
Add VM template for Cinder disks should set the correct parent
Maor Lipchuk has posted comments on this change.
Change subject: core: CloneCinderDisks - handle command statuses
..
Patch Set 1: Code-Review+2
I uploaded https://gerrit.ovirt.org/#/c/42318/ for the remove operation
--
To
Maor Lipchuk has posted comments on this change.
Change subject: core: Introduce TryBackToAllCinderSnapshotsCommand
..
Patch Set 23: Verified+1
--
To view, visit https://gerrit.ovirt.org/42061
To unsubscribe, visit
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Introduce TryBackToCinderSnapshotCommand.
..
core: Introduce TryBackToCinderSnapshotCommand.
Introduce preview command for single Cinder disk.
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Introduce TryBackToAllCinderSnapshotsCommand
..
core: Introduce TryBackToAllCinderSnapshotsCommand
Introduce new command for previewing all Cinder
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Support preview for Cinder snapshot
..
core: Support preview for Cinder snapshot
Adding support for Cinder snapshot.
Change-Id:
Maor Lipchuk has posted comments on this change.
Change subject: core: Introduce TryBackToCinderSnapshotCommand.
..
Patch Set 23: Verified+1
--
To view, visit https://gerrit.ovirt.org/42062
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Introduce TryBackToAllCinderSnapshotsCommand
..
Patch Set 19:
(3 comments)
Maor Lipchuk has posted comments on this change.
Change subject: core: Support preview for Cinder snapshot
..
Patch Set 1:
(4 comments)
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use generics in CloneCinderDisksCommandCallback
..
core: Use generics in CloneCinderDisksCommandCallback
Use generics for
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Use generics in CloneSingleCinderDiskCommandCallback
..
core: Use generics in CloneSingleCinderDiskCommandCallback
Use generics for
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Change clone cinder call back to use container id.
..
core: Change clone cinder call back to use container id.
Use container id insted of
Maor Lipchuk has uploaded a new change for review.
Change subject: core: RemoveAllVmCinderDisks - handle command statuses.
..
core: RemoveAllVmCinderDisks - handle command statuses.
* Handle NOT_STARTED and SUCCEEDED command
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Change parameter class to be removeCinderDiskParameters
..
core: Change parameter class to be removeCinderDiskParameters
Add parent command and parameters
Maor Lipchuk has posted comments on this change.
Change subject: core: Support preview for Cinder snapshot
..
Patch Set 5:
(1 comment)
Maor Lipchuk has posted comments on this change.
Change subject: core: Change clone cinder call back to use container id.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42255/1//COMMIT_MSG
Commit Message:
Line 7:
Maor Lipchuk has posted comments on this change.
Change subject: core: Introduce TryBackToCinderSnapshotCommand.
..
Patch Set 19:
(5 comments)
Maor Lipchuk has posted comments on this change.
Change subject: core: Change clone cinder call back to use container id.
..
Patch Set 2: Code-Review+2
echo ack of derez
--
To view, visit https://gerrit.ovirt.org/42255
To
Maor Lipchuk has posted comments on this change.
Change subject: core: delete Cinder volumes should be surrounded by try catch.
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/42252/1//COMMIT_MSG
Commit Message:
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Refactor updateOldImageAsActive to baseImagesCommand
..
core: Refactor updateOldImageAsActive to baseImagesCommand
Refactor method
Maor Lipchuk has posted comments on this change.
Change subject: core: Introduce TryBackToAllCinderSnapshotsCommand
..
Patch Set 22:
(1 comment)
Maor Lipchuk has abandoned this change.
Change subject: core: Use CoCo for add cinder disk command
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/36345
To unsubscribe, visit https://gerrit.ovirt.org/settings
Maor Lipchuk has abandoned this change.
Change subject: core | restapi | tools | history | engine | userportal |
webadmin: short summary under 50 chars
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/42312
To
Maor Lipchuk has posted comments on this change.
Change subject: core: Add helper in DiskStorageType enum
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/42311
To unsubscribe, visit
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Fix preview snapshot in Cinder broker
..
core: Fix preview snapshot in Cinder broker
Unset sourceVolId and set volume type before calling Cinder
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add helper in DiskStorageType enum
..
core: Add helper in DiskStorageType enum
Add isSupportsSnapshot helper method for Cinder and Image disks.
Maor Lipchuk has posted comments on this change.
Change subject: core: Refactor updateOldImageAsActive to baseImagesCommand
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42310
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Change clone cinder call back to use container id.
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/42255
To unsubscribe, visit
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add type to list at CinderDisksProvider
..
core: Add type to list at CinderDisksProvider
Add CinderDisk type to cinderDisks list at
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: add VolumeClassification to DiskImageDAODbFacadeImpl
..
core: add VolumeClassification to DiskImageDAODbFacadeImpl
add VolumeClassification to the
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: delete Cinder volumes should be surrounded by try catch.
..
core: delete Cinder volumes should be surrounded by try catch.
Delete of volume and
Maor Lipchuk has posted comments on this change.
Change subject: core: Introduce TryBackToCinderSnapshotCommand.
..
Patch Set 22:
(1 comment)
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Refactor updateOldImageAsActive to baseImagesCommand
..
core: Refactor updateOldImageAsActive to baseImagesCommand
Refactor method updateOldImageAsActive
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Add helper method for snapshots in DiskImageBase
..
core: Add helper method for snapshots in DiskImageBase
Add isStorageTypeSupportsSnapshot for Cinder
Maor Lipchuk has uploaded a new change for review.
Change subject: core | restapi | tools | history | engine | userportal |
webadmin: short summary under 50 chars
..
core | restapi | tools | history | engine | userportal |
Maor Lipchuk has posted comments on this change.
Change subject: core: validate Cinder disks status on RunVmValidator
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42322
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Fix NPE when removing a VM with Cinder disks.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42333
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: RemoveAllVmCinderDisks - handle command statuses
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42324
To unsubscribe, visit
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Fix NPE when removing a VM with Cinder disks.
..
core: Fix NPE when removing a VM with Cinder disks.
Remove disk from snapshot's OVF only if the snapshot
Maor Lipchuk has posted comments on this change.
Change subject: core: RemoveAllVmCinderDisks - set parent on build params
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/42323
To unsubscribe, visit
Maor Lipchuk has abandoned this change.
Change subject: core: Set parent command for cloneCinderDisks,
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/42314
To unsubscribe, visit https://gerrit.ovirt.org/settings
Maor Lipchuk has abandoned this change.
Change subject: core: RemoveAllVmCinderDisks - handle command statuses.
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/42318
To unsubscribe, visit
Maor Lipchuk has abandoned this change.
Change subject: core: Change parameter class to be removeCinderDiskParameters
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/42332
To unsubscribe, visit
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Introduce restore all cinder snapshots command.
..
core: Introduce restore all cinder snapshots command.
Introduce restore for all cinder snapshts
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Introduce restore from Cinder snapshot
..
core: Introduce restore from Cinder snapshot
Intoroduce restore for Cinder snapshot.
Change-Id:
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Support restore for Cinder snapshot
..
core: Support restore for Cinder snapshot
Add support for restoring VM snapshot with snapshots.
Change-Id:
Maor Lipchuk has posted comments on this change.
Change subject: core: introduce LibvirtSecretDao
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/41551
To unsubscribe, visit
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Change clone cinder call back to use container id.
..
core: Change clone cinder call back to use container id.
Use container id insted of destinationid in
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Support preview for Cinder snapshot
..
core: Support preview for Cinder snapshot
Adding support for Cinder snapshot.
Change-Id:
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Use generics in CloneSingleCinderDiskCommandCallback
..
core: Use generics in CloneSingleCinderDiskCommandCallback
Use generics for
Maor Lipchuk has uploaded a new change for review.
Change subject: core: add VolumeClassification to DiskImageDAODbFacadeImpl
..
core: add VolumeClassification to DiskImageDAODbFacadeImpl
add VolumeClassification to the mapper
Maor Lipchuk has uploaded a new change for review.
Change subject: core: delete Cinder volumes should be surrounded by try catch.
..
core: delete Cinder volumes should be surrounded by try catch.
Delete of volume and snapshot
Maor Lipchuk has uploaded a new change for review.
Change subject: core: Use generics in CloneCinderDisksCommandCallback
..
core: Use generics in CloneCinderDisksCommandCallback
Use generics for CloneCinderDisksCommandCallback
Maor Lipchuk has posted comments on this change.
Change subject: core: Introduce TryBackToAllCinderSnapshotsCommand
..
Patch Set 19: Verified+1
--
To view, visit https://gerrit.ovirt.org/42061
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: delete Cinder volumes should be surrounded by try catch.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42252
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: Change clone cinder call back to use container id.
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/42255
To unsubscribe, visit
1 - 100 of 4914 matches
Mail list logo
