Laszlo Hornyak has abandoned this change.
Change subject: engine: check if host exists with same name
..
Patch Set 12: Abandoned
outdated, never got +2
--
To view, visit http://gerrit.ovirt.org/10910
To unsubscribe, visit
Sahina Bose has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10910
To
Shireesh Anjal has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10910
To
Alon Bar-Lev has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 12:
Yair, please CC me at any host deploy change.
I don't really understand this patch... if I put
Allon Mureinik has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 12: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10910
To
Michael Kublin has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 11:
Laszlo, it is your decision
--
To view, visit http://gerrit.ovirt.org/10910
To unsubscribe, visit
Laszlo Hornyak has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 10:
Michael, rather than cleaning up all the problems any of the code had around in
the name of a
Allon Mureinik has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 10: Looks good to me, but someone else must approve
(1 inline comment)
@laszlo - please fix the
Michael Kublin has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 10: I would prefer that you didn't submit this
The following queries are used in order to check if
Laszlo Hornyak has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 10:
what's next with this patch?
--
To view, visit http://gerrit.ovirt.org/10910
To unsubscribe,
Yair Zaslavsky has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 10:
Allon/Moti - care to take a look as well?
--
To view, visit http://gerrit.ovirt.org/10910
To
Moti Asayag has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10910
To
Yair Zaslavsky has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 10: Looks good to me, but someone else must approve
Giving +1 - I see Laszlo fixed Sahina's comment
Sahina Bose has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 10: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10910
To
Sahina Bose has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 8: (3 inline comments)
Minor : equals comparison parameter may be incorrect. Please check
Allon Mureinik has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 6: (6 inline comments)
minor issues, see inline
Allon Mureinik has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 7:
@Laszlo - please see comments in patchset 6
--
To view, visit http://gerrit.ovirt.org/10910
To
Laszlo Hornyak has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 7:
Yes, I fixed that already, only fighting with gerrit
--
To view, visit
Laszlo Hornyak has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/10910
To unsubscribe, visit
Yair Zaslavsky has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 8: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10910
To
Sahina Bose has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 5: (2 inline comments)
Also, there are similar methods in VDSHandler - isVdsWithSameNameExistStatic,
Shireesh Anjal has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 6:
No diff between patch-set 5 and 6?
--
To view, visit http://gerrit.ovirt.org/10910
To unsubscribe,
Shireesh Anjal has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 3: (1 inline comment)
File
Yair Zaslavsky has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 3: Looks good to me, approved
Good job on checking the rest of of the flows.
--
To view, visit
Yair Zaslavsky has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 3: No score
Actually Laszlo,
What about Moti's comment regarding Update VDS?
--
To view, visit
Yair Zaslavsky has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 1: (1 inline comment)
Minor comment.
File
Moti Asayag has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 1: (1 inline comment)
Please add the same validation to UpdateVdsCommand to make sure not only a
Moti Asayag has posted comments on this change.
Change subject: engine: check if host exists with same name
..
Patch Set 1:
note that the ACTION_TYPE_FAILED_DUPLICATE_VDS_NAME is not required (since
there is already a message
28 matches
Mail list logo
