Michael Kublin has posted comments on this change.
Change subject: engine-core: add lun to the log when can't connect
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1650
To unsubscribe,
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add JobRepository
..
Patch Set 3:
Next patch will change the package of JobRepository from
org.ovirt.engine.core.dao.job to
Eli Mesika has posted comments on this change.
Change subject: core: Task Manager Add Tables
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1083
To unsubscribe, visit
Moti Asayag has posted comments on this change.
Change subject: core: Fixing VM Static DAO test.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1645
To unsubscribe, visit
Moti Asayag has submitted this change and it was merged.
Change subject: core: Fixing VM Static DAO test.
..
core: Fixing VM Static DAO test.
Now that VmStatic does not have
originType automatically set this fix is required
as
Eli Mesika has posted comments on this change.
Change subject: core: Task Manager Add stored-procedures
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1084
To unsubscribe, visit
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add Tables
..
Patch Set 8: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1083
To unsubscribe, visit
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add Tables
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1083
To unsubscribe, visit
Moti Asayag has submitted this change and it was merged.
Change subject: core: Task Manager Add Tables
..
core: Task Manager Add Tables
The patch adds 3 tables for the Task Manager:
Job table - stores the job entity, describes
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add stored-procedures
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1084
To unsubscribe,
Moti Asayag has submitted this change and it was merged.
Change subject: core: Task Manager Add stored-procedures
..
core: Task Manager Add stored-procedures
The patch adds stored-procedures for the Task Manager feature.
The
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add business entities
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1085
To unsubscribe,
Moti Asayag has submitted this change and it was merged.
Change subject: core: Task Manager Add ExecutionContext
..
core: Task Manager Add ExecutionContext
The patch introduces the ExecutionContext class which acts as the
Moti Asayag has submitted this change and it was merged.
Change subject: core: Task Manager Add DAO objects
..
core: Task Manager Add DAO objects
The patch adds the DAO interfaces and implementation for the Job,
Step and
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add DAO objects
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1086
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: engine-core: Copy Disk Command
..
Patch Set 2: (1 inline comment)
File
Michael Kublin has posted comments on this change.
Change subject: engine-core: Move disk command
..
Patch Set 3: (1 inline comment)
Except small remark, everything is ok for me.( Also adding someone from gwt
team for error
Ofer Schreiber has uploaded a new change for review.
Change subject: sdk: packaging - Remove release field from tarball
..
sdk: packaging - Remove release field from tarball
The source tarball shouldn't containt the release
ovirt_engine_dao_unit_tests - Build # 104 - Fixed:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/104/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
Omer Frenkel has posted comments on this change.
Change subject: engine : Hotplug - vdsbroker changes
..
Patch Set 2: (3 inline comments)
File
Allon Mureinik has uploaded a new change for review.
Change subject: core: Views for handling query permissions
..
core: Views for handling query permissions
Each view gives a flat set of user IDs and the objects of that type
Michael Pasternak has posted comments on this change.
Change subject: sdk: packaging - Remove release field from tarball
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1698
To
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: packaging - Remove release field from tarball
..
sdk: packaging - Remove release field from tarball
The source tarball shouldn't containt the
Michael Kublin has posted comments on this change.
Change subject: engine : Hotplug - vdsbroker changes
..
Patch Set 2: (3 inline comments)
File
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add JobRepositoryFactory
..
Patch Set 7:
moved JobRepository* from org.ovirt.engine.core.dao.job. to
org.ovirt.engine.core.dal.job..
--
To
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add Jobs handling on server startup
..
Patch Set 6:
moved JobRepository* from org.ovirt.engine.core.dao.job. to
Michael Kublin has posted comments on this change.
Change subject: Engine : Hotplug feature - error messages
..
Patch Set 2: (2 inline comments)
File
Michael Pasternak has posted comments on this change.
Change subject: sdk: rebase on 1.3 upstream
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1700
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup warnings in CommandBase
..
Patch Set 9: Looks good to me, but someone else must approve
reviewed and approved by mkublin in previous patch - was
Allon Mureinik has posted comments on this change.
Change subject: core: addUserTheadContext in SessionDataContainer
..
Patch Set 10: Looks good to me, but someone else must approve
reviewed and approved by mkublin in previous
Allon Mureinik has posted comments on this change.
Change subject: core: Clean up warnings on Backend
..
Patch Set 9: Looks good to me, but someone else must approve
reviewed and approved by mkublin in previous patch - was
Allon Mureinik has posted comments on this change.
Change subject: core: Introduce notion of internal queries
..
Patch Set 8: Looks good to me, but someone else must approve
reviewed and approved by mkublin in previous patch -
Daniel Erez has posted comments on this change.
Change subject: webadmin: Suppress Etag for GWT selector scripts (#784379)
..
Patch Set 2: Verified; Looks good to me, but someone else must approve
--
To view, visit
Eyal Edri has posted comments on this change.
Change subject: packaging: classify params and groups (plugins step 1/3)
..
Patch Set 4: (2 inline comments)
File
Omer Frenkel has posted comments on this change.
Change subject: engine : Hotplug - a new command added, main logic
..
Patch Set 2: (1 inline comment)
File
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Fixed using ovirt-engine instead of 'rhevm'
(#784850)
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Fixed using ovirt-engine instead of 'rhevm'
(#784850)
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Fixed using ovirt-engine instead of 'rhevm'
(#784850)
..
packaging: Fixed using ovirt-engine instead of 'rhevm' (#784850)
Michael Kublin has posted comments on this change.
Change subject: engine : Hotplug - a new command added, main logic
..
Patch Set 2: (1 inline comment)
File
Michael Kublin has posted comments on this change.
Change subject: core: Test suite for SessionDataContainer
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1315
To unsubscribe, visit
Omer Frenkel has posted comments on this change.
Change subject: engine-core: host with same name/address (#786104)
..
Patch Set 1:
that's good for data integrity, i wonder if we have a nice way to fail this in
canDoAction
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup to basic query classes
..
Patch Set 10: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1293
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: Introduce notion of internal queries
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1386
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup warnings in CommandBase
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1316
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: addUserTheadContext in SessionDataContainer
..
Patch Set 10: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1317
To unsubscribe,
Michael Kublin has posted comments on this change.
Change subject: core: Clean up warnings on Backend
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1375
To unsubscribe, visit
Omer Frenkel has posted comments on this change.
Change subject: engine : Hotplug - a new command added, main logic
..
Patch Set 2: (1 inline comment)
File
Omer Frenkel has posted comments on this change.
Change subject: engine : Hotplug feature - db scripts
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1631
To unsubscribe, visit
Doron Fediuck has posted comments on this change.
Change subject: VdsInstaller: drop netconsole code
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Hi Dan, thanks.
This is still not ready to be
Omer Frenkel has posted comments on this change.
Change subject: Engine : Hotplug feature - error messages
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1632
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: Take 2: Prepration for query permissions
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1272
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: Checking permissions when executing queries
..
Patch Set 8: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1585
To unsubscribe,
Omer Frenkel has posted comments on this change.
Change subject: engine-core: host with same name/address (#786104)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1648
ol...@redhat.com has uploaded a new change for review.
Change subject: restapi: Vm Start Time Displayed When Vm is Down
..
restapi: Vm Start Time Displayed When Vm is Down
Change-Id: Ide3aed65480d2cbfa2096d37a070c190ba637a94
Michael Kublin has posted comments on this change.
Change subject: engine : Hotplug - a new command added, main logic
..
Patch Set 4: Verified; Looks good to me, approved
already acked, rebase
--
To view, visit
Michael Kublin has posted comments on this change.
Change subject: engine : Hotplug - vdsbroker changes
..
Patch Set 3: Verified; Looks good to me, approved
already acked, rebase
--
To view, visit http://gerrit.ovirt.org/1634
Michael Kublin has posted comments on this change.
Change subject: Enginne : Hotplug feature - changes at api
..
Patch Set 3: Verified; Looks good to me, approved
already acked, rebase
--
To view, visit
Michael Kublin has posted comments on this change.
Change subject: Engine : Hotplug feature - error messages
..
Patch Set 3: Verified; Looks good to me, approved
already acked, rebase
--
To view, visit
Michael Kublin has submitted this change and it was merged.
Change subject: engine : Hotplug - a new command added, main logic
..
engine : Hotplug - a new command added, main logic
The following patch caontains a new added
Michael Kublin has submitted this change and it was merged.
Change subject: engine : Hotplug - vdsbroker changes
..
engine : Hotplug - vdsbroker changes
This change is dine on vdsBroker level in order to allow an rpc call with
Michael Kublin has submitted this change and it was merged.
Change subject: Engine : Hotplug feature - error messages
..
Engine : Hotplug feature - error messages
The following patch contains a newally added error messages and
Michael Kublin has submitted this change and it was merged.
Change subject: Enginne : Hotplug feature - changes at api
..
Enginne : Hotplug feature - changes at api
The following changes are done in API, because of a new field
Omer Frenkel has posted comments on this change.
Change subject: [DO NOT SUBMIT!] core: Rename MergeSnapshot to RemoveSnapshot
..
Patch Set 2: (2 inline comments)
File
Omer Frenkel has posted comments on this change.
Change subject: [DO NOT SUBMIT!] core: Cleanup of parameters - remove the JAXB
annotations
..
Patch Set 2: Looks good to me, approved
--
To view, visit
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: host with same name/address (#786104)
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1648
To
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine-core: host with same name/address (#786104)
..
engine-core: host with same name/address (#786104)
Omer Frenkel has posted comments on this change.
Change subject: [DO NOT SUBMIT!] core: Simplify RemoveSnapshot command to get id
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1130
To
Allon Mureinik has posted comments on this change.
Change subject: core: Take 2: Prepration for query permissions
..
--
To view, visit http://gerrit.ovirt.org/1272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup to basic query classes
..
Patch Set 10: Verified
--
To view, visit http://gerrit.ovirt.org/1293
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Test suite for SessionDataContainer
..
Patch Set 11: Verified
--
To view, visit http://gerrit.ovirt.org/1315
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Cleanup warnings in CommandBase
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/1316
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: addUserTheadContext in SessionDataContainer
..
Patch Set 10: Verified
--
To view, visit http://gerrit.ovirt.org/1317
To unsubscribe, visit
Allon Mureinik has posted comments on this change.
Change subject: core: Checking permissions when executing queries
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/1585
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: Take 2: Prepration for query permissions
..
--
To view, visit http://gerrit.ovirt.org/1272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Michael Kublin has posted comments on this change.
Change subject: core: Checking permissions when executing queries
..
Patch Set 8: Verified
--
To view, visit http://gerrit.ovirt.org/1585
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: Introduce notion of internal queries
..
--
To view, visit http://gerrit.ovirt.org/1386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Michael Kublin has posted comments on this change.
Change subject: core: Clean up warnings on Backend
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/1375
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup warnings in CommandBase
..
--
To view, visit http://gerrit.ovirt.org/1316
To unsubscribe, visit http://gerrit.ovirt.org/settings
Michael Kublin has posted comments on this change.
Change subject: core: Test suite for SessionDataContainer
..
Patch Set 12: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1315
To unsubscribe,
Michael Kublin has posted comments on this change.
Change subject: core: Introduce notion of internal queries
..
Patch Set 9: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1386
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: Clean up warnings on Backend
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1375
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup to basic query classes
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1293
To unsubscribe, visit
Michael Kublin has posted comments on this change.
Change subject: core: Cleanup warnings in CommandBase
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1316
To unsubscribe,
Michael Kublin has posted comments on this change.
Change subject: core: Take 2: Prepration for query permissions
..
Patch Set 9: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1272
To
Michael Kublin has submitted this change and it was merged.
Change subject: core: Introduce notion of internal queries
..
core: Introduce notion of internal queries
currently, this is only a property (which can be set and
Michael Kublin has submitted this change and it was merged.
Change subject: core: addUserTheadContext in SessionDataContainer
..
core: addUserTheadContext in SessionDataContainer
Move addUserToThreadContext from CommandBase to
Michael Kublin has submitted this change and it was merged.
Change subject: core: Cleanup warnings in CommandBase
..
core: Cleanup warnings in CommandBase
(Already approved by mkublin - resent due to merging issues, no code
Barak Azulay has posted comments on this change.
Change subject: packaging: classify params and groups (plugins step 1/3)
..
Patch Set 4: (3 inline comments)
please fix comments
ovirt_engine_dao_unit_tests - Build # 108 - Still Failing:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/108/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
Michael Kublin has submitted this change and it was merged.
Change subject: core : Fix default values of is_plugged property for devices
..
core : Fix default values of is_plugged property for devices
Disk Interface should
Omer Frenkel has posted comments on this change.
Change subject: core: DO NOT SUBMIT DAL: removing of DiskImageTemplate
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Daniel Erez has posted comments on this change.
Change subject: engine-core: Move disk command
..
Patch Set 4: Verified; Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1608
To
ovirt_engine_dao_unit_tests - Build # 109 - Still Failing:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/109/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
Moti Asayag has uploaded a new change for review.
Change subject: core: Modify commands invocation with compansation context
..
core: Modify commands invocation with compansation context
The patch modifies invocation of
Yair Zaslavsky has posted comments on this change.
Change subject: core: DO NOT SUBMIT common: Fixing entities to reflect removal
of DiskImageTemplate
..
Patch Set 3: (1 inline comment)
Muli Salem has uploaded a new change for review.
Change subject: engine-core: Uniting 2 Commands (Review Only)
..
engine-core: Uniting 2 Commands (Review Only)
This patch unites the AttachUserToVmCommand with the
Jaroslav Henner has posted comments on this change.
Change subject: sdk: Add HTTP request and response hooks.
..
Patch Set 3: (1 inline comment)
File
Michael Kublin has posted comments on this change.
Change subject: engine-core: Uniting 2 Commands (Review Only)
..
Patch Set 2: (7 inline comments)
File
Roy Golan has posted comments on this change.
Change subject: core: Minor clean up of VDSStatus
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1617
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: core: Minor clean up of VDSStatus
..
--
To view, visit http://gerrit.ovirt.org/1617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType:
1 - 100 of 104 matches
Mail list logo
