Gal Hammer has uploaded a new change for review.
Change subject: agent: a new non-blocking uninstalled notification.
..
agent: a new non-blocking uninstalled notification.
The echo command blocks if the host is not connected to
Michael Pasternak has uploaded a new change for review.
Change subject: cli: fix broken help in the /update command
..
cli: fix broken help in the /update command
Change-Id: I92bbbe7476b74528ef74492a479e0503c6755b77
Michael Pasternak has posted comments on this change.
Change subject: cli: fix broken help in the /update command
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10477
To
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: fix broken help in the /update command
..
cli: fix broken help in the /update command
Change-Id: I92bbbe7476b74528ef74492a479e0503c6755b77
Liron Aravot has posted comments on this change.
Change subject: core,ui: support multiple concurrent disks migration
..
Patch Set 5: (15 inline comments)
File
Omer Frenkel has posted comments on this change.
Change subject: core,ui: VM,Template name - support Unicode characters
..
Patch Set 1:
i don't understand, is unicode supported in all vdsm versions that engine works
with?
--
Alona Kaplan has posted comments on this change.
Change subject: engine: Remove duplicate semicolons
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10468
To
Alona Kaplan has uploaded a new change for review.
Change subject: engine: Change ActivateDeactivateVmNic to be internal command
..
engine: Change ActivateDeactivateVmNic to be internal command
ActivateDeactivateVmNic should be
Omer Frenkel has posted comments on this change.
Change subject: engine: Import Cluster Error message needs clarity (#883542)
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10430
To
Omer Frenkel has posted comments on this change.
Change subject: engine: Import Cluster Error message needs clarity (#883542)
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10430
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Import Cluster Error message needs clarity (#883542)
..
engine: Import Cluster Error message needs clarity (#883542)
Added missing action
Michael Pasternak has uploaded a new change for review.
Change subject: cli: release 3.2.0.8-1
..
cli: release 3.2.0.8-1
Change-Id: Iacff563a59bd735a6f17e4b511f08dc4fd76f692
Signed-off-by: Michael Pasternak mpast...@redhat.com
Michael Pasternak has uploaded a new change for review.
Change subject: cli: update connection metadata implicitly
..
cli: update connection metadata implicitly
Change-Id: I964d27bdd47fe71f3bdce805bdb1b1cac358db61
Liron Aravot has posted comments on this change.
Change subject: core,ui: support multiple concurrent disks migration
..
Patch Set 5: (1 inline comment)
File
Michael Pasternak has posted comments on this change.
Change subject: cli: update connection metadata implicitly
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10479
To
Michael Pasternak has posted comments on this change.
Change subject: cli: release 3.2.0.8-1
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10480
To unsubscribe, visit
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: release 3.2.0.8-1
..
cli: release 3.2.0.8-1
Change-Id: Iacff563a59bd735a6f17e4b511f08dc4fd76f692
Signed-off-by: Michael Pasternak
Roy Golan has posted comments on this change.
Change subject: core,ui: VM,Template name - support Unicode characters
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10473
To unsubscribe,
Alona Kaplan has posted comments on this change.
Change subject: restapi: Adding Network Linking
..
Patch Set 12: Verified
--
To view, visit http://gerrit.ovirt.org/10165
To unsubscribe, visit http://gerrit.ovirt.org/settings
Alona Kaplan has posted comments on this change.
Change subject: restapi: Activate/Deactivate vnic should use edit
..
Patch Set 5: Verified
--
To view, visit http://gerrit.ovirt.org/10358
To unsubscribe, visit
Ofer Schreiber has posted comments on this change.
Change subject: packaging: add configurable prefix to rpm list
..
Patch Set 2: Verified; Looks good to me, approved
VERIFIED by author.
--
To view, visit
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: add configurable prefix to rpm list
..
packaging: add configurable prefix to rpm list
Change-Id: I321fd181d6bea292dec210a438bc923b66067200
Ofer Schreiber has posted comments on this change.
Change subject: packaging: sync miniyum implementation with recent otopi
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10308
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: sync miniyum implementation with recent otopi
..
packaging: sync miniyum implementation with recent otopi
Change-Id:
Alona Kaplan has posted comments on this change.
Change subject: restapi: Adding Network Linking
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/10165
To unsubscribe, visit http://gerrit.ovirt.org/settings
Alona Kaplan has posted comments on this change.
Change subject: engine: Port mirroring setting requires a network
..
Patch Set 3: Verified
--
To view, visit http://gerrit.ovirt.org/10442
To unsubscribe, visit
Ofer Schreiber has posted comments on this change.
Change subject: packaging: upgrade: print yum transaction details
..
Patch Set 1:
I see only logging of current transaction, not printing it to the user, is that
in purpose?
Ofer Schreiber has posted comments on this change.
Change subject: packaging: upgrade: rewrite rollbackAvailable
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10310
To
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: upgrade: print yum transaction details
..
Patch Set 1:
I see only logging of current transaction, not printing it to the user, is
that in purpose?
Ofer Schreiber has posted comments on this change.
Change subject: packaging: upgrade: support engine yum group
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10311
To
Ofer Schreiber has posted comments on this change.
Change subject: packaging: upgrade: print yum transaction details
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10309
To
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: upgrade: print yum transaction details
..
packaging: upgrade: print yum transaction details
Change-Id:
Ofer Schreiber has posted comments on this change.
Change subject: packaging: upgrade: rewrite rollbackAvailable
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10310
To
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: upgrade: rewrite rollbackAvailable
..
packaging: upgrade: rewrite rollbackAvailable
So far the query of local cache was for any package of
Ofer Schreiber has posted comments on this change.
Change subject: packaging: upgrade: support engine yum group
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10311
To
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: upgrade: support engine yum group
..
packaging: upgrade: support engine yum group
Change-Id: Iafbd1aac08925f4476fa83427a35070a4e29fe34
Ofer Schreiber has posted comments on this change.
Change subject: Packaging: Fix answer-file typo in engine setup.
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9813
To
Ofer Schreiber has submitted this change and it was merged.
Change subject: Packaging: Fix answer-file typo in engine setup.
..
Packaging: Fix answer-file typo in engine setup.
This patch fixes a typo.
Replacing
Alon Bar-Lev has posted comments on this change.
Change subject: host-deploy: enforce random vdsm id in case of duplicate
..
Patch Set 1: I would prefer that you didn't submit this
--
To view, visit
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Remove overriden JBoss modules
..
Patch Set 2: Looks good to me, but someone else must approve
Juan - what's preventing us from pushing this in?
--
Ofer Schreiber has posted comments on this change.
Change subject: packaging: Updated cleanup to ignore DB if no_drop_db supplied
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Looks good
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3088/
Build Number: 3088
Build Status: Failure
Triggered By: Started by upstream project ovirt_engine build number 3,762
-
Changes Since
Alon Bar-Lev has uploaded a new change for review.
Change subject: tune/tuned: don't set a profile for gluster nodes
..
tune/tuned: don't set a profile for gluster nodes
Change-Id: I37ede841eb1cfcfa3c24abeb7265362f25885c46
Daniel Erez has posted comments on this change.
Change subject: core: enabling Unicode support in OVF
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10472
To unsubscribe, visit
ofri masad has uploaded a new change for review.
Change subject: webadmin: Fix UI for cpu flags
..
webadmin: Fix UI for cpu flags
The value of the use host cpu check-box was not saved in cases when
Allow VM migration only
Eli Mesika has posted comments on this change.
Change subject: core : DB FK validation
..
Patch Set 6: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10248
To unsubscribe, visit
Eli Mesika has submitted this change and it was merged.
Change subject: core : DB FK validation
..
core : DB FK validation
The purpose of this utility is to find inconsistent data that violates
FK(Forign Keys), display it
Michael Pasternak has posted comments on this change.
Change subject: engine: Remove duplicate semicolons
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10468
To
Ayal Baron has posted comments on this change.
Change subject: core: Fix typo in Storage Domain deactivate command
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/10388
Michael Pasternak has posted comments on this change.
Change subject: restapi: Vnic's network update when portMirroring is set
behaves wrong
..
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Michael Pasternak has posted comments on this change.
Change subject: restapi: Organize imports
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10407
To unsubscribe, visit
Muli Salem has posted comments on this change.
Change subject: restapi: Organize imports
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10407
To unsubscribe, visit
Liron Aravot has posted comments on this change.
Change subject: engine: consolidate userPortal vm and pool queries
..
Patch Set 1: (5 inline comments)
File
Michael Pasternak has posted comments on this change.
Change subject: API : API Refactoring
..
Patch Set 11:
eli i still se you using Guid id while should be Guid guid see patch-set 7
for details
--
To view, visit
Project: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/
Build: http://jenkins.ovirt.org/job/ovirt_engine_find_bugs/3089/
Build Number: 3089
Build Status: Fixed
Triggered By: Started by upstream project ovirt_engine build number 3,763,
Started by upstream project ovirt_engine build number
Michael Pasternak has posted comments on this change.
Change subject: API: Adding support for external events
..
Patch Set 11: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10097
To unsubscribe, visit
Maor Lipchuk has posted comments on this change.
Change subject: core: audit log on error during GetVms\Templates from export
domain
..
Patch Set 1: (1 inline comment)
File
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Refactor validateVlanId method
..
engine: Refactor validateVlanId method
Refactor method to use iteration, which makes it easier to read, and
also
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Change VmNicValidator to work with Version
..
engine: Change VmNicValidator to work with Version
Version is the actual data that is needed so work with
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Networking commands reuse methods
..
engine: Networking commands reuse methods
Refactored network handling commands to reuse getNetwork() and
Mike Kolesnik has uploaded a new change for review.
Change subject: engine: Add FeatureSupported class
..
engine: Add FeatureSupported class
This is a convenience class that allows to check if a feature is
supported for a given
Roy Golan has posted comments on this change.
Change subject: core: enabling Unicode support in OVF
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10472
To unsubscribe, visit
Roy Golan has posted comments on this change.
Change subject: engine: Model the smartcard as a device
..
Patch Set 2: Looks good to me, approved
(1 inline comment)
File
Omer Frenkel has posted comments on this change.
Change subject: engine: Delete getChangeablePropertiesList()
..
Patch Set 3: Looks good to me, but someone else must approve
when you verify, please make sure queries are still
Omer Frenkel has posted comments on this change.
Change subject: core: Delete OnPropertyChanged from entities
..
Patch Set 3: Looks good to me, but someone else must approve
please make sure to have +1 from UI as well,
what
Omer Frenkel has posted comments on this change.
Change subject: engine: Model the smartcard as a device
..
Patch Set 2: (1 inline comment)
File
Omer Frenkel has posted comments on this change.
Change subject: engine: Model the smartcard as a device
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10302
To unsubscribe, visit
Omer Frenkel has posted comments on this change.
Change subject: engine: Model the smartcard as a device
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10302
To unsubscribe,
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Model the smartcard as a device
..
engine: Model the smartcard as a device
Since the VDSM models the smartcard as a device, the engine
has been
Michael Pasternak has posted comments on this change.
Change subject: restapi: Report Guest Agent Network Devices of VM
..
Patch Set 5: I would prefer that you didn't submit this
(1 inline comment)
great job Muli!, two tiny
Omer Frenkel has posted comments on this change.
Change subject: gluster: Fixed deadlock in nested command execution
..
Patch Set 1:
although this solution seems to work, i would like to suggest checking if using
existing
Alex Lourie has uploaded a new change for review.
Change subject: packaging: Updated spec to correctly set backup permissions
..
packaging: Updated spec to correctly set backup permissions
* Updated the specfile to correctly
Mike Kolesnik has posted comments on this change.
Change subject: engine: Change VLAN range validation to framework
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10469
To unsubscribe, visit
Mike Kolesnik has posted comments on this change.
Change subject: engine: Replace validation by simpler one
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10470
To unsubscribe, visit
Michael Pasternak has posted comments on this change.
Change subject: restapi: Guest Agent Network Devices of Nic
..
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
great job Muli!, one tiny
Mike Kolesnik has posted comments on this change.
Change subject: engine: Networking commands reuse methods
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10483
To unsubscribe, visit
Mike Kolesnik has posted comments on this change.
Change subject: engine: Refactor validateVlanId method
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10484
To unsubscribe, visit
Mike Kolesnik has posted comments on this change.
Change subject: engine: Change VmNicValidator to work with Version
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10485
To unsubscribe, visit
Mike Kolesnik has posted comments on this change.
Change subject: engine: Add FeatureSupported class
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10486
To unsubscribe, visit
Mike Kolesnik has posted comments on this change.
Change subject: engine: Change validation in network common
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/10471
To unsubscribe, visit
Alex Lourie has posted comments on this change.
Change subject: packaging: Updated spec to correctly set backup permissions
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/10487
To unsubscribe, visit
Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Updated spec to correctly set backup permissions
..
Patch Set 1: (1 inline comment)
File
Michael Pasternak has posted comments on this change.
Change subject: API : API Refactoring
..
Patch Set 12: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10096
To unsubscribe, visit
Michael Pasternak has posted comments on this change.
Change subject: API: Adding support for external events
..
Patch Set 12: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10097
To unsubscribe, visit
Michael Pasternak has posted comments on this change.
Change subject: restapi: Activate/Deactivate vnic should use edit
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10358
To unsubscribe,
Michael Pasternak has posted comments on this change.
Change subject: restapi : Custom property values with multiple = not
returned (#886802)
..
Patch Set 1: Looks good to me, approved
--
To view, visit
Alona Kaplan has uploaded a new change for review.
Change subject: restapi: Port mirroring was disabled if it wasn't set.
..
restapi: Port mirroring was disabled if it wasn't set.
If port mirroring is not set, it shouldn't be
Alona Kaplan has posted comments on this change.
Change subject: restapi: Vnic's network update when portMirroring is set
behaves wrong
..
Patch Set 1: (2 inline comments)
Michael Pasternak has posted comments on this change.
Change subject: restapi: Vnic's network update when portMirroring is set
behaves wrong
..
Patch Set 2: Looks good to me, approved
--
To view, visit
Alona Kaplan has posted comments on this change.
Change subject: restapi: Vnic's network update when portMirroring is set
behaves wrong
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit
Alona Kaplan has submitted this change and it was merged.
Change subject: restapi: Vnic's network update when portMirroring is set
behaves wrong
..
restapi: Vnic's network update when portMirroring is set behaves wrong
If
Alona Kaplan has posted comments on this change.
Change subject: webadmin: [SetupNetwork] networks detached when adding nic to a
bond
..
Patch Set 2: Verified; Looks good to me, approved
rebased
--
To view, visit
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: [SetupNetwork] networks detached when adding nic to a
bond
..
webadmin: [SetupNetwork] networks detached when adding nic to a bond
When
Arik Hadas has uploaded a new change for review.
Change subject: engine: ensure video devices are defined for imported VMs
..
engine: ensure video devices are defined for imported VMs
VM that was imported or was created from
Mike Kolesnik has posted comments on this change.
Change subject: engine: Port mirroring setting requires a network
..
Patch Set 4: (2 inline comments)
Basically looks good, just 2 small comments
Omer Frenkel has posted comments on this change.
Change subject: engine: ensure video devices are defined for imported VMs
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
Mike Kolesnik has posted comments on this change.
Change subject: engine: Change ActivateDeactivateVmNic to be internal command
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10478
To
Leonid Natapov has posted comments on this change.
Change subject: core: OvfDataUpdater - removal of update/remove OVF vdsm calls
..
Patch Set 31: Verified
tested on iscsi and nfs. used 2 storage domains for both. (2 NFS and 2
Leonid Natapov has posted comments on this change.
Change subject: core: introducing OvfAutoUpdate
..
Patch Set 29: Verified
tested on iscsi and nfs. used 2 storage domains for both. (2 NFS and 2 iscsi).
Michael Pasternak has posted comments on this change.
Change subject: core : API changes Multi-Tier fencing
..
Patch Set 14: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10262
To unsubscribe, visit
1 - 100 of 281 matches
Mail list logo
