Re: [Fab-user] Code review for changes in 1.x

2011-02-15 Thread Michael Gliwinski
On Monday 14 Feb 2011 17:05:27 Travis Swicegood wrote: > michael.gliwin...@henderson-group.com> wrote: > > Hmm, I see your point, however I'm wondering if it might be better then > > to formalize and clean up that registry first... > > We could -- that was against the idea behind this style. I wa

Re: [Fab-user] Code review for changes in 1.x

2011-02-15 Thread Travis Swicegood
On Tue, Feb 15, 2011 at 6:47 AM, Michael Gliwinski < michael.gliwin...@henderson-group.com> wrote: > > > There are two use cases. The one you mentioned (fab production.deploy, > fab > > staging.deploy). I use that quite a bit. > > > > The other case that I'm hoping this encourages is shared stuff

[Fab-user] Patch for files.py

2011-02-15 Thread Morgan LEFIEUX
Hello, I've made a little modification of the 'files.py' code to handle correctly sed versions without '-i' option like on NetBSD and OpenBSD. thanks ! Bye >From cecd8cf8b20fd5fb6cd55df72042857003f59306 Mon Sep 17 00:00:00 2001 From: Morgan LEFIEUX Date: Tue, 15 Feb 2011 22:38:44 +0100 Subje

Re: [Fab-user] Patch for files.py

2011-02-15 Thread Morgan LEFIEUX
No sorry, i don't have a fork, neither a GitHub account. But if you have one, feel free to do it for me ;) it's the first time i use git... i'm a mercurial addict :) Thanks a lot ! Le 15/02/2011 23:36, Morgan Goose a écrit : Do you have a fork on github? We can open a bug for that, and get yo

Re: [Fab-user] Patch for files.py

2011-02-15 Thread Travis Swicegood
FWIW: sed on BSD (at least a Darwin) does support inline editing via -i, but I think the syntax is slightly different. I'm also not familiar with platform.system() -- is it going to be aware of the other OS? I routinely execute code on Ubuntu from my Mac. Wouldn't this code use the BSD syntax ra

Re: [Fab-user] Patch for files.py

2011-02-15 Thread Morgan LEFIEUX
oh you're right ! i've made a mistake using platform module, i correct this and post another patch soon. sed on FreeBSD and Darwin support inline editing via -i but not on NetBSD and OpenBSD Thanks again for your remarks Le 15/02/2011 23:47, Travis Swicegood a écrit : FWIW: sed on BSD (at l

Re: [Fab-user] Patch for files.py

2011-02-15 Thread Morgan LEFIEUX
This is a fixed release of the patch, sorry for the mistake. Any comment is welcome. Le 15/02/2011 23:47, Travis Swicegood a écrit : FWIW: sed on BSD (at least a Darwin) does support inline editing via -i, but I think the syntax is slightly different. I'm also not familiar with platform.system