[FFmpeg-devel] [PATCH V3] libavfilter/qsvvpp: change the output frame's width and height

2021-03-28 Thread wenbin . chen
From: "Chen,Wenbin" qsvvpp align the width and height with 16, and that right. But qsvvpp asign this value to frame->width and frame->height, and that may lead to error. For example, when we use qsvvpp to resize frame to 1080p, qsvvpp will align frame to 1088 and set frame->height to 1088,

Re: [FFmpeg-devel] [PATCH] avformat: add apic to AVStream

2021-03-28 Thread Lynne
Mar 28, 2021, 17:58 by jamr...@gmail.com: > As a replacement for attached_pic, which is in turn deprecated and scheduled > for removal. > > Signed-off-by: James Almer > --- > TODO: APIChanges entry and version bump. > > Decided to use the name apic for the field, since it's how id3v2 and other >

Re: [FFmpeg-devel] [RFC PATCH] avformat/dashdec: Improve implementation

2021-03-28 Thread Steven Liu
> 在 2021年3月29日,04:50,Derek Buitenhuis 写道: > > On 28/03/2021 21:05, Carl Eugen Hoyos wrote: >> The patch clearly mentions that it is a "rework". >> If the maintainer likes it, it would be nice if it can be simplified but >> this may not be possible. > > Of course it's /possible/. People have

Re: [FFmpeg-devel] [RFC PATCH] avformat/dashdec: Improve implementation

2021-03-28 Thread Carl Eugen Hoyos
Am So., 28. März 2021 um 22:58 Uhr schrieb Derek Buitenhuis : > > On 28/03/2021 21:05, Carl Eugen Hoyos wrote: > > The patch clearly mentions that it is a "rework". > > If the maintainer likes it, it would be nice if it can be simplified but > > this may not be possible. > > Of course it's

Re: [FFmpeg-devel] [RFC PATCH] avformat/dashdec: Improve implementation

2021-03-28 Thread Derek Buitenhuis
On 28/03/2021 21:05, Carl Eugen Hoyos wrote: > The patch clearly mentions that it is a "rework". > If the maintainer likes it, it would be nice if it can be simplified but > this may not be possible. Of course it's /possible/. People have been splitting rewrites/refactors into these since

Re: [FFmpeg-devel] [PATCH] avformat: add apic to AVStream

2021-03-28 Thread James Almer
On 3/28/2021 5:32 PM, Marton Balint wrote: On Sun, 28 Mar 2021, James Almer wrote: As a replacement for attached_pic, which is in turn deprecated and scheduled for removal. Signed-off-by: James Almer --- TODO: APIChanges entry and version bump. Decided to use the name apic for the field,

Re: [FFmpeg-devel] [PATCH] avformat: add apic to AVStream

2021-03-28 Thread Marton Balint
On Sun, 28 Mar 2021, James Almer wrote: As a replacement for attached_pic, which is in turn deprecated and scheduled for removal. Signed-off-by: James Almer --- TODO: APIChanges entry and version bump. Decided to use the name apic for the field, since it's how id3v2 and other formats call

Re: [FFmpeg-devel] [RFC PATCH] avformat/dashdec: Improve implementation

2021-03-28 Thread Carl Eugen Hoyos
Am Sa., 27. März 2021 um 17:45 Uhr schrieb Derek Buitenhuis : > > On 22/03/2021 22:25, zsugabubus wrote: > > Compared to previous implementation, this rework tries to: > > > > - Improve code quality, > > - Provide better error handling (also: reduce numerous (potential) > > memory leaks), > > -

Re: [FFmpeg-devel] [PATCH V3 3/3] libavfilter: add filter dnn_detect for object detection

2021-03-28 Thread Nicolas George
Andreas Rheinhardt (12021-03-01): > 3. As you probably guessed from the last part of 2., I don't think that > casting avoids the possibility of undefined behaviour* (because this > conversion is done automatically anyway); but it might very well protect > the code from aggressively optimizing

[FFmpeg-devel] [PATCH] avformat: add apic to AVStream

2021-03-28 Thread James Almer
As a replacement for attached_pic, which is in turn deprecated and scheduled for removal. Signed-off-by: James Almer --- TODO: APIChanges entry and version bump. Decided to use the name apic for the field, since it's how id3v2 and other formats call it. Also, in a fortunate coincidence, the

Re: [FFmpeg-devel] [PATCH 01/12] avcodec/vorbisenc: Remove always-false check

2021-03-28 Thread Andreas Rheinhardt
On Thu, Mar 25, 2021 at 4:50 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > The PutBitContext is big enough: It has just been initialized to 8192B. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vorbisenc.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/7] avformat/utils: Fix integer overflow with duration_gcd in ff_rfps_calculate()

2021-03-28 Thread Michael Niedermayer
On Thu, Mar 04, 2021 at 07:48:33PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 136323327 * 281474976710656 cannot be > represented in type 'long' > Fixes: > 30913/clusterfuzz-testcase-minimized-ffmpeg_dem_IVF_fuzzer-5753392189931520 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 4/7] avcodec/dvbsubdec: Support computing clut only once

2021-03-28 Thread Michael Niedermayer
On Thu, Mar 04, 2021 at 07:59:34PM +0100, Marton Balint wrote: > > > On Thu, 4 Mar 2021, Michael Niedermayer wrote: > > > This avoids crafted files from consuming excessive resources recomputing > > the clut after each pixel change > > > > Signed-off-by: Michael Niedermayer > > --- > >

Re: [FFmpeg-devel] [PATCH] avformat/vividas: Use signed n in read_sb_block()

2021-03-28 Thread Michael Niedermayer
On Thu, Feb 25, 2021 at 09:59:40PM +0100, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Wed, Feb 24, 2021 at 03:23:40PM +0100, Anton Khirnov wrote: > >> Quoting Michael Niedermayer (2021-02-15 21:31:23) > >>> Fixes: OOM > >>> Fixes: > >>>

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/sonic: Use unsigned temporary in predictor_calc_error()

2021-03-28 Thread Michael Niedermayer
On Thu, Feb 11, 2021 at 10:17:14PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2147471366 - 18638 cannot be represented in > type 'int' > Fixes: > 30157/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SONIC_fuzzer-5171199746506752 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 2/3] avformat/jacosubdec: Use 64bit intermediate for start/end timestamp shift

2021-03-28 Thread Michael Niedermayer
On Thu, Feb 11, 2021 at 11:39:26PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1957694447 + -1620425806 cannot be > represented in type 'int' > Fixes: > 30207/clusterfuzz-testcase-minimized-ffmpeg_dem_JACOSUB_fuzzer-5050791771635712 > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 3/3] avformat/flvdec: Check array entry number

2021-03-28 Thread Michael Niedermayer
On Thu, Feb 11, 2021 at 11:39:27PM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in type > 'int' > Fixes: > 30209/clusterfuzz-testcase-minimized-ffmpeg_dem_FLV_fuzzer-5724831658147840 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 3/4] avfilter/asrc_sine: Fix invalid left shift of negative number

2021-03-28 Thread Nicolas George
Andreas Rheinhardt (12021-03-26): > No impact whatsoever. Disassembly of request_frame is unchanged with > both GCC (10) and Clang (11) on O0-O3 (I was actually surprised about > O0, but not about the others.) > (If it were otherwise I would have opted for a different path (like > casting to

Re: [FFmpeg-devel] [PATCH] avformat/rtpenc_mpegts: stop leaks

2021-03-28 Thread Gyan Doshi
On 2021-03-28 15:52, Marton Balint wrote: On Sun, 28 Mar 2021, Gyan Doshi wrote: Fixes CID 1474460 & 1474461 --- libavformat/rtpenc_mpegts.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) LGTM, thanks. Thanks. Pushed as 8b2bde04948e6e10896b6f923b0367aaba153014 to

Re: [FFmpeg-devel] [PATCH] avformat/rtpenc_mpegts: stop leaks

2021-03-28 Thread Marton Balint
On Sun, 28 Mar 2021, Gyan Doshi wrote: Fixes CID 1474460 & 1474461 --- libavformat/rtpenc_mpegts.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) LGTM, thanks. Marton diff --git a/libavformat/rtpenc_mpegts.c b/libavformat/rtpenc_mpegts.c index f7ee5a4448..9f95b3a4e8

[FFmpeg-devel] [PATCH] avformat/rtpenc_mpegts: stop leaks

2021-03-28 Thread Gyan Doshi
Fixes CID 1474460 & 1474461 --- libavformat/rtpenc_mpegts.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/libavformat/rtpenc_mpegts.c b/libavformat/rtpenc_mpegts.c index f7ee5a4448..9f95b3a4e8 100644 --- a/libavformat/rtpenc_mpegts.c +++

[FFmpeg-devel] Facing Seg Fault

2021-03-28 Thread Abhinav Singh
Hello everyone, I m trying to convert my audio from planner 32bit( AV_SAMPLE_FMT_S32P) to AV_SAMPLE_FMT_S16 . I m doing this so that I can play sound using libsdl, this is code for it ``` SwrContext* context = swr_alloc_set_opts( nullptr, dst_channel_layout,