Re: [FFmpeg-devel] [PATCH] avutil/cpu: Use HW_NCPUONLINE to detect # of online CPUs with OpenBSD

2021-04-16 Thread Brad Smith
ping. On 4/3/2021 2:49 PM, Brad Smith wrote: avutil/cpu: Use HW_NCPUONLINE to detect # of online CPUs with OpenBSD Signed-off-by: Brad Smith --- libavutil/cpu.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavutil/cpu.c b/libavutil/cpu.c index 8e3576a1f3..9d249737df 100644

[FFmpeg-devel] [PATCH v2] avformat/wavdec: Fix reading files with id3v2 apic before fmt tag

2021-04-16 Thread Andreas Rheinhardt
Up until now the cover images will get the stream index 0 in this case, violating the hardcoded assumption that this is the index of the audio stream. Fix this by creating the audio stream first; this is also in line with the expectations of ff_pcm_read_seek() and ff_spdif_read_packet(). It also

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

2021-04-16 Thread Andreas Rheinhardt
James Almer: > On 4/16/2021 9:13 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 4/16/2021 8:45 PM, Andreas Rheinhardt wrote: James Almer: > On 4/16/2021 7:45 PM, James Almer wrote: >> On 4/16/2021 7:24 PM, Andreas Rheinhardt wrote: >>> James Almer: On 4/16/2021 4:04

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

2021-04-16 Thread James Almer
On 4/16/2021 9:13 PM, Andreas Rheinhardt wrote: James Almer: On 4/16/2021 8:45 PM, Andreas Rheinhardt wrote: James Almer: On 4/16/2021 7:45 PM, James Almer wrote: On 4/16/2021 7:24 PM, Andreas Rheinhardt wrote: James Almer: On 4/16/2021 4:04 PM, Michael Niedermayer wrote: On Thu, Apr 15,

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

2021-04-16 Thread Andreas Rheinhardt
James Almer: > On 4/16/2021 8:45 PM, Andreas Rheinhardt wrote: >> James Almer: >>> On 4/16/2021 7:45 PM, James Almer wrote: On 4/16/2021 7:24 PM, Andreas Rheinhardt wrote: > James Almer: >> On 4/16/2021 4:04 PM, Michael Niedermayer wrote: >>> On Thu, Apr 15, 2021 at 06:22:10PM

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

2021-04-16 Thread James Almer
On 4/16/2021 8:45 PM, Andreas Rheinhardt wrote: James Almer: On 4/16/2021 7:45 PM, James Almer wrote: On 4/16/2021 7:24 PM, Andreas Rheinhardt wrote: James Almer: On 4/16/2021 4:04 PM, Michael Niedermayer wrote: On Thu, Apr 15, 2021 at 06:22:10PM -0300, James Almer wrote: On 4/15/2021 5:44

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

2021-04-16 Thread Andreas Rheinhardt
James Almer: > On 4/16/2021 7:45 PM, James Almer wrote: >> On 4/16/2021 7:24 PM, Andreas Rheinhardt wrote: >>> James Almer: On 4/16/2021 4:04 PM, Michael Niedermayer wrote: > On Thu, Apr 15, 2021 at 06:22:10PM -0300, James Almer wrote: >> On 4/15/2021 5:44 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

2021-04-16 Thread James Almer
On 4/16/2021 7:45 PM, James Almer wrote: On 4/16/2021 7:24 PM, Andreas Rheinhardt wrote: James Almer: On 4/16/2021 4:04 PM, Michael Niedermayer wrote: On Thu, Apr 15, 2021 at 06:22:10PM -0300, James Almer wrote: On 4/15/2021 5:44 PM, Michael Niedermayer wrote: Fixes: runtime error: signed

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

2021-04-16 Thread James Almer
On 4/16/2021 7:45 PM, James Almer wrote: On 4/16/2021 7:24 PM, Andreas Rheinhardt wrote: James Almer: On 4/16/2021 4:04 PM, Michael Niedermayer wrote: On Thu, Apr 15, 2021 at 06:22:10PM -0300, James Almer wrote: On 4/15/2021 5:44 PM, Michael Niedermayer wrote: Fixes: runtime error: signed

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

2021-04-16 Thread James Almer
On 4/16/2021 7:24 PM, Andreas Rheinhardt wrote: James Almer: On 4/16/2021 4:04 PM, Michael Niedermayer wrote: On Thu, Apr 15, 2021 at 06:22:10PM -0300, James Almer wrote: On 4/15/2021 5:44 PM, Michael Niedermayer wrote: Fixes: runtime error: signed integer overflow: 65312 * 65535 cannot be

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

2021-04-16 Thread Andreas Rheinhardt
James Almer: > On 4/16/2021 4:04 PM, Michael Niedermayer wrote: >> On Thu, Apr 15, 2021 at 06:22:10PM -0300, James Almer wrote: >>> On 4/15/2021 5:44 PM, Michael Niedermayer wrote: Fixes: runtime error: signed integer overflow: 65312 * 65535 cannot be represented in type 'int'

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

2021-04-16 Thread James Almer
On 4/16/2021 4:04 PM, Michael Niedermayer wrote: On Thu, Apr 15, 2021 at 06:22:10PM -0300, James Almer wrote: On 4/15/2021 5:44 PM, Michael Niedermayer wrote: Fixes: runtime error: signed integer overflow: 65312 * 65535 cannot be represented in type 'int' Fixes:

[FFmpeg-devel] [PATCH] avformat/wavdec: Fix reading files with id3v2 apic before fmt tag

2021-04-16 Thread Andreas Rheinhardt
In this case the cover images will get the stream index 0, violating the hardcoded assumption that this is the index of the audio stream. Fixes #8540; regression since f5aad350d3695b5b16e7d135154a4c61e4dce9d8. Signed-off-by: Andreas Rheinhardt --- libavformat/wavdec.c | 51

Re: [FFmpeg-devel] [PATCH 3/4] avformat/rmdec: Use 64bit for intermediate for DEINT_ID_INT4

2021-04-16 Thread Michael Niedermayer
On Thu, Apr 15, 2021 at 06:22:10PM -0300, James Almer wrote: > On 4/15/2021 5:44 PM, Michael Niedermayer wrote: > > Fixes: runtime error: signed integer overflow: 65312 * 65535 cannot be > > represented in type 'int' > > Fixes: > >

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/webpenc: don't assume animated webp streams will have more than one packet

2021-04-16 Thread James Almer
On 4/16/2021 11:36 AM, Carl Eugen Hoyos wrote: Am 16.04.2021 um 16:15 schrieb James Almer : ffmpeg | branch: master | James Almer | Sat Apr 10 22:53:34 2021 -0300| [55d667d86af7d13fc5aa2b4071a5b97eb10e2da6] | committer: James Almer avformat/webpenc: don't assume animated webp streams

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/webpenc: don't assume animated webp streams will have more than one packet

2021-04-16 Thread Carl Eugen Hoyos
> Am 16.04.2021 um 16:15 schrieb James Almer : > > ffmpeg | branch: master | James Almer | Sat Apr 10 > 22:53:34 2021 -0300| [55d667d86af7d13fc5aa2b4071a5b97eb10e2da6] | committer: > James Almer > > avformat/webpenc: don't assume animated webp streams will have more than one > packet > >

Re: [FFmpeg-devel] [PATCH] avformat/movenc: fix writing dOps atoms

2021-04-16 Thread James Almer
On 4/15/2021 1:39 AM, James Almer wrote: Don't blindly copy all bytes in extradata past ChannelMappingFamily. Instead check if ChannelMappingFamily is not 0 and then only write the correct amount of bytes from ChannelMappingTable, as defined in the spec[1]. Should fix ticket #9190. [1]

Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: export frame pict_type

2021-04-16 Thread James Almer
On 4/13/2021 9:14 PM, James Almer wrote: Should fix ticket #9180 Signed-off-by: James Almer --- libavcodec/libaomdec.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c index 1fc0a0001d..6de3bcc5c3 100644 ---

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/af_astats: Remove fraction part of integer metadata entries

2021-04-16 Thread Tobias Rapp
On 09.04.2021 09:58, Tobias Rapp wrote: On 08.04.2021 11:34, Nicolas George wrote: Anton Khirnov (12021-04-08): Does this mean that there are no stability guarantees for metadata exported by filters? We can have stability for the components that are good enough to be stable, and no stability

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libwebpenc_animencoder: stop propagating bogus empty packets

2021-04-16 Thread James Almer
On 4/10/2021 11:12 PM, James Almer wrote: Packets must have at least one of data or side_data. If none are available, then got_packet must not be signaled. The generic encode code already discarded these empty packets, but it's better just not propagating them at all. Signed-off-by: James

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: set correct extradata size for Opus streams

2021-04-16 Thread James Almer
On 4/15/2021 1:02 AM, James Almer wrote: map_type 0 is always 19 bytes, whereas map_type 1 and 255 are 21 + channel count bytes. Should fix ticket #9190. Signed-off-by: James Almer --- libavformat/mpegts.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mpegts.c

[FFmpeg-devel] [PATCH 1/1] avcodec/nvenc: move lossless presets after new ones

2021-04-16 Thread Martin Pulec
A check in nvenc.c checks for NV_ENC_CAPS_SUPPORT_LOSSLESS_ENCODE if preset >= PRESET_LOSSLESS_DEFAULT which was true for the new presets. As a result, the use of new presets (P1-P7) fail if the card doesn't support lossless encoding. --- libavcodec/nvenc.h | 4 ++-- libavcodec/nvenc_h264.c

[FFmpeg-devel] [PATCH 1/1] avcodec/nvenc: move lossless presets after new ones

2021-04-16 Thread Martin Pulec
A simplier alternative to this patch would be replacing the condition in nvenc.c: if (ctx->preset >= PRESET_LOSSLESS_DEFAULT && ret <= 0) { with if ((ctx->preset >= PRESET_LOSSLESS_DEFAULT && (ctx->preset <= PRESET_LOSSLESS_HP)) && ret <= 0) { But a comment in the preset enum

Re: [FFmpeg-devel] [PATCH 1/2] Include attributes.h directly

2021-04-16 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Some files currently rely on libavutil/cpu.h to include it for them; > yet said file won't use include it any more after the currently > deprecated functions are removed, so include attributes.h directly. > > Signed-off-by: Andreas Rheinhardt > --- >

Re: [FFmpeg-devel] [PATCH] avcodec/jpeglsdec: Don't allocate+free JPEGLSState for every frame

2021-04-16 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/jpeglsdec.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/jpeglsdec.c b/libavcodec/jpeglsdec.c > index 69980eaa49..92df81600b 100644 > --- a/libavcodec/jpeglsdec.c >

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: Remove unnecessary function calls

2021-04-16 Thread Andreas Rheinhardt
Andreas Rheinhardt: > ffio_fill() is used when initially writing unknown length elements; > yet it can happen that the amount of bytes written by it is zero in > which case it is of course unnecessary to ever call it. Whether it is > possible to know this during compiletime depends upon how

Re: [FFmpeg-devel] [PATCH] avformat/utils: Combine identical statements

2021-04-16 Thread Andreas Rheinhardt
Andreas Rheinhardt: > This would only make a difference in case the first attempt to > initialize the encoder failed and the second succeeded. The only > reason I can think of for this to happen is that the options (in > particular the codec whitelist) are not used for the second try > and that

[FFmpeg-devel] [PATCH] fate/ffprobe: Verify ffprobe XML output against schema file

2021-04-16 Thread Tobias Rapp
Adds schema validation for ffprobe XML output so that updating the ffprobe.xsd file upon changes to ffprobe is not forgotten. This was suggested by Marton Balint in: http://ffmpeg.org/pipermail/ffmpeg-devel/2021-March/278428.html The schema FATE test is only run if xmllint command is available.

[FFmpeg-devel] [PATCH] Added bandwidth parameter manual configurare in HLS master playlist

2021-04-16 Thread Dhanish Vijayan
--- libavformat/hlsenc.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 7d97ce1789..957eb609a0 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -183,6 +183,7 @@ typedef struct VariantStream { const char *sgroup;

Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffprobe: Remove check on show_frames and show_packets in XML writer

2021-04-16 Thread Tobias Rapp
On 13.04.2021 08:54, Tobias Rapp wrote: On 31.03.2021 12:13, Tobias Rapp wrote: The "packets_and_frames" element has been added to ffprobe.xsd in 0c9f0da0f7656059e9bd41931d250aafddf35ea3 but apparently removing the check in ffprobe.c has been forgotten. Signed-off-by: Tobias Rapp ---