Re: [FFmpeg-devel] [PATCH] avfilter: add QSV variants of the stack filters

2021-07-18 Thread Xiang, Haihao
On Sun, 2021-07-18 at 11:57 +0800, Linjie Fu wrote: > Hi Haihao, > > On Wed, Jun 9, 2021 at 3:36 PM Haihao Xiang wrote: > > > > Include hstack_qsv, vstack_qsv and xstack_qsv, some code is copy and > > pasted from other filters > > > > Example: > > $> ffmpeg -hwaccel qsv -c:v hevc_qsv -i

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/argo: use bits_per_coded_sample instead of bits_per_raw_sample

2021-07-18 Thread Zane van Iperen
Will apply this and parts 3-8 of part 1 soon. On 18/7/21 7:01 pm, Zane van Iperen wrote: Signed-off-by: Zane van Iperen --- libavcodec/argo.c| 4 ++-- libavcodec/version.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/argo.c b/libavcodec/argo.c index

Re: [FFmpeg-devel] [PATCH V2] avformat/mxf: fixed frame wrapping detection for J2K essence container

2021-07-18 Thread Marton Balint
On Sun, 18 Jul 2021, p...@sandflow.com wrote: From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: For JPEG 2000 essence, the MXF input format module currently uses the value of byte 14 of the essence container UL to determine whether the J2K essence is

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Fix declaration-after-statement warning

2021-07-18 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > What is actually the reason that we stick to this C90 rule? > Is it because of compability with ancient compilers? (Given that we > already require several C99 features, I doubt that there are compilers > which would fail if we

Re: [FFmpeg-devel] [PATCH] mxfdec.c: fixed frame wrapping detection for MXFGCP1FrameWrappedPicture essence container

2021-07-18 Thread Pierre-Anthony Lemieux
Ok. Thanks. Submitted V2 of the patch at: http://ffmpeg.org/pipermail/ffmpeg-devel/2021-July/282414.html On Sun, Jul 18, 2021 at 12:07 AM Marton Balint wrote: > > > > On Sat, 17 Jul 2021, Pierre-Anthony Lemieux wrote: > > > You mean something like this? > > Yes, thanks. > > Marton > > > > >

[FFmpeg-devel] [PATCH V2] avformat/mxf: fixed frame wrapping detection for J2K essence container

2021-07-18 Thread pal
From: Pierre-Anthony Lemieux Signed-off-by: Pierre-Anthony Lemieux --- Notes: For JPEG 2000 essence, the MXF input format module currently uses the value of byte 14 of the essence container UL to determine whether the J2K essence is clip- (byte 14 is 0x02) or frame-wrapped (byte 14

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: Fix declaration-after-statement warning

2021-07-18 Thread Paul B Mahol
LGTM ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: accelerate seeking while reading input at native frame rate

2021-07-18 Thread Linjie Fu
On Sun, Jul 18, 2021 at 8:57 PM Gyan Doshi wrote: > > > > On 2021-07-18 15:37, Linjie Fu wrote: > > On Sun, Jul 18, 2021 at 5:26 PM Gyan Doshi wrote: > >> > >> > >> On 2021-07-18 13:35, Linjie Fu wrote: > >>> On Sun, Jul 18, 2021 at 1:21 PM Gyan Doshi wrote: > > On 2021-07-18 10:42,

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/argo: use bits_per_coded_sample instead of bits_per_raw_sample

2021-07-18 Thread Michael Niedermayer
On Sun, Jul 18, 2021 at 07:01:22PM +1000, Zane van Iperen wrote: > Signed-off-by: Zane van Iperen > --- > libavcodec/argo.c| 4 ++-- > libavcodec/version.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) both patches LGTM thx [...] -- Michael GnuPG fingerprint:

[FFmpeg-devel] [WIP] [RFC] [PATCH] avfilter: add audio psychoacoustic clipper

2021-07-18 Thread Paul B Mahol
Signed-off-by: Paul B Mahol --- doc/filters.texi | 15 + libavfilter/Makefile | 1 + libavfilter/af_apsyclip.c | 645 ++ libavfilter/allfilters.c | 1 + 4 files changed, 662 insertions(+) create mode 100644 libavfilter/af_apsyclip.c diff

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/argo: use pixel format provided by the demuxer

2021-07-18 Thread Zane van Iperen
On 18/7/21 11:18 pm, James Almer wrote: On 7/17/2021 10:21 PM, Zane van Iperen wrote: But fall back to bits_per_raw_sample, in case we're with older libavformat. What older libavformat? We bumped major version a few months ago, so you can't link git head lavc with lavf <= 58. Or is this

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/argo: use pixel format provided by the demuxer

2021-07-18 Thread James Almer
On 7/17/2021 10:21 PM, Zane van Iperen wrote: But fall back to bits_per_raw_sample, in case we're with older libavformat. What older libavformat? We bumped major version a few months ago, so you can't link git head lavc with lavf <= 58. Or is this about changes in the following patches? If

Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: accelerate seeking while reading input at native frame rate

2021-07-18 Thread Gyan Doshi
On 2021-07-18 15:37, Linjie Fu wrote: On Sun, Jul 18, 2021 at 5:26 PM Gyan Doshi wrote: On 2021-07-18 13:35, Linjie Fu wrote: On Sun, Jul 18, 2021 at 1:21 PM Gyan Doshi wrote: On 2021-07-18 10:42, Linjie Fu wrote: Hi Gyan, On Sun, Jul 18, 2021 at 12:24 PM Gyan Doshi wrote: On

[FFmpeg-devel] [PATCH] avformat/movenc: Fix tfdt out of sync

2021-07-18 Thread Hu Weiwen
Fix an edge case when auto flushing an empty fragment, and the previous fragment has inaccurate duration, the track->frag_start would be out of sync from input dts, and all subsequent tfdt box will have out of sync base_media_decode_time. This error can accumulate to quite large over long-running

Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: accelerate seeking while reading input at native frame rate

2021-07-18 Thread Linjie Fu
On Sun, Jul 18, 2021 at 5:26 PM Gyan Doshi wrote: > > > > On 2021-07-18 13:35, Linjie Fu wrote: > > On Sun, Jul 18, 2021 at 1:21 PM Gyan Doshi wrote: > >> > >> > >> On 2021-07-18 10:42, Linjie Fu wrote: > >>> Hi Gyan, > >>> On Sun, Jul 18, 2021 at 12:24 PM Gyan Doshi wrote: > > On

Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: accelerate seeking while reading input at native frame rate

2021-07-18 Thread Gyan Doshi
On 2021-07-18 13:35, Linjie Fu wrote: On Sun, Jul 18, 2021 at 1:21 PM Gyan Doshi wrote: On 2021-07-18 10:42, Linjie Fu wrote: Hi Gyan, On Sun, Jul 18, 2021 at 12:24 PM Gyan Doshi wrote: On 2021-07-18 09:32, Linjie Fu wrote: On Wed, Jul 7, 2021 at 9:42 AM Linjie Fu wrote: On Sun,

Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg: accelerate seeking while reading input at native frame rate

2021-07-18 Thread Linjie Fu
On Sun, Jul 18, 2021 at 1:21 PM Gyan Doshi wrote: > > > > On 2021-07-18 10:42, Linjie Fu wrote: > > Hi Gyan, > > On Sun, Jul 18, 2021 at 12:24 PM Gyan Doshi wrote: > >> > >> > >> On 2021-07-18 09:32, Linjie Fu wrote: > >>> On Wed, Jul 7, 2021 at 9:42 AM Linjie Fu > >>> wrote: > On Sun,

[FFmpeg-devel] [PATCH 2/2] avformat/argo_brp: use bits_per_coded_sample instead of bits_per_raw_sample

2021-07-18 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_brp.c | 2 +- libavformat/version.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/argo_brp.c b/libavformat/argo_brp.c index 059418cd1d..2ccdbd3e5b 100644 --- a/libavformat/argo_brp.c +++

[FFmpeg-devel] [PATCH 1/2] avcodec/argo: use bits_per_coded_sample instead of bits_per_raw_sample

2021-07-18 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/argo.c| 4 ++-- libavcodec/version.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/argo.c b/libavcodec/argo.c index 87c646f56c..057100bd12 100644 --- a/libavcodec/argo.c +++ b/libavcodec/argo.c @@ -676,12

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/argo: use pixel format provided by the demuxer

2021-07-18 Thread Paul B Mahol
On Sun, Jul 18, 2021 at 10:35 AM Zane van Iperen wrote: > > I really doubt this is correct approach. No other video decoder use pix > > format set from demuxer. > > > > I could change it to use bits_per_coded_sample instead, would that be > better? > I see that's what Cinepak does. > > Probably,

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/argo: use pixel format provided by the demuxer

2021-07-18 Thread Zane van Iperen
I really doubt this is correct approach. No other video decoder use pix format set from demuxer. I could change it to use bits_per_coded_sample instead, would that be better? I see that's what Cinepak does. Zane ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 1/8] avcodec/argo: use pixel format provided by the demuxer

2021-07-18 Thread Paul B Mahol
On Sun, Jul 18, 2021 at 3:22 AM Zane van Iperen wrote: > But fall back to bits_per_raw_sample, in case we're with older > libavformat. > > Signed-off-by: Zane van Iperen > --- > libavcodec/argo.c| 21 ++--- > libavcodec/version.h | 2 +- > 2 files changed, 15

Re: [FFmpeg-devel] [PATCH] mxfdec.c: fixed frame wrapping detection for MXFGCP1FrameWrappedPicture essence container

2021-07-18 Thread Marton Balint
On Sat, 17 Jul 2021, Pierre-Anthony Lemieux wrote: You mean something like this? Yes, thanks. Marton diff --git a/libavformat/mxf.h b/libavformat/mxf.h index ca510f5a2f..b9fe7fe7ef 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -76,7 +76,7 @@ typedef enum { D10D11Wrap,