Re: [FFmpeg-devel] [PATCH] avfilter: add (a)segment filters

2021-08-08 Thread Nicolas George
I intend to look at this today. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with

Re: [FFmpeg-devel] [PATCH] configure: add initial RISC-V support

2021-08-08 Thread Brad Smith
ping. On 7/25/2021 6:31 PM, Brad Smith wrote: OpenBSD only supports riscv64 but this is an attempt at adding some of the initial bits for RISC-V support. diff --git a/configure b/configure index b3b8065188..8b5edaa01e 100755 --- a/configure +++ b/configure @@ -2021,6 +2021,7 @@ ARCH_LIST="

Re: [FFmpeg-devel] [PATCH 07/10] sws: add a new scaling API

2021-08-08 Thread James Almer
On 8/8/2021 2:29 PM, Anton Khirnov wrote: +int sws_frame_start(struct SwsContext *c, AVFrame *dst, const AVFrame *src) +{ +int ret, allocated = 0; + +ret = av_frame_ref(c->frame_src, src); +if (ret < 0) +return ret; + +if (!dst->buf[0]) { The frame could have non

Re: [FFmpeg-devel] [PATCH v3 2/2] Add time logging flags to docs

2021-08-08 Thread Gyan Doshi
On 2021-08-09 06:17 am, Soft Works wrote: Signed-off-by: softworkz --- doc/fftools-common-opts.texi | 4 1 file changed, 4 insertions(+) diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi index 7643dd8396..483a50d8e9 100644 --- a/doc/fftools-common-opts.texi

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvence: Use QSV encoder defaults as ffmpeg defaults

2021-08-08 Thread Xiang, Haihao
On Sat, 2021-08-07 at 03:50 +, Soft Works wrote: > Signed-off-by: softworkz > --- > libavcodec/qsvenc.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/qsvenc.h b/libavcodec/qsvenc.h > index fc8a14143e..7f729ce2ba 100644 > --- a/libavcodec/qsvenc.h >

[FFmpeg-devel] [PATCH v4 2/2] fftools: Add option to log timing

2021-08-08 Thread Soft Works
This commit adds two logging flags: 'timing' and 'datetiming'. Usage: ffmpeg -loglevel +timing or ffmpeg -loglevel +datetiming Signed-off-by: softworkz --- doc/fftools-common-opts.texi | 4 fftools/cmdutils.c | 14 ++ fftools/ffmpeg.c | 6 +- 3

[FFmpeg-devel] [PATCH v4 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time

2021-08-08 Thread Soft Works
Signed-off-by: softworkz --- v2: split commits differently, fix AVBPrint finalization doc/APIchanges | 3 +++ libavutil/log.c | 33 ++--- libavutil/log.h | 10 ++ libavutil/version.h | 2 +- 4 files changed, 44 insertions(+), 4 deletions(-)

Re: [FFmpeg-devel] [PATCH v2 4/4] avdevice/decklink: support for more duplex mode for Decklink 8K Pro

2021-08-08 Thread lance . lmwang
On Sat, Aug 07, 2021 at 08:02:05PM +0200, Marton Balint wrote: > > > On Fri, 6 Aug 2021, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/indevs.texi | 16 +++- > > doc/outdevs.texi| 16

Re: [FFmpeg-devel] [PATCH v3 1/2] Add option to log timing

2021-08-08 Thread Andreas Rheinhardt
Soft Works: >> -Original Message- >> From: ffmpeg-devel On Behalf Of >> Andreas Rheinhardt >> Sent: Monday, 9 August 2021 03:11 >> To: ffmpeg-devel@ffmpeg.org >> Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] Add option to log timing >> >> Soft Works: >>> This commit adds two logging flags:

Re: [FFmpeg-devel] [PATCH v3 1/2] Add option to log timing

2021-08-08 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Andreas Rheinhardt > Sent: Monday, 9 August 2021 03:11 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] Add option to log timing > > Soft Works: > > This commit adds two logging flags: 'timing' and

[FFmpeg-devel] [PATCH] avutil/twofish: Fixed decryption

2021-08-08 Thread Sebastian Kirmayer
The previous implementation swapped the two halves of the plaintext. The existing tests only decrypted data with a plaintext of all zeroes, which is not affected by swapping the halves. Tests which detect the old buggy behavior have been added. Signed-off-by: Sebastian Kirmayer ---

Re: [FFmpeg-devel] [PATCH v2 3/4] avdevice/decklink: add levelA configure

2021-08-08 Thread lance . lmwang
On Sat, Aug 07, 2021 at 07:27:22PM +0200, Marton Balint wrote: > > > On Fri, 6 Aug 2021, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > just rebase the code to the master branch to fix the first warning. > > > > doc/outdevs.texi

Re: [FFmpeg-devel] [PATCH v2 1/4] avdevice/decklink: add link configuration

2021-08-08 Thread lance . lmwang
On Sat, Aug 07, 2021 at 07:09:01PM +0200, Marton Balint wrote: > > > On Fri, 6 Aug 2021, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/outdevs.texi| 5 + > > libavdevice/decklink_common.cpp | 9 + > >

Re: [FFmpeg-devel] [PATCH v2 2/4] avdevice/decklink: add sqd configure

2021-08-08 Thread lance . lmwang
On Sat, Aug 07, 2021 at 07:22:45PM +0200, Marton Balint wrote: > > > On Fri, 6 Aug 2021, lance.lmw...@gmail.com wrote: > > > From: Limin Wang > > > > Signed-off-by: Limin Wang > > --- > > doc/outdevs.texi| 4 > > libavdevice/decklink_common.cpp | 11 +++ > >

Re: [FFmpeg-devel] [PATCH v3 1/2] Add option to log timing

2021-08-08 Thread Andreas Rheinhardt
Soft Works: > This commit adds two logging flags: 'timing' and 'datetiming'. > > Usage: > > ffmpeg -loglevel +timing > > or > > ffmpeg -loglevel +datetiming > > Signed-off-by: softworkz > (cherry picked from commit 960c82cede25c21bcea478b26309691fdc7fcec7) > (cherry picked from commit

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264_picture: add ff_h264_replace_picture()

2021-08-08 Thread James Almer
On 8/8/2021 9:34 PM, Andreas Rheinhardt wrote: James Almer: On 8/8/2021 8:16 PM, Andreas Rheinhardt wrote: James Almer: Will remove unnecessary allocations when both src and dst picture contain references to the same buffers. Signed-off-by: James Almer ---   libavcodec/h264_picture.c | 45

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264_picture: add ff_h264_replace_picture()

2021-08-08 Thread Andreas Rheinhardt
James Almer: > On 8/8/2021 8:16 PM, Andreas Rheinhardt wrote: >> James Almer: >>> Will remove unnecessary allocations when both src and dst picture >>> contain >>> references to the same buffers. >>> >>> Signed-off-by: James Almer >>> --- >>>   libavcodec/h264_picture.c | 45

[FFmpeg-devel] [PATCH v3 2/2] Add time logging flags to docs

2021-08-08 Thread Soft Works
Signed-off-by: softworkz --- doc/fftools-common-opts.texi | 4 1 file changed, 4 insertions(+) diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi index 7643dd8396..483a50d8e9 100644 --- a/doc/fftools-common-opts.texi +++ b/doc/fftools-common-opts.texi @@ -198,6

[FFmpeg-devel] [PATCH v3 1/2] Add option to log timing

2021-08-08 Thread Soft Works
This commit adds two logging flags: 'timing' and 'datetiming'. Usage: ffmpeg -loglevel +timing or ffmpeg -loglevel +datetiming Signed-off-by: softworkz (cherry picked from commit 960c82cede25c21bcea478b26309691fdc7fcec7) (cherry picked from commit 0851f36f5ecead61317a1ce631facdacae76d886)

[FFmpeg-devel] [PATCH v2] libavformat/asfdec: A collection of related fixes for asfdec

2021-08-08 Thread Soft Works
Fix 1: Commit c8140fe7324f264faacf7395b27e12531d1f13f7 had introduced a check for value_len > UINT16_MAX. As a consequence, attached images of sizes larger than UINT16_MAX could no longer be read. Fix 2: The value_len is an uint32 not an int32 per spec. That value must not be truncated,

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264_picture: add ff_h264_replace_picture()

2021-08-08 Thread James Almer
On 8/8/2021 8:16 PM, Andreas Rheinhardt wrote: James Almer: Will remove unnecessary allocations when both src and dst picture contain references to the same buffers. Signed-off-by: James Almer --- libavcodec/h264_picture.c | 45 +++ libavcodec/h264dec.h

[FFmpeg-devel] [PATCH] libavformat/asfdec: A collection of related fixes for asfdec

2021-08-08 Thread Soft Works
Fix 1: Commit c8140fe7324f264faacf7395b27e12531d1f13f7 had introduced a check for value_len > UINT16_MAX. As a consequence, attached images of sizes larger than UINT16_MAX could no longer be read. Fix 2: The value_len is an uint32 not an int32 per spec. That value must not be truncated,

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/h264_slice: use ff_h264_replace_picture when updating thread contexts

2021-08-08 Thread James Almer
On 8/8/2021 8:22 PM, Andreas Rheinhardt wrote: James Almer: Signed-off-by: James Almer --- libavcodec/h264_slice.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index a31e804620..0d7107d455 100644 ---

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/h264_picture: add ff_h264_replace_picture()

2021-08-08 Thread Andreas Rheinhardt
James Almer: > Will remove unnecessary allocations when both src and dst picture contain > references to the same buffers. > > Signed-off-by: James Almer > --- > libavcodec/h264_picture.c | 45 +++ > libavcodec/h264dec.h | 1 + > 2 files changed, 46

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/h264_slice: use ff_h264_replace_picture when updating thread contexts

2021-08-08 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > libavcodec/h264_slice.c | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c > index a31e804620..0d7107d455 100644 > --- a/libavcodec/h264_slice.c > +++

[FFmpeg-devel] [PATCH 3/3] avcodec/h264_slice: use ff_h264_replace_picture when updating thread contexts

2021-08-08 Thread James Almer
Signed-off-by: James Almer --- libavcodec/h264_slice.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c index a31e804620..0d7107d455 100644 --- a/libavcodec/h264_slice.c +++ b/libavcodec/h264_slice.c @@ -379,19

[FFmpeg-devel] [PATCH 2/3] avcodec/h264_picture: add ff_h264_replace_picture()

2021-08-08 Thread James Almer
Will remove unnecessary allocations when both src and dst picture contain references to the same buffers. Signed-off-by: James Almer --- libavcodec/h264_picture.c | 45 +++ libavcodec/h264dec.h | 1 + 2 files changed, 46 insertions(+) diff --git

[FFmpeg-devel] [PATCH 1/3] avcodec/h264_picture: split copying some H264Picture fields into a separate function

2021-08-08 Thread James Almer
Signed-off-by: James Almer --- libavcodec/h264_picture.c | 57 ++- 1 file changed, 33 insertions(+), 24 deletions(-) diff --git a/libavcodec/h264_picture.c b/libavcodec/h264_picture.c index eec5e9fb9a..89aef37edd 100644 --- a/libavcodec/h264_picture.c +++

Re: [FFmpeg-devel] [PATCH 01/10] ffmpeg: reset the dict iterator before use

2021-08-08 Thread James Almer
On 8/8/2021 2:29 PM, Anton Khirnov wrote: --- fftools/ffmpeg_filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 49076f13ee..b252ee4138 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -971,6 +971,7 @@ int

Re: [FFmpeg-devel] [PATCH] aarch64: h264dsp: Fix indentation of some functions to match the rest

2021-08-08 Thread Martin Storsjö
On Thu, 5 Aug 2021, Martin Storsjö wrote: Signed-off-by: Martin Storsjö --- libavcodec/aarch64/h264dsp_neon.S | 520 +++--- 1 file changed, 260 insertions(+), 260 deletions(-) Pushed this one too. // Martin ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] aarch64: h264dsp: Remove unnecessary sign extensions

2021-08-08 Thread Martin Storsjö
On Thu, 5 Aug 2021, Martin Storsjö wrote: These became unnecessary when the stride arguments were changed from int to ptrdiff_t in bc26fe89275c267d169b468356c82ee59874407d (0576ef466d8a631326d1d0a5ec2e4c4c81d25353) and d5d699ab6e6f8a8290748d107416fd5c19757a1b

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: make MXFMetadataSet part of all metadata sets

2021-08-08 Thread Marton Balint
On Mon, 2 Aug 2021, Tomas Härdin wrote: sön 2021-08-01 klockan 03:55 +0200 skrev Marton Balint: The code expects every kind of metadata set to start with the generic metadata set attributes. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 66

Re: [FFmpeg-devel] [PATCH v2] avcodec/mpeg12dec: report error when picture type is unknown and err_detect is EXPLODE

2021-08-08 Thread Marton Balint
On Sun, 8 Aug 2021, Michael Niedermayer wrote: On Sat, Aug 07, 2021 at 08:32:35PM +0200, Marton Balint wrote: On Sat, 7 Aug 2021, Michael Niedermayer wrote: On Sat, Aug 07, 2021 at 09:21:36AM +0200, Marton Balint wrote: On Fri, 6 Aug 2021, Michael Niedermayer wrote: On Mon, Aug 02,

[FFmpeg-devel] [PATCH 1/2] avcodec/vc1dec: ff_print_debug_info() does not support WMV3 field_mode

2021-08-08 Thread Michael Niedermayer
Fixes: out of array read Fixes: 36331/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WMV3_fuzzer-5140494328922112.fuzz Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vc1dec.c | 6 --

[FFmpeg-devel] [PATCH 2/2] avcodec/h264dec: use picture parameters in ff_print_debug_info2()

2021-08-08 Thread Michael Niedermayer
Fixes: out of array read Fixes: 36341/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-6737583085322240 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/h264dec.c | 2 +- 1 file

Re: [FFmpeg-devel] How to correctly handle Matroska timestamps

2021-08-08 Thread MattKC
Follow up: I appear to have solved this and have some further information which may be useful. TL;DR: Setting AVStream's avg_frame_rate, which corresponds to mkvinfo's "Default duration" field, appears to have fixed this. From my investigation, it appears VLC will use a few different sources

Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image attachments

2021-08-08 Thread Carl Eugen Hoyos
Am So., 8. Aug. 2021 um 03:40 Uhr schrieb Soft Works : > When I do this: > > if (value_len < 0 || value_len >= (INT_MAX - LEN) / 2) > return AVERROR_INVALIDDATA; > > Shouldn't we return a different error code? Actually this is not about invalid > data but about a limitation in

[FFmpeg-devel] [PATCH] avcodec/h264_slice: clear old slice POC values on parsing failure

2021-08-08 Thread James Almer
If a slice header fails to parse, and the next one uses different Sequence and Picture parameter sets, certain values may not be read if they are not coded, resulting in the previous slice values being used. Signed-off-by: James Almer --- libavcodec/h264_slice.c | 3 +++ 1 file changed, 3

Re: [FFmpeg-devel] [PATCH 06/10] lavu/slicethread: return ENOSYS rather than EINVAL in the dummy func

2021-08-08 Thread Andreas Rheinhardt
Anton Khirnov: > EINVAL is the wrong error code here, since the arguments passed to the > function are valid. The error is that the function is not implemented in > the build, which corresponds to ENOSYS. > --- > libavutil/slicethread.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [FFmpeg-devel] [PATCH 02/10] ffmpeg_filter: do not override -filter_threads with -threads

2021-08-08 Thread Paul B Mahol
lgtm ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 09/10] sws: implement slice threading

2021-08-08 Thread Anton Khirnov
--- libswscale/options.c | 3 ++ libswscale/swscale.c | 56 libswscale/swscale_internal.h | 14 ++ libswscale/utils.c| 82 +++ 4 files changed, 155 insertions(+) diff --git a/libswscale/options.c

[FFmpeg-devel] [PATCH 07/10] sws: add a new scaling API

2021-08-08 Thread Anton Khirnov
--- libswscale/swscale.c | 280 ++ libswscale/swscale.h | 80 ++ libswscale/swscale_internal.h | 19 +++ libswscale/utils.c| 70 + 4 files changed, 386 insertions(+), 63 deletions(-) diff --git

[FFmpeg-devel] [PATCH 08/10] lavfi/vf_scale: convert to the frame-based sws API

2021-08-08 Thread Anton Khirnov
--- libavfilter/vf_scale.c | 73 -- 1 file changed, 49 insertions(+), 24 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index 7e70665cdd..b62fb37d4b 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -619,29

[FFmpeg-devel] [PATCH 10/10] lavfi/vf_scale: pass the thread count to the scaler

2021-08-08 Thread Anton Khirnov
--- libavfilter/vf_scale.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index b62fb37d4b..14e202bf77 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -542,6 +542,7 @@ static int config_props(AVFilterLink *outlink)

[FFmpeg-devel] [PATCH 06/10] lavu/slicethread: return ENOSYS rather than EINVAL in the dummy func

2021-08-08 Thread Anton Khirnov
EINVAL is the wrong error code here, since the arguments passed to the function are valid. The error is that the function is not implemented in the build, which corresponds to ENOSYS. --- libavutil/slicethread.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH 05/10] lavfi/vf_scale: remove the nb_slices option

2021-08-08 Thread Anton Khirnov
It was intended for debugging only and has been superseded by the standalone tool for testing sliced scaling. --- libavfilter/vf_scale.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index aa855b894a..7e70665cdd 100644 ---

[FFmpeg-devel] [PATCH 03/10] FATE: allow multithreaded filtering

2021-08-08 Thread Anton Khirnov
--- tests/fate-run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index cd16f5fcff..bc1efa22d7 100755 --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -279,7 +279,7 @@ echov(){ echo "$@" >&3 } -AVCONV_OPTS="-nostdin -nostats

[FFmpeg-devel] [PATCH 04/10] fate/pixfmt: test xyz12le

2021-08-08 Thread Anton Khirnov
--- tests/fate/pixfmt.mak| 1 + tests/ref/pixfmt/xyz12le | 2 ++ 2 files changed, 3 insertions(+) create mode 100644 tests/ref/pixfmt/xyz12le diff --git a/tests/fate/pixfmt.mak b/tests/fate/pixfmt.mak index 46fd888ac9..715a4763d4 100644 --- a/tests/fate/pixfmt.mak +++

[FFmpeg-devel] [PATCH 01/10] ffmpeg: reset the dict iterator before use

2021-08-08 Thread Anton Khirnov
--- fftools/ffmpeg_filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 49076f13ee..b252ee4138 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -971,6 +971,7 @@ int configure_filtergraph(FilterGraph *fg)

[FFmpeg-devel] [PATCH 02/10] ffmpeg_filter: do not override -filter_threads with -threads

2021-08-08 Thread Anton Khirnov
When both -filter_threads and -threads are specified, the latter takes effect. Since -threads is an encoder option and -filter_threads is a filter option, it makes sense for the -filter_threads to take precedence. --- fftools/ffmpeg_filter.c | 9 + 1 file changed, 5 insertions(+), 4

[FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-08 Thread Nicolas George
Hi. Here is a patch series for fateserver, to fix warnings and enable Perl's taint checks, thus protecting against a whole class of security issues. There would be more work to make this really clean, but I need to wait for my ISP to fix its crap before I can do it comfortably. If it looks to

Re: [FFmpeg-devel] [PATCH 2/3] lavfi/vf_scale: dump the exact swscale_options to passed to libswscale

2021-08-08 Thread Linjie Fu
On Sat, Aug 7, 2021 at 9:12 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Linjie Fu: > > From: Linjie Fu > > > > Printed verbose log doesn't match the sws_flags specified in the cmdline > > for simple filter graph. > > > > ffmpeg .. -sws_flags bicubic .. > > [auto_scaler_0]

Re: [FFmpeg-devel] [PATCH v2] avcodec/mpeg12dec: report error when picture type is unknown and err_detect is EXPLODE

2021-08-08 Thread Michael Niedermayer
On Sat, Aug 07, 2021 at 08:32:35PM +0200, Marton Balint wrote: > > > On Sat, 7 Aug 2021, Michael Niedermayer wrote: > > > On Sat, Aug 07, 2021 at 09:21:36AM +0200, Marton Balint wrote: > > > > > > > > > On Fri, 6 Aug 2021, Michael Niedermayer wrote: > > > > > > > On Mon, Aug 02, 2021 at

Re: [FFmpeg-devel] [PATCH 2/2] report.cgi: Clean chars in time and slot

2021-08-08 Thread Michael Niedermayer
On Sun, Aug 08, 2021 at 01:00:30PM +0100, Derek Buitenhuis wrote: > On 8/8/2021 9:28 AM, Michael Niedermayer wrote: > > +$req_slot =~ s/[^-._A-Za-z0-9 ]*//g; > > I don't think it is wise to allow periods here, considering > we use string ops to append it to a dir name just below. Periods are

Re: [FFmpeg-devel] [PATCH 2/2] report.cgi: Clean chars in time and slot

2021-08-08 Thread Derek Buitenhuis
On 8/8/2021 9:28 AM, Michael Niedermayer wrote: > +$req_slot =~ s/[^-._A-Za-z0-9 ]*//g; I don't think it is wise to allow periods here, considering we use string ops to append it to a dir name just below. .. and we probably should not be using string ops to construct directory names. >

Re: [FFmpeg-devel] [PATCH] fftools/cmdutils: don't print build configuration by default

2021-08-08 Thread Stephen Hutchinson
On 8/8/2021 12:31 AM, Gyan Doshi wrote: On 2021-08-06 11:34 pm, James Almer wrote: From: Matthieu Patou Suggested-by: ffm...@fb.com Signed-off-by: James Almer ---   fftools/cmdutils.c | 5 +++--   1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fftools/cmdutils.c

Re: [FFmpeg-devel] [PATCH 3/3] libavfilter/graphparser: Add scale_sws_opts parse support in avfilter_graph_parse2

2021-08-08 Thread Linjie Fu
Andreas: On Sat, Aug 7, 2021 at 9:52 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Linjie Fu: > > From: Linjie Fu > > > > To pass the swscale options for the inserted scalers. > > > > ffmpeg -i input.mp4 -filter_complex \ > >

[FFmpeg-devel] [PATCH v3 8/9] [GSoC] lavfi/dnn_backend_tf: Error Handling for tf_create_inference_request

2021-08-08 Thread Shubhanshu Saxena
This commit includes the check for the case when the newly created TFInferRequest is NULL. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_tf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter/dnn/dnn_backend_tf.c b/libavfilter/dnn/dnn_backend_tf.c index

[FFmpeg-devel] [PATCH v3 7/9] [GSoC] lavfi/dnn: Extract Common Parts from get_output functions

2021-08-08 Thread Shubhanshu Saxena
The frame allocation and filling the TaskItem with execution parameters is common in the three backends. This commit shifts this logic to dnn_backend_common. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_common.c | 26 + libavfilter/dnn/dnn_backend_common.h |

[FFmpeg-devel] [PATCH v3 9/9] [GSoC] lavfi/dnn: DNNAsyncExecModule Execution Failure Handling

2021-08-08 Thread Shubhanshu Saxena
This commit adds the case handling if the asynchronous execution of a request fails by checking the exit status of the thread when joining before starting another execution. On failure, it does the cleanup as well. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_common.c | 23

[FFmpeg-devel] [PATCH v3 6/9] [GSoC] lavfi/dnn_backend_tf: Add TF_Status to TFRequestItem

2021-08-08 Thread Shubhanshu Saxena
Since requests are running in parallel, there is inconsistency in the status of the execution. To resolve it, we avoid using mutex as it would result in single TF_Session running at a time. So add TF_Status to the TFRequestItem Signed-off-by: Shubhanshu Saxena ---

[FFmpeg-devel] [PATCH v3 5/9] [GSoC] lavfi/dnn_backend_tf: Error Handling for execute_model_tf

2021-08-08 Thread Shubhanshu Saxena
This patch adds error handling for cases where the execute_model_tf fails, clears the used memory in the TFRequestItem and finally pushes it back to the request queue. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_tf.c | 52 ++-- 1 file changed, 36

[FFmpeg-devel] [PATCH v3 4/9] [GSoC] lavfi/dnn: Async Support for TensorFlow Backend

2021-08-08 Thread Shubhanshu Saxena
This commit enables async execution in the TensorFlow backend and adds function to flush extra frames. The async execution mechanism executes the TFInferRequests on a separate thread which is joined before the next execution of same TFRequestItem/while freeing the model. The following is the

[FFmpeg-devel] [PATCH v3 3/9] [GSoC] lavfi/dnn_backend_tf: TFInferRequest Execution and Documentation

2021-08-08 Thread Shubhanshu Saxena
This commit adds a function for execution of TFInferRequest and documentation for functions related to TFInferRequest. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_tf.c | 45 1 file changed, 45 insertions(+) diff --git

[FFmpeg-devel] [PATCH v3 2/9] [GSoC] lavfi/dnn: Common Function to Get Async Result in DNN Backends

2021-08-08 Thread Shubhanshu Saxena
This commits refactors the get async result function for common use in all three backends. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_common.c | 20 libavfilter/dnn/dnn_backend_common.h | 15 +++ libavfilter/dnn/dnn_backend_openvino.c |

[FFmpeg-devel] [PATCH v3 1/9] [GSoC] lavfi/dnn: Add Async Execution Mechanism and Documentation

2021-08-08 Thread Shubhanshu Saxena
This commit adds an async execution mechanism for common use in the TensorFlow and Native backends. This commit also adds the documentation of typedefs and functions in the async module for common use in DNN backends. Signed-off-by: Shubhanshu Saxena --- libavfilter/dnn/dnn_backend_common.c |

[FFmpeg-devel] fateserver

2021-08-08 Thread Michael Niedermayer
Hi all on 8 Aug 2021 08:02:54 +0200 janne informed ffmpeg-security about a arbitrary code execution vulnerability in the fateserver code in both libav and ffmpeg. From the log janne showed us it was apparently used by someone yesterday to attempt to run sudo i did shutdown apache on

[FFmpeg-devel] [PATCH 1/2] report: fail if the report does not exists

2021-08-08 Thread Michael Niedermayer
From: Janne Grunau --- report.cgi | 1 + 1 file changed, 1 insertion(+) diff --git a/report.cgi b/report.cgi index a980617..43ea134 100755 --- a/report.cgi +++ b/report.cgi @@ -30,6 +30,7 @@ my $slotdir = "$fatedir/$req_slot"; my $repdir = "$slotdir/$req_time"; my $report =

[FFmpeg-devel] [PATCH 2/2] report.cgi: Clean chars in time and slot

2021-08-08 Thread Michael Niedermayer
based on a39e4d1bee74647f534589b09eaf15246359d6b6 Signed-off-by: Michael Niedermayer --- report.cgi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/report.cgi b/report.cgi index 43ea134..5c457ac 100755 --- a/report.cgi +++ b/report.cgi @@ -25,6 +25,8 @@ use FATE; my $req_slot = param