Re: [FFmpeg-devel] [RFC] Switching ffmpeg.c to a threaded architecture

2022-04-13 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Nicolas George > Sent: Wednesday, April 13, 2022 11:43 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [RFC] Switching ffmpeg.c to a threaded > architecture > > Soft Works

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-04-13 Thread Vignesh Venkatasubramanian
On Wed, Apr 13, 2022 at 2:04 PM Andreas Rheinhardt wrote: > > Vignesh Venkatasubramanian: > > On Mon, Mar 21, 2022 at 1:46 PM Andreas Rheinhardt > > wrote: > >> > >> Vignesh Venkatasubramanian: > >>> Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > >>> > >>> AVIF Specifiation:

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-04-13 Thread Vignesh Venkatasubramanian
On Wed, Apr 13, 2022 at 2:01 PM Andreas Rheinhardt wrote: > > Vignesh Venkatasubramanian: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > AVIF Specification: https://aomediacodec.github.io/av1-avif > > > > Sample usage for still image: > > ffmpeg -i image.png -c:v

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-04-13 Thread Andreas Rheinhardt
Vignesh Venkatasubramanian: > On Mon, Mar 21, 2022 at 1:46 PM Andreas Rheinhardt > wrote: >> >> Vignesh Venkatasubramanian: >>> Add an AVIF muxer by re-using the existing the mov/mp4 muxer. >>> >>> AVIF Specifiation: https://aomediacodec.github.io/av1-avif >>> >>> Sample usage for still image:

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-04-13 Thread Andreas Rheinhardt
Vignesh Venkatasubramanian: > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > AVIF Specification: https://aomediacodec.github.io/av1-avif > > Sample usage for still image: > ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif > > Sample usage for animated AVIF image:

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-04-13 Thread Vignesh Venkatasubramanian
On Wed, Apr 13, 2022 at 10:22 AM James Zern wrote: > > On Mon, Mar 28, 2022 at 1:49 PM Vignesh Venkatasubramanian > wrote: > > > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > > > > Specification > Fixed. > >

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-04-13 Thread Vignesh Venkatasubramanian
Add an AVIF muxer by re-using the existing the mov/mp4 muxer. AVIF Specification: https://aomediacodec.github.io/av1-avif Sample usage for still image: ffmpeg -i image.png -c:v libaom-av1 -avif-image 1 image.avif Sample usage for animated AVIF image: ffmpeg -i video.mp4 animated.avif We can

[FFmpeg-devel] [PATCH 2/3] avformat/av1: Add a parameter to av1c to omit seq header

2022-04-13 Thread Vignesh Venkatasubramanian
Add a parameter to omit seq header when generating the av1C atom. For now, this does not change any behavior. This will be used by a follow-up patch to add AVIF support. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/av1.c | 7 +-- libavformat/av1.h | 4 +++-

[FFmpeg-devel] [PATCH 1/3] avcodec/libaomenc: Add parameter for avif single image encoding

2022-04-13 Thread Vignesh Venkatasubramanian
Add a parameter to libaom-av1 encoder to enforce some of the single image constraints in the AV1 encoder. Setting this flag will limit the encoder to producing exactly one frame and the sequence header that is produced by the encoder will be conformant to the AVIF specification [1]. Part of

Re: [FFmpeg-devel] [PATCH 1/1] librtmp: use AVBPrint instead of char *

2022-04-13 Thread Martin Storsjö
On Wed, 13 Apr 2022, Marton Balint wrote: On Wed, 13 Apr 2022, Martin Storsjö wrote: On Mon, 11 Apr 2022, Tristan Matthews wrote: This avoids having to do one pass to calculate the full length to allocate followed by a second pass to actually append values. --- libavformat/librtmp.c

Re: [FFmpeg-devel] [PATCH 1/1] librtmp: use AVBPrint instead of char *

2022-04-13 Thread Marton Balint
On Wed, 13 Apr 2022, Martin Storsjö wrote: On Mon, 11 Apr 2022, Tristan Matthews wrote: This avoids having to do one pass to calculate the full length to allocate followed by a second pass to actually append values. --- libavformat/librtmp.c | 123

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-04-13 Thread James Zern
On Mon, Mar 28, 2022 at 1:49 PM Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > Specification > Sample usage for still image: > ffmpeg -i image.png -c:v libaom-av1 -avif-image 1

[FFmpeg-devel] [PATCH 2/2] avdevice/dshow: silence warnings about unused variable

2022-04-13 Thread James Almer
Use av_unused instead of wrapping the declaration under the DSHOWDEBUG check in case future changes make use of it. Signed-off-by: James Almer --- libavdevice/dshow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index

[FFmpeg-devel] [PATCH 1/2] avdevice/dshow: remove unused variables

2022-04-13 Thread James Almer
Remnant from f125c504d8fece6420bb97767f9e72414c26312a Signed-off-by: James Almer --- libavdevice/dshow.c | 8 1 file changed, 8 deletions(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index 1e69620880..ac8b64366f 100644 --- a/libavdevice/dshow.c +++ b/libavdevice/dshow.c

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/avcodec: Don't reset decoder-fields for encoders when flushing

2022-04-13 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-04-13 17:58:08) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2022-04-13 16:49:51) > >> - > >> -avctx->pts_correction_last_pts = > >> -avctx->pts_correction_last_dts = INT64_MIN; > >> - > >> -if (avci->bsf) > > > > did you drop this check on

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/avcodec: Don't reset decoder-fields for encoders when flushing

2022-04-13 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2022-04-13 16:49:51) >> Signed-off-by: Andreas Rheinhardt >> --- >> Needs to be applied before >> https://ffmpeg.org/pipermail/ffmpeg-devel/2022-March/294507.html >> or flushing an encoder will segfault. >> Btw: All this stuff is unused by subtitle

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/encode: Fix check for encoders impl. encode-simple API

2022-04-13 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-04-13 16:43:28) > FFCodec.cb is a union. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/encode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/encode.c b/libavcodec/encode.c > index 6ae47b736c..e7ae2cd4c1 100644 >

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/avcodec: Don't reset decoder-fields for encoders when flushing

2022-04-13 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2022-04-13 16:49:51) > Signed-off-by: Andreas Rheinhardt > --- > Needs to be applied before > https://ffmpeg.org/pipermail/ffmpeg-devel/2022-March/294507.html > or flushing an encoder will segfault. > Btw: All this stuff is unused by subtitle decoders, > so one could

[FFmpeg-devel] Audiotoolbox fix missing decoder out properties

2022-04-13 Thread MCC CS
This is a repost of the patch by Chris Snowhill who originally sent this patch on 31 December - which didn't receive any replies. As you can see on https://trac.ffmpeg.org/ticket/9564 the patch is needed and works perfectly. I have rebased it and recompiled it. Original commit description:

Re: [FFmpeg-devel] [PATCH v1] avformat/ipfsgateway: define PATH_MAX

2022-04-13 Thread Mark Gaiser
On Wed, Apr 13, 2022 at 5:21 PM Mark Gaiser wrote: > PATH_MAX is posix. Some compilers (MSVC) don't define this > thus failing to compile the ipfsgateway file. > Defining it fixes the compile. > > Signed-off-by: Mark Gaiser > --- > libavformat/ipfsgateway.c | 6 ++ > 1 file changed, 6

[FFmpeg-devel] [PATCH v1] avformat/ipfsgateway: define PATH_MAX

2022-04-13 Thread Mark Gaiser
PATH_MAX is posix. Some compilers (MSVC) don't define this thus failing to compile the ipfsgateway file. Defining it fixes the compile. Signed-off-by: Mark Gaiser --- libavformat/ipfsgateway.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/ipfsgateway.c

Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support.

2022-04-13 Thread Mark Gaiser
On Wed, Apr 13, 2022 at 4:45 PM Hendrik Leppkes wrote: > On Wed, Apr 13, 2022 at 3:14 PM Mark Gaiser wrote: > > > > On Wed, Apr 13, 2022 at 2:28 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > > > Mark Gaiser: > > > > On Wed, Apr 13, 2022 at 1:10 AM James Almer >

Re: [FFmpeg-devel] [PATCH 6/8] lavc/avcodec: only allocate decoding packets for decoders

2022-04-13 Thread Andreas Rheinhardt
Anton Khirnov: > --- > libavcodec/avcodec.c | 7 +-- > libavcodec/decode.c | 8 > 2 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c > index c7daa385e7..5fd988a41c 100644 > --- a/libavcodec/avcodec.c > +++

[FFmpeg-devel] [PATCH 4/4] avcodec/avcodec: Simplify accessing AVSubtitleRect via dedicated pointer

2022-04-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/avcodec.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c index 0d971a61d4..d11f035481 100644 --- a/libavcodec/avcodec.c +++ b/libavcodec/avcodec.c @@ -452,12 +452,15

[FFmpeg-devel] [PATCH 3/4] avcodec/avcodec: Don't reset decoder-fields for encoders when flushing

2022-04-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- Needs to be applied before https://ffmpeg.org/pipermail/ffmpeg-devel/2022-March/294507.html or flushing an encoder will segfault. Btw: All this stuff is unused by subtitle decoders, so one could condition the else on that and avoid the allocations.

[FFmpeg-devel] [PATCH 2/4] avcodec/avcodec: Avoid av_frame_unref(NULL)

2022-04-13 Thread Andreas Rheinhardt
It works, but it is not documented to work. Signed-off-by: Andreas Rheinhardt --- libavcodec/avcodec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/avcodec.c b/libavcodec/avcodec.c index e0f38ac42a..ded6b5b307 100644 --- a/libavcodec/avcodec.c +++

Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support.

2022-04-13 Thread Hendrik Leppkes
On Wed, Apr 13, 2022 at 3:14 PM Mark Gaiser wrote: > > On Wed, Apr 13, 2022 at 2:28 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > > > Mark Gaiser: > > > On Wed, Apr 13, 2022 at 1:10 AM James Almer wrote: > > > > > >> > > >> > > >> On 4/12/2022 3:02 PM, Michael Niedermayer

[FFmpeg-devel] [PATCH 1/4] avcodec/encode: Fix check for encoders impl. encode-simple API

2022-04-13 Thread Andreas Rheinhardt
FFCodec.cb is a union. Signed-off-by: Andreas Rheinhardt --- libavcodec/encode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index 6ae47b736c..e7ae2cd4c1 100644 --- a/libavcodec/encode.c +++ b/libavcodec/encode.c @@ -589,7 +589,7

Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support.

2022-04-13 Thread Mark Gaiser
On Wed, Apr 13, 2022 at 2:28 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Mark Gaiser: > > On Wed, Apr 13, 2022 at 1:10 AM James Almer wrote: > > > >> > >> > >> On 4/12/2022 3:02 PM, Michael Niedermayer wrote: > >>> On Sun, Apr 10, 2022 at 04:41:27PM +0200, Michael

[FFmpeg-devel] [PATCH v2] avformat/hls: check IV size inside EXT-X-KEY

2022-04-13 Thread Zhao Zhili
Before the patch, an implicit padding on the right is applied for incomplete IV in manifest. No padding is allowed for IV inside EXT-X-KEY. --- libavformat/hls.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index

Re: [FFmpeg-devel] [PATCH RFC] avformat/hls: check IV size inside EXT-X-KEY

2022-04-13 Thread zhilizhao(赵志立)
> On Apr 13, 2022, at 7:53 PM, Anton Khirnov wrote: > > Quoting Zhao Zhili (2022-04-12 10:27:50) >> IV should always be 128 bits. If the IV attribute was truncated >> inside EXT-X-KEY, padding on the left which is the same as when >> using sequence number as IV. >> --- >> I'm not sure which

Re: [FFmpeg-devel] [PATCH v13 1/1] avformat: Add IPFS protocol support.

2022-04-13 Thread Andreas Rheinhardt
Mark Gaiser: > On Wed, Apr 13, 2022 at 1:10 AM James Almer wrote: > >> >> >> On 4/12/2022 3:02 PM, Michael Niedermayer wrote: >>> On Sun, Apr 10, 2022 at 04:41:27PM +0200, Michael Niedermayer wrote: On Wed, Apr 06, 2022 at 02:00:56PM +0200, Mark Gaiser wrote: [...] > +

Re: [FFmpeg-devel] [PATCH RFC] avformat/hls: check IV size inside EXT-X-KEY

2022-04-13 Thread Anton Khirnov
Quoting Zhao Zhili (2022-04-12 10:27:50) > IV should always be 128 bits. If the IV attribute was truncated > inside EXT-X-KEY, padding on the left which is the same as when > using sequence number as IV. > --- > I'm not sure which method is better: do padding or just return > AVERROR_INVALIDDATA?

Re: [FFmpeg-devel] [PATCH] avcodec: Pass the HDR10+ metadata to the packet side data in VP9 encoder

2022-04-13 Thread Michael Niedermayer
On Thu, Jun 17, 2021 at 10:20:44PM -0700, Mohammad Izadi wrote: > HDR10+ metadata is stored in the bit stream for HEVC. The story is different > for VP9 and cannot store the metadata in the bit stream. HDR10+ should be > passed to packet side data an stored in the container (mkv) for VP9. > >

Re: [FFmpeg-devel] [PATCH 3/3] lavc/encode: pick a sane default for bits_per_raw_sample if it's not set

2022-04-13 Thread Anton Khirnov
Quoting Paul B Mahol (2022-04-06 13:24:35) > Ping for this. Current state is imho bad. pushed -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

Re: [FFmpeg-devel] [PATCH 1/8] lavc/avcodec: simplify codec id/type validity checking

2022-04-13 Thread Anton Khirnov
pushed patches 1-3 + new patch dropping EncodeSimpleContext. Will push the rest soonish if nobody objects. -- Anton Khirnov ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

Re: [FFmpeg-devel] [PATCH] lavc/snow: only allocate mconly_picture for decoding

2022-04-13 Thread Anton Khirnov
Quoting Michael Niedermayer (2022-04-11 21:28:10) > On Mon, Apr 11, 2022 at 10:49:34AM +0200, Anton Khirnov wrote: > > It is not used in the encoder. > > --- > > Does this fix the crash? > > --- > > libavcodec/snow.c | 12 > > 1 file changed, 8 insertions(+), 4 deletions(-) > > This

Re: [FFmpeg-devel] [PATCH 09/49] fftools/ffmpeg: store output format separately from the muxer context

2022-04-13 Thread Anton Khirnov
Quoting James Almer (2022-04-06 14:00:21) > On 4/4/2022 8:29 AM, Anton Khirnov wrote: > > Allows accessing it without going through the muxer context. This will > > be useful in the following commits, where the muxer context will be > > hidden. > > --- > > fftools/ffmpeg.c | 18

Re: [FFmpeg-devel] [PATCH v2 0/2] Add common V4L2 request API code

2022-04-13 Thread Elie Roudninski
Please disregard this patch series. Since I sent those yesterday I have been contacted by the original authors and was told that those are outdated. Both LibreELEC and RPi devs are working on a different version of the code that would need to be consolidated first before it can go upstream. Sorry

Re: [FFmpeg-devel] [RFC] Switching ffmpeg.c to a threaded architecture

2022-04-13 Thread Nicolas George
Soft Works (12022-04-12): > I have always asked you kindly You have been repeatedly rude towards the people who know libavfilter well. On top of that, you have shown that you do not understand how libavfilter currently works. On top of that, you have refused to learn how libavfilter currently

Re: [FFmpeg-devel] [PATCH 1/1] librtmp: use AVBPrint instead of char *

2022-04-13 Thread Martin Storsjö
On Mon, 11 Apr 2022, Tristan Matthews wrote: This avoids having to do one pass to calculate the full length to allocate followed by a second pass to actually append values. --- libavformat/librtmp.c | 123 +++--- 1 file changed, 32 insertions(+), 91

Re: [FFmpeg-devel] [PATCH 4/4] fate/oma: Use REMUX where appropriate

2022-04-13 Thread Martin Storsjö
On Tue, 12 Apr 2022, Andreas Rheinhardt wrote: Simplifies the checks. Signed-off-by: Andreas Rheinhardt --- tests/fate/oma.mak | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tests/fate/oma.mak b/tests/fate/oma.mak index a088feff21..7e2020b7d0 100644 ---

Re: [FFmpeg-devel] [PATCH 3/4] fate/subtitles: Use REMUX where appropriate

2022-04-13 Thread Martin Storsjö
On Tue, 12 Apr 2022, Andreas Rheinhardt wrote: It also adds the missing depenencies on the file and pipe protocols and the framecrc muxer. Signed-off-by: Andreas Rheinhardt --- tests/fate/subtitles.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/subtitles.mak

Re: [FFmpeg-devel] [PATCH 2/4] fate/image: Use TRANSCODE where appropriate

2022-04-13 Thread Martin Storsjö
On Tue, 12 Apr 2022, Andreas Rheinhardt wrote: This also adds previously forgotten requirements. E.g. fate-jpg-icc actually depends on the png decoder, so that it should not be run when e.g. zlib is disabled, yet it happens, see

Re: [FFmpeg-devel] [PATCH 1/4] tests/Makefile: Add auxiliary functions for transcode and stream_remux

2022-04-13 Thread Martin Storsjö
On Tue, 12 Apr 2022, Andreas Rheinhardt wrote: Tests using the transcode and stream_remux functions have some common requirements (namely the file and pipe protocols as well as the framecrc muxer) and also other commonalities: The create a file and read it immediately afterwards, so that they

Re: [FFmpeg-devel] [PATCH] avfilter/lensfun: add option db_path

2022-04-13 Thread Gyan Doshi
Pushed as 1405b65d22d8e05ae8bb74fc13e275be2ae6b9f9 On 2022-04-10 11:15 pm, Gyan Doshi wrote: Plan to push tomorrow. On 2022-04-10 11:36 am, Gyan Doshi wrote: The lensfun filter, at present, loads its database from a path hardcoded at build time. This may not be known or available to end

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/hwcontext_vulkan: Fix VK_FORMAT_R8G8_UNORM and VK_FORMAT_R16G16_UNORM map problem on Vulkan

2022-04-13 Thread Xiang, Haihao
On Wed, 2022-03-30 at 11:41 +0800, Wenbin Chen wrote: > Vulkan map both DRM_FORMAT_RG88 and DRM_FORMAT_GR88 to > VK_FORMAT_R8G8_UNORM. This cannot distinguish nv12/nv24 and nv21/nv42. > Vulkan also map both DRM_FORMAT_RG1616 and DRM_FORMAT_GR1616 to > VK_FORMAT_R16G16_UNORM. This causes issue when