On 2022-08-26 02:45 am, Andreas Rheinhardt wrote:
Fixes Coverity issue #1512413.
Signed-off-by: Andreas Rheinhardt
---
fftools/ffmpeg_opt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 8128dcf9fb..aec94dc0f4 100644
---
On Thu, Aug 25, 2022 at 1:58 PM Andreas Rheinhardt
wrote:
>
> Improves the test; also should fix Coverity issue #1512408.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/tests/imf.c | 10 ++
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git
Since we are protecting against the algorithm within
get_next_track_with_minimum_timestamp() return NULL, should this patch
also include immediately returning from imf_read_packet() if
get_next_track_with_minimum_timestamp() returns NULL?
On Thu, Aug 25, 2022 at 7:53 PM Steven Liu wrote:
>
> fix
From: Pierre-Anthony Lemieux
Fixes Coverity issue #1512406
---
libavformat/imfdec.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
index 5bbe7a53f8..fde91a6419 100644
--- a/libavformat/imfdec.c
+++ b/libavformat/imfdec.c
@@
fix CID: 1512404
When there have no val value should not xmlFree it.
Signed-off-by: Steven Liu
---
libavformat/dashdec.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index 63bf7e96a5..bf9adf2183 100644
---
fix CID: 1512414
Signed-off-by: Steven Liu
---
libavformat/imfdec.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavformat/imfdec.c b/libavformat/imfdec.c
index 5bbe7a53f8..a97dcc3b8b 100644
--- a/libavformat/imfdec.c
+++ b/libavformat/imfdec.c
@@ -697,8 +697,9 @@
Andreas Rheinhardt:
> The API for frame-threaded encoders only works
> for one-in-one-out encoders.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/tests/avcodec.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/libavcodec/tests/avcodec.c b/libavcodec/tests/avcodec.c
>
The legacy API is long gone.
Signed-off-by: Andreas Rheinhardt
---
Now with a more concise description than v1.
libavcodec/internal.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/internal.h b/libavcodec/internal.h
index 52e7f111c1..e8c24d81bd 100644
---
Fixes Coverity issue #1512413.
Signed-off-by: Andreas Rheinhardt
---
fftools/ffmpeg_opt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index 8128dcf9fb..aec94dc0f4 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -2769,6
LGTM
On Thu, Aug 25, 2022 at 2:01 PM Andreas Rheinhardt
wrote:
>
> Fixes Coverity issue #1512407.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/imf_cpl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c
> index
Fixes Coverity issue #1512407.
Signed-off-by: Andreas Rheinhardt
---
libavformat/imf_cpl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c
index 4acc20feee..474db6b7f5 100644
--- a/libavformat/imf_cpl.c
+++
Improves the test; also should fix Coverity issue #1512408.
Signed-off-by: Andreas Rheinhardt
---
libavformat/tests/imf.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/libavformat/tests/imf.c b/libavformat/tests/imf.c
index e65629ccbc..a7b2ed3b4d 100644
---
Dawid Kozinski:
> - Changes in mov_write_video_tag function to handle EVC elementary stream
> - Provided structure EVCDecoderConfigurationRecord that specifies the decoder
> configuration information for ISO/IEC 23094-1 video content
>
> Signed-off-by: Dawid Kozinski
> ---
>
Andreas Rheinhardt:
> The struct aom_codec_ctx for the encoder is part of the
> AOMEncoderContext, it is not separately allocated.
> Therefore 5bab794e4aaed55d3146723974ffb5ad792617ab broke compilation.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/libaomenc.c | 2 +-
> 1 file
The struct aom_codec_ctx for the encoder is part of the
AOMEncoderContext, it is not separately allocated.
Therefore 5bab794e4aaed55d3146723974ffb5ad792617ab broke compilation.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/libaomenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On Thu, Aug 25, 2022 at 12:30 PM James Zern wrote:
>
> encoder is a struct, not a pointer; use '.' to access iface.
>
> Signed-off-by: James Zern
> ---
> libavcodec/libaomenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Already fixed.
> diff --git a/libavcodec/libaomenc.c
On Thu, Aug 25, 2022 at 12:28 PM James Almer wrote:
>
> On 8/25/2022 4:21 PM, James Zern wrote:
> > On Thu, Aug 25, 2022 at 10:39 AM James Almer wrote:
> >>
> >> On 8/25/2022 2:34 PM, James Zern wrote:
> >>> On Thu, Aug 25, 2022 at 10:16 AM James Almer wrote:
>
> Signed-off-by: James
encoder is a struct, not a pointer; use '.' to access iface.
Signed-off-by: James Zern
---
libavcodec/libaomenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c
index a82b933c18..1e89b7e3a8 100644
--- a/libavcodec/libaomenc.c
On 8/25/2022 4:21 PM, James Zern wrote:
On Thu, Aug 25, 2022 at 10:39 AM James Almer wrote:
On 8/25/2022 2:34 PM, James Zern wrote:
On Thu, Aug 25, 2022 at 10:16 AM James Almer wrote:
Signed-off-by: James Almer
---
There doesn't seem to be any proper API to check if an encoder is open.
On Thu, Aug 25, 2022 at 10:39 AM James Almer wrote:
>
> On 8/25/2022 2:34 PM, James Zern wrote:
> > On Thu, Aug 25, 2022 at 10:16 AM James Almer wrote:
> >>
> >> Signed-off-by: James Almer
> >> ---
> >> There doesn't seem to be any proper API to check if an encoder is open.
> >>
> >
> > true.
>
On Wed, 24 Aug 2022, Anton Khirnov wrote:
The code will call avpriv_set_pts_info() for each video frame, possibly
setting a different timebase if the stream framerate changes. This
violates API conventions, as the timebase is supposed to stay constant
after stream creation.
Change the
Don't use an intermediary buffer. Achieve this by replacing FrameListData with
a PacketList, and by allocating and populating every packet's payload before
inserting them into the list.
Signed-off-by: James Almer
---
libavcodec/libaomenc.c | 201 +++--
1 file
On 8/25/2022 2:34 PM, James Zern wrote:
On Thu, Aug 25, 2022 at 10:16 AM James Almer wrote:
Signed-off-by: James Almer
---
There doesn't seem to be any proper API to check if an encoder is open.
true.
libavcodec/libaomenc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
On Thu, Aug 25, 2022 at 10:16 AM James Almer wrote:
>
> Signed-off-by: James Almer
> ---
> There doesn't seem to be any proper API to check if an encoder is open.
>
true.
> libavcodec/libaomenc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
lgtm.
> diff --git
Signed-off-by: James Almer
---
There doesn't seem to be any proper API to check if an encoder is open.
libavcodec/libaomenc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c
index 485f554165..fb9a6ff8b2 100644
---
On 8/25/2022 1:29 PM, Andreas Rheinhardt wrote:
James Almer:
Don't use an intermediary buffer. Achieve this by replacing FrameListData with
a PacketList, and by allocating and populating every packet's payload before
inserting them into the list.
Signed-off-by: James Almer
---
Only used by decoders, as the SAR has to be set by the user
when encoding.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/av1dec.c | 1 +
libavcodec/decode.h | 6 ++
libavcodec/dvdec.c | 1 +
libavcodec/exr.c| 1 +
libavcodec/h264_slice.c | 1 +
libavcodec/hevcdec.c
Forgotten after 1e85a698c01133a7f8d35502d5901e3b65fa3317.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/targa.c | 75 +++---
1 file changed, 37 insertions(+), 38 deletions(-)
diff --git a/libavcodec/targa.c b/libavcodec/targa.c
index
Signed-off-by: Andreas Rheinhardt
---
libavcodec/dvdsub.c| 3 ++-
libavcodec/dvdsub.h| 26 ++
libavcodec/dvdsubdec.c | 2 +-
libavcodec/dvdsubenc.c | 2 +-
libavcodec/internal.h | 2 --
5 files changed, 30 insertions(+), 5 deletions(-)
create mode 100644
Signed-off-by: Andreas Rheinhardt
---
libavcodec/ac3dec.c | 1 -
libavcodec/dca_core.c | 1 -
libavcodec/dca_lbr.c | 1 -
libavcodec/dca_xll.c | 1 -
libavcodec/decode.h | 6 ++
libavcodec/internal.h | 6 --
libavcodec/mlpdec.c | 3 ---
7 files changed, 6 insertions(+), 13
It is only used by encoders; in fact, AVCodecContext.time_base
is only used by encoders, so it is only useful for encoders.
Also constify the AVCodecContext parameter in it.
Also fixup the other headers a bit while removing now unnecessary
internal.h inclusions.
Signed-off-by: Andreas
Decoder-only, as the dimensions are set by the user when encoding.
Also fixup the other headers a bit while removing unnecessary internal.h
inclusions.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/agm.c | 3 ---
libavcodec/aliaspixdec.c | 1 -
libavcodec/ansi.c
Only used by decoders (encoders have ff_encode_alloc_frame()).
Also clean up the other headers a bit while removing now redundant
internal.h inclusions.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/012v.c | 2 +-
libavcodec/4xm.c | 2 +-
libavcodec/8bps.c
James Almer:
> Don't use an intermediary buffer. Achieve this by replacing FrameListData with
> a PacketList, and by allocating and populating every packet's payload before
> inserting them into the list.
>
> Signed-off-by: James Almer
> ---
> libavcodec/libaomenc.c | 195
> > You will never fit all the features of complex
> > containers like MXF, MP4, TS (and for argument's sake XML) inside a
> > generalised framework like FFmpeg.
>
> Maybe true but the reason is not that it cant be dont just that there are
> features noone uses and noone needs.
> I do know some
On Wed, Aug 24, 2022 at 10:18:04PM +0100, Kieran Kunhya wrote:
> >
> > for libxml2 these problems are less likely to hit us as we likely never
> > need a
> > "new xml feature" but for a (de)muxer we quite likely will need the
> > latests version on every platform.
> > Also we have regression
- Changelog update
- MAINTAINERS update
Signed-off-by: Dawid Kozinski
---
Changelog | 4 ++--
MAINTAINERS | 5 +
2 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Changelog b/Changelog
index fa83786a20..9631262858 100644
--- a/Changelog
+++ b/Changelog
@@ -36,7 +36,8 @@
- Added evc extension to the list of extensions for ff_mov_demuxer
Signed-off-by: Dawid Kozinski
---
libavformat/mov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 1d8c5b2904..be9501655b 100644
--- a/libavformat/mov.c
+++
- Changes in mov_write_video_tag function to handle EVC elementary stream
- Provided structure EVCDecoderConfigurationRecord that specifies the decoder
configuration information for ISO/IEC 23094-1 video content
Signed-off-by: Dawid Kozinski
---
libavformat/Makefile| 2 +-
- Added EVC decoder wrapper
- Changes in project configuration file and libavcodec Makefile
- Added documentation for xevd wrapper
Signed-off-by: Dawid Kozinski
---
configure | 4 +
doc/decoders.texi | 24 +++
doc/general_contents.texi | 10 +-
libavcodec/Makefile
- Added EVC encoder wrapper
- Changes in project configuration file and libavcodec Makefile
- Added documentation for xeve wrapper
Signed-off-by: Dawid Kozinski
---
configure | 4 +
doc/encoders.texi | 69 +
doc/general_contents.texi | 11 +
libavcodec/Makefile
- Provided AVInputFormat structure describing EVC input format (ff_evc_demuxer)
Signed-off-by: Dawid Kozinski
---
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/evcdec.c | 142 +++
3 files changed, 144 insertions(+)
- Provided AVOutputFormat structure describing EVC output format (ff_evc_muxer)
- Added documentation for EVC muxer
Signed-off-by: Dawid Kozinski
---
doc/muxers.texi | 6 ++
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/rawenc.c | 13
Signed-off-by: Dawid Kozinski
---
libavcodec/Makefile | 1 +
libavcodec/evc_parser.c | 758
libavcodec/parsers.c| 1 +
3 files changed, 760 insertions(+)
create mode 100644 libavcodec/evc_parser.c
diff --git a/libavcodec/Makefile
Added prerequisites that must be met before providing support for the MPEG-5
EVC codec
- Added new entry to codec IDs list
- Added new entry to the codec descriptor list
- Bumped libavcodec minor version
- Added profiles for EVC codec
Signed-off-by: Dawid Kozinski
---
libavcodec/avcodec.h|
The patchset allows to control whether to print date, time or both.
In practical use, I ended up printing a line with the date on startup
and print only time information, e.g. like this:
01:40:42.467 ffmpeg version 5.1...
01:40:42.467 built with ...
01:40:42.468 Execution Date: 2022-08-16
On Sun, 14 Aug 2022, Lynne wrote:
The fastest fast Fourier transform in not just the west, but the world,
now for the most popular toy ISA.
On a high level, it follows the design of the AVX2 version closely,
with the exception that the input is slightly less permuted as we don't have
to do
Quoting Andreas Rheinhardt (2022-08-24 16:33:22)
> Anton Khirnov:
> > Demuxers are not supposed to update AVCodecParameters after the stream
> > was seen by the caller. This value is not important enough to support
> > dynamic updates for.
> > ---
> > libavformat/dv.c | 2 +-
> > 1 file changed,
The function contains only two assignments, setting DVVideoContext.avctx
and AVCodecContext.chroma_sample_location. However, the decoder does not
use the former, and the encoder should not be setting the latter.
Therefore move the first assignment to dvenc and the second to dvdec.
Make the
Quoting Anton Khirnov (2022-08-25 11:48:27)
> Quoting Andreas Rheinhardt (2022-08-24 14:27:43)
> > There is actually another issue here: Encoders are not supposed to set
> > chroma_sample_location at all according to the documentation. I sent a
> > patch to implement this
> >
Quoting Andreas Rheinhardt (2022-08-24 14:27:43)
> There is actually another issue here: Encoders are not supposed to set
> chroma_sample_location at all according to the documentation. I sent a
> patch to implement this
> (https://ffmpeg.org/pipermail/ffmpeg-devel/2022-July/298518.html -- it
>
Quoting Andreas Rheinhardt (2022-08-24 18:25:48)
>
> This is unnecessary as the Makefile above ensures that dv.o is built
> when iec61883 is built.
For a given build, yes. But it is perfectly legal to swap out SOs with
different sets of enabled components. E.g. Debian has libav* and
libav*-extra
update_video_stats() currently uses OutputStream.data_size to print the
total size of the encoded stream so far and the average bitrate.
However, that field is updated in the muxer thread, right before the
packet is sent to the muxer. Not only is this racy, but the numbers may
not match even if
It is either equal to OutputStream.enc_ctx->codec, or NULL when enc_ctx
is NULL. Replace the use of enc with enc_ctx->codec, or the equivalent
enc_ctx->codec_* fields where more convenient.
---
fftools/ffmpeg.c| 27 +-
fftools/ffmpeg.h| 1 -
It is only used within new_video_stream(), so make it a local variable
there.
---
fftools/ffmpeg.h | 1 -
fftools/ffmpeg_opt.c | 8
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
index 68f24bd1d3..481b836d30 100644
---
ost->enc is always non-NULL here, since
- this code is never called for streamcopy
- opening the output file will fail if an encoder cannot be found, so
filters are never initialized
---
fftools/ffmpeg_filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
This code cannot be triggered, since after 90944ee3ab7 opening the
output file will abort if an encoder cannot be found and streamcopy was
not explicitly requested.
---
fftools/ffmpeg_filter.c | 8
1 file changed, 8 deletions(-)
diff --git a/fftools/ffmpeg_filter.c
Forgotten in 8cbf229c941b3c77a756bff05d0ceb5f4f2219c5
---
fftools/ffmpeg.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
index 921e579c32..50654bf8db 100644
--- a/fftools/ffmpeg.h
+++ b/fftools/ffmpeg.h
@@ -650,7 +650,6 @@ extern float
tor. 25. aug. 2022 kl. 02:11 skrev Stephen Hutchinson :
> On 8/24/22 1:04 PM, Steinar Apalnes wrote:
> > tir. 8. feb. 2022 kl. 12:03 skrev Stephen Hutchinson :
> >
> >> * Field Order
> >> * Chroma Location
> >> * Color Transfer Characteristics
> >> * Color Range
> >> * Color Primaries
> >> *
59 matches
Mail list logo
