Re: [FFmpeg-devel] Converting build to CMake

2022-08-28 Thread Martijn van Beurden
Op ma 29 aug. 2022 om 01:17 schreef Jaime Rios : > The reason I ask is that I am not a fan of having to install MinGW just to > build on Windows > There's no need to install MinGW, just MSYS will do: https://trac.ffmpeg.org/wiki/CompilationGuide/MSVC

Re: [FFmpeg-devel] [PATCH 1/2] lavc/qsvenc: ignore video signal info buffer for VP9

2022-08-28 Thread Xiang, Haihao
On Tue, 2022-08-23 at 14:19 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > The SDK doesn't support this type of buffer for vp9 encoding > > Signed-off-by: Haihao Xiang > --- > libavcodec/qsvenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 3/9] avformat/avisynth: add read_frameprops option

2022-08-28 Thread Andreas Rheinhardt
Stephen Hutchinson: > Allows turning the reading of frame properties entirely on and off. > Defaults to reading frame properties. > > Signed-off-by: Stephen Hutchinson > --- > libavformat/avisynth.c | 355 + > 1 file changed, 179 insertions(+), 176

Re: [FFmpeg-devel] Converting build to CMake

2022-08-28 Thread Gerion Entrup
Am Montag, 29. August 2022, 01:31:12 CEST schrieb Gonzalo Garramuño: > > On 28/8/22 20:17, Jaime Rios wrote: > > Sorry if this has been asked before in the past. > > > > I am wondering if there has been any conversation around changing the > > current build setup of ffmpeg to CMake. > > > > The

[FFmpeg-devel] [PATCH 9/9] avformat/avisynth: add read_frameprop_chroma_location option

2022-08-28 Thread Stephen Hutchinson
Signed-off-by: Stephen Hutchinson --- libavformat/avisynth.c | 50 +++--- 1 file changed, 27 insertions(+), 23 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 99173a8d51..4e7395c22b 100644 --- a/libavformat/avisynth.c +++

[FFmpeg-devel] [PATCH 8/9] avformat/avisynth: add read_frameprop_matrix option

2022-08-28 Thread Stephen Hutchinson
Signed-off-by: Stephen Hutchinson --- libavformat/avisynth.c | 98 ++ 1 file changed, 51 insertions(+), 47 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index ff4435758e..99173a8d51 100644 --- a/libavformat/avisynth.c +++

[FFmpeg-devel] [PATCH 7/9] avformat/avisynth: add read_frameprop_transfer option

2022-08-28 Thread Stephen Hutchinson
Signed-off-by: Stephen Hutchinson --- libavformat/avisynth.c | 112 + 1 file changed, 58 insertions(+), 54 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 945ce0e245..ff4435758e 100644 --- a/libavformat/avisynth.c +++

[FFmpeg-devel] [PATCH 6/9] avformat/avisynth: add read_frameprop_primaries option

2022-08-28 Thread Stephen Hutchinson
Signed-off-by: Stephen Hutchinson --- libavformat/avisynth.c | 82 ++ 1 file changed, 43 insertions(+), 39 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 65d8448e89..945ce0e245 100644 --- a/libavformat/avisynth.c +++

[FFmpeg-devel] [PATCH 5/9] avformat/avisynth: add read_frameprop_range option

2022-08-28 Thread Stephen Hutchinson
Signed-off-by: Stephen Hutchinson --- libavformat/avisynth.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index c76b50421c..65d8448e89 100644 --- a/libavformat/avisynth.c +++

[FFmpeg-devel] [PATCH 4/9] avformat/avisynth: add read_frameprop_field_order option

2022-08-28 Thread Stephen Hutchinson
Signed-off-by: Stephen Hutchinson --- libavformat/avisynth.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c index 5d726d70a5..c76b50421c 100644 --- a/libavformat/avisynth.c +++

[FFmpeg-devel] [PATCH 3/9] avformat/avisynth: add read_frameprops option

2022-08-28 Thread Stephen Hutchinson
Allows turning the reading of frame properties entirely on and off. Defaults to reading frame properties. Signed-off-by: Stephen Hutchinson --- libavformat/avisynth.c | 355 + 1 file changed, 179 insertions(+), 176 deletions(-) diff --git

[FFmpeg-devel] [PATCH 2/9] avformat/avisynth: add read_frameprop_sar option

2022-08-28 Thread Stephen Hutchinson
Because SAR is much more likely to be negatively affected by operations made in-script, given that resizing is probably far more common than the sort of color manipulation involved in most of the other frame properties, the safest option is to disable reading it by default, allowing users to opt

[FFmpeg-devel] [PATCH 1/9] avformat/avisynth: read _SARNum/_SARDen from frame properties

2022-08-28 Thread Stephen Hutchinson
Initialized to 1:1, but if the script sets these properties, it will be set to those instead (0:0 disables it, apparently). Signed-off-by: Stephen Hutchinson --- libavformat/avisynth.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/avisynth.c b/libavformat/avisynth.c

[FFmpeg-devel] [PATCH 0/9] avisynth: add user options

2022-08-28 Thread Stephen Hutchinson
The introduction of reading _SARNum/Den values spurred the idea of making sure that users can turn the frameprop value reading ability on and off. Resizing is a much more common activity in AviSynth scripts than the kind of broad color work that would potentially severely impact the usage of the

[FFmpeg-devel] [PATCH 16/16] avutil/fifo: Properly deprecate av_tempfile()

2022-08-28 Thread Andreas Rheinhardt
It has been deprecated in b4f59beeb4c2171879d0d7607a4a7d6165f07791, but the attribute_deprecated was not set and there was no entry in APIchanges. This commit adds these and schedules it for removal. Given that the reason behind the deprecation is exactly the same as in av_fopen_utf8(), reuse its

[FFmpeg-devel] [PATCH 15/16] avutil/internal: Move avpriv-file API to a header of its own

2022-08-28 Thread Andreas Rheinhardt
It is not used by the large majority of files that include lavu/internal.h. Signed-off-by: Andreas Rheinhardt --- libavcodec/dvdsubdec.c| 1 + libavcodec/libxvid.c | 2 +- libavdevice/bktr.c| 1 + libavdevice/fbdev_common.c| 1 +

[FFmpeg-devel] [PATCH 14/16] avutil/dict: Move avpriv_dict_set_timestamp() to a header of its own

2022-08-28 Thread Andreas Rheinhardt
It is used almost nowhere, so it needn't be auto-included almost everywhere. Signed-off-by: Andreas Rheinhardt --- libavformat/flvdec.c | 1 + libavformat/ifv.c | 1 + libavformat/matroskadec.c | 1 + libavformat/mov.c | 1 + libavformat/mux_utils.c | 1 +

[FFmpeg-devel] [PATCH 13/16] avutil/internal: Remove unused FF_SYMVER

2022-08-28 Thread Andreas Rheinhardt
It is unused since d63443b9684fa7b3e086634f7b44b203b6d9221e. Furthermore, it was always in the wrong header: libavutil/internal.h is auto-included almost everywhere, but FF_SYMVER would only ever be used at a few places, so a proper header of its own would be appropriate for it. Signed-off-by:

[FFmpeg-devel] [PATCH 12/16] avutil/internal: Remove unused ff_rint64_clip()

2022-08-28 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/internal.h | 36 1 file changed, 36 deletions(-) diff --git a/libavutil/internal.h b/libavutil/internal.h index b44cbaaa7b..c118936598 100644 --- a/libavutil/internal.h +++ b/libavutil/internal.h @@ -217,42

Re: [FFmpeg-devel] Converting build to CMake

2022-08-28 Thread Gonzalo Garramuño
On 28/8/22 20:17, Jaime Rios wrote: Sorry if this has been asked before in the past. I am wondering if there has been any conversation around changing the current build setup of ffmpeg to CMake. The reason I ask is that I am not a fan of having to install MinGW just to build on Windows, and

[FFmpeg-devel] Converting build to CMake

2022-08-28 Thread Jaime Rios
Sorry if this has been asked before in the past. I am wondering if there has been any conversation around changing the current build setup of ffmpeg to CMake. The reason I ask is that I am not a fan of having to install MinGW just to build on Windows, and my experience so far with CMake has been

[FFmpeg-devel] [PATCH 06/11] avcodec/flac: Remove unused parameter from ff_flac_is_extradata_valid()

2022-08-28 Thread Andreas Rheinhardt
format is write-only. Signed-off-by: Andreas Rheinhardt --- libavcodec/flac.c| 3 --- libavcodec/flac.h| 6 -- libavcodec/flacdec.c | 3 +-- 3 files changed, 1 insertion(+), 11 deletions(-) diff --git a/libavcodec/flac.c b/libavcodec/flac.c index 03c7bfb9e6..1da8aed21b 100644 ---

[FFmpeg-devel] [PATCH 11/11] avcodec/frame_thread_encoder: Stop serializing unreferencing AVFrames

2022-08-28 Thread Andreas Rheinhardt
Currently, the frame-threaded decoding API still supports thread-unsafe callbacks. If one uses a thread-unsafe get_buffer2() callback, calls to av_frame_unref() by the decoder are serialized, because it is presumed that the underlying deallocator is thread-unsafe. The frame-threaded encoder seems

[FFmpeg-devel] [PATCH 10/11] avcodec/encode: Avoid unreferencing blank AVFrames

2022-08-28 Thread Andreas Rheinhardt
ff_thread_video_encode_frame() already returns blank frames. Signed-off-by: Andreas Rheinhardt --- libavcodec/encode.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index 2c02b24cf2..8c6d81286c 100644 ---

[FFmpeg-devel] [PATCH 09/11] avcodec/flac: Don't use bytestream API unnecessarily

2022-08-28 Thread Andreas Rheinhardt
It makes no sense here, as flac_parse_block_header() is not even supposed to advance the caller's pointer. Signed-off-by: Andreas Rheinhardt --- libavcodec/flac.h | 6 +++--- libavformat/flacdec.c | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/flac.h

[FFmpeg-devel] [PATCH 08/11] avcodec/flac: Move decoder+parser stuff into a new header, flac_parse.h

2022-08-28 Thread Andreas Rheinhardt
(The FLAC parser currently ignores the streaminfo block; therefore some of this is decoder-only. Given that the FLAC parser should probably use the streaminfo block, this stuff is moved to flac_parse.h.) Signed-off-by: Andreas Rheinhardt --- libavcodec/flac.c| 1 + libavcodec/flac.h

[FFmpeg-devel] [PATCH 07/11] avcodec/flac: Remove pointless define

2022-08-28 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/flac.h | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/libavcodec/flac.h b/libavcodec/flac.h index 7d6286bf0f..dbfca546cf 100644 --- a/libavcodec/flac.h +++ b/libavcodec/flac.h @@ -55,24 +55,23 @@ enum {

[FFmpeg-devel] [PATCH 05/11] avcodec/flac: Move ff_flac_get_max_frame_size() to flacenc.c

2022-08-28 Thread Andreas Rheinhardt
It is its only user. Signed-off-by: Andreas Rheinhardt --- libavcodec/Makefile | 2 +- libavcodec/flac.c| 21 - libavcodec/flac.h| 8 libavcodec/flacenc.c | 40 ++-- 4 files changed, 35 insertions(+), 36 deletions(-)

[FFmpeg-devel] [PATCH 04/11] avcodec/flacdec: Don't infer max_framesize unnecessarily

2022-08-28 Thread Andreas Rheinhardt
This field is not really used by the decoder at all: It is only output in some debug log message, but this debug log message should better use the value read from the streaminfo instead of a second-guessed value from the decoder. Signed-off-by: Andreas Rheinhardt --- libavcodec/flacdec.c | 6

[FFmpeg-devel] [PATCH 03/11] avcodec/flacdec: Shorten name

2022-08-28 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/flacdec.c | 80 ++-- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/libavcodec/flacdec.c b/libavcodec/flacdec.c index 5ddc5a34d2..d03369eb6d 100644 --- a/libavcodec/flacdec.c +++

[FFmpeg-devel] [PATCH 02/11] avcodec/flac: Remove unnecessary FLACSTREAMINFO define

2022-08-28 Thread Andreas Rheinhardt
Possible since 38f5a266eed1160e87da8e832a0a07818d7673cb. Signed-off-by: Andreas Rheinhardt --- libavcodec/flac.h | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavcodec/flac.h b/libavcodec/flac.h index cb220ab4c0..315df492a3 100644 --- a/libavcodec/flac.h +++

[FFmpeg-devel] [PATCH 01/11] avcodec/mpeg4video: Factor non-codec stuff out into a header of its own

2022-08-28 Thread Andreas Rheinhardt
This avoids including mpegvideo.h in mpeg4_unpack_bframes_bsf.c. Signed-off-by: Andreas Rheinhardt --- libavcodec/h263dec.c | 1 + libavcodec/ituh263dec.c | 1 + libavcodec/mpeg4_unpack_bframes_bsf.c | 2 +- libavcodec/mpeg4video.h | 42

[FFmpeg-devel] [PATCH v3] avcodec/videotoolboxenc: Add CBR option to H264 and HEVC encoder

2022-08-28 Thread Sebastian Beckmann
Adds an option to use constant bitrate instead of average bitrate to the videotoolbox encoders. This is enabled via -constant_bit_rate true. macOS 13 is required for this option to work. Signed-off-by: Sebastian Beckmann --- Removed the hard-coded check for Apple Silicon CPUs.

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: Add CBR option to H264 and HEVC encoder

2022-08-28 Thread Rick Kern
On Fri, Aug 26, 2022 at 7:42 AM Sebastian Beckmann < beckmann.sebast...@outlook.de> wrote: > Adds an option to use constant bitrate instead of average bitrate to the > videotoolbox encoders. This is enabled via -constant_bit_rate true. > macOS 13 is required for this option to work. > >

Re: [FFmpeg-devel] [PATCH] avformat/mov: Check count sums in build_open_gop_key_points()

2022-08-28 Thread Michael Niedermayer
On Tue, Aug 23, 2022 at 09:37:37PM +0200, Michael Niedermayer wrote: > Fixes: ffmpeg.md > Fixes: Out of array access > Fixes: CVE-2022-2566 > > Found-by: Andy Nguyen > Found-by: 3pvd <3...@google.com> > Reviewed-by: Andy Nguyen > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c |

Re: [FFmpeg-devel] [PATCH v2] doc/git-howto.texi: Document commit signing

2022-08-28 Thread Michael Niedermayer
On Tue, Aug 23, 2022 at 03:07:53PM -0300, James Almer wrote: > On 8/23/2022 3:00 PM, Michael Niedermayer wrote: > > On Wed, Aug 10, 2022 at 12:19:02AM +0200, Michael Niedermayer wrote: > > > On Tue, Aug 09, 2022 at 04:38:56PM -0300, James Almer wrote: > > > > On 8/9/2022 4:34 PM, Michael

Re: [FFmpeg-devel] [PATCH 1/4] libavformat/iff: Check for overflow in body_end calculation

2022-08-28 Thread Michael Niedermayer
On Tue, Aug 23, 2022 at 12:55:44AM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -6322983228386819992 - 5557477266266529857 > cannot be represented in type 'long' > Fixes: > 50112/clusterfuzz-testcase-minimized-ffmpeg_dem_IFF_fuzzer-6329186221948928 > > Found-by:

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/m101: Move checks before ff_get_buffer()

2022-08-28 Thread Michael Niedermayer
On Mon, Aug 22, 2022 at 04:58:32PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 50109/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_M101_fuzzer-6553193986785280 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 3/4] tools/target_dec_fuzzer: Adjust threshold for bethsoftvid

2022-08-28 Thread Michael Niedermayer
On Fri, Aug 19, 2022 at 12:35:34AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 49791/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BETHSOFTVID_fuzzer-4583956145635328 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/bethsoftvideo: Pass GetByteContext into set_palette()

2022-08-28 Thread Michael Niedermayer
On Fri, Aug 19, 2022 at 12:35:32AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/bethsoftvideo.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) will apply [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/bethsoftvideo: Check block_type before frame alloc

2022-08-28 Thread Michael Niedermayer
On Fri, Aug 19, 2022 at 12:35:33AM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/bethsoftvideo.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) will apply [...] -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/speedhq: Check width

2022-08-28 Thread Michael Niedermayer
On Sun, Aug 21, 2022 at 04:23:09PM +0200, Michael Niedermayer wrote: > On Sun, Aug 21, 2022 at 12:54:57PM +0200, Paul B Mahol wrote: > > On Fri, Aug 19, 2022 at 12:36 AM Michael Niedermayer > > > > wrote: > > > > > Fixes: out of array access > > > Fixes: > > >

Re: [FFmpeg-devel] [PATCH] avformat/avidec: Prevent entity expansion attacks

2022-08-28 Thread Michael Niedermayer
On Thu, Aug 18, 2022 at 12:32:57AM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes no testcase, this is the same idea as similar attacks against XML > parsers > > Signed-off-by: Michael Niedermayer > --- > libavformat/avidec.c | 12 +++- > 1 file changed, 11 insertions(+), 1

[FFmpeg-devel] [PATCH] avcodec/vpx_rac: Adjust vpx_rac_is_end) threshold

2022-08-28 Thread Michael Niedermayer
A threshold of 180 is needed and sufficient for the sample, twice this is used to cover potentially worse samples fate/vp5 changes as the sample file is truncated and the damaged part is handled differently Fixes: ticket #9754 Signed-off-by: Michael Niedermayer --- libavcodec/vpx_rac.h | 2

[FFmpeg-devel] [PATCH]lavc/j2kdec: Do not ignore colour association for packed formats

2022-08-28 Thread Carl Eugen Hoyos
Hi everybody! Attached patch fixes ticket #9468 for me. Please review, Carl Eugen From a28a5e26892adf56a0bb9b33de2fb76b2405cc97 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 28 Aug 2022 17:47:23 +0200 Subject: [PATCH] lavc/j2kdec: Do not ignore colour association for packed

[FFmpeg-devel] [PATCH v1] avformat/mxf: set stream frame rates for ST 422 essence containers

2022-08-28 Thread pal
From: Pierre-Anthony Lemieux The MXF demuxer does not currently set AVStream::avg_frame_rate and ::r_frame_rate when J2K essence is wrapped according to SMPTE ST 422. --- libavformat/mxfdec.c | 25 + 1 file changed, 25 insertions(+) diff --git a/libavformat/mxfdec.c

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-28 Thread Michael Niedermayer
On Sat, Aug 27, 2022 at 09:05:06AM +0200, Tomas Härdin wrote: > ons 2022-08-24 klockan 22:54 +0200 skrev Michael Niedermayer: > > On Wed, Aug 24, 2022 at 06:35:04PM +0200, Tomas Härdin wrote: > > > But for some reason the notion > > > that the same applies to *all* parsers, including decoders and

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-28 Thread Tomas Härdin
lör 2022-08-27 klockan 10:34 -0700 skrev Baptiste Coudurier: > On Aug 27, 2022, at 4:30 AM, Tomas Härdin wrote: > > > > lör 2022-08-27 klockan 09:53 +0200 skrev Paul B Mahol: > > > On Sat, Aug 27, 2022 at 9:30 AM Tomas Härdin > > > wrote: > > > > > > > ons 2022-08-24 klockan 23:03 +0200 skrev

Re: [FFmpeg-devel] [PATCH] avfilter: add bilateral_cuda filter

2022-08-28 Thread Timo Rothenpieler
On 22.08.2022 22:03, Mohamed Khaled Mohamed wrote: avfilter: add bilateral_cuda filter GSoC'22 libavfilter/vf_bilateral_cuda.cu:the CUDA kernel for the filter libavfilter/vf_bilateral_cuda.c: the C side that calls the kernel and gets user input libavfilter/allfilters.c: added the filter to it