On 9/15/2022 10:10 PM, Andreas Rheinhardt wrote:
Signed-off-by: Andreas Rheinhardt
---
Maybe use av_channel_layout_check?
libavcodec/decode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index 2961705c9d..e24005cc44 100644
---
Signed-off-by: Andreas Rheinhardt
---
tests/fate/lavf-audio.mak | 2 ++
tests/ref/lavf/dfpwm | 3 +++
2 files changed, 5 insertions(+)
create mode 100644 tests/ref/lavf/dfpwm
diff --git a/tests/fate/lavf-audio.mak b/tests/fate/lavf-audio.mak
index 68fca35298..d557d43c08 100644
---
Signed-off-by: Andreas Rheinhardt
---
libavformat/dfpwmdec.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavformat/dfpwmdec.c b/libavformat/dfpwmdec.c
index 98fb4102e3..2244aa99fe 100644
--- a/libavformat/dfpwmdec.c
+++ b/libavformat/dfpwmdec.c
@@ -20,13 +20,11 @@
* Foundation,
Signed-off-by: Andreas Rheinhardt
---
libavformat/dfpwmdec.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavformat/dfpwmdec.c b/libavformat/dfpwmdec.c
index 685b95148c..98fb4102e3 100644
--- a/libavformat/dfpwmdec.c
+++ b/libavformat/dfpwmdec.c
@@ -50,7 +50,7 @@
This decoder does not have the AV_CODEC_CAP_CHANNEL_CONF set,
so that number of channels has to be set by the user before
avcodec_open2().
Signed-off-by: Andreas Rheinhardt
---
libavcodec/dfpwmdec.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/libavcodec/dfpwmdec.c
Signed-off-by: Andreas Rheinhardt
---
Maybe use av_channel_layout_check?
libavcodec/decode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/decode.c b/libavcodec/decode.c
index 2961705c9d..e24005cc44 100644
--- a/libavcodec/decode.c
+++ b/libavcodec/decode.c
@@
Forgotten in 18e55de45a4d0ea197eaeae3a3a9daea186159b9.
Signed-off-by: Andreas Rheinhardt
---
configure | 2 --
1 file changed, 2 deletions(-)
diff --git a/configure b/configure
index 240ae942d1..c157338b1f 100755
--- a/configure
+++ b/configure
@@ -2775,9 +2775,7 @@
On Thu, Sep 15, 2022 at 4:07 PM Lynne wrote:
>
> Sep 16, 2022, 00:46 by p...@sandflow.com:
>
> > From: Pierre-Anthony Lemieux
> >
> > ---
> > MAINTAINERS | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index ed2ec0b90c..2d37f0b86a 100644
> > ---
Sep 16, 2022, 00:46 by p...@sandflow.com:
> From: Pierre-Anthony Lemieux
>
> ---
> MAINTAINERS | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ed2ec0b90c..2d37f0b86a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -436,6 +436,7 @@
From: Pierre-Anthony Lemieux
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index ed2ec0b90c..2d37f0b86a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -436,6 +436,7 @@ Muxers/Demuxers:
idcin.c Mike Melanson
Carl Eugen Hoyos:
> Am Mo., 12. Sept. 2022 um 17:04 Uhr schrieb Andreas Rheinhardt
> :
>>
>> Should fix ticket #9909, fixing a regression since
>> bfb28b5ce89f3e950214b67ea95b45e3355c2caf.
>>
>> Thanks to Carl Eugen Hoyos for analyzing the issue.
>>
>> Signed-off-by: Andreas Rheinhardt
>> ---
>>
Am Mo., 12. Sept. 2022 um 17:04 Uhr schrieb Andreas Rheinhardt
:
>
> Should fix ticket #9909, fixing a regression since
> bfb28b5ce89f3e950214b67ea95b45e3355c2caf.
>
> Thanks to Carl Eugen Hoyos for analyzing the issue.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> This would be my solution. What
On Wed, Sep 14, 2022 at 04:20:02PM -0700, Philip Langdale wrote:
> Since introducing the various packed formats used by VAAPI (and p012),
> we've noticed that there's actually a gap in how
> av_find_best_pix_fmt_of_2 works. It doesn't actually assign any value
> to having the same bit depth as the
Op do 15 sep. 2022 om 20:20 schreef Andreas Rheinhardt <
andreas.rheinha...@outlook.com>:
> (In any case, I don't get why there are two samples: The flac decoder is
> intra-only, so if you made the samples so that one of the frames had a
> wasted bit, you could test all the codepaths that two
Andreas Rheinhardt:
> Possible since 81d070dd09ce154d635414fd07d80a591266b421.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/dolby_e_parser.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/libavcodec/dolby_e_parser.c b/libavcodec/dolby_e_parser.c
> index
Do this by setting AVCodecInternal.pad_samples.
This prevents reading into the frame's padding and writing
into the packet's padding.
This actually happened in our FATE tests (where the number of samples
is 2 mod 4), which therefore needed to be updated.
Signed-off-by: Andreas Rheinhardt
---
Some audio codecs work with atomic units that decode to a fixed
number of audio samples with this number being so small that it is
common to put multiple of these atoms into one packet. In these
cases it makes no sense to pad the last frame to the big frame_size,
so allow encoders to set the
In particular, check that there is only one small last frame
in case the encoder has the AV_CODEC_CAP_SMALL_LAST_FRAME set.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/encode.c | 21 +
libavcodec/internal.h | 4 ++--
2 files changed, 11 insertions(+), 14 deletions(-)
The APTX (HD) decoder decodes blocks of four (six) bytes to four
output samples. It makes no sense to handle incomplete blocks:
They would just lead to synchronization errors, in which case
the complete frame is discarded. So only handle complete blocks.
This also avoids reading from the packet's
Just because we try to put multiple units of block_align bytes
(the atomic units for APTX and APTX HD) into one packet
does not mean that packets with fewer units than the
one we wanted are corrupt; only those packets that are not
a multiple of block_align are.
Signed-off-by: Andreas Rheinhardt
This field was misunderstood: It gives the number of samples
in a packet, not the number of bytes. Its usage was wrong for APTX HD.
Signed-off-by: Andreas Rheinhardt
---
libavformat/aptxdec.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavformat/aptxdec.c b/libavformat/aptxdec.c
Currently the APTX (HD) codecs set frame_size if unset and check
whether it is divisible by block_size (corresponding to block_align
as used by other codecs). But this is based upon a misunderstanding
of the API: frame_size is not in bytes, but in samples.
Said value is also not intended to be
APTX decodes four bytes of input to four stereo samples; APTX HD
does the same with six bytes of input. So it can be easily supported
in av_get_audio_frame_duration().
This fixes invalid durations and (derived) timestamps of demuxed
APTX HD packets and therefore fixed the timestamp in the aptx-hd
We have de- and encoders for APTX and APTX HD, yet not FATE tests.
This commit therefore adds a transcoding test to utilize them.
Furthermore, during creating these tests it turned out that
the duration is set incorrectly for APTX HD. This will be fixed
in a future commit.
(Thanks to Andriy
Am 15.09.22 um 15:56 schrieb Anton Khirnov:
The opaque parameter for the callback is set in videotoolbox_start(),
called when the hwaccel is initialized. When frame threading is used,
avctx will be the context corresponding to the frame thread currently
doing the decoding. Using this same codec
If create_cv_pixel_buffer() fails, pixel_buffer_info might get into CFRelease()
containing an arbitrary value.
---
libavcodec/videotoolboxenc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/videotoolboxenc.c
index
From: Rémi Denis-Courmont
---
libavutil/riscv/intmath.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavutil/riscv/intmath.h b/libavutil/riscv/intmath.h
index 3263a79dc4..45bce9a0e7 100644
--- a/libavutil/riscv/intmath.h
+++ b/libavutil/riscv/intmath.h
@@ -61,8
Martijn van Beurden:
> Op do 15 sep. 2022 om 18:58 schreef Andreas Rheinhardt <
> andreas.rheinha...@outlook.com>:
>
>> Martijn van Beurden:
>>> ---
>>> tests/fate/flac.mak | 9 +
>>> 1 file changed, 9 insertions(+)
>>>
>>> diff --git a/tests/fate/flac.mak b/tests/fate/flac.mak
>>> index
On Sat, 10 Sep 2022, Leo Izen wrote:
This patch allows decoders to set AVFrame->time_base, which
determines the units that AVFrame->pts will use. Currently
no decoders do this, but it will allow it in the future.
This is patch is wrong, because it implies that decoders can output frames
On Wed, Sep 14, 2022 at 03:43:04PM -0700, Philip Langdale wrote:
> On Wed, 14 Sep 2022 23:08:16 +0200
> Michael Niedermayer wrote:
[...]
> > > +// Favour formats where bit depth exactly matches. If
> > > all other
> > > +// scoring is equal, we'd rather use the bit depth
>
On Wed, Aug 31, 2022 at 2:32 PM Tristan Matthews wrote:
>
> Fix suggested by Mark Harris. Fixes ticket #9890
> ---
> libavcodec/opus_silk.c | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/libavcodec/opus_silk.c b/libavcodec/opus_silk.c
> index 8523b55ada..0b4438388e 100644
> ---
Op do 15 sep. 2022 om 18:58 schreef Andreas Rheinhardt <
andreas.rheinha...@outlook.com>:
> Martijn van Beurden:
> > ---
> > tests/fate/flac.mak | 9 +
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/tests/fate/flac.mak b/tests/fate/flac.mak
> > index 115cc965e1..4db28b1e1d
Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/bonk.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/libavformat/bonk.c b/libavformat/bonk.c
> index fc400979b3..0fff0b5bda 100644
> --- a/libavformat/bonk.c
> +++ b/libavformat/bonk.c
> @@ -79,7 +79,6 @@
On 9/10/22, Paul B Mahol wrote:
> Patches attached.
>
will apply soon.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org
On 9/12/22, Paul B Mahol wrote:
> On 9/12/22, Paul B Mahol wrote:
>> Patch attached.
>>
>
> Updated patch attached.
>
Will apply soon.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To
Martijn van Beurden:
> ---
> tests/fate/flac.mak | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/tests/fate/flac.mak b/tests/fate/flac.mak
> index 115cc965e1..4db28b1e1d 100644
> --- a/tests/fate/flac.mak
> +++ b/tests/fate/flac.mak
> @@ -6,6 +6,8 @@ FATE_FLAC +=
---
tests/fate/flac.mak | 9 +
1 file changed, 9 insertions(+)
diff --git a/tests/fate/flac.mak b/tests/fate/flac.mak
index 115cc965e1..4db28b1e1d 100644
--- a/tests/fate/flac.mak
+++ b/tests/fate/flac.mak
@@ -6,6 +6,8 @@ FATE_FLAC += fate-flac-16-chmode-indep
Add encoding of 32 bit-per-sample PCM to FLAC files to libavcodec.
Coding to this format is at this point considered experimental and
-strict -2 is needed to get ffmpeg to encode such files.
---
libavcodec/flacenc.c| 519
libavcodec/put_bits.h | 7
Add decoding of FLAC files coding for 32 bit-per-sample PCM to libavcodec.
---
libavcodec/flac.c | 4 +-
libavcodec/flacdec.c | 250 ++
libavcodec/get_bits.h | 12 ++
libavcodec/mathops.h | 9 ++
4 files changed, 251 insertions(+), 24
Recently libFLAC gained the ability (first released in FLAC 1.4.0)
to create FLAC files containing 32-bit int PCM samples. To
keep complexity reasonable, the choice was made to limit residuals
to 32-bit integers, which the encoder must make sure of. In case
the encoder cannot find any predictor of
On 9/15/22, Andreas Rheinhardt wrote:
> Otherwise the buffer might be too small. Fixes assert violations
> when encoding mono audio with exactly one sample.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/adpcmenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
Otherwise the buffer might be too small. Fixes assert violations
when encoding mono audio with exactly one sample.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/adpcmenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/adpcmenc.c b/libavcodec/adpcmenc.c
index
Patch attached.
There are cases when previously decoded substreams
would, if they have overlapping channels with final substream, cause
incorrect decoding results.
From adf5fd3bdb397f88a52d7ce0cf76491a55d33eef Mon Sep 17 00:00:00 2001
From: Paul B Mahol
Date: Thu, 15 Sep 2022 16:14:08 +0200
On 2022-09-15 08:35 pm, r...@remlab.net wrote:
From: Rémi Denis-Courmont
---
libavutil/lfg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/lfg.h b/libavutil/lfg.h
index 2b669205d1..9a1e277acd 100644
--- a/libavutil/lfg.h
+++ b/libavutil/lfg.h
@@ -27,7 +27,7
From: Rémi Denis-Courmont
---
libavutil/lfg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/lfg.h b/libavutil/lfg.h
index 2b669205d1..9a1e277acd 100644
--- a/libavutil/lfg.h
+++ b/libavutil/lfg.h
@@ -27,7 +27,7 @@
/**
* Context structure for the Lagged
The opaque parameter for the callback is set in videotoolbox_start(),
called when the hwaccel is initialized. When frame threading is used,
avctx will be the context corresponding to the frame thread currently
doing the decoding. Using this same codec context in all subsequent
invocations of the
This field has never been used for anything, so stop setting it and
deprecate it.
---
libavcodec/version_major.h | 1 +
libavcodec/videotoolbox.c | 2 --
libavcodec/videotoolbox.h | 5 +
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/libavcodec/version_major.h
Hello,
mpegvideo_enc.c contains this check in ff_mpv_encode_init:
if (s->q_scale_type == 1) {
if (avctx->qmax > 28) {
av_log(avctx, AV_LOG_ERROR,
"non linear quant only supports qmax <= 28 currently\n");
return AVERROR_PATCHWELCOME;
Forgotten in eb5c5ae658aaf8cd7c03e1d0a6c84274d3a39a66.
Signed-off-by: Andreas Rheinhardt
---
Will apply this tonight unless there are objections.
libavcodec/intrax8.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/intrax8.h b/libavcodec/intrax8.h
index 966f1b18a0..9ef2fc3dd3
Li-Heng Chen (12022-09-14):
> Please allow me to explain again with your example. That's say we have
> an input with 20 frames (0-19), and we want to keep prime number frames
> with select filter, -vf select='eq(n\,2)+eq(n\,3)+...+eq(n\,13)+eq(n\,17)'
>
> In the activation function,
Zhao Zhili 于2022年9月6日周二 14:38写道：
>
> On Mon, 2022-09-05 at 18:40 +0800, 1035567...@qq.com wrote:
> > From: Wang Yaqiang
> >
> > For example, if the jpeg contains exif information
> > and the rotation direction is included in the exif,
> > the displaymatrix will be set on the side_data of the
On 12 Sep 2022, at 8:59, Wang Bin wrote:
> Wang Bin 于2022年9月12日周一 10:02写道：
>
>>
>>> av_packet_unref(p->avpkt);
>>> @@ -655,6 +670,14 @@ void ff_thread_finish_setup(AVCodecContext *avctx) {
>>> async_lock(p->parent);
>>> }
>>>
>>> +/* save hwaccel state for passing to the
On 9/15/22, James Almer wrote:
> Fixes ticket #9924
>
> Signed-off-by: James Almer
> ---
> libavfilter/vf_drawbox.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavfilter/vf_drawbox.c b/libavfilter/vf_drawbox.c
> index 65bd039d65..64ce12 100644
> ---
On 15 Sep 2022, at 4:12, James Almer wrote:
> On 9/14/2022 10:52 PM, Marvin Scholz wrote:
>> ---
>> libswresample/swresample.h | 8
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/libswresample/swresample.h b/libswresample/swresample.h
>> index
54 matches
Mail list logo
