ping
-Chema
On Mon, Sep 12, 2022 at 4:50 PM Chema Gonzalez wrote:
>
> Note that the motion information includes subpel motion information
>
> This was likely forgotten in 56bdf61baa04c4fd8d165f34499115ce0aa97c43.
>
> Tested:
> ```
> $ make examples -j
> ...
> $ doc/examples/extract_mvs in.264 |
Signed-off-by: Wenbin Chen
---
doc/encoders.texi | 4
libavcodec/qsvenc.c | 21 +
libavcodec/qsvenc.h | 2 ++
3 files changed, 27 insertions(+)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index 2b6412dbec..741d545ea1 100644
--- a/doc/encoders.texi
+++
Signed-off-by: Wenbin Chen
---
doc/encoders.texi | 6 ++
libavcodec/qsvenc.c | 38 ++
libavcodec/qsvenc.h | 5 +
3 files changed, 49 insertions(+)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index 4ed7ce1bb0..2b6412dbec 100644
---
Signed-off-by: Wenbin Chen
---
doc/encoders.texi | 3 +++
libavcodec/qsvenc.c | 26 ++
libavcodec/qsvenc.h | 2 ++
3 files changed, 31 insertions(+)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index ac71f50ad2..4ed7ce1bb0 100644
--- a/doc/encoders.texi
+++
Use the stream duration as last resort, as an off-by-one result of the
"st->duration / (caf->packets - 1)" calculation can break playback on some
devices.
Also, don't write the sample_rate value propagated by encoders like libopus.
The sample rate of the audio fed to it is irrelevant for the
Will help debugging.
Signed-off-by: James Almer
---
tests/checkasm/lpc.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
index 8528fd6e20..49e608f8c1 100644
--- a/tests/checkasm/lpc.c
+++ b/tests/checkasm/lpc.c
@@ -45,8
On Wed, Sep 21, 2022 at 12:14 PM James Zern wrote:
>
> On Tue, Sep 20, 2022 at 2:17 PM Vignesh Venkatasubramanian
> wrote:
> >
> > According to the HEIF specification (ISO/IEC 23008-12) Section
> > 7.5.3.1, tracks with handler_type 'auxv' must contain a 'auxi' box
> > in its SampleEntry to
Signed-off-by: James Almer
---
libavcodec/x86/lpc.asm | 17 +++--
1 file changed, 15 insertions(+), 2 deletions(-)
diff --git a/libavcodec/x86/lpc.asm b/libavcodec/x86/lpc.asm
index 61a5796e5d..a585c17ef5 100644
--- a/libavcodec/x86/lpc.asm
+++ b/libavcodec/x86/lpc.asm
@@ -79,11
On 9/22/22 08:43, Anton Khirnov wrote:
Quoting Scott Theisen (2022-09-22 03:04:16)
On 9/21/22 15:51, James Almer wrote:
On 9/21/2022 4:44 PM, Rémi Denis-Courmont wrote:
Le keskiviikkona 21. syyskuuta 2022, 22.26.11 EEST Scott Theisen a
écrit :
diff --git a/libavcodec/avcodec.h
Simplifies the test, while trying more values and preventing pointlessly
running benchmarks in a loop.
Signed-off-by: James Almer
---
tests/checkasm/lpc.c | 19 +++
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
index
Signed-off-by: James Almer
---
libavcodec/lpc.c | 1 +
libavcodec/x86/lpc.asm | 10 +++---
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/libavcodec/lpc.c b/libavcodec/lpc.c
index 8603bb9709..dc6a3060ce 100644
--- a/libavcodec/lpc.c
+++ b/libavcodec/lpc.c
@@ -53,6
From: Rémi Denis-Courmont
---
libavcodec/riscv/aacpsdsp_init.c | 3 +++
libavcodec/riscv/aacpsdsp_rvv.S | 37
2 files changed, 40 insertions(+)
diff --git a/libavcodec/riscv/aacpsdsp_init.c b/libavcodec/riscv/aacpsdsp_init.c
index 76f55502ee..20b1a12741
From: Rémi Denis-Courmont
---
libavcodec/riscv/aacpsdsp_init.c | 6 +-
libavcodec/riscv/aacpsdsp_rvv.S | 19 +++
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/libavcodec/riscv/aacpsdsp_init.c b/libavcodec/riscv/aacpsdsp_init.c
index 525fc9aa38..90c9c501c3
From: Rémi Denis-Courmont
---
libavcodec/riscv/audiodsp_init.c | 2 ++
libavcodec/riscv/audiodsp_rvv.S | 20
2 files changed, 22 insertions(+)
diff --git a/libavcodec/riscv/audiodsp_init.c b/libavcodec/riscv/audiodsp_init.c
index ddd561484f..6f38b7bc83 100644
---
From: Rémi Denis-Courmont
---
libavcodec/riscv/audiodsp_init.c | 7 ++-
libavcodec/riscv/audiodsp_rvv.S | 18 ++
2 files changed, 24 insertions(+), 1 deletion(-)
diff --git a/libavcodec/riscv/audiodsp_init.c b/libavcodec/riscv/audiodsp_init.c
index ce8b60ee52..ddd561484f
From: Rémi Denis-Courmont
---
libavcodec/riscv/aacpsdsp_init.c | 14
libavcodec/riscv/aacpsdsp_rvv.S | 37
2 files changed, 47 insertions(+), 4 deletions(-)
diff --git a/libavcodec/riscv/aacpsdsp_init.c b/libavcodec/riscv/aacpsdsp_init.c
index
From: Rémi Denis-Courmont
This starts with one-time initialisation of the 26 constant factors
like 08edacc248bce3f8946d75e97188d189c74a6de6. That is done with
the scalar instruction set. While the formula can readily be vectored,
the gains would (probably) be more than lost in transfering the
From: Rémi Denis-Courmont
---
libavcodec/aacpsdsp.h| 1 +
libavcodec/aacpsdsp_template.c | 2 ++
libavcodec/riscv/Makefile| 2 ++
libavcodec/riscv/aacpsdsp_init.c | 37 ++
libavcodec/riscv/aacpsdsp_rvv.S | 39
From: Rémi Denis-Courmont
This uses the following vectorisation:
for (i = 0; i < blocksize; i++) {
ang[i] = mag[i] - copysignf(fmaxf(ang[i], 0.f), mag[i]);
mag[i] = mag[i] - copysignf(fminf(ang[i], 0.f), mag[i]);
}
---
libavcodec/riscv/Makefile | 2 ++
From: Rémi Denis-Courmont
---
libavcodec/fmtconvert.c| 2 ++
libavcodec/fmtconvert.h| 1 +
libavcodec/riscv/Makefile | 2 ++
libavcodec/riscv/fmtconvert_init.c | 39 +
libavcodec/riscv/fmtconvert_rvv.S | 40
From: Rémi Denis-Courmont
---
libavcodec/riscv/fmtconvert_init.c | 7 ++-
libavcodec/riscv/fmtconvert_rvv.S | 29 +
2 files changed, 35 insertions(+), 1 deletion(-)
diff --git a/libavcodec/riscv/fmtconvert_init.c
b/libavcodec/riscv/fmtconvert_init.c
index
From: Rémi Denis-Courmont
RVV defines a total of 12 different extensions, including:
- 5 different instruction subsets:
- Zve32x: 8-, 16- and 32-bit integers,
- Zve32f: Zve32x plus single precision floats,
- Zve64x: Zve32x plus 64-bit integers,
- Zve64f: Zve32f plus Zve64x,
- Zve64d:
From: Rémi Denis-Courmont
---
libavcodec/riscv/Makefile| 1 +
libavcodec/riscv/audiodsp_init.c | 9
libavcodec/riscv/audiodsp_rvv.S | 37
3 files changed, 47 insertions(+)
create mode 100644 libavcodec/riscv/audiodsp_rvv.S
diff --git
From: Rémi Denis-Courmont
---
libavutil/riscv/float_dsp_init.c | 2 ++
libavutil/riscv/float_dsp_rvv.S | 21 +
2 files changed, 23 insertions(+)
diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c
index dacd81c08b..cc9b7e83dc 100644
---
From: Rémi Denis-Courmont
---
libavutil/fixed_dsp.c| 4 +++-
libavutil/fixed_dsp.h| 1 +
libavutil/riscv/Makefile | 4 +++-
libavutil/riscv/fixed_dsp_init.c | 38 +
libavutil/riscv/fixed_dsp_rvv.S | 41
From: Rémi Denis-Courmont
---
libavutil/riscv/float_dsp_init.c | 3 +++
libavutil/riscv/float_dsp_rvv.S | 35
2 files changed, 38 insertions(+)
diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c
index 9b8fd9942b..dacd81c08b
From: Rémi Denis-Courmont
---
libavutil/riscv/float_dsp_init.c | 3 +++
libavutil/riscv/float_dsp_rvv.S | 22 ++
2 files changed, 25 insertions(+)
diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c
index f164b1308f..9b8fd9942b 100644
---
From: Rémi Denis-Courmont
---
libavutil/riscv/float_dsp_init.c | 3 +++
libavutil/riscv/float_dsp_rvv.S | 19 +++
2 files changed, 22 insertions(+)
diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c
index 6027a67b46..c2d93e0cd7 100644
---
From: Rémi Denis-Courmont
---
libavutil/riscv/float_dsp_init.c | 3 +++
libavutil/riscv/float_dsp_rvv.S | 20
2 files changed, 23 insertions(+)
diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c
index d17d0f66c5..2ddd2050f7 100644
---
From: Rémi Denis-Courmont
---
libavutil/riscv/float_dsp_init.c | 2 ++
libavutil/riscv/float_dsp_rvv.S | 19 +++
2 files changed, 21 insertions(+)
diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c
index 2ddd2050f7..f164b1308f 100644
---
From: Rémi Denis-Courmont
---
libavutil/riscv/float_dsp_init.c | 6 +-
libavutil/riscv/float_dsp_rvv.S | 18 ++
2 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c
index 60b79bd59e..6027a67b46
From: Rémi Denis-Courmont
---
libavutil/riscv/float_dsp_init.c | 3 +++
libavutil/riscv/float_dsp_rvv.S | 19 +++
2 files changed, 22 insertions(+)
diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c
index c2d93e0cd7..d17d0f66c5 100644
---
From: Rémi Denis-Courmont
Benchmarks on SiFive U74-MC (courtesy of Shanghai StarFive Tech):
get_pixels_c: 180.0
get_pixels_rvi: 136.7
---
libavcodec/pixblockdsp.c| 2 +
libavcodec/pixblockdsp.h| 2 +
libavcodec/riscv/Makefile | 2 +
From: Rémi Denis-Courmont
---
libavutil/riscv/float_dsp_init.c | 3 +++
libavutil/riscv/float_dsp_rvv.S | 18 ++
2 files changed, 21 insertions(+)
diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c
index b829c0f736..60b79bd59e 100644
---
From: Rémi Denis-Courmont
---
Makefile | 2 +-
configure| 15 +++
ffbuild/arch.mak | 2 ++
3 files changed, 18 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 61f79e27ae..1fb742f390 100644
--- a/Makefile
+++ b/Makefile
@@ -91,7 +91,7 @@
From: Rémi Denis-Courmont
---
libavutil/riscv/float_dsp_init.c | 9 -
libavutil/riscv/float_dsp_rvv.S | 18 ++
2 files changed, 26 insertions(+), 1 deletion(-)
diff --git a/libavutil/riscv/float_dsp_init.c b/libavutil/riscv/float_dsp_init.c
index
From: Rémi Denis-Courmont
This is based on existing code from the VLC git tree with two minor
changes to account for the different function prototypes.
---
libavutil/float_dsp.c| 2 ++
libavutil/float_dsp.h| 1 +
libavutil/riscv/Makefile | 4 +++-
From: Rémi Denis-Courmont
RV64G supports MIN & MAX instructions natively only on floating point
registers, not general purpose ones. The later would require the Zbb
extension. Due to that, it is actually faster to perform the clipping
"properly" in FPU.
Benchmarks on SiFive U74-MC (courtesy of
From: Rémi Denis-Courmont
---
libavutil/riscv/asm.S | 77 +++
1 file changed, 77 insertions(+)
create mode 100644 libavutil/riscv/asm.S
diff --git a/libavutil/riscv/asm.S b/libavutil/riscv/asm.S
new file mode 100644
index 00..dbd97f40a4
---
From: Rémi Denis-Courmont
This introduces compile-time and run-time CPU detection on RISC-V. In
practice, I doubt that FFmpeg will ever see a RISC-V CPU without all of
I, F and D extensions, and if it does, it probably won't have run-time
detection. So the flags are essentially always set.
But
Changes since v3bis:
- Added aacpsdsp analysis.
Changes since v3:
- Rebased on, and resovled conflicts with, fmtconvert clean-up.
The following changes since commit 48615f0a7861fd1c24195f74856f68e06c7ca73c:
x86/aacpsdsp: add ps_hybrid_analysis_fma3 (2022-09-22 13:27:43 -0300)
are available
On 9/22/22 10:59, Anton Khirnov wrote:
Quoting Scott Theisen (2022-09-16 19:41:43)
Ping; it still applies cleanly.
Missing motivation for this change. Is it faster, or why is the new code
better?
To make it easier to read. `buf_end` is shorter than `frag->data +
frag->data_size`.
Paul B Mahol:
> On 9/22/22, Anton Khirnov wrote:
>> Should be straightforward to forward get_buffer2() and support
>> AV_CODEC_CAP_DR1.
>
> How ?
>
You copy the get_buffer2 callback as well as AVCodecContext.opaque to
the subdecoder.
- Andreas
___
the type is also changed to int as it is interpreted as int in av_get_packet()
Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type
'int'
Fixes:
50993/clusterfuzz-testcase-minimized-ffmpeg_dem_WSVQA_fuzzer-6593408795279360
Found-by: continuous fuzzing process
Fixes: signed integer overflow: 119760682 - -2084600173 cannot be represented
in type 'int'
Fixes:
50993/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-6745781167587328
Found-by: continuous fuzzing process
https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by:
On 9/22/22, Anton Khirnov wrote:
> Should be straightforward to forward get_buffer2() and support
> AV_CODEC_CAP_DR1.
How ?
>
> --
> Anton Khirnov
> ___
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
>
Signed-off-by: James Almer
---
libavcodec/lpc.c | 4 ++--
libavcodec/lpc.h | 5 +++--
libavcodec/x86/lpc.asm| 1 -
libavcodec/x86/lpc_init.c | 6 +++---
tests/checkasm/lpc.c | 2 +-
5 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/libavcodec/lpc.c
Anton Khirnov 于2022年9月19日周一 21:22写道：
> Fixes assertion failures after avcodec_flush_buffers(), where
> stashed hwaccel state is present, but prev_thread is NULL.
>
> Found-by: Wang Bin
> ---
> libavcodec/pthread_frame.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>
On Thu, Sep 22, 2022 at 03:01:05PM +0200, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2022-09-18 19:14:10)
> > Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in
> > type 'int'
> > Fixes:
> >
>> Yeah this is due to the way probing in lavf works. When I did
development on the Part 1 decoder I dummied out the first decode, which
always runs at full resolution btw, regardless of what -lowres is set
to.
Can this be fixed?
Decoding sauna-cut.jph errors out with
Post 14864313 too big
On Thu, Sep 22, 2022 at 03:18:20PM +0200, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2022-09-18 19:14:07)
> > Fixes: signed integer overflow: 119760682 - -2084600173 cannot be
> > represented in type 'int'
> > Fixes:
> >
From: Rémi Denis-Courmont
Except for add_squares, telling the compiler that the output vector(s)
cannot alias helps quite a bit (cycles on SiFive U7-MC):
ps_add_squares_c: 98277.7
ps_add_squares_r: 98320.2
ps_hybrid_analysis_c: 3731.2
ps_hybrid_analysis_r: 2495.7
ps_hybrid_analysis_ileave_c:
Quoting Zhao Zhili (2022-09-17 06:30:01)
> From: Zhao Zhili
>
> There are two issues here. Firstly, the floating-point comparison
> is always true. Seconly, the code depends on the default value of
> min_hard_comp implicitly, which can be dangerous.
>
> Partially fixes ticket 9859.
> ---
>
Andreas Rheinhardt:
> There is no check for whether these supposedly redundant PPS
> are actually redundant. One could check via memcmp which would
> work in practice* (because all content buffers are initially
> zero-allocated), but this is not portable as compilers may
> trash padding inside
On Sat, Sep 17, 2022 at 04:45:52PM +0200, Paul B Mahol wrote:
> On 9/17/22, Michael Niedermayer wrote:
> > Fixes: signed integer overflow: 3 * -2147483648 cannot be represented in
> > type 'int'
> > Fixes:
> > 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_AIFF_fuzzer-6668935979728896
> >
> >
On Sat, Sep 17, 2022 at 04:45:28PM +0200, Paul B Mahol wrote:
> On 9/17/22, Michael Niedermayer wrote:
> > Fixes: signed integer overflow: 3 * -2147483648 cannot be represented in
> > type 'int'
> > Fixes:
> > 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_AIFF_fuzzer-6668935979728896
> >
> >
On Tue, Sep 20, 2022 at 01:12:44PM +0200, Tomas Härdin wrote:
> sön 2022-09-11 klockan 16:27 +0200 skrev Michael Niedermayer:
> > Signed-off-by: Michael Niedermayer
> > ---
> > libavformat/mxfdec.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git
From: Rémi Denis-Courmont
INT_MAX is (typically) a value with 31 significant bits but float can
only represent 23 significant bits, leading to a rounding error.
This substitutes the actual rounded value as an unsigned int,
to avoid a clang warning while not overflowing signed int:
warning:
From: Rémi Denis-Courmont
Even though they have the same size, and typically the same alignment,
uint32_t and float are under no circumstances compatible types in C.
The casts from float * to uint32_t * are invalid here. Insofar as the
resulting pointers are dereferenced, this is undefined
Quoting Scott Theisen (2022-09-16 19:41:43)
> Ping; it still applies cleanly.
Missing motivation for this change. Is it faster, or why is the new code
better?
--
Anton Khirnov
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
Hi,
On Thu, Sep 22, 2022 at 9:49 AM Anton Khirnov wrote:
> It is very nonobvious to me that it makes sense to define a global job
> count that is independent of the task at hand.
>
I agree with Anton here. This is very heuristical and dependent on the type
of job. This therefore belongs as an
av_display_rotation_get will return NAN when the display matrix is invalid,
which would end up printing NAN as an integer in the rotation field. This
is poor for multiple reasons:
* Users of ffprobe have no way of discerning "valid but ugly rotation from
display matrix" from "invalid display
On 9/22/2022 2:20 PM, Derek Buitenhuis wrote:
> ---
> fftools/ffprobe.c | 10 --
> 1 file changed, 8 insertions(+), 2 deletions(-)
Sorry, broken patch. Will send v2.
- Derek
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
It is very nonobvious to me that it makes sense to define a global job
count that is independent of the task at hand.
And we could really do with fewer global variables, not more.
--
Anton Khirnov
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
ons 2022-09-21 klockan 20:56 +0200 skrev Marton Balint:
>
>
> On Wed, 21 Sep 2022, Tomas Härdin wrote:
>
> > ons 2022-09-21 klockan 11:35 +0200 skrev Michael Niedermayer:
> > > On Tue, Sep 20, 2022 at 01:20:00PM +0200, Tomas Härdin wrote:
> > > > tis 2022-09-20 klockan 13:07 +0200 skrev Tomas
Quoting Paul B Mahol (2022-09-22 11:09:03)
> On 8/31/22, Paul B Mahol wrote:
> > New patch updated from feedback received.
> >
>
> Will apply soon.
This needs tests.
--
Anton Khirnov
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
av_display_rotation_get will return NAN when the display matrix is invalid,
which would end up printing NAN as an integer in the rotation field. This
is poor for multiple reasons:
* Users of ffprobe have no way of discerning "valid but ugly rotation from
display matrix" from "invalid display
Quoting Michael Niedermayer (2022-09-18 19:14:07)
> Fixes: signed integer overflow: 119760682 - -2084600173 cannot be represented
> in type 'int'
> Fixes:
> 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_VIVIDAS_fuzzer-6745781167587328
>
> Found-by: continuous fuzzing process
>
Quoting Michael Niedermayer (2022-09-18 19:14:10)
> Fixes: signed integer overflow: 2147483647 + 1 cannot be represented in type
> 'int'
> Fixes:
> 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_WSVQA_fuzzer-6593408795279360
>
> Found-by: continuous fuzzing process
>
Quoting James Almer (2022-09-21 23:42:02)
> In case new orders are added in the future, existing library users can still
> use the layout simply by ignoring everything but the channel count in it, so
> make this explicit.
sure
--
Anton Khirnov
___
Should be straightforward to forward get_buffer2() and support
AV_CODEC_CAP_DR1.
--
Anton Khirnov
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
Quoting Scott Theisen (2022-09-22 03:04:16)
> On 9/21/22 15:51, James Almer wrote:
> > On 9/21/2022 4:44 PM, Rémi Denis-Courmont wrote:
> >> Le keskiviikkona 21. syyskuuta 2022, 22.26.11 EEST Scott Theisen a
> >> écrit :
> >>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> >>> index
> On Sep 1, 2022, at 14:17, Steven Liu wrote:
>
> Zhao Zhili 于2022年9月1日周四 10:59写道：
>>
>> From: Zhao Zhili
>>
>> Signed-off-by: Zhao Zhili
>> ---
>> fftools/ffmpeg.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
>> index
Marvin Scholz:
>
>
> On 22 Sep 2022, at 13:33, Andreas Rheinhardt wrote:
>
>> Marvin Scholz:
>>> This is a more explicit iteration API rather than using the "magic"
>>> av_dict_get(d, "", t, AV_DICT_IGNORE_SUFFIX) which is not really
>>> trivial to grasp what it does when casually reading
> On Sep 17, 2022, at 12:30, Zhao Zhili wrote:
>
> From: Zhao Zhili
>
> There are two issues here. Firstly, the floating-point comparison
> is always true. Seconly, the code depends on the default value of
> min_hard_comp implicitly, which can be dangerous.
>
> Partially fixes ticket 9859.
On 22 Sep 2022, at 13:33, Andreas Rheinhardt wrote:
> Marvin Scholz:
>> This is a more explicit iteration API rather than using the "magic"
>> av_dict_get(d, "", t, AV_DICT_IGNORE_SUFFIX) which is not really
>> trivial to grasp what it does when casually reading through code.
>> ---
>>
Marvin Scholz:
> This is a more explicit iteration API rather than using the "magic"
> av_dict_get(d, "", t, AV_DICT_IGNORE_SUFFIX) which is not really
> trivial to grasp what it does when casually reading through code.
> ---
> libavutil/dict.c| 19 +++
> libavutil/dict.h|
On 9/22/22, Andreas Rheinhardt wrote:
> Paul B Mahol:
>> Subject: [PATCH] avcodec: add Media 100i decoder
>>
>> Signed-off-by: Paul B Mahol
>> ---
>> libavcodec/Makefile | 1 +
>> libavcodec/allcodecs.c | 1 +
>> libavcodec/codec_desc.c | 7 ++
>> libavcodec/codec_id.h | 1 +
>>
On 8/31/22, Paul B Mahol wrote:
> New patch updated from feedback received.
>
Will apply soon.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
79 matches
Mail list logo
