Re: [FFmpeg-devel] [PATCH v1 00/11] Add support for H266/VVC

2022-12-12 Thread Nuo Mi
Hi Thomas, Thank you for sending the patch set. It seems the patchset is based on https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=3487 Please do not change the author's name. thank you On Wed, Oct 19, 2022 at 3:26 PM wrote: > From: Thomas Siedel > > This patch set adds H266/VVC

Re: [FFmpeg-devel] [PATCH v3 3/7] avcodec/mediacodecenc: use bsf to handle crop

2022-12-12 Thread zhilizhao(赵志立)
> On Dec 12, 2022, at 23:27, Tomas Härdin wrote: > > lör 2022-12-10 klockan 01:22 +0800 skrev Zhao Zhili: >> From: Zhao Zhili >> >> It's well known that mediacodec encoder requires 16x16 alignment. >> Use our bsf to fix the crop info. >> --- >> v3: don't change the dimension for

Re: [FFmpeg-devel] [PATCH v2 5/7] avcodec/mediacodecenc: remove the strategy to create DTS

2022-12-12 Thread zhilizhao(赵志立)
> On Dec 12, 2022, at 23:28, Tomas Härdin wrote: > > ons 2022-12-07 klockan 17:31 +0800 skrev Zhao Zhili: >> From: Zhao Zhili >> >> Use input PTS as DTS has multiple problems: >> 1. If there is no reordering, it's better to just use the output >> PTS as DTS, since encoder may change the

[FFmpeg-devel] [PATCH v3 4/4] swscale/bswapdsp: copy over bswapdsp from avcodec

2022-12-12 Thread mindmark
From: Mark Reid There are some places in input.c that could use it too but they aren't currently being pass the SwsContext --- libswscale/Makefile | 1 + libswscale/bswapdsp.c| 59 libswscale/bswapdsp.h| 66 + libswscale/output.c

[FFmpeg-devel] [PATCH v3 3/4] avcodec/bswapdsp: add documentation

2022-12-12 Thread mindmark
From: Mark Reid --- libavcodec/bswapdsp.h | 33 + 1 file changed, 33 insertions(+) diff --git a/libavcodec/bswapdsp.h b/libavcodec/bswapdsp.h index 10519cfd2e..ecc37d2c56 100644 --- a/libavcodec/bswapdsp.h +++ b/libavcodec/bswapdsp.h @@ -21,11 +21,44 @@

[FFmpeg-devel] [PATCH v3 2/4] avcodec/bswapdsp: rename bswap_buf to bswap_buf32

2022-12-12 Thread mindmark
From: Mark Reid --- libavcodec/4xm.c | 8 libavcodec/alsdec.c | 6 +++--- libavcodec/apedec.c | 4 ++-- libavcodec/asvdec.c | 4 ++-- libavcodec/asvenc.c | 4 ++-- libavcodec/bswapdsp.c| 8

[FFmpeg-devel] [PATCH v3 1/4] avcodec/bswapdsp: remove unused cextern

2022-12-12 Thread mindmark
From: Mark Reid --- libavcodec/x86/bswapdsp.asm | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/x86/bswapdsp.asm b/libavcodec/x86/bswapdsp.asm index 31c6c48a21..2aa235e13c 100644 --- a/libavcodec/x86/bswapdsp.asm +++ b/libavcodec/x86/bswapdsp.asm @@ -26,8 +26,6 @@

Re: [FFmpeg-devel] [PATCH 2/2] av1dec: fix typo in logged error

2022-12-12 Thread Tristan Matthews
On Mon, Nov 28, 2022 at 10:39 AM Tristan Matthews wrote: > > --- > libavcodec/av1dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > index 80da0943d4..d83c902f1f 100644 > --- a/libavcodec/av1dec.c > +++ b/libavcodec/av1dec.c

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/avfilter: add avfilter_print_config_formats()

2022-12-12 Thread Soft Works
Another Ping Thanks, softworkz > -Original Message- > From: Paul B Mahol > Sent: Thursday, November 3, 2022 10:58 AM > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Cc: softworkz > Subject: Re: [FFmpeg-devel] [PATCH 1/2] avfilter/avfilter: add >

Re: [FFmpeg-devel] [PATCH 0/3] Add option to log timing

2022-12-12 Thread Soft Works
Ping again Thanks > -Original Message- > From: ffmpegagent > Sent: Wednesday, August 24, 2022 9:38 PM > To: ffmpeg-devel@ffmpeg.org > Cc: softworkz > Subject: [PATCH 0/3] Add option to log timing > > This pathcset adds two logging flags: 'timing' and 'datetiming'. > > Usage: > >

[FFmpeg-devel] [PATCH v5 2/2] avcodec/mjpegdec: add support for frame threading

2022-12-12 Thread Timo Rothenpieler
In my tests, this lead to a notable speed increase with the amount of threads used. Decoding a 720p sample gave the following results: 1 Thread: 1428 FPS 2 Threads: 2501 FPS 8 Threads: 7575 FPS Automatic: 11326 FPS (On a 16 Core/32 Threads system) --- libavcodec/jpeglsdec.c | 2 +-

[FFmpeg-devel] [PATCH v5 1/2] lavc: convert frame threading to the receive_frame() pattern

2022-12-12 Thread Timo Rothenpieler
From: Anton Khirnov Reorganize the code such that the frame threading code does not call the decoders directly, but instead calls back into the generic decoding code. This avoids duplicating the logic that wraps the decoder invocation and will be useful in the following commits. ---

Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-12 Thread Carl Eugen Hoyos
Am Mo., 12. Dez. 2022 um 22:02 Uhr schrieb Thomson Tan : > > I built the latest FFmpeg with WSL2+MSVC on Windows. Tried configure > with --disable-optimizations, but still got an optimized build which makes > it hard to set breakpoint on hot functions (likely inlined). Of course, this explains

Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-12 Thread Thomson Tan
I built the latest FFmpeg with WSL2+MSVC on Windows. Tried configure with --disable-optimizations, but still got an optimized build which makes it hard to set breakpoint on hot functions (likely inlined). On Mon, Dec 12, 2022 at 12:49 PM Carl Eugen Hoyos wrote: > Am Mo., 12. Dez. 2022 um 19:30

Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-12 Thread Carl Eugen Hoyos
Am Mo., 12. Dez. 2022 um 19:30 Uhr schrieb : > > Currently -O1 is set to _cflags_noopt, but -O1 is actually for size > optimization instead of no-opt which causes size optimized binaries > been built with --disable-optimizations. > > Signed-off-by: Thomson Tan > --- > configure | 2 +- > 1 file

Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-12 Thread Timo Rothenpieler
On 12.12.2022 21:32, Thomson Tan wrote: Thanks. Wondering why and where DCE is needed in FFmpeg build? Every single time "HAVE_SOMETHING" or "CONFIG_SOMETHING" is used in a normal if() instead of a pre-processor #if. That's used in a lot of places all over the codebase.

Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-12 Thread Thomson Tan
Thanks. Wondering why and where DCE is needed in FFmpeg build? On Mon, Dec 12, 2022 at 12:26 PM Timo Rothenpieler wrote: > On 12.12.2022 19:30, lilo...@gmail.com wrote: > > Currently -O1 is set to _cflags_noopt, but -O1 is actually for size > > optimization instead of no-opt which causes size

Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-12 Thread Timo Rothenpieler
On 12.12.2022 19:30, lilo...@gmail.com wrote: Currently -O1 is set to _cflags_noopt, but -O1 is actually for size optimization instead of no-opt which causes size optimized binaries been built with --disable-optimizations. It's like this very intentionally, since ffmpeg relies on

[FFmpeg-devel] [PATCH] libavcodec: Make disposition forced work with mov_text subtitles.

2022-12-12 Thread facefunk
We are not currently able to force mov_text subtitles by setting -disposition:s:0 +forced or equivalent. By setting the forced flags in movtextenc as specifid in https://developer.apple.com/library/archive/documentation/QuickTime/QTFF/QTFFChap3/qtff3.html subtitles can be forced as expected in

Re: [FFmpeg-devel] [PATCH] swscale/output: Use av_sat_add32 in yuv2rgba64 templates to avoid underflow

2022-12-12 Thread Drew Dunne
Here is the problematic input video attached. On Mon, Dec 12, 2022 at 3:08 PM Drew Dunne wrote: > Previously I sent this patch to solve an overflow in these templates. That > patch wasn't used in favor of one that biased the output calculations to > avoid the double clipping. Now I've found an

[FFmpeg-devel] [PATCH] swscale/output: Use av_sat_add32 in yuv2rgba64 templates to avoid underflow

2022-12-12 Thread Drew Dunne
Previously I sent this patch to solve an overflow in these templates. That patch wasn't used in favor of one that biased the output calculations to avoid the double clipping. Now I've found an underflow case, which I've put the command below, and I'll attach an input image in a reply. ./ffmpeg \

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/src_movie: switch to activate()

2022-12-12 Thread Paul B Mahol
Can I ask some knowledgeable people to comment why this patch have issues? On 4/2/22, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/src_movie.c | 90 + > 1 file changed, 56 insertions(+), 34 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/mov: re-allow zero sample sizes if that is not the default

2022-12-12 Thread Chris Ribble
On Sun, Dec 11, 2022 at 2:34 PM Chris Ribble wrote: > > This looks great and I've confirmed it fixes the issue. I see the > warning on STDERR about ignoring the trun box: "Ignoring trun box with > zero sized samples", which is great. > Actually, this introduces a new issue when I try to

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/jpeg2000dec: Add support for HTJ2K decoding.

2022-12-12 Thread Pierre-Anthony Lemieux
On Fri, Dec 2, 2022 at 10:46 AM Tomas Härdin wrote: > > fre 2022-12-02 klockan 21:11 +0300 skrev etemesica...@gmail.com: > > > > +/** > > + * Given a precomputed c, checks whether n % d == 0 > > + */ > > +static av_always_inline uint32_t is_divisible(uint32_t n, uint64_t > > c) > > +{ > > +

[FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-12 Thread lilotom
Currently -O1 is set to _cflags_noopt, but -O1 is actually for size optimization instead of no-opt which causes size optimized binaries been built with --disable-optimizations. Signed-off-by: Thomson Tan --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure

Re: [FFmpeg-devel] [PATCH] avformat/file: add fd protocol

2022-12-12 Thread Zhao Zhili
On Mon, 2022-12-12 at 18:31 +0200, Rémi Denis-Courmont wrote: > Le maanantaina 5. joulukuuta 2022, 4.51.34 EET zhilizhao(赵志立) a écrit > : > > > On Nov 19, 2022, at 02:48, Zhao Zhili > > > wrote: > > > > > > From: Zhao Zhili > > > > > > Unlike the pipe protocol, fd protocol has seek support if

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/file: add fd protocol

2022-12-12 Thread Rémi Denis-Courmont
Le sunnuntaina 11. joulukuuta 2022, 17.17.27 EET Zhao Zhili a écrit : > From: Zhao Zhili > > Unlike the pipe protocol, fd protocol has seek support if it > corresponding to a regular file. > --- > v2: dup the file descriptor for safety > > doc/protocols.texi | 24 ++ >

Re: [FFmpeg-devel] [PATCH] avformat/file: add fd protocol

2022-12-12 Thread Rémi Denis-Courmont
Le maanantaina 5. joulukuuta 2022, 4.51.34 EET zhilizhao(赵志立) a écrit : > > On Nov 19, 2022, at 02:48, Zhao Zhili wrote: > > > > From: Zhao Zhili > > > > Unlike the pipe protocol, fd protocol has seek support if it > > corresponding to a regular file. > > --- > > Sometimes it's the only way to

Re: [FFmpeg-devel] [PATCH] avformat: Rename IPFS to IPFS gateway

2022-12-12 Thread Tomas Härdin
fre 2022-12-09 klockan 15:52 + skrev Derek Buitenhuis: > On 12/9/2022 3:45 PM, Nicolas George wrote: > > > -static int ipfs_read(URLContext *h, unsigned char *buf, int > > > size) > > > +static int ipfs_gateway_read(URLContext *h, unsigned char *buf, > > > int size) > > > > There is no need

Re: [FFmpeg-devel] [PATCH 1/2] doc/protocols: Remove third party server

2022-12-12 Thread Derek Buitenhuis
On 12/9/2022 3:27 PM, Derek Buitenhuis wrote: > --- > doc/protocols.texi | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) I will push these two later today if there are no objections. - Derek ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] Defect: MediaCodec Encoder - Pixel ColorSpace of many Adreno GPUs not supported

2022-12-12 Thread Tomas Härdin
tor 2022-12-08 klockan 01:16 +0800 skrev Zhao Zhili: > > We can add query the supported color format and add some hints when > mediacodec configure failed. > Or we can add a helper function for user to query the color format. > It will be a bunch of JNI code, limited > by the ugly

Re: [FFmpeg-devel] [PATCH v2 5/7] avcodec/mediacodecenc: remove the strategy to create DTS

2022-12-12 Thread Tomas Härdin
ons 2022-12-07 klockan 17:31 +0800 skrev Zhao Zhili: > From: Zhao Zhili > > Use input PTS as DTS has multiple problems: > 1. If there is no reordering, it's better to just use the output > PTS as DTS, since encoder may change the timestamp value (do it > on purpose or rounding error). > > 2. If

Re: [FFmpeg-devel] [PATCH v3 3/7] avcodec/mediacodecenc: use bsf to handle crop

2022-12-12 Thread Tomas Härdin
lör 2022-12-10 klockan 01:22 +0800 skrev Zhao Zhili: > From: Zhao Zhili > > It's well known that mediacodec encoder requires 16x16 alignment. > Use our bsf to fix the crop info. > --- > v3: don't change the dimension for AV_PIX_FMT_MEDIACODEC. It can have > side effect. Looks like this silently

[FFmpeg-devel] [PATCH] configure: add OpenVino v.2022.x support

2022-12-12 Thread Saliev, Rafik F
Since OpenVino release 2022.1, the C API library filename changed from 'libinference_engine_c_api.so' to 'libopenvino_c.so'. This commit reflects such rename in the 'configure' script. Signed-off-by: Rafik Saliev --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_blackdetect: support full-range YUV

2022-12-12 Thread Niklas Haas
Any objections to these two patches? On Fri, 09 Dec 2022 01:28:05 +0100 Niklas Haas wrote: > From: Niklas Haas > > This filter currently makes the distinction between limited and full > range by testing for the deprecated YUVJ pixel formats at link setup > time. This is deprecated and should

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/decode: add a function to set frame props from a user provided packet

2022-12-12 Thread James Almer
On 12/8/2022 11:07 AM, James Almer wrote: It will be useful for decoders that don't rely on last_pkt_props to set frame props. Signed-off-by: James Almer --- libavcodec/decode.c | 19 +++ libavcodec/decode.h | 5 + 2 files changed, 20 insertions(+), 4 deletions(-)

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/mpeg4videodec: duplicate the last decoded frame when the last coded frame was skipped

2022-12-12 Thread James Almer
On 12/4/2022 6:52 PM, James Almer wrote: This ensures the video stream duration is not lost after decoding. Signed-off-by: James Almer --- libavcodec/h263dec.c | 13 + libavcodec/mpegvideo.h | 1 + 2 files changed, 14 insertions(+) diff --git a/libavcodec/h263dec.c

[FFmpeg-devel] [PATCH] libavfilter/dnn/dnn_backend_openvino.c: fix openvino async mode

2022-12-12 Thread Saliev, Rafik F
Bugfix: The OpenVino DNN backend in the 'async' mode sets 'task->inference_done' to 'complete' prior to data copy from OpenVino output buffer to task's output frame. This order causes task destroy in ff_dnn_get_result_common() prior to model output processing. Signed-off-by: Rafik Saliev ---