Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol

2023-01-10 Thread Xiang, Haihao
On Wo, 2023-01-11 at 11:18 +0800, zhilizhao(赵志立) wrote: > > On Jan 9, 2023, at 11:17, zhilizhao(赵志立) wrote: > > > > > On Dec 15, 2022, at 01:10, Zhao Zhili wrote: > > > > > > From: Zhao Zhili > > > > > > v2: > > > 1. Forbid pass file descriptor via fd:{num}, instead of -fd option > > > 2.

[FFmpeg-devel] [PATCH] avutil/hwcontext_mediacodec: fix backward compatibility

2023-01-10 Thread Zhao Zhili
From: Zhao Zhili AVMediaCodecDeviceContext without surface or native_window is useless, it shouldn't be created at all. Such dummy AVHWDeviceContext is allowed before, and it's used by mpv player. Creating a ANativeWindow automatically breaks such usecases. So disable creating a ANativeWindow

Re: [FFmpeg-devel] [PATCH] ffmpeg: apply discontinuity adjustment per-stream

2023-01-10 Thread Gyan Doshi
On 2023-01-11 01:40 am, Michael Niedermayer wrote: On Tue, Jan 03, 2023 at 03:52:17PM +0530, Gyan Doshi wrote: At present, the offset for discontinuity adjustment is applied per-file but the check for discontinuity is intra-stream so the same discontinuity when seen in multiple streams with

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec/mediacodecdec: check ff_Build_SDK_INT return value

2023-01-10 Thread zhilizhao(赵志立)
> On Jan 10, 2023, at 21:37, Tomas Härdin wrote: > > tis 2023-01-10 klockan 19:35 +0800 skrev Zhao Zhili: >> From: Zhao Zhili >> >> --- >> v3: when target API <= 24 ==> when target API < 24 >> v2: add comments >> >> libavcodec/mediacodecdec.c | 8 +++- >> 1 file changed, 7

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/videotoolboxenc: fix error code

2023-01-10 Thread zhilizhao(赵志立)
> On Jan 4, 2023, at 10:38, Steven Liu wrote: > > Zhao Zhili 于2023年1月4日周三 10:35写道: >> >> From: Zhao Zhili >> >> 1. Fix return 0 on success. >> 2. Fix return OS error code passthrough. >> --- >> libavcodec/videotoolboxenc.c | 8 ++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >>

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/videotoolboxenc: pass error code through

2023-01-10 Thread zhilizhao(赵志立)
> On Jan 4, 2023, at 10:35, zhilizhao(赵志立) wrote: > > > >> On Jan 4, 2023, at 02:11, Tomas Härdin wrote: >> >> tis 2023-01-03 klockan 18:18 +0800 skrev Zhao Zhili: >>> From: Zhao Zhili >>> >>> Signed-off-by: Zhao Zhili >>> --- >>> libavcodec/videotoolboxenc.c | 4 ++-- >>> 1 file

Re: [FFmpeg-devel] [PATCH v3 0/8] add fd protocol

2023-01-10 Thread zhilizhao(赵志立)
> On Jan 9, 2023, at 11:17, zhilizhao(赵志立) wrote: > >> On Dec 15, 2022, at 01:10, Zhao Zhili wrote: >> >> From: Zhao Zhili >> >> v2: >> 1. Forbid pass file descriptor via fd:{num}, instead of -fd option >> 2. Set CLOEXEC >> 3. Prefer fd over pipe for fftools >> >> v1: dup file descriptor

[FFmpeg-devel] [PATCH] lavf/spdifdec: support EAC3

2023-01-10 Thread rcombs
Parsing should probably be enabled for all codecs, at least for headers, but e.g. the AAC parser produces 1-byte packets of zero padding with it, so I'm just enabling it for EAC3 for the moment. --- libavformat/spdifdec.c | 19 +- tests/fate/spdif.mak| 3 +

Re: [FFmpeg-devel] [PATCH v3 08/11] lavc/vaapi_hevc: Pass SCC parameters Through VA-API

2023-01-10 Thread Wang, Fei W
> -Original Message- > From: Wang, Fei W > Sent: Tuesday, January 3, 2023 9:00 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Linjie Fu ; Linjie Fu ; > Wang, > Fei W > Subject: [FFmpeg-devel][PATCH v3 08/11] lavc/vaapi_hevc: Pass SCC parameters > Through VA-API > > From: Linjie Fu > >

Re: [FFmpeg-devel] [PATCH v3 10/11] lavc/vaapi_hevc: Set correct rps type for scc

2023-01-10 Thread Wang, Fei W
> -Original Message- > From: Wang, Fei W > Sent: Tuesday, January 3, 2023 9:00 PM > To: ffmpeg-devel@ffmpeg.org > Cc: Linjie Fu ; Linjie Fu ; > Wang, > Fei W > Subject: [FFmpeg-devel][PATCH v3 10/11] lavc/vaapi_hevc: Set correct rps type > for scc > > From: Linjie Fu > > According to

[FFmpeg-devel] [PATCH v2] lavf/rtpenc_jpeg: Retrieve sampling factor from SOF0

2023-01-10 Thread Yeoh, Hoong Tee
In ff_rtp_send_jpeg, the type is defined based on PIX_FMT and color-range parsed in. There is limitation on current design where need to include support newly introduced PIX_FMT such as AV_PIX_FMT_QSV and there might be more and more in future. Hence, retrive the sampling factor from SOF0 in JPEG

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpx: remove thread limit

2023-01-10 Thread James Zern
On Tue, Jan 10, 2023 at 2:47 AM myp...@gmail.com wrote: > > On Thu, Jan 5, 2023 at 6:42 PM Dmitrii Ovchinnikov > wrote: > [...] > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > > index 9aa5510c28..0627e13973 100644 > > --- a/libavcodec/libvpxenc.c > > +++

Re: [FFmpeg-devel] [PATCH v3 1/4] avcodec/bswapdsp: remove unused cextern

2023-01-10 Thread Mark Reid
On Tue, Jan 10, 2023 at 3:07 AM Anton Khirnov wrote: > Quoting Mark Reid (2023-01-06 19:09:10) > > On Mon, Dec 26, 2022 at 1:31 PM Mark Reid wrote: > > > > > > > > > > > On Mon, Dec 12, 2022 at 6:42 PM wrote: > > > > > >> From: Mark Reid > > >> > > >> --- > > >> libavcodec/x86/bswapdsp.asm |

[FFmpeg-devel] [PATCH v2] fate/imfdec: add audio test

2023-01-10 Thread pal
From: Pierre-Anthony Lemieux Improves the test material by using audio and video resources whose respective temporal boundaries do not line up. https://www.sandflow.com/public/countdown-audio-2023-01-10-2.zip --- tests/fate/imf.mak| 3 + tests/ref/fate/imf-cpl-with-audio |

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: expose AVAmbientViewingEnvironment side data in AVFrames

2023-01-10 Thread James Almer
On 1/10/2023 6:19 PM, Jan Ekström wrote: --- fftools/ffprobe.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index d2f126d9d6..15c61e1c7c 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -33,6 +33,7 @@ #include

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/cbs_{h2645, sei}: add support for Ambient Viewing Environment SEI

2023-01-10 Thread James Almer
On 1/10/2023 6:19 PM, Jan Ekström wrote: Defined by H.274, this SEI message is utilized by iPhones to save the nominal ambient viewing environment for the display of recorded HDR content. --- libavcodec/cbs_h2645.c | 6 ++ libavcodec/cbs_sei.h | 6 ++

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/h2645_sei: add support for Ambient Viewing Environment SEI

2023-01-10 Thread James Almer
On 1/10/2023 6:19 PM, Jan Ekström wrote: Defined by H.274, this SEI message is utilized by iPhones to save the nominal ambient viewing environment for the display of recorded HDR content. The contents of the message are exposed to API users as AVFrame side data containing

Re: [FFmpeg-devel] [PATCH 2/4] avutil: introduce AVAmbientViewingEnvironment side data

2023-01-10 Thread James Almer
On 1/10/2023 6:19 PM, Jan Ekström wrote: This enables exposing H.274 Ambient Viewing Environment metadata in the framework. --- doc/APIchanges | 6 +++ libavutil/Makefile | 2 + libavutil/ambient_viewing_environment.c | 51 ++

[FFmpeg-devel] [PATCH 4/4] avcodec/h2645_sei: add support for Ambient Viewing Environment SEI

2023-01-10 Thread Jan Ekström
Defined by H.274, this SEI message is utilized by iPhones to save the nominal ambient viewing environment for the display of recorded HDR content. The contents of the message are exposed to API users as AVFrame side data containing AVAmbientViewingEnvironment. As the DV RPU test sample is from an

[FFmpeg-devel] [PATCH 3/4] ffprobe: expose AVAmbientViewingEnvironment side data in AVFrames

2023-01-10 Thread Jan Ekström
--- fftools/ffprobe.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index d2f126d9d6..15c61e1c7c 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -33,6 +33,7 @@ #include "libavformat/version.h" #include "libavcodec/avcodec.h"

[FFmpeg-devel] [PATCH 2/4] avutil: introduce AVAmbientViewingEnvironment side data

2023-01-10 Thread Jan Ekström
This enables exposing H.274 Ambient Viewing Environment metadata in the framework. --- doc/APIchanges | 6 +++ libavutil/Makefile | 2 + libavutil/ambient_viewing_environment.c | 51 ++ libavutil/ambient_viewing_environment.h | 72

[FFmpeg-devel] [PATCH 1/4] avcodec/cbs_{h2645, sei}: add support for Ambient Viewing Environment SEI

2023-01-10 Thread Jan Ekström
Defined by H.274, this SEI message is utilized by iPhones to save the nominal ambient viewing environment for the display of recorded HDR content. --- libavcodec/cbs_h2645.c | 6 ++ libavcodec/cbs_sei.h | 6 ++ libavcodec/cbs_sei_syntax_template.c | 17

Re: [FFmpeg-devel] [PATCH] Request for adding XPSNR avfilter

2023-01-10 Thread Paul B Mahol
On 1/10/23, Helmrich, Christian wrote: > Hi, > > please find attached a patch (relative to FFmpeg master as of early January > 10, 2023) > adding avfilter support for extended perceptually weighted peak > signal-to-noise ratio > (XPSNR) measurements for videos, as described in the related

Re: [FFmpeg-devel] [PATCH] ffmpeg: apply discontinuity adjustment per-stream

2023-01-10 Thread Michael Niedermayer
On Tue, Jan 03, 2023 at 03:52:17PM +0530, Gyan Doshi wrote: > At present, the offset for discontinuity adjustment is applied per-file but > the check for discontinuity is intra-stream so the same discontinuity when > seen in multiple streams with copyts, leads to compounded adjustment of the >

Re: [FFmpeg-devel] [PATCH] ffmpeg: apply discontinuity adjustment per-stream

2023-01-10 Thread Gyan Doshi
On 2023-01-10 04:32 pm, Anton Khirnov wrote: Quoting Gyan Doshi (2023-01-03 11:22:17) At present, the offset for discontinuity adjustment is applied per-file but the check for discontinuity is intra-stream so the same discontinuity when seen in multiple streams with copyts, leads to

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-10 Thread Paul B Mahol
On 1/10/23, Jeffrey CHAPUIS wrote: > Hello, > I decided to continue on a simpler path without 'reset/reset_count', it was > only to experiment anyway, 'limit' is the main goal. > 'limit' is added to the metadata to control that the result is associated to > a change at runtime, it's after scaling

[FFmpeg-devel] [PATCH 2/2] fate: update test reference data to include AV_PKT_FLAG_FIXED_DURATION

2023-01-10 Thread Miguel Borges de Freitas
From: Miguel Borges de Freitas Updates some of the test reference data to include the new AV_PKT_FLAG_FIXED_DURATION (this is the case for most matroska subtitles) Signed-off-by: Miguel Borges de Freitas --- tests/ref/fate/matroska-dvbsub-remux | 84 ++--

[FFmpeg-devel] [PATCH 1/2] libavformat/matroskadec: set fixed duration for subtitles

2023-01-10 Thread Miguel Borges de Freitas
From: Miguel Borges de Freitas The matroska specification states the start time and duration of subtitle entries are encoded in the block TimeStamp and BlockDuration. Furthermore, for all subtitle formats except S_HDMV/PGS the BlockDuration must always be defined and have an absolute value even

[FFmpeg-devel] [PATCH 0/2] libavformat/matroskadec: set fixed duration for subtitles

2023-01-10 Thread ffmpegagent
The matroska specification states the start time and duration of subtitle entries are encoded in the block TimeStamp and BlockDuration. Furthermore, for all subtitle formats except S_HDMV/PGS the BlockDuration must always be defined and have an absolute value even if it is simply 0. ffmpeg assumes

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/mediacodec_wrapper: get api level via NDK method

2023-01-10 Thread Tomas Härdin
tis 2023-01-10 klockan 19:30 +0800 skrev Zhao Zhili: > From: Zhao Zhili > > android_get_device_api_level() is a static inline before API level > 29. It was implemented via __system_property_get(). We can do the > same thing, but I don't want to mess up with __system_property_get. > --- >  

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec/mediacodecdec: check ff_Build_SDK_INT return value

2023-01-10 Thread Tomas Härdin
tis 2023-01-10 klockan 19:35 +0800 skrev Zhao Zhili: > From: Zhao Zhili > > --- > v3: when target API <= 24 ==> when target API < 24 > v2: add comments > >  libavcodec/mediacodecdec.c | 8 +++- >  1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/mediacodecdec.c

Re: [FFmpeg-devel] [PATCH] avfilter/vf_cropdetect: add ability to change limit/reset at runtime

2023-01-10 Thread Jeffrey CHAPUIS
Hello, I decided to continue on a simpler path without 'reset/reset_count', it was only to experiment anyway, 'limit' is the main goal. 'limit' is added to the metadata to control that the result is associated to a change at runtime, it's after scaling with bitdetph but that's not really a

Re: [FFmpeg-devel] [PATCH v1 00/11] Add support for H266/VVC

2023-01-10 Thread myp...@gmail.com
On Tue, Jan 10, 2023 at 10:56 AM Nuo Mi wrote: > > Hi Thomas > It works for me. > > BTW, I will send out a C version of VVC native decoder very soon. > Please also help review and improve it. > Thank you. Ha, it's great news > > On Tue, Jan 3, 2023 at 10:02 PM Thomas Siedel > wrote: > > > On

Re: [FFmpeg-devel] [PATCH v3 1/4] avcodec/bswapdsp: remove unused cextern

2023-01-10 Thread Anton Khirnov
Quoting Mark Reid (2023-01-06 19:09:10) > On Mon, Dec 26, 2022 at 1:31 PM Mark Reid wrote: > > > > > > > On Mon, Dec 12, 2022 at 6:42 PM wrote: > > > >> From: Mark Reid > >> > >> --- > >> libavcodec/x86/bswapdsp.asm | 2 -- > >> 1 file changed, 2 deletions(-) > >> > >> diff --git

Re: [FFmpeg-devel] [PATCH] ffmpeg: apply discontinuity adjustment per-stream

2023-01-10 Thread Anton Khirnov
Quoting Gyan Doshi (2023-01-03 11:22:17) > At present, the offset for discontinuity adjustment is applied per-file but > the check for discontinuity is intra-stream so the same discontinuity when > seen in multiple streams with copyts, leads to compounded adjustment of the > discontinuity offset.

Re: [FFmpeg-devel] [PATCH v3] lavc/libvpx: remove thread limit

2023-01-10 Thread myp...@gmail.com
On Thu, Jan 5, 2023 at 6:42 PM Dmitrii Ovchinnikov wrote: > > From: Dmitrii Ovchinnikov > > This change improves the performance and multicore > scalability of the vp9 codec for streaming single-pass encoded videos. The > current thread limit for ffmpeg codecs is 16 (MAX_AUTO_THREADS in >

Re: [FFmpeg-devel] [PATCH] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames

2023-01-10 Thread David Rosca
On Mon, Jan 9, 2023 at 10:11 PM Mark Thompson wrote: > > On 09/01/2023 07:37, David Rosca wrote: > > On Mon, Jan 9, 2023 at 3:22 AM Xiang, Haihao wrote: > >> > >> On Do, 2022-12-29 at 22:20 +0100, David Rosca wrote: > >>> --- > >>> libavcodec/vaapi_encode_h264.c | 2 +- > >>> 1 file changed,

[FFmpeg-devel] [PATCH v2] vaapi_encode_h264: Only set pic_order_cnt_type to 0 with B-frames

2023-01-10 Thread David Rosca
v2: frame_num steps by 2 --- libavcodec/vaapi_encode_h264.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/vaapi_encode_h264.c b/libavcodec/vaapi_encode_h264.c index 7a6b54ab6f..8093c47179 100644 --- a/libavcodec/vaapi_encode_h264.c +++