[FFmpeg-devel] [PATCH] avcodec/nvenc: fix intraRefreshPeriod setting

2023-07-05 Thread Zhao Zhili
From: Zhao Zhili Regression since 99dfdb45. intraRefreshPeriod access cc->gopLength, which has been overwritten to NVENC_INFINITE_GOPLENGTH before. Fixes #10445. --- libavcodec/nvenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/nvenc.c

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

2023-07-05 Thread David Lemler
> On 07/05/2023 2:16 PM CDT James Zern wrote: > > > On Wed, Jul 5, 2023 at 12:15 PM James Zern wrote: > > > > Hi, > > > > +ffmpeg-dev. I took the wrong email off the reply. > > > On Mon, Jul 3, 2023 at 10:08 PM David Lemler wrote: > > > > > > Prevent the fifo used in encoding VPx videos

Re: [FFmpeg-devel] [PATCH v4] avcodec/cbs_h266: add support for Adaptation parameter set NALU type

2023-07-05 Thread James Almer
On 7/5/2023 9:41 PM, Nuo Mi wrote: +if (current->alf_cc_cb_filter_signal_flag) +ue(alf_cc_cb_filters_signalled_minus1, 0, 3); +else +infer(alf_cc_cb_filters_signalled_minus1, 0); Not right, it will overread one filter set even alf_cc_cb_filter_signal_flag is false. It

Re: [FFmpeg-devel] [PATCH v4] avcodec/cbs_h266: add support for Adaptation parameter set NALU type

2023-07-05 Thread Nuo Mi
On Thu, Jul 6, 2023 at 2:36 AM James Almer wrote: > Signed-off-by: James Almer > --- > v3 was mistakenly sent without the amended changes, so it's the > same as v2. > > libavcodec/cbs_h2645.c| 21 +++ > libavcodec/cbs_h266.h | 46 + >

Re: [FFmpeg-devel] [PATCH 1/6] avradio/sdrdemux: end on EOF dont wraparound

2023-07-05 Thread Michael Niedermayer
On Wed, Jul 05, 2023 at 12:22:57AM +0200, Michael Niedermayer wrote: > This is more usefull for testing > > Signed-off-by: Michael Niedermayer > --- > libavradio/sdrdemux.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) will apply patchset [...] -- Michael GnuPG

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-05 Thread Michael Niedermayer
On Wed, Jul 05, 2023 at 11:22:44AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-07-05 01:50:12) > > On Tue, Jul 04, 2023 at 07:54:06AM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2023-07-04 01:50:57) > > > > On Mon, Jul 03, 2023 at 11:09:54PM +0200, Anton

Re: [FFmpeg-devel] [PATCH v4 0/7] avfilter/vf_bwdif: Add aarch64 neon functions

2023-07-05 Thread Martin Storsjö
On Tue, 4 Jul 2023, John Cox wrote: Also adds a filter_line3 method which on aarch64 neon yields approx 30% speedup over 2xfilter_line and a memcpy Differences from v3: Remove a few lines of neon in filter_line that should have been removed when copying from line3 Sorry about the two patch

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

2023-07-05 Thread James Zern
On Wed, Jul 5, 2023 at 12:15 PM James Zern wrote: > > Hi, > +ffmpeg-dev. I took the wrong email off the reply. > On Mon, Jul 3, 2023 at 10:08 PM David Lemler wrote: > > > > Prevent the fifo used in encoding VPx videos from filling up and stopping > > encode when it reaches 21845 items, which

[FFmpeg-devel] [PATCH v4] avcodec/cbs_h266: add support for Adaptation parameter set NALU type

2023-07-05 Thread James Almer
Signed-off-by: James Almer --- v3 was mistakenly sent without the amended changes, so it's the same as v2. libavcodec/cbs_h2645.c| 21 +++ libavcodec/cbs_h266.h | 46 + libavcodec/cbs_h266_syntax_template.c | 231 ++ libavcodec/vvc.h

[FFmpeg-devel] [PATCH v3] avcodec/cbs_h266: add support for Adaptation parameter set NALU type

2023-07-05 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 21 +++ libavcodec/cbs_h266.h | 46 ++ libavcodec/cbs_h266_syntax_template.c | 230 ++ libavcodec/vvc.h | 10 ++ 4 files changed, 307 insertions(+) diff

[FFmpeg-devel] [PATCH v2 3/4] avcodec/cbs_h266: add support for Adaptation parameter set NALU type

2023-07-05 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h2645.c| 21 +++ libavcodec/cbs_h266.h | 46 ++ libavcodec/cbs_h266_syntax_template.c | 230 ++ libavcodec/vvc.h | 10 ++ 4 files changed, 307 insertions(+) diff

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/h264_mp4toannexb_bsf: fix missing PS before IDR frames

2023-07-05 Thread Thilo Borgmann
Hi, Am 19.05.23 um 18:41 schrieb Zhao Zhili: From: Zhao Zhili If there is a single group of SPS/PPS before an IDR frame, but no SPS/PPS after that, we will miss the chance to reset idr_sps_seen/idr_pps_seen. No SPS/PPS are inserted afterwards. This patch saves in-band SPS/PPS and insert them

Re: [FFmpeg-devel] [PATCH v3 1/3] avutil/random_seed: use fread() in read_random()

2023-07-05 Thread Rémi Denis-Courmont
Le keskiviikkona 5. heinäkuuta 2023, 2.26.12 EEST James Almer a écrit : > This ensures the requested amount of bytes is read. You're moving the problem though. Now, you may read more than necessary (and block longer than necessary) due to stdio internal buffering, which you did not disable. >

Re: [FFmpeg-devel] [PATCH v2 4/5] mpegtsenc: Don't periodically announce PCR on SCTE-35 streams

2023-07-05 Thread Devin Heitmueller
Hi Marton, On Mon, Jul 3, 2023 at 3:20 PM Marton Balint wrote: > Hmm, only one PID per service should generate PCR, and if there is a video > stream in the service, then that is preferred for PCR generation. An SCTE > stream should only get selected for PCR if there are no video streams in a >

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/cbs_h266: add support for Operating point information NALU type

2023-07-05 Thread Nuo Mi
On Mon, Jul 3, 2023 at 7:28 AM James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cbs_h2645.c| 18 ++ > libavcodec/cbs_h266.h | 11 +++ > libavcodec/cbs_h266_syntax_template.c | 27 +++ > 3 files

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/cbs_h266: add support for Adaptation parameter set NALU type

2023-07-05 Thread Nuo Mi
On Mon, Jul 3, 2023 at 7:28 AM James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cbs_h2645.c| 21 +++ > libavcodec/cbs_h266.h | 46 ++ > libavcodec/cbs_h266_syntax_template.c | 201 ++ > libavcodec/vvc.h

[FFmpeg-devel] [PATCH v2] cbs_h266: add range extension support

2023-07-05 Thread Nuo Mi
From: frankplow example clips: * 12b444vvc1_E_Sony_2 * 12b444Ietsrc_A_Kwai_2 * 10b444P16_D_Sony_2 * 12b444Iepp_A_Sharp_2 * 12b444SPetsrc_B_Kwai_2 Co-authored-by: Nuo Mi --- libavcodec/cbs_h266.h | 23 +++- libavcodec/cbs_h266_syntax_template.c | 81

Re: [FFmpeg-devel] [PATCH v4 2/4] avutil/random_seed: add av_random_bytes()

2023-07-05 Thread James Almer
On 7/5/2023 9:46 AM, Anton Khirnov wrote: Quoting James Almer (2023-07-05 14:12:47) Uses the existing code for av_get_random_seed() to return a buffer with cryptographically secure random data, or an error if none could be generated. Signed-off-by: James Almer --- libavutil/random_seed.c |

Re: [FFmpeg-devel] [PATCH v3 1/3] avutil/random_seed: use fread() in read_random()

2023-07-05 Thread James Almer
On 7/5/2023 9:43 AM, Anton Khirnov wrote: Quoting James Almer (2023-07-05 01:26:12) This ensures the requested amount of bytes is read. Also remove /dev/random as it's no longer necessary. Signed-off-by: James Almer --- libavutil/random_seed.c | 23 --- 1 file changed,

Re: [FFmpeg-devel] [PATCH v3 3/3] avutil/random_seed: add support for gcrypt and OpenSSL as source of randomness

2023-07-05 Thread James Almer
On 7/5/2023 9:56 AM, Anton Khirnov wrote: Quoting James Almer (2023-07-05 01:26:14) Signed-off-by: James Almer --- configure | 2 +- libavutil/random_seed.c | 16 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/configure b/configure index

Re: [FFmpeg-devel] [PATCH v3 3/3] avutil/random_seed: add support for gcrypt and OpenSSL as source of randomness

2023-07-05 Thread Anton Khirnov
Quoting James Almer (2023-07-05 01:26:14) > Signed-off-by: James Almer > --- > configure | 2 +- > libavutil/random_seed.c | 16 > 2 files changed, 17 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index 107d533b3e..d6e78297fe 100755 > ---

Re: [FFmpeg-devel] [PATCH] cbs_h266: add range extension support

2023-07-05 Thread Frank Plowman
On 05/07/2023 13:38, Frank Plowman wrote: On 05/07/2023 12:45, James Almer wrote: On 7/5/2023 8:38 AM, Nuo Mi wrote: From: frankplow ---   libavcodec/cbs_h266.h | 18 ++   libavcodec/cbs_h266_syntax_template.c | 79 +--   2 files changed, 93

Re: [FFmpeg-devel] [PATCH v4 2/4] avutil/random_seed: add av_random_bytes()

2023-07-05 Thread Anton Khirnov
Quoting James Almer (2023-07-05 14:12:47) > Uses the existing code for av_get_random_seed() to return a buffer with > cryptographically secure random data, or an error if none could be generated. > > Signed-off-by: James Almer > --- > libavutil/random_seed.c | 33

Re: [FFmpeg-devel] [PATCH v3 1/3] avutil/random_seed: use fread() in read_random()

2023-07-05 Thread Anton Khirnov
Quoting James Almer (2023-07-05 01:26:12) > This ensures the requested amount of bytes is read. > Also remove /dev/random as it's no longer necessary. > > Signed-off-by: James Almer > --- > libavutil/random_seed.c | 23 --- > 1 file changed, 12 insertions(+), 11 deletions(-)

Re: [FFmpeg-devel] [PATCH] cbs_h266: add range extension support

2023-07-05 Thread Frank Plowman
On 05/07/2023 12:45, James Almer wrote: On 7/5/2023 8:38 AM, Nuo Mi wrote: From: frankplow ---   libavcodec/cbs_h266.h | 18 ++   libavcodec/cbs_h266_syntax_template.c | 79 +--   2 files changed, 93 insertions(+), 4 deletions(-) diff --git

[FFmpeg-devel] [PATCH v4 2/4] avutil/random_seed: add av_random_bytes()

2023-07-05 Thread James Almer
Uses the existing code for av_get_random_seed() to return a buffer with cryptographically secure random data, or an error if none could be generated. Signed-off-by: James Almer --- libavutil/random_seed.c | 33 ++--- libavutil/random_seed.h | 13 + 2

Re: [FFmpeg-devel] [PATCH] cbs_h266: add range extension support

2023-07-05 Thread James Almer
On 7/5/2023 8:38 AM, Nuo Mi wrote: From: frankplow --- libavcodec/cbs_h266.h | 18 ++ libavcodec/cbs_h266_syntax_template.c | 79 +-- 2 files changed, 93 insertions(+), 4 deletions(-) diff --git a/libavcodec/cbs_h266.h b/libavcodec/cbs_h266.h

[FFmpeg-devel] [PATCH 2/2] vvc.h: Enable 16-bit support for VVC_MAX_POINTS_IN_QP_TABLE

2023-07-05 Thread Nuo Mi
--- libavcodec/vvc.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/vvc.h b/libavcodec/vvc.h index 099d2fc2ad..7cf26d5e8c 100644 --- a/libavcodec/vvc.h +++ b/libavcodec/vvc.h @@ -102,9 +102,10 @@ enum { VVC_MAX_REF_ENTRIES = VVC_MAX_DPB_SIZE + 13,

[FFmpeg-devel] [PATCH 1/2] cbs_h266: expand the bit depth range to 16 bits

2023-07-05 Thread Nuo Mi
From: Frank Plowman --- libavcodec/cbs_h266_syntax_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec/cbs_h266_syntax_template.c index ae44565a54..485c02f590 100644 --- a/libavcodec/cbs_h266_syntax_template.c

[FFmpeg-devel] [PATCH] cbs_h266: add range extension support

2023-07-05 Thread Nuo Mi
From: frankplow --- libavcodec/cbs_h266.h | 18 ++ libavcodec/cbs_h266_syntax_template.c | 79 +-- 2 files changed, 93 insertions(+), 4 deletions(-) diff --git a/libavcodec/cbs_h266.h b/libavcodec/cbs_h266.h index e33d08a0f5..40aba9eb13 100644 ---

Re: [FFmpeg-devel] [PATCH v3 2/3] avutil/random_seed: add av_random_bytes()

2023-07-05 Thread Anton Khirnov
Quoting James Almer (2023-07-05 01:26:13) > diff --git a/libavutil/random_seed.h b/libavutil/random_seed.h > index 0462a048e0..8df37da8f8 100644 > --- a/libavutil/random_seed.h > +++ b/libavutil/random_seed.h > @@ -36,6 +36,18 @@ > */ > uint32_t av_get_random_seed(void); > > +/** > + *

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-05 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-07-05 01:50:12) > On Tue, Jul 04, 2023 at 07:54:06AM +0200, Anton Khirnov wrote: > > Quoting Michael Niedermayer (2023-07-04 01:50:57) > > > On Mon, Jul 03, 2023 at 11:09:54PM +0200, Anton Khirnov wrote: > > > > Quoting Marton Balint (2023-07-03 22:54:41) > > > >