Re: [FFmpeg-devel] [RFC] Release 6.1

2023-07-07 Thread Neal Gompa
On Thu, Jul 6, 2023 at 12:04 PM Lynne wrote: > > It's been a while since we've had a release, and we've had > a lot of new features in. > We did say we would make releases more often, and I think > it's about time we have a new release. > > Anything anyone wants to have merged or should we branch

Re: [FFmpeg-devel] [RFC] Release 6.1

2023-07-07 Thread Michael Niedermayer
On Fri, Jul 07, 2023 at 05:33:32PM +0200, Lynne wrote: > Jul 7, 2023, 17:07 by mich...@niedermayer.cc: > > > Hi > > > > On Thu, Jul 06, 2023 at 06:04:41PM +0200, Lynne wrote: > > > >> It's been a while since we've had a release, and we've had > >> a lot of new features in. > >> We did say we

[FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

2023-07-07 Thread David Lemler
Prevent the fifo used in encoding VPx videos from filling up and stopping encode when it reaches 21845 items, which happens when the video has more than that number of frames. Incorporated suggestion from James Zern to prevent calling frame_data_submit() at all when performing the first pass of a

Re: [FFmpeg-devel] [PATCH] lavu/random_seed: use getrandom() when available

2023-07-07 Thread Marton Balint
On Fri, 7 Jul 2023, Anton Khirnov wrote: It is a better interface for /dev/u?random on Linux, which avoids the issues associated with opening files. getrandom() actually have the same problem as read(). It can read less than requested. So you should use it in a loop in that case or if it

Re: [FFmpeg-devel] [PATCH] configure: use just the pkg-config for sndio

2023-07-07 Thread Brad Smith
On 2023-07-01 2:58 p.m., Brad Smith wrote: On 2023-06-23 7:36 p.m., Brad Smith wrote: On 2023-06-23 7:35 p.m., Michael Niedermayer wrote: On Fri, Jun 23, 2023 at 06:56:30PM -0400, Brad Smith wrote: On 2023-06-23 6:55 p.m., Michael Niedermayer wrote: On Fri, Jun 23, 2023 at 06:41:08PM -0400,

[FFmpeg-devel] [PATCH 9/9] avradio/sdrdemux: Use 2 differnt FM station detectors

2023-07-07 Thread Michael Niedermayer
Detect station if both lie within 1kHz of each other This eliminates some artifacts being detected Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c

[FFmpeg-devel] [PATCH 8/9] avradio/sdrdemux: increase the FM station frequency tolerance

2023-07-07 Thread Michael Niedermayer
The current FM station probing code is quite inaccurate with the detected frequency. Doing better requires some extra computations, maybe this is good enough Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[FFmpeg-devel] [PATCH 7/9] avradio/sdr: Compute and use detection histogram

2023-07-07 Thread Michael Niedermayer
By analyzing the behavior of the detectability of stations with different SDR settings we can separate some SDR artifacts from weak stations. Signed-off-by: Michael Niedermayer --- libavradio/sdr.h | 5 + libavradio/sdrdemux.c | 36 +++- 2 files

[FFmpeg-devel] [PATCH 6/9] avradio/sdrdemux: count timeout irrespective of a station being active

2023-07-07 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavradio/sdrdemux.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavradio/sdrdemux.c b/libavradio/sdrdemux.c index ad3e253ced..6cb9d3b70a 100644 --- a/libavradio/sdrdemux.c +++ b/libavradio/sdrdemux.c @@ -327,12 +327,11 @@

[FFmpeg-devel] [PATCH 5/9] avradio/sdr: Allow user to adjust FM/AM thresholds

2023-07-07 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- doc/demuxers.texi | 9 + libavradio/sdr.h | 3 +++ libavradio/sdrdemux.c | 18 +++--- 3 files changed, 19 insertions(+), 11 deletions(-) diff --git a/doc/demuxers.texi b/doc/demuxers.texi index fc2ab9fc27..81c46ce08f 100644

[FFmpeg-devel] [PATCH 4/9] avradio/sdr: Eliminate station list

2023-07-07 Thread Michael Niedermayer
Its redudnant with the AVTree information Makes the code simpler Signed-off-by: Michael Niedermayer --- libavradio/sdr.h | 9 libavradio/sdrdemux.c | 107 ++ 2 files changed, 55 insertions(+), 61 deletions(-) diff --git a/libavradio/sdr.h

[FFmpeg-devel] [PATCH 3/9] avradio/sdr: consolidate the candidate station list with the main list

2023-07-07 Thread Michael Niedermayer
This way any updates to one is reflected in the other --- libavradio/sdr.h | 1 + libavradio/sdrdemux.c | 53 ++- 2 files changed, 28 insertions(+), 26 deletions(-) diff --git a/libavradio/sdr.h b/libavradio/sdr.h index 29465df0a1..4b1543efd3 100644

[FFmpeg-devel] [PATCH 2/9] avradio/sdr: Consolidate candidate station entries

2023-07-07 Thread Michael Niedermayer
also average frequcnies in candiddate station detections Signed-off-by: Michael Niedermayer --- libavradio/sdr.h | 1 + libavradio/sdrdemux.c | 45 --- 2 files changed, 39 insertions(+), 7 deletions(-) diff --git a/libavradio/sdr.h

[FFmpeg-devel] [PATCH 1/9] avradio/sdr: use AVTree for candidate stations

2023-07-07 Thread Michael Niedermayer
This is needed so we can keep more information about stations without performance issues Signed-off-by: Michael Niedermayer --- libavradio/sdr.h | 4 +- libavradio/sdrdemux.c | 126 -- 2 files changed, 110 insertions(+), 20 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

2023-07-07 Thread James Zern
On Wed, Jul 5, 2023 at 7:22 PM David Lemler wrote: > > > On 07/05/2023 2:16 PM CDT James Zern wrote: > > > > > > On Wed, Jul 5, 2023 at 12:15 PM James Zern wrote: > > > > > > Hi, > > > > > > > +ffmpeg-dev. I took the wrong email off the reply. > > > > > On Mon, Jul 3, 2023 at 10:08 PM David

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: prevent fifo from filling up

2023-07-07 Thread James Zern
On Thu, Jul 6, 2023 at 12:45 AM Anton Khirnov wrote: > > Quoting James Zern (2023-07-05 21:16:37) > > On Wed, Jul 5, 2023 at 12:15 PM James Zern wrote: > > > > > > Hi, > > > > > > > +ffmpeg-dev. I took the wrong email off the reply. > > > > > On Mon, Jul 3, 2023 at 10:08 PM David Lemler wrote:

Re: [FFmpeg-devel] [PATCH v2 03/14] vvcdec: add sps, pps, sh parser

2023-07-07 Thread James Almer
On 7/7/2023 12:48 PM, Nuo Mi wrote: Hi James, thank you for the review. On Fri, Jul 7, 2023 at 10:28 PM James Almer wrote: On 7/7/2023 11:05 AM, Nuo Mi wrote: --- libavcodec/vvc/Makefile |4 +- libavcodec/vvc/vvc_data.c | 3295 +++

Re: [FFmpeg-devel] [PATCH] Optimization: support for libx264's mb_info

2023-07-07 Thread Carotti, Elias
On Mon, 2023-07-03 at 15:51 +, Carotti, Elias wrote: > On Sat, 2023-07-01 at 10:33 +0200, Anton Khirnov wrote: > > CAUTION: This email originated from outside of the organization. Do > > not click links or open attachments unless you can confirm the > > sender > > and know the content is safe.

Re: [FFmpeg-devel] [PATCH v2 03/14] vvcdec: add sps, pps, sh parser

2023-07-07 Thread Nuo Mi
Hi James, thank you for the review. On Fri, Jul 7, 2023 at 10:28 PM James Almer wrote: > On 7/7/2023 11:05 AM, Nuo Mi wrote: > > --- > > libavcodec/vvc/Makefile |4 +- > > libavcodec/vvc/vvc_data.c | 3295 +++ > > libavcodec/vvc/vvc_data.h | 69 + > >

Re: [FFmpeg-devel] [RFC] Release 6.1

2023-07-07 Thread Lynne
Jul 7, 2023, 17:07 by mich...@niedermayer.cc: > Hi > > On Thu, Jul 06, 2023 at 06:04:41PM +0200, Lynne wrote: > >> It's been a while since we've had a release, and we've had >> a lot of new features in. >> We did say we would make releases more often, and I think >> it's about time we have a new

Re: [FFmpeg-devel] [RFC] Release 6.1

2023-07-07 Thread Michael Niedermayer
Hi On Thu, Jul 06, 2023 at 06:04:41PM +0200, Lynne wrote: > It's been a while since we've had a release, and we've had > a lot of new features in. > We did say we would make releases more often, and I think > it's about time we have a new release. yes > > Anything anyone wants to have merged

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-07 Thread Michael Niedermayer
On Fri, Jul 07, 2023 at 10:05:50AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2023-07-07 02:55:46) > > > > The litteral wording was > > "that guarantees either cryptographically secure randomness or an error." > > > > that was what i refered to. > > > > the wording used now: > >

Re: [FFmpeg-devel] [PATCH v2 03/14] vvcdec: add sps, pps, sh parser

2023-07-07 Thread James Almer
On 7/7/2023 11:05 AM, Nuo Mi wrote: --- libavcodec/vvc/Makefile |4 +- libavcodec/vvc/vvc_data.c | 3295 +++ libavcodec/vvc/vvc_data.h | 69 + libavcodec/vvc/vvc_ps.c | 3436 + libavcodec/vvc/vvc_ps.h | 828

[FFmpeg-devel] [PATCH v2 09/14] vvcdec: add intra prediction

2023-07-07 Thread Nuo Mi
--- libavcodec/vvc/Makefile |3 +- libavcodec/vvc/vvc_ctu.c| 39 + libavcodec/vvc/vvc_ctu.h|2 + libavcodec/vvc/vvc_intra.c | 771 libavcodec/vvc/vvc_intra.h | 49 ++ libavcodec/vvc/vvc_intra_template.c | 1018

[FFmpeg-devel] [PATCH v2 12/14] vvcdec: add CTU parser

2023-07-07 Thread Nuo Mi
--- libavcodec/vvc/vvc_ctu.c | 2378 +- libavcodec/vvc/vvc_ctu.h | 11 + 2 files changed, 2384 insertions(+), 5 deletions(-) diff --git a/libavcodec/vvc/vvc_ctu.c b/libavcodec/vvc/vvc_ctu.c index d46a522a0d..4b86925ff7 100644 --- a/libavcodec/vvc/vvc_ctu.c

[FFmpeg-devel] [PATCH v2 08/14] vvcdec: add inv transform 1d

2023-07-07 Thread Nuo Mi
--- libavcodec/vvc/Makefile | 3 +- libavcodec/vvc/vvc_itx_1d.c | 713 libavcodec/vvc/vvc_itx_1d.h | 52 +++ 3 files changed, 767 insertions(+), 1 deletion(-) create mode 100644 libavcodec/vvc/vvc_itx_1d.c create mode 100644

[FFmpeg-devel] [PATCH v2 05/14] vvcdec: add reference management

2023-07-07 Thread Nuo Mi
--- libavcodec/vvc/Makefile | 3 +- libavcodec/vvc/vvc_refs.c | 502 ++ libavcodec/vvc/vvc_refs.h | 51 3 files changed, 555 insertions(+), 1 deletion(-) create mode 100644 libavcodec/vvc/vvc_refs.c create mode 100644 libavcodec/vvc/vvc_refs.h diff

[FFmpeg-devel] [PATCH v2 11/14] vvcdec: add dsp init and inv transform

2023-07-07 Thread Nuo Mi
--- libavcodec/vvc/Makefile | 3 +- libavcodec/vvc/vvcdsp.c | 323 +++ libavcodec/vvc/vvcdsp_template.c | 119 3 files changed, 444 insertions(+), 1 deletion(-) create mode 100644 libavcodec/vvc/vvcdsp.c create mode 100644

[FFmpeg-devel] [PATCH v2 07/14] vvcdec: add inter prediction

2023-07-07 Thread Nuo Mi
--- libavcodec/vvc/Makefile |1 + libavcodec/vvc/vvc_inter.c | 992 ++ libavcodec/vvc/vvc_inter.h | 42 + libavcodec/vvc/vvc_inter_template.c | 1473 +++ libavcodec/vvc/vvcdec.h |2 +

[FFmpeg-devel] [PATCH v2 06/14] vvcdec: add motion vector decoder

2023-07-07 Thread Nuo Mi
--- libavcodec/vvc/Makefile |1 + libavcodec/vvc/vvc_ctu.c | 20 +- libavcodec/vvc/vvc_ctu.h |2 + libavcodec/vvc/vvc_mvs.c | 1803 ++ libavcodec/vvc/vvc_mvs.h | 46 + 5 files changed, 1871 insertions(+), 1 deletion(-) create mode 100644

[FFmpeg-devel] [PATCH v2 14/14] vvcdec: add full vvc decoder

2023-07-07 Thread Nuo Mi
vvc decoder plug-in to avcodec. split frames into slices/tiles and send them to vvc_thread for further decoding reorder and wait for the frame decoding to be done and output the frame Features: + Support I, P, B frames + Support 8/10/12 bits, chroma 400, 420, 422, and 444 and range

[FFmpeg-devel] [PATCH v2 04/14] vvcdec: add cabac decoder

2023-07-07 Thread Nuo Mi
add Context-based Adaptive Binary Arithmetic Coding (CABAC) decoder --- libavcodec/vvc/Makefile|2 + libavcodec/vvc/vvc_cabac.c | 2483 libavcodec/vvc/vvc_cabac.h | 126 ++ libavcodec/vvc/vvc_ctu.c | 32 + libavcodec/vvc/vvc_ctu.h | 404 ++

[FFmpeg-devel] [PATCH v2 13/14] vvcdec: add CTU thread logical

2023-07-07 Thread Nuo Mi
This is the main entry point for the CTU (Coding Tree Unit) decoder. The code will divide the CTU decoder into several stages. It will check the stage dependencies and run the stage decoder. --- libavcodec/vvc/Makefile | 3 +- libavcodec/vvc/vvc_thread.c | 804

[FFmpeg-devel] [PATCH v2 02/14] vvcdec: add vvc decoder stub

2023-07-07 Thread Nuo Mi
--- configure | 1 + libavcodec/allcodecs.c | 1 + libavcodec/vvc/Makefile | 3 +- libavcodec/vvc/vvcdec.c | 84 +++ libavcodec/vvc/vvcdec.h | 306 5 files changed, 394 insertions(+), 1 deletion(-) create mode 100644

[FFmpeg-devel] [PATCH v2 01/14] vvcdec: add thread executor

2023-07-07 Thread Nuo Mi
The executor design pattern was inroduced by java it also adapted by python Compared to handcrafted thread pool management, it greatly

[FFmpeg-devel] [PATCH v2 00/14] add vvc decoder

2023-07-07 Thread Nuo Mi
Major changes since v1: * 12 bits and range extension support added. Thanks to GSOC contributor frankplow. * Make parser and inter prediction blockless to improve performance on high core count CPU. Fixed following review comment since v1: * Rename vvc prefix for executor, thanks to Lynne and

[FFmpeg-devel] [PATCH] avfilter/vf_vidstabdetect: force ASCII mode if possible

2023-07-07 Thread Timo Rothenpieler
Newer versions of the library added a new binary output format, and prefer using it by default. Those binary files seem to cause issues for a lot of users, where ffmpeg fails to (sometimes?) read back the trf file it has just written itself. My guess is that this might be because of the

[FFmpeg-devel] [PATCH 3/3] doc/filters: Extend description of overlay filter format option values

2023-07-07 Thread Tobias Rapp
--- doc/filters.texi | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 3b82edf..b57bb5a 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -18591,28 +18591,28 @@ Set the format for the output video. It accepts the

[FFmpeg-devel] [PATCH 2/3] tests/fate: Add test for overlay filter using yuv444p10 output format

2023-07-07 Thread Tobias Rapp
--- tests/fate/filter-video.mak | 2 +- tests/filtergraphs/overlay_yuv444p10| 5 + tests/ref/fate/filter-overlay_yuv444p10 | 8 3 files changed, 14 insertions(+), 1 deletion(-) create mode 100644 tests/filtergraphs/overlay_yuv444p10 create mode 100644

[FFmpeg-devel] [PATCH 1/3] avfilter/vf_overlay: Add support for yuv444p10 pixel format

2023-07-07 Thread Tobias Rapp
--- doc/filters.texi | 3 +++ libavfilter/vf_overlay.c | 36 +++- libavfilter/vf_overlay.h | 1 + 3 files changed, 39 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index f17488c..3b82edf 100644 --- a/doc/filters.texi +++

[FFmpeg-devel] [PATCH] avformat/mov: avss box should be AV_CODEC_ID_CAVS

2023-07-07 Thread Zhao Zhili
From: Zhao Zhili I cannot find the spec, but according to the original commit d4fdba0df71, it's CAVS. e571305a714 changed it to AVS by accident. Ten years on, nothing happened. We still have the sample [1], however, since there is no cavs_mp4tofoobar bsf, the cavs decoder doesn't work. I don't

Re: [FFmpeg-devel] [PATCH] lavu/random_seed: use getrandom() when available

2023-07-07 Thread James Almer
On 7/7/2023 7:21 AM, Anton Khirnov wrote: It is a better interface for /dev/u?random on Linux, which avoids the issues associated with opening files. --- configure | 2 ++ libavutil/random_seed.c | 15 +++ 2 files changed, 17 insertions(+) diff --git a/configure

[FFmpeg-devel] [PATCH] tests/fate-run: add testing with a random number of threads

2023-07-07 Thread Anton Khirnov
Useful for discovering bugs that depend on a specific thread count. Use like THREADS=randomX for a random thread count from 1 to X, with X=16 when not specified. --- Now using the awk rand() function, also used in configure. The thread count can now be written into the errfile on test failure.

[FFmpeg-devel] [PATCH] lavu/random_seed: use getrandom() when available

2023-07-07 Thread Anton Khirnov
It is a better interface for /dev/u?random on Linux, which avoids the issues associated with opening files. --- configure | 2 ++ libavutil/random_seed.c | 15 +++ 2 files changed, 17 insertions(+) diff --git a/configure b/configure index d6e78297fe..a4b09577cf 100755

[FFmpeg-devel] [PATCH 17/22] fftools/ffmpeg_filter: only flush vsync code if encoding actually started

2023-07-07 Thread Anton Khirnov
Otherwise this has no effect. Will be useful in following commits. --- fftools/ffmpeg_filter.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index f8e64ce6cc..4955fe38dd 100644 --- a/fftools/ffmpeg_filter.c +++

[FFmpeg-devel] [PATCH 14/22] fftools/ffmpeg_filter: stop accessing encoder from pixfmt selection

2023-07-07 Thread Anton Khirnov
ffmpeg CLI pixel format selection for filtering currently special-cases MJPEG encoding, where it will restrict the supported list of pixel formats depending on the value of the -strict option. In order to get that value it will apply it from the options dict into the encoder context, which is a

[FFmpeg-devel] [PATCH 09/22] fftools/ffmpeg_filter: make OutputFile.ch_layout private

2023-07-07 Thread Anton Khirnov
It is not used outside of the filtering code. --- fftools/ffmpeg.h| 1 - fftools/ffmpeg_filter.c | 17 ++--- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 5b4117eeea..b789233a08 100644 --- a/fftools/ffmpeg.h +++

[FFmpeg-devel] [PATCH 11/22] fftools/ffmpeg_filter: make OutputFile.{formats, ch_layouts, sample_rates} private

2023-07-07 Thread Anton Khirnov
They are not used outside of the filtering code. --- fftools/ffmpeg.h| 6 -- fftools/ffmpeg_filter.c | 35 --- 2 files changed, 20 insertions(+), 21 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 79f3f35b3a..3201163a4f 100644 ---

[FFmpeg-devel] [PATCH 05/22] lavc/encode: improve unsupported-format error messages

2023-07-07 Thread Anton Khirnov
Mention encoder name in the message to emphasize that the value in question is not supported by this specific encoder, not necessarily by libavcodec in general. Print a list of values supported by the encoder. --- libavcodec/encode.c | 45 + 1 file

[FFmpeg-devel] [PATCH 08/22] fftools/ffmpeg_filter: make OutputFile.format/sample_rate private

2023-07-07 Thread Anton Khirnov
They are not used outside of the filtering code. --- fftools/ffmpeg.h| 2 -- fftools/ffmpeg_filter.c | 39 +-- 2 files changed, 29 insertions(+), 12 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 316cd2b7a6..5b4117eeea 100644 ---

[FFmpeg-devel] [PATCH 21/22] fftools/ffmpeg: rework -enc_time_base handling

2023-07-07 Thread Anton Khirnov
Read the timebase from FrameData rather than the input stream. This should fix #10393 and generally be more reliable. Replace the use of '-1' to indicate demuxing timebase with the string 'demux'. Also allow to request filter timebase with '-enc_time_base filter'. --- doc/ffmpeg.texi |

[FFmpeg-devel] [PATCH 20/22] fftools/ffmpeg: add more structure to FrameData

2023-07-07 Thread Anton Khirnov
It now contains data from multiple sources, so group those items that always come from the decoder. Also, initialize them to invalid values, so that frames that did not originate from a decoder can be distinguished. --- fftools/ffmpeg.c | 8 +++- fftools/ffmpeg.h | 10 +++---

[FFmpeg-devel] [PATCH 18/22] fftools/ffmpeg_enc: initialize audio/video encoders from frame parameters

2023-07-07 Thread Anton Khirnov
This is possible now that enc_open() is always called with a non-NULL frame for audio/video. Previously the code would directly reach into the buffersink, which is a layering violation. --- fftools/ffmpeg_enc.c | 35 +-- 1 file changed, 21 insertions(+), 14

[FFmpeg-devel] [PATCH 13/22] fftools/ffmpeg_filter: stop disregarding user-specified pixel format

2023-07-07 Thread Anton Khirnov
When the user explicitly specifies a pixel format that is not supported by the encoder, ffmpeg CLI will currently use some heuristics to pick another supported format. This is wrong and the correct action here is to fail. Surprisingly, a number of FATE tests are affected by this and actually use

[FFmpeg-devel] [PATCH 15/22] fftools/ffmpeg: drop an obsolete debug log

2023-07-07 Thread Anton Khirnov
The value it prints has not been cur_dts from lavf for a very long time, so it's misleading. --- fftools/ffmpeg.c | 4 1 file changed, 4 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 435e12a37b..013935d6ce 100644 --- a/fftools/ffmpeg.c +++ b/fftools/ffmpeg.c @@ -941,10

[FFmpeg-devel] [PATCH 12/22] fftools/ffmpeg_filter: consolidate calling avfilter_graph_set_auto_convert()

2023-07-07 Thread Anton Khirnov
Do not call it from choose_pix_fmts(), as that function is not supposed to modify random filtergraph properties. --- fftools/ffmpeg_filter.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index

[FFmpeg-devel] [PATCH 10/22] fftools/ffmpeg_filter: make OutputFile.width, height private

2023-07-07 Thread Anton Khirnov
They are not used outside of the filtering code. --- fftools/ffmpeg.h| 3 --- fftools/ffmpeg_filter.c | 14 -- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index b789233a08..79f3f35b3a 100644 --- a/fftools/ffmpeg.h +++

[FFmpeg-devel] [PATCH 19/22] fftools/ffmpeg_filter: make OutputFilter.filter private

2023-07-07 Thread Anton Khirnov
It should not be accessed from outside of filtering code. --- fftools/ffmpeg.h| 1 - fftools/ffmpeg_filter.c | 18 ++ 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 3201163a4f..abea424486 100644 ---

[FFmpeg-devel] [PATCH 16/22] fftools/ffmpeg: rework initializing encoders with no frames

2023-07-07 Thread Anton Khirnov
When no frames were passed from a filtergraph to an encoder, but the filtergraph is configured (i.e. has output parameters), encoder flush code will use those parameters to initialize the encoder in a last-ditch effort to produce some useful output. Rework this process so that it is triggered by

[FFmpeg-devel] [PATCH 22/22] doc/ffmpeg: fix -enc_time_base documentation

2023-07-07 Thread Anton Khirnov
Stop claiming the argument is always a floating point number, which * confuses floating point and decimal numbers * is not always true even accounting for the above point --- doc/ffmpeg.texi | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/doc/ffmpeg.texi

[FFmpeg-devel] [PATCH 07/22] fftools/ffmpeg_filter: make sure no input or output is bound twice

2023-07-07 Thread Anton Khirnov
--- fftools/ffmpeg_filter.c | 4 1 file changed, 4 insertions(+) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 60e09866af..432e2fced9 100644 --- a/fftools/ffmpeg_filter.c +++ b/fftools/ffmpeg_filter.c @@ -595,6 +595,8 @@ static int ifilter_bind_ist(InputFilter

[FFmpeg-devel] [PATCH 06/22] lavfi: make sure frame SAR matches the link value

2023-07-07 Thread Anton Khirnov
--- libavfilter/avfilter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 0141b64cbc..04887b6ee5 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -984,6 +984,8 @@ int ff_filter_frame(AVFilterLink *link, AVFrame

[FFmpeg-devel] [PATCH 01/22] lavc/encode: print separate messages for unknown and unsupported formats

2023-07-07 Thread Anton Khirnov
The former is typically a bug in the calling program, while the latter will more often be a user configuration issue. --- libavcodec/encode.c | 25 + 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index

[FFmpeg-devel] [PATCH 04/22] lavc/encode: improve input sample rate validation

2023-07-07 Thread Anton Khirnov
Reject zero sample rates in addition to negative ones and describe them as 'invalid' rather than 'unsupported'. --- libavcodec/encode.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index ba91dcc31e..9a279d9842 100644 ---

[FFmpeg-devel] [PATCH 03/22] lavc/encoder: always print an error on an unsupported channel layout

2023-07-07 Thread Anton Khirnov
Even if the layout is indescribable. --- libavcodec/encode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index 0d44f70ee9..ba91dcc31e 100644 --- a/libavcodec/encode.c +++ b/libavcodec/encode.c @@ -675,8 +675,8 @@ static int

[FFmpeg-devel] [PATCH 02/22] lavc/encode: shorten code by using a local variable

2023-07-07 Thread Anton Khirnov
--- libavcodec/encode.c | 48 +++-- 1 file changed, 25 insertions(+), 23 deletions(-) diff --git a/libavcodec/encode.c b/libavcodec/encode.c index 2da9f6ba23..0d44f70ee9 100644 --- a/libavcodec/encode.c +++ b/libavcodec/encode.c @@ -550,6 +550,7 @@ int

Re: [FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: fall back to av_get_random_seed() when generating AES128 key

2023-07-07 Thread Anton Khirnov
Quoting Michael Niedermayer (2023-07-07 02:55:46) > > The litteral wording was > "that guarantees either cryptographically secure randomness or an error." > > that was what i refered to. > > the wording used now: > "to the best of our ability, and that of the underlying libraries we rely on) >

Re: [FFmpeg-devel] [RFC] Release 6.1

2023-07-07 Thread Steven Liu
Lynne 于2023年7月7日周五 14:40写道: > > Jul 6, 2023, 18:19 by j...@videolan.org: > > > Heya, > > > > On Thu, 6 Jul 2023, at 18:04, Lynne wrote: > > > >> It's been a while since we've had a release, and we've had > >> a lot of new features in. > >> We did say we would make releases more often, and I think

Re: [FFmpeg-devel] [RFC] Release 6.1

2023-07-07 Thread Ingo Oppermann
Leavitt https://en.wikipedia.org/wiki/Henrietta_Swan_Leavitt > On 7 Jul 2023, at 08:40, Lynne wrote: > > Jul 6, 2023, 18:19 by j...@videolan.org: > >> Heya, >> >> On Thu, 6 Jul 2023, at 18:04, Lynne wrote: >> >>> It's been a while since we've had a release, and we've had >>> a lot of new

Re: [FFmpeg-devel] [RFC] Release 6.1

2023-07-07 Thread Lynne
Jul 6, 2023, 18:19 by j...@videolan.org: > Heya, > > On Thu, 6 Jul 2023, at 18:04, Lynne wrote: > >> It's been a while since we've had a release, and we've had >> a lot of new features in. >> We did say we would make releases more often, and I think >> it's about time we have a new release. >> >