Re: [FFmpeg-devel] [PATCH] lavc/dxv: fix incorrect back-reference index calculation in DXT5 decoding

2024-02-04 Thread Connor Worley
Given that Paul is no longer a maintainer, can someone else please take a look? -- Connor Worley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

[FFmpeg-devel] [PATCH v7 1/2] libavformat/dvdvideo: add DVD-Video demuxer powered by libdvdnav and libdvdread

2024-02-04 Thread Marth64
Sorry for the quick follow-up to v6, I wanted to get this update out now hopefully before v6 is actually reviewed. v7 fixes a few documentation typos, options descriptions, and log messages: nothing major. I also flattened this out to be a 2-patch set with subtitle palette support. This is the

[FFmpeg-devel] [PATCH v7 2/2] libavformat/dvdvideo: add DVD CLUT utilities and enable palette support

2024-02-04 Thread Marth64
DVD subtitle palettes, which are natively YUV, are currently carried as a hex string in their respective subtitle streams and have no concept of colorspace tagging. In fact, the convention is to convert them to RGB prior to storage. Common players will only render the palettes properly if they are

[FFmpeg-devel] [PATCH 2/2] lavc/dxvenc: migrate DXT1 encoder to lavu hashtable

2024-02-04 Thread Connor Worley
Offers a modest performance gain due to the switch from naive linear probling to robin hood. Signed-off-by: Connor Worley --- libavcodec/dxvenc.c | 121 +--- 1 file changed, 35 insertions(+), 86 deletions(-) diff --git a/libavcodec/dxvenc.c

[FFmpeg-devel] [PATCH 1/2] lavu/hashtable: create generic robin hood hash table

2024-02-04 Thread Connor Worley
Signed-off-by: Connor Worley --- libavutil/Makefile | 2 + libavutil/hashtable.c | 172 libavutil/hashtable.h | 62 + libavutil/tests/hashtable.c | 104 ++ 4 files changed, 340 insertions(+) create mode

[FFmpeg-devel] [PATCH 2/2] avfilter/signature_lookup: Do not dereference NULL pointers after malloc failure

2024-02-04 Thread Michael Niedermayer
Fixes: CID 1403229 Dereference after null check Signed-off-by: Michael Niedermayer --- libavfilter/signature_lookup.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/libavfilter/signature_lookup.c b/libavfilter/signature_lookup.c index

[FFmpeg-devel] [PATCH 1/2] avcodec/ac3enc_template: add fbw_channels assert

2024-02-04 Thread Michael Niedermayer
fbw_channels must be > 0 as teh code is only run if cpl_enabled is set and that requires mode >= AC3_CHMODE_STEREO CID 718138 Uninitialized scalar variable assumes this assert to be false Signed-off-by: Michael Niedermayer --- libavcodec/ac3enc_template.c | 2 ++ 1 file changed, 2

Re: [FFmpeg-devel] [PATCH] lavc/qsvenc: Add workaround for VP9 keyframe

2024-02-04 Thread Xiang, Haihao
On Vr, 2024-01-26 at 12:28 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > The runtime doesn't set the frame type to MFX_FRAMETYPE_IDR on the > returned mfx bitstream for a keyframe, it set the frame type to > MFX_FRAMETYPE_I only. This patch added workaround for VP9 keyframe to > make the

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-04 Thread James Almer
On 2/3/2024 7:00 AM, Tomas Härdin wrote: fre 2024-02-02 klockan 16:55 +0100 skrev Jerome Martinez: Before this patch, the FFmpeg MXF parser correctly detects content with 2 fields in 1 AVPacket as e.g. interlaced 720x486 but the FFmpeg JPEG 2000 decoder reads the JPEG 2000 SIZ header without

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/d3d12va_decode: fix different 'const' qualifiers warning

2024-02-04 Thread Xiang, Haihao
On Wo, 2024-01-31 at 19:56 +0800, tong1.wu-at-intel@ffmpeg.org wrote: > From: Tong Wu > > Signed-off-by: Tong Wu > --- >  libavcodec/d3d12va_decode.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/d3d12va_decode.c b/libavcodec/d3d12va_decode.c > index

Re: [FFmpeg-devel] [PATCH] avcodec/d3d12va_vc1: add support for D3D12_VIDEO_DECODE_PROFILE_VC1_D2010 guid.

2024-02-04 Thread Xiang, Haihao
On Wo, 2024-01-31 at 19:30 +0800, Tong Wu wrote: > From: Aleksoid > > The VC1_D2010 profile, also known as VC1_VLD2010, has the same functionality > and specification as the VC1_D profile. Support for this profile serves only > as a positive indication that the accelerator has been designed with

Re: [FFmpeg-devel] [PATCH v2] doc/formats: clarify meaning of igndts as per definition in avformat.h

2024-02-04 Thread Stefano Sabatini
On date Sunday 2024-02-04 12:41:33 -0600, Marth64 wrote: > This updates the documentation to be more clear about igndts, > as per feedback in December variant of this patch (thank you) > > Signed-off-by: Marth64 > --- > doc/formats.texi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [FFmpeg-devel] [PATCH] libavformat/matroskaenc: reformat options table indentation and descriptions

2024-02-04 Thread Stefano Sabatini
On date Sunday 2024-02-04 12:30:01 -0600, Marth64 wrote: > matroskaenc options table has grown packed over time, and is now challenging > to read. The purpose of this patch is to reformat the table, indentation-wise, > and to make the capitalization/endings of each description at least >

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: support of 2 fields in 1 AVPacket

2024-02-04 Thread Tomas Härdin
> > > > > The logic that scans the packet for two SOI markers shouldn't > > > > > be > > > > > necessary if the relevant information is carried over from > > > > > the > > > > > MXF > > > > > demuxer. > > > > > > > > As far as I know there is nothing in the MXF file saying where > > > > is > > >

Re: [FFmpeg-devel] [PATCH v6] libavformat/dvdvideo: add DVD-Video demuxer powered by libdvdnav and libdvdread

2024-02-04 Thread Marth64
Gah, just realized a minor issue in the documentation only. The -clut_rgb option documentation is meant for the accompanying subtitle patchset, and can be ignored. I'll remove it, but will buffer the update in case there is more feedback. Thanks! On Sun, Feb 4, 2024 at 6:06 PM Marth64 wrote: >

[FFmpeg-devel] [PATCH v6] libavformat/dvdvideo: add DVD-Video demuxer powered by libdvdnav and libdvdread

2024-02-04 Thread Marth64
- Further improve documentation, logging, and indentation - Improve stream starting logic to be far more robust and not break GOPs - Resolve and remove timing workaround for chapter markers when starting after ch. 1 - Fix sketchy error handling logic for certain edge case when NAV pack is

Re: [FFmpeg-devel] [PATCH 0/2] Remove SDL2 output devices

2024-02-04 Thread Stefano Sabatini
On date Sunday 2024-02-04 10:02:31 +0100, J. Dekker wrote: > With the addition of threading in ffmpeg.c, the SDL2 devices no longer have > the > 'main' thread. This means that both the SDL2 and OpenGL output device are > broken > in master. Rather than attempting to fix it, they should be

Re: [FFmpeg-devel] [PATCH] avdevice/caca: Allow to list multiple dither option types at once

2024-02-04 Thread Stefano Sabatini
On date Sunday 2024-02-04 18:36:45 +0100, Andreas Rheinhardt wrote: > This can be achieved by using AV_OPT_TYPE_FLAGS instead of > AV_OPT_TYPE_STRING. It also avoids strcmp() when accessing > the option. > > Signed-off-by: Andreas Rheinhardt > --- > libavdevice/caca.c | 34

Re: [FFmpeg-devel] [PATCH v5 1/2] avfilter: add audio overlay filter

2024-02-04 Thread Stefano Sabatini
On date Thursday 2024-02-01 18:31:56 +0530, Harshit Karwal wrote: > Co-authored-by: Paul B Mahol > Signed-off-by: Harshit Karwal > --- > doc/filters.texi | 40 +++ > libavfilter/Makefile | 1 + > libavfilter/af_aoverlay.c | 548 ++ >

[FFmpeg-devel] [PATCH] avutil/thread: fix pthread_setname_np parameters for NetBSD and Apple

2024-02-04 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/thread.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavutil/thread.h b/libavutil/thread.h index fa74dd2ea7..2c00c7cc35 100644 --- a/libavutil/thread.h +++ b/libavutil/thread.h @@ -220,7 +220,13 @@ static inline int

Re: [FFmpeg-devel] Sovereign Tech Fund

2024-02-04 Thread Rémi Denis-Courmont
Hi, Le 4 février 2024 21:28:44 GMT+02:00, Michael Niedermayer a écrit : >On Sun, Feb 04, 2024 at 03:38:43PM +0100, Rémi Denis-Courmont wrote: >> Hi, >> >> Le 4 février 2024 14:41:15 GMT+01:00, Michael Niedermayer >> a écrit : >> >Hi >> > >> >As said on IRC, i thought people knew it, but ‘the

Re: [FFmpeg-devel] [PATCH 18/24] avutil: remove deprecated FF_API_PKT_DURATION

2024-02-04 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > doc/ffprobe.xsd | 2 - > fftools/ffmpeg_filter.c | 5 - > fftools/ffprobe.c| 6 - > libavcodec/decode.c | 6 - > libavdevice/alsa_enc.c

Re: [FFmpeg-devel] [PATCH 16/24] avutil: remove deprecated FF_API_OLD_CHANNEL_LAYOUT

2024-02-04 Thread Andreas Rheinhardt
James Almer: > Signed-off-by: James Almer > --- > diff --git a/libavutil/channel_layout.c b/libavutil/channel_layout.c > index b59d798f29..35b03078c8 100644 > --- a/libavutil/channel_layout.c > +++ b/libavutil/channel_layout.c > @@ -214,190 +214,6 @@ static const struct channel_layout_name >

Re: [FFmpeg-devel] [PATCH v2] lavu/thread: add support for setting thread name on *bsd and solaris

2024-02-04 Thread Marton Balint
On Wed, 31 Jan 2024, Brad Smith wrote: On 2024-01-23 2:44 p.m., Brad Smith wrote: On 2024-01-16 1:25 a.m., Brad Smith wrote: On 2024-01-07 12:55 a.m., Brad Smith wrote: lavu/thread: add support for setting thread name on *bsd and solaris FreeBSD/DragonFly/Solaris use

Re: [FFmpeg-devel] Sovereign Tech Fund

2024-02-04 Thread Michael Niedermayer
On Sun, Feb 04, 2024 at 03:38:43PM +0100, Rémi Denis-Courmont wrote: > Hi, > > Le 4 février 2024 14:41:15 GMT+01:00, Michael Niedermayer > a écrit : > >Hi > > > >As said on IRC, i thought people knew it, but ‘the same person as before’ is > >Thilo. > > > >Ive updated the price design

[FFmpeg-devel] [PATCH v2 5/5] avformat/mov_chan: add support for reading custom channel layouts when layout_tag == 0

2024-02-04 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mov_chan.c | 99 +++--- 1 file changed, 54 insertions(+), 45 deletions(-) diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c index 6b206745b4..302639c332 100644 --- a/libavformat/mov_chan.c +++

[FFmpeg-devel] [PATCH v2 4/5] avutil/channel_layout: add av_channel_layout_retype()

2024-02-04 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/APIchanges | 3 ++ libavutil/channel_layout.c | 106 + libavutil/channel_layout.h | 40 ++ libavutil/version.h| 2 +- 4 files changed, 150 insertions(+), 1 deletion(-) diff --git

[FFmpeg-devel] [PATCH v2 3/5] avutil/channel_layout: add av_channel_layout_custom_init()

2024-02-04 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavutil/channel_layout.c | 20 libavutil/channel_layout.h | 17 + libavutil/version.h| 4 ++-- 4 files changed, 42 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges

Re: [FFmpeg-devel] [PATCH] flv: fix stereo flag when writing PCMA/PCMU

2024-02-04 Thread Marton Balint
On Wed, 31 Jan 2024, aler9 wrote: Hello again, i'm bumping this patch since currently it's impossible to stream 16khz or stereo G711 tracks with RTMP, as these are always marked as 8khz, mono tracks. Please consider merging. Thanks. Will apply, thanks. Marton Il giorno dom 21 gen 2024

Re: [FFmpeg-devel] 回复: [PATCH] lavc/d3d12va: Improve behaviour on missing decoder support

2024-02-04 Thread Mark Thompson
On 04/02/2024 16:57, Wu Jianhua wrote: 发件人: ffmpeg-devel 代表 Mark Thompson 发送时间: 2024年2月4日 5:24 收件人: FFmpeg development discussions and patches 主题: [FFmpeg-devel] [PATCH] lavc/d3d12va: Improve behaviour on missing decoder support Distinguish between a decoder being entirely missing and a

[FFmpeg-devel] [PATCH v2] doc/formats: clarify meaning of igndts as per definition in avformat.h

2024-02-04 Thread Marth64
This updates the documentation to be more clear about igndts, as per feedback in December variant of this patch (thank you) Signed-off-by: Marth64 --- doc/formats.texi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/formats.texi b/doc/formats.texi index

[FFmpeg-devel] [PATCH] libavformat/matroskaenc: reformat options table indentation and descriptions

2024-02-04 Thread Marth64
matroskaenc options table has grown packed over time, and is now challenging to read. The purpose of this patch is to reformat the table, indentation-wise, and to make the capitalization/endings of each description at least consistent. I intend to sort the options in a follow-up patch, but wanted

[FFmpeg-devel] [PATCH] avdevice/caca: Allow to list multiple dither option types at once

2024-02-04 Thread Andreas Rheinhardt
This can be achieved by using AV_OPT_TYPE_FLAGS instead of AV_OPT_TYPE_STRING. It also avoids strcmp() when accessing the option. Signed-off-by: Andreas Rheinhardt --- libavdevice/caca.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git

[FFmpeg-devel] 回复: [PATCH] lavc/d3d12va: Improve behaviour on missing decoder support

2024-02-04 Thread Wu Jianhua
> 发件人: ffmpeg-devel 代表 Mark Thompson > > 发送时间: 2024年2月4日 5:24 > 收件人: FFmpeg development discussions and patches > 主题: [FFmpeg-devel] [PATCH] lavc/d3d12va: Improve behaviour on missing decoder > support > > Distinguish between a decoder being entirely missing and a decoder which > requires

[FFmpeg-devel] [PATCH] avutil/opt: Fix AV_OPT_TYPE_CONST default value

2024-02-04 Thread Andreas Rheinhardt
It uses the int64_t instead of the double member. (This code can currently not be reached: av_opt_get() calls av_opt_find2() with NULL as unit in which case AV_OPT_TYPE_CONST options are never returned, leading av_opt_get() to always return AVERROR_OPTION_NOT_FOUND when searching for

Re: [FFmpeg-devel] [PATCH 1/2] lavc/cbs_av1: fill in ref_frame_sign_bias

2024-02-04 Thread Mark Thompson
On 02/02/2024 02:57, Lynne wrote: Needed for AV1. > From 81be215060a718fdc3d043847e8155ba56fcb431 Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Fri, 2 Feb 2024 03:54:06 +0100 > Subject: [PATCH 1/2] lavc/cbs_av1: fill in ref_frame_sign_bias > > Needed for AV1. > --- > libavcodec/cbs_av1.h

Re: [FFmpeg-devel] [PATCH v4 3/3] tests/fate/mov: add a test for reading and writing amve box

2024-02-04 Thread James Almer
On 2/4/2024 12:14 PM, Cosmin Stejerean via ffmpeg-devel wrote: From: Cosmin Stejerean --- tests/fate/mov.mak| 5 + tests/ref/fate/mov-read-amve | 8 tests/ref/fate/mov-write-amve | 33 + 3 files changed, 46 insertions(+)

Re: [FFmpeg-devel] [PATCH v4 1/3] avcodec: add ambient viewing environment packet side data.

2024-02-04 Thread Marton Balint
On Sun, 4 Feb 2024, Cosmin Stejerean via ffmpeg-devel wrote: From: Damiano Galassi --- doc/APIchanges| 3 +++ fftools/ffprobe.c | 3 +++ libavcodec/avpacket.c | 1 + libavcodec/decode.c | 1 + libavcodec/packet.h | 9 - libavcodec/version.h | 2 +- 6 files changed, 17

[FFmpeg-devel] [PATCH v4 3/3] tests/fate/mov: add a test for reading and writing amve box

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Cosmin Stejerean --- tests/fate/mov.mak| 5 + tests/ref/fate/mov-read-amve | 8 tests/ref/fate/mov-write-amve | 33 + 3 files changed, 46 insertions(+) create mode 100644 tests/ref/fate/mov-read-amve create mode 100644

[FFmpeg-devel] [PATCH v4 2/3] avformat/mov: add support for 'amve' ambient viewing environment box. As defined in ISOBMFF (ISO/IEC 14496-12) document.

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Damiano Galassi Co-Authored-By: Cosmin Stejerean --- libavformat/dump.c | 15 + libavformat/isom.h | 3 +++ libavformat/mov.c| 35 +++ libavformat/movenc.c | 50 ++-- 4 files changed, 92

[FFmpeg-devel] [PATCH v4 1/3] avcodec: add ambient viewing environment packet side data.

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Damiano Galassi --- doc/APIchanges| 3 +++ fftools/ffprobe.c | 3 +++ libavcodec/avpacket.c | 1 + libavcodec/decode.c | 1 + libavcodec/packet.h | 9 - libavcodec/version.h | 2 +- 6 files changed, 17 insertions(+), 2 deletions(-) diff --git a/doc/APIchanges

[FFmpeg-devel] [PATCH v4 0/3] avformat/mov: add support for 'amve' ambient viewing environment

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Cosmin Stejerean Version 4 resolves feedback from v3 by moving new side data field in packet.h to the end for ABI compatibility, bumping the minor API version for lavc, adding APIChanges entry, using -c:v in the FATE test, cleaning up formatting in avformat/movenc and renaming rescale_mdcv

Re: [FFmpeg-devel] [PATCH 0/2] Remove SDL2 output devices

2024-02-04 Thread Marton Balint
On Sun, 4 Feb 2024, Rémi Denis-Courmont wrote: Le 4 février 2024 11:11:12 GMT+01:00, Marton Balint a écrit : Actually they work here on a linux box with OpenSuse 15.5. So even if they are broken on some setups, they are not broken everywhere, or not more broken than they used to be.

[FFmpeg-devel] [PATCH] lavc/aarch64/fdct: add neon-optimized fdct for aarch64

2024-02-04 Thread Ramiro Polla
The code is imported from libjpeg-turbo-3.0.1. The neon registers used have been changed to avoid modifying v8-v15. --- libavcodec/aarch64/Makefile | 2 + libavcodec/aarch64/fdct.h | 26 ++ libavcodec/aarch64/fdctdsp_init_aarch64.c | 39 +++

Re: [FFmpeg-devel] Sovereign Tech Fund

2024-02-04 Thread Rémi Denis-Courmont
Hi, Le 4 février 2024 14:41:15 GMT+01:00, Michael Niedermayer a écrit : >Hi > >As said on IRC, i thought people knew it, but ‘the same person as before’ is >Thilo. > >Ive updated the price design suggestion for the merge task, its 16€ / commit >limited to 50k€ >this comes from looking at

[FFmpeg-devel] [PATCH 2/2] avcodec/libaomdec: print libaomdec version in verbose level

2024-02-04 Thread James Almer
info level will be too noisy if several instances of the decoder are fired at the same time, as will be the case with tiled AVIF. Signed-off-by: James Almer --- libavcodec/libaomdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libaomdec.c

[FFmpeg-devel] [PATCH 1/2] avcodec/libdav1d: print libdav1d version in verbose level

2024-02-04 Thread James Almer
info level will be too noisy if several instances of the decoder are fired at the same time, as will be the case with tiled AVIF. Signed-off-by: James Almer --- libavcodec/libdav1d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libdav1d.c

[FFmpeg-devel] [PATCH] avfilter/fifo: Remove (a)fifo filters

2024-02-04 Thread Andreas Rheinhardt
Obsolete since 4ca1fb9d2a91757c8c4c34dd456abf340e3f765f. Signed-off-by: Andreas Rheinhardt --- doc/filters.texi | 9 --- libavfilter/Makefile | 1 - libavfilter/allfilters.c | 2 - libavfilter/fifo.c | 165 --- 4 files changed, 177

Re: [FFmpeg-devel] Sovereign Tech Fund

2024-02-04 Thread Michael Niedermayer
Hi On Sun, Feb 04, 2024 at 11:02:30AM +0100, J. Dekker wrote: > > > On Sun, Feb 4, 2024, at 10:49, Rémi Denis-Courmont wrote: > > Hi, > > > > I don't believe it is appropriate to hold the vote before Derek's > > question is addressed. > > > > We don't really know what we're voting on here. > >

[FFmpeg-devel] [PATCH] lavc/d3d12va: Improve behaviour on missing decoder support

2024-02-04 Thread Mark Thompson
Distinguish between a decoder being entirely missing and a decoder which requires features which are not present in the incomplete implementation in libavcodec and therefore can't be used. --- libavcodec/d3d12va_decode.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff

Re: [FFmpeg-devel] [PATCH 0/2] Remove SDL2 output devices

2024-02-04 Thread Michael Niedermayer
On Sun, Feb 04, 2024 at 10:02:31AM +0100, J. Dekker wrote: > With the addition of threading in ffmpeg.c, the SDL2 devices no longer have > the > 'main' thread. This means that both the SDL2 and OpenGL output device are > broken > in master. Rather than attempting to fix it, they should be

Re: [FFmpeg-devel] [PATCH 00/24] Major library version bump

2024-02-04 Thread James Almer
On 1/28/2024 9:31 AM, Anton Khirnov wrote: Quoting James Almer (2024-01-25 14:43:23) As the subject states, this set removes deprecated API scheduled for removal in the past year, since the last major bump. So what is the actual rule you used for deciding what to remove and what to postpone?

Re: [FFmpeg-devel] [PATCH v3 3/3] tests/fate/mov: add a test for reading and writing amve box

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 4, 2024, at 13:44, James Almer wrote: > > On 2/4/2024 8:16 AM, Cosmin Stejerean via ffmpeg-devel wrote: >> From: Cosmin Stejerean >> >> --- >> tests/fate/mov.mak| 5 + >> tests/ref/fate/mov-read-amve | 8 >> tests/ref/fate/mov-write-amve | 33

Re: [FFmpeg-devel] [PATCH v3 3/3] tests/fate/mov: add a test for reading and writing amve box

2024-02-04 Thread James Almer
On 2/4/2024 8:16 AM, Cosmin Stejerean via ffmpeg-devel wrote: From: Cosmin Stejerean --- tests/fate/mov.mak| 5 + tests/ref/fate/mov-read-amve | 8 tests/ref/fate/mov-write-amve | 33 + 3 files changed, 46 insertions(+) create

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/mov: add support for 'amve' ambient viewing environment box. As defined in ISOBMFF (ISO/IEC 14496-12) document.

2024-02-04 Thread James Almer
On 2/4/2024 8:16 AM, Cosmin Stejerean via ffmpeg-devel wrote: From: Damiano Galassi Co-Authored-By: Cosmin Stejerean --- libavformat/dump.c | 15 +++ libavformat/isom.h | 3 +++ libavformat/mov.c| 35 +++ libavformat/movenc.c | 30

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec: add ambient viewing environment packet side data.

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
> On Feb 4, 2024, at 12:45, Anton Khirnov wrote: > > Quoting Cosmin Stejerean via ffmpeg-devel (2024-02-04 12:16:53) >> diff --git a/libavcodec/packet.h b/libavcodec/packet.h >> index 2c57d262c6..215b1c9970 100644 >> --- a/libavcodec/packet.h >> +++ b/libavcodec/packet.h >> @@ -299,6 +299,13

Re: [FFmpeg-devel] [PATCH v3 1/3] avcodec: add ambient viewing environment packet side data.

2024-02-04 Thread Anton Khirnov
Quoting Cosmin Stejerean via ffmpeg-devel (2024-02-04 12:16:53) > diff --git a/libavcodec/packet.h b/libavcodec/packet.h > index 2c57d262c6..215b1c9970 100644 > --- a/libavcodec/packet.h > +++ b/libavcodec/packet.h > @@ -299,6 +299,13 @@ enum AVPacketSideDataType { > */ >

Re: [FFmpeg-devel] [PATCH 0/2] Remove SDL2 output devices

2024-02-04 Thread Rémi Denis-Courmont
Le 4 février 2024 10:02:31 GMT+01:00, "J. Dekker" a écrit : >With the addition of threading in ffmpeg.c, the SDL2 devices no longer have the >'main' thread. This means that both the SDL2 and OpenGL output device are >broken >in master. Rather than attempting to fix it, they should be removed

Re: [FFmpeg-devel] [PATCH 0/2] Remove SDL2 output devices

2024-02-04 Thread Rémi Denis-Courmont
Le 4 février 2024 11:11:12 GMT+01:00, Marton Balint a écrit : >Actually they work here on a linux box with OpenSuse 15.5. So even if they >are broken on some setups, they are not broken everywhere, or not more broken >than they used to be. No. They were always broken in terms of the design,

[FFmpeg-devel] [PATCH v3 3/3] tests/fate/mov: add a test for reading and writing amve box

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Cosmin Stejerean --- tests/fate/mov.mak| 5 + tests/ref/fate/mov-read-amve | 8 tests/ref/fate/mov-write-amve | 33 + 3 files changed, 46 insertions(+) create mode 100644 tests/ref/fate/mov-read-amve create mode 100644

[FFmpeg-devel] [PATCH v3 2/3] avformat/mov: add support for 'amve' ambient viewing environment box. As defined in ISOBMFF (ISO/IEC 14496-12) document.

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Damiano Galassi Co-Authored-By: Cosmin Stejerean --- libavformat/dump.c | 15 +++ libavformat/isom.h | 3 +++ libavformat/mov.c| 35 +++ libavformat/movenc.c | 30 ++ 4 files changed, 83 insertions(+) diff

[FFmpeg-devel] [PATCH v3 1/3] avcodec: add ambient viewing environment packet side data.

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Damiano Galassi --- fftools/ffprobe.c | 3 +++ libavcodec/avpacket.c | 1 + libavcodec/decode.c | 1 + libavcodec/packet.h | 7 +++ 4 files changed, 12 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index f33e2471cb..aa1153e709 100644 --- a/fftools/ffprobe.c

[FFmpeg-devel] [PATCH v3 0/3] avformat/mov: add support for 'amve' ambient viewing environment box

2024-02-04 Thread Cosmin Stejerean via ffmpeg-devel
From: Cosmin Stejerean This rebases the previous patch series from Damiano Galassi after the packet side data changes and adds FATE tests for both reading and writing amve Cosmin Stejerean (1): tests/fate/mov: add a test for reading and writing amve box Damiano Galassi (2): avcodec: add

Re: [FFmpeg-devel] [PATCH v2 2/2] fate/video: add DXV3 HQ tests

2024-02-04 Thread Connor Worley
Samples have been added to fate-suite and this series is ready to be merged. -- Connor Worley ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH v9 2/6] avcodec/webp: separate VP8 decoding

2024-02-04 Thread Thilo Borgmann via ffmpeg-devel
On 03.02.24 14:53, Andreas Rheinhardt wrote: Thilo Borgmann via ffmpeg-devel: Am 28.01.24 um 11:29 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2024-01-25 16:39:19) Am 25.01.24 um 11:04 schrieb Anton Khirnov: Quoting Thilo Borgmann via ffmpeg-devel (2023-12-31 13:30:14)

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vp8: Enforce key-frame only for WebP

2024-02-04 Thread Thilo Borgmann via ffmpeg-devel
On 03.02.24 14:57, Andreas Rheinhardt wrote: Andreas Rheinhardt: VP8-in-WebP only uses key frame encoding (see [1]), yet this is currently not enforced. This commit does so in order to make output reproducible with frame-threading as the VP8 decoder's update_thread_context is not called at

Re: [FFmpeg-devel] [RFC] Vote STF/SPI 2024-02

2024-02-04 Thread Paul B Mahol
On Sun, Feb 4, 2024 at 1:42 AM Michael Niedermayer wrote: > On Sat, Feb 03, 2024 at 04:37:54AM +0100, Michael Niedermayer wrote: > > On Thu, Feb 01, 2024 at 05:29:26AM +0100, Michael Niedermayer wrote: > > > Hi all > > > > > > To do the STF/SPI thing properly, and make sure we do what the >

Re: [FFmpeg-devel] [PATCH 0/2] Remove SDL2 output devices

2024-02-04 Thread Marton Balint
On Sun, 4 Feb 2024, J. Dekker wrote: With the addition of threading in ffmpeg.c, the SDL2 devices no longer have the 'main' thread. This means that both the SDL2 and OpenGL output device are broken in master. Rather than attempting to fix it, they should be removed instead as there are

Re: [FFmpeg-devel] Sovereign Tech Fund

2024-02-04 Thread Paul B Mahol
On Sun, Feb 4, 2024 at 11:03 AM J. Dekker wrote: > > > On Sun, Feb 4, 2024, at 10:49, Rémi Denis-Courmont wrote: > > Hi, > > > > I don't believe it is appropriate to hold the vote before Derek's > > question is addressed. > > > > We don't really know what we're voting on here. > > > > Le 1

Re: [FFmpeg-devel] [PATCH 0/2] Remove SDL2 output devices

2024-02-04 Thread Paul B Mahol
FFmpeg project leader never left, it is still Michael. But now there are his minions like Anton and others. FFmpeg is already dead project. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] Sovereign Tech Fund

2024-02-04 Thread J. Dekker
On Sun, Feb 4, 2024, at 10:49, Rémi Denis-Courmont wrote: > Hi, > > I don't believe it is appropriate to hold the vote before Derek's > question is addressed. > > We don't really know what we're voting on here. > > Le 1 février 2024 20:22:14 GMT+01:00, Derek Buitenhuis > a écrit : >>On

Re: [FFmpeg-devel] Sovereign Tech Fund

2024-02-04 Thread Rémi Denis-Courmont
Hi, I don't believe it is appropriate to hold the vote before Derek's question is addressed. We don't really know what we're voting on here. Le 1 février 2024 20:22:14 GMT+01:00, Derek Buitenhuis a écrit : >On 1/31/2024 9:44 PM, Derek Buitenhuis wrote: >> On 1/30/2024 1:48 AM, Michael

[FFmpeg-devel] [PATCH v2 2/2] avcodec/pngenc: write cLLi and mDVc chunks

2024-02-04 Thread Leo Izen
These chunks contain the Content Light Level Information and the Mastering Display Color Volume information that FFmpeg already supports as AVFrameSideData. This patch adds support for the png encoder to save this metadata as the corresponding chunks in the PNG stream. Signed-off-by: Leo Izen

[FFmpeg-devel] [PATCH v2 1/2] avcodec/pngdec: read cLLi and mDVc chunks

2024-02-04 Thread Leo Izen
These chunks contain the Content Light Level Information and the Mastering Display Color Volume information that FFmpeg already supports as AVFrameSideData. This patch adds support for the png decoder to read these chunks if present and attach the corresponding side data to the decoded frame.

[FFmpeg-devel] [PATCH v2 0/2] PNG cLLi and mDVc chunk support

2024-02-04 Thread Leo Izen
This adds support for cLLi and mDVc chunks in the PNG specification[1]. [1]: https://www.w3.org/TR/png-3/ Changes from v1: - fix regression in cHRM writing, causing fate failure Leo Izen (2): avcodec/pngdec: read cLLi and mDVc chunks avcodec/pngenc: write cLLi and mDVc chunks

Re: [FFmpeg-devel] [PATCH 0/2] Remove SDL2 output devices

2024-02-04 Thread Anton Khirnov
Quoting Zhao Zhili (2024-02-04 10:19:11) > > On Feb 4, 2024, at 17:02, J. Dekker wrote: > > > > With the addition of threading in ffmpeg.c, the SDL2 devices no longer have > > the > > 'main' thread. This means that both the SDL2 and OpenGL output device are > > broken > > in master. Rather

Re: [FFmpeg-devel] [PATCH 0/2] Remove SDL2 output devices

2024-02-04 Thread Anton Khirnov
Quoting J. Dekker (2024-02-04 10:02:31) > With the addition of threading in ffmpeg.c, the SDL2 devices no longer have > the > 'main' thread. This means that both the SDL2 and OpenGL output device are > broken > in master. Rather than attempting to fix it, they should be removed instead as >

Re: [FFmpeg-devel] [PATCH 0/2] Remove SDL2 output devices

2024-02-04 Thread Zhao Zhili
> On Feb 4, 2024, at 17:02, J. Dekker wrote: > > With the addition of threading in ffmpeg.c, the SDL2 devices no longer have > the > 'main' thread. This means that both the SDL2 and OpenGL output device are > broken > in master. Rather than attempting to fix it, they should be removed

Re: [FFmpeg-devel] [PATCH] avformat/wavenc: use strtoull for UMID conversion

2024-02-04 Thread Gyan Doshi
On 2024-02-02 03:34 pm, Gyan Doshi wrote: On 2024-01-29 10:30 am, Gyan Doshi wrote: Existing use of strtoll can lead to ERANGE errors leading to incorrect storage of UMID. Plan to push tomorrow. Pushed as 7375a6ca7b4a4b223a71f85a772c64a34e60eabe Regards, Gyan

Re: [FFmpeg-devel] [PATCH] avformat/nutenc: Fix indentation

2024-02-04 Thread Anton Khirnov
Quoting Leo Izen (2024-02-04 08:20:55) > > If we're changing this block of code anyway, could we possibly replace > this line: > > if ((ret = ff_nut_add_sp(nut, nut->last_syncpoint_pos, 0 > /*unused*/, pkt->dts)) < 0) > goto fail; > > With something like this? >

[FFmpeg-devel] [PATCH 2/2] avdevice: remove OpenGL device

2024-02-04 Thread J. Dekker
Signed-off-by: J. Dekker --- MAINTAINERS |1 - configure| 15 - doc/outdevs.texi | 39 -- libavdevice/Makefile |1 - libavdevice/alldevices.c |1 - libavdevice/opengl_enc.c | 1313 -- 6 files changed,

[FFmpeg-devel] [PATCH 1/2] avdevice: remove sdl2 outdev

2024-02-04 Thread J. Dekker
Signed-off-by: J. Dekker --- MAINTAINERS | 2 - configure| 3 +- doc/outdevs.texi | 66 --- libavdevice/Makefile | 1 - libavdevice/alldevices.c | 1 - libavdevice/sdl2.c | 370 --- 6 files changed, 1

[FFmpeg-devel] [PATCH 0/2] Remove SDL2 output devices

2024-02-04 Thread J. Dekker
With the addition of threading in ffmpeg.c, the SDL2 devices no longer have the 'main' thread. This means that both the SDL2 and OpenGL output device are broken in master. Rather than attempting to fix it, they should be removed instead as there are better alternatives for debugging or viewing