Re: [FFmpeg-devel] [PATCH v1] libavfilter/af_channelsplit.c:fix memory leak

2024-04-14 Thread Zhao Zhili
> On Apr 12, 2024, at 17:49, Zhao Zhili wrote: > > >> On Apr 12, 2024, at 17:19, LuMingYin wrote: >> >> Signed-off-by: LuMingYin >> --- >> libavfilter/af_channelsplit.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/libavfilter/af_channelsplit.c

Re: [FFmpeg-devel] [PATCH] avformat/httpauth.c [support both RFC 2617 and RFC 7617]

2024-04-14 Thread 정지우 | Eugene
Hello, thank you for taking the time to review my code. I've made a new commit incorporating the code style improvements you suggested. This includes adding spaces before pointers, removing unnecessary comments, performing case-insensitive comparisons, applying consistent brace styles, and adding

[FFmpeg-devel] [PATCH] avformat/httpauth.c Support RFC7616 [Style fixed]

2024-04-14 Thread 정지우 | Eugene
Update digest authentication in httpauth.c - Refactor make_digest_auth() to support RFC 2617 and RFC 7617 - Add support for SHA-256 and SHA-512/256 algorithms along with MD5 - MD5 and SHA-256 tested, but SHA-512/256 untested due to lack of server - Replace AVMD5 structure with AVHashContext for

[FFmpeg-devel] [PATCH 3/3] lavc/vaapi_encode_av1: insert HDR_CLL metadata if have

2024-04-14 Thread Xiang, Haihao
From: Haihao Xiang Only look for HDR_CLL on key frame on the output. Signed-off-by: Haihao Xiang --- libavcodec/vaapi_encode_av1.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavcodec/vaapi_encode_av1.c b/libavcodec/vaapi_encode_av1.c index 4077d21202..b868f5b66a

[FFmpeg-devel] [PATCH 2/3] lavc/vaapi_encode_av1: Insert HDR_MDCV metadata if have

2024-04-14 Thread Xiang, Haihao
From: Haihao Xiang Only look for HDR_MDVC on key frame on the output. Signed-off-by: Haihao Xiang --- libavcodec/vaapi_encode_av1.c | 46 +++ 1 file changed, 46 insertions(+) diff --git a/libavcodec/vaapi_encode_av1.c b/libavcodec/vaapi_encode_av1.c index

[FFmpeg-devel] [PATCH 1/3] lavc/vaapi_encode_av1: implement write_extra_header callback

2024-04-14 Thread Xiang, Haihao
From: Haihao Xiang This can be used to insert a metadata OBU to the stream later. Signed-off-by: Haihao Xiang --- libavcodec/vaapi_encode_av1.c | 42 ++- 1 file changed, 41 insertions(+), 1 deletion(-) diff --git a/libavcodec/vaapi_encode_av1.c

Re: [FFmpeg-devel] [PATCH 1/3] lavfi/tonemap_vaapi: By default use bt709 for output frame

2024-04-14 Thread Xiang, Haihao
On Ma, 2024-03-18 at 16:12 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > By default don't use the color properties from input frame as output > frame properties when performing HDR to SDR conversion > > Signed-off-by: Haihao Xiang > --- >  doc/filters.texi   | 4 ++-- >  

Re: [FFmpeg-devel] [PATCH 1/3] lavfi: Add pad_vaapi filter

2024-04-14 Thread Xiang, Haihao
On Ma, 2024-03-18 at 14:06 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > Signed-off-by: Haihao Xiang > --- >  configure  |   1 + >  doc/filters.texi   |  77 ++ >  libavfilter/Makefile   |   1 + >  libavfilter/allfilters.c   |   1 + >  

Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/vaapi_decode: Use dynamic frame pool if possible

2024-04-14 Thread Xiang, Haihao
On Wo, 2024-04-10 at 11:01 +0800, Xiang, Haihao wrote: > From: Haihao Xiang > > libva2 doesn't require a fixed surface-array any more, so we may use > dynamic frame pool for decoding when libva2 is available, which allows a > downstream element stores more frames from VAAPI decoders and fixes

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/vaapi_encode_h264: use is_reference to fill reference_pic_flag

2024-04-14 Thread Xiang, Haihao
On Di, 2024-03-05 at 16:02 +0800, tong1.wu-at-intel@ffmpeg.org wrote: > From: Tong Wu > > This codec supports FLAG_B_PICTURE_REFERENCES. We need to correctly fill > the reference_pic_flag with is_reference variable instead of 0 for B > frames. > > Signed-off-by: Tong Wu > --- >  

Re: [FFmpeg-devel] [PATCH v3 1/2] lavc/vaapi_encode_h265: Map HEVC AV REXT profile to VA REXT profile

2024-04-14 Thread Xiang, Haihao
On Ma, 2024-03-18 at 12:21 +0800, fei.w.wang-at-intel@ffmpeg.org wrote: > From: Fei Wang > > There is no Main8/10 profile defined in HEVC REXT profiles. Use Main12 > which is compatible with 8/10bit. > > Signed-off-by: Fei Wang > --- >  libavcodec/vaapi_encode_h265.c | 4 ++-- >  1 file

Re: [FFmpeg-devel] [PATCH] vulkan_av1: add workaround for NVIDIA drivers tested on broken CTS

2024-04-14 Thread Lynne
Apr 14, 2024, 14:49 by d...@lynne.ee: > The first release of the CTS for AV1 decoding had incorrect > offsets for the OrderHints values. > The CTS will be fixed, and eventually, the drivers will be > updated to the proper spec-conforming behaviour, but we still > need to add a workaround as this

Re: [FFmpeg-devel] [RFC] Anyone using 6.0, 4.1, 3.4 ?

2024-04-14 Thread James Almer
On 4/14/2024 8:55 PM, Michael Niedermayer wrote: Hi I see nothing using 6.0 and 4.1 on our downstreams page, so i suggest to move 6.0 to the archieve page after 6.0.2 and 4.1 probably without new releases 4.1 is used by debian old-old-stable, so one last point release would not be unwelcome.

[FFmpeg-devel] [RFC] Anyone using 6.0, 4.1, 3.4 ?

2024-04-14 Thread Michael Niedermayer
Hi I see nothing using 6.0 and 4.1 on our downstreams page, so i suggest to move 6.0 to the archieve page after 6.0.2 and 4.1 probably without new releases About 3.4 ubuntu 18.04 last updated its FFmpeg 3.4 package 15 November 2023 sadly "apt changelog" doesnt seem to work with that package so

Re: [FFmpeg-devel] [PATCH] avcodec/vvc/ps: reset sps_id_used on PS uninit

2024-04-14 Thread James Almer
On 4/13/2024 7:18 AM, Frank Plowman wrote: On 09/04/2024 14:36, Nuo Mi wrote: On Mon, Apr 8, 2024 at 11:15 PM Frank Plowman wrote: On 08/04/2024 15:12, Nuo Mi wrote: On Mon, Apr 8, 2024 at 4:37 PM Frank Plowman wrote: On 07/04/2024 15:48, James Almer wrote: On 4/7/2024 10:38 AM, Nuo

Re: [FFmpeg-devel] [PATCH 4/5] avformat/mxfdec: Check index_edit_rate

2024-04-14 Thread Marton Balint
On Wed, 10 Apr 2024, Tomas Härdin wrote: tis 2024-04-09 klockan 22:58 +0200 skrev Marton Balint: On Tue, 9 Apr 2024, Tomas Härdin wrote: > mån 2024-04-08 klockan 21:46 +0200 skrev Marton Balint: > > > > > > On Mon, 8 Apr 2024, Tomas Härdin wrote: > > > > > tor 2024-04-04 klockan 00:51

Re: [FFmpeg-devel] [PATCH] avutil/opt: add AV_OPT_FLAG_FORCE_CONST

2024-04-14 Thread Timo Rothenpieler
On 14.04.2024 22:30, Marton Balint wrote: On Sun, 14 Apr 2024, Timo Rothenpieler wrote: --- doc/APIchanges  |  3 +++ libavutil/opt.c | 14 ++ libavutil/opt.h |  5 + libavutil/version.h |  2 +- 4 files changed, 23 insertions(+), 1 deletion(-) Where do you intend

Re: [FFmpeg-devel] [PATCH] avutil/opt: add AV_OPT_FLAG_FORCE_CONST

2024-04-14 Thread Marton Balint
On Sun, 14 Apr 2024, Timo Rothenpieler wrote: --- doc/APIchanges | 3 +++ libavutil/opt.c | 14 ++ libavutil/opt.h | 5 + libavutil/version.h | 2 +- 4 files changed, 23 insertions(+), 1 deletion(-) Where do you intend to use this flag? So some justification or

Re: [FFmpeg-devel] [PATCH v2 1/2] lavc/av1: Record reference ordering information for each frame

2024-04-14 Thread Mark Thompson
On 13/04/2024 20:05, Mark Thompson wrote: > This is needed by Vulkan.  Constructing this can't be delegated to CBS > because packets might contain multiple frames (when non-shown frames are > present) but we need separate snapshots immediately before each frame > for the decoder. > --- > Changes

[FFmpeg-devel] [PATCH] avutil/opt: add AV_OPT_FLAG_FORCE_CONST

2024-04-14 Thread Timo Rothenpieler
--- doc/APIchanges | 3 +++ libavutil/opt.c | 14 ++ libavutil/opt.h | 5 + libavutil/version.h | 2 +- 4 files changed, 23 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 63e7a47126..da2c87909b 100644 --- a/doc/APIchanges +++

Re: [FFmpeg-devel] [PATCH] libavdevice: Improve example in deprecation message for opengl and sdl

2024-04-14 Thread Nicolas George
Nicolas George (12024-04-14): > Either we find options to make ffplay display frames as fast as > possible, or we must document to the user that no adequate replacement > exists. Please add “-vf setpts=0”. It still has a little more latency than a built-in device, but at least the feature is not

Re: [FFmpeg-devel] [PATCH] libavdevice: Improve example in deprecation message for opengl and sdl

2024-04-14 Thread Nicolas George
Alexander Strasser via ffmpeg-devel (12024-04-14): > When piping ffmpeg into ffplay both programs write a status line in > the terminal. That causes flickering and invisibility of one or the > other status line. The suggestion of piping to ffplay to replace opengl is inadequate: the muxing, pipe,

[FFmpeg-devel] [PATCH] libavdevice: Improve example in deprecation message for opengl and sdl

2024-04-14 Thread Alexander Strasser via ffmpeg-devel
When piping ffmpeg into ffplay both programs write a status line in the terminal. That causes flickering and invisibility of one or the other status line. As compromise set ffplay log level to warning, so it doesn't show the status line. The user is usually testing ffmpeg command lines and

[FFmpeg-devel] [PATCH 6/6] avcodec/ac3enc: Avoid copying samples

2024-04-14 Thread Andreas Rheinhardt
Only the last 256 samples of each frame are used; the encoder currently uses a buffer for 1536 + 256 samples whose first 256 samples contain are the last 256 samples from the last frame and the next 1536 are the samples of the current frame. Yet since 238b2d4155d9779d770fccb3594076bb32742c82 all

[FFmpeg-devel] [PATCH 5/6] avcodec/ac3enc: Combine cpl_coord buffers

2024-04-14 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3enc.c | 12 ++-- libavcodec/ac3enc.h | 3 +-- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index eb878afc7b..71d3026d40 100644 --- a/libavcodec/ac3enc.c +++

[FFmpeg-devel] [PATCH 4/6] avcodec/ac3enc: Combine loops

2024-04-14 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3enc.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index 1ef670622a..eb878afc7b 100644 --- a/libavcodec/ac3enc.c +++ b/libavcodec/ac3enc.c @@ -2459,6

[FFmpeg-devel] [PATCH 3/6] avcodec/ac3enc: Avoid indirections, allocations of small arrays

2024-04-14 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3enc.c | 44 libavcodec/ac3enc.h | 22 +++--- 2 files changed, 15 insertions(+), 51 deletions(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index a3a05b3ac8..1ef670622a

[FFmpeg-devel] [PATCH 2/6] avcodec/ac3enc: Avoid allocation for mdct_window

2024-04-14 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3enc.c | 1 - libavcodec/ac3enc.h | 5 - libavcodec/ac3enc_fixed.c| 7 +-- libavcodec/ac3enc_float.c| 7 +-- libavcodec/ac3enc_template.c | 4 ++-- 5 files changed, 8 insertions(+), 16 deletions(-) diff

[FFmpeg-devel] [PATCH 1/6] avcodec/ac3enc: Avoid allocation for windowed_samples

2024-04-14 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3enc.c | 4 libavcodec/ac3enc.h | 7 ++- libavcodec/ac3enc_template.c | 12 +--- 3 files changed, 15 insertions(+), 8 deletions(-) diff --git a/libavcodec/ac3enc.c b/libavcodec/ac3enc.c index

[FFmpeg-devel] [PATCH] vulkan_av1: add workaround for NVIDIA drivers tested on broken CTS

2024-04-14 Thread Lynne
The first release of the CTS for AV1 decoding had incorrect offsets for the OrderHints values. The CTS will be fixed, and eventually, the drivers will be updated to the proper spec-conforming behaviour, but we still need to add a workaround as this will take months. Only NVIDIA use these values at