Thanks.
On Fri, Apr 12, 2024 at 6:05 AM Stefano Sabatini wrote:
> On date Wednesday 2024-04-10 16:46:55 -0700, ffmpeg-devel Mailing List
> wrote:
> > Sure, I thought these warnings were disabled while looking at codec2.c
> > Sorry for the bad merge of the doc.
>
> > From
Sure, I thought these warnings were disabled while looking at codec2.c
Sorry for the bad merge of the doc.
From 975040408f32431efc3fae0a0b8c048f02159515 Mon Sep 17 00:00:00 2001
From: Antoine SOULIER
Date: Thu, 4 Apr 2024 22:38:03 +
Subject: [PATCH] avformat/lc3: Add file format for
Sorry for that, I missed the rebasing.
I have followed your recommendations, and put the muxer/demuxer in the same
file.
Here is the patch:
>From f85989288a99130eb3583d5ae9c5bf441e961ed4 Mon Sep 17 00:00:00 2001
From: Antoine SOULIER
Date: Thu, 4 Apr 2024 22:38:03 +
Subject: [PATCH]
From: Antoine SOULIER
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for
test purpose. This is the format implemented here.
---
Changelog| 1 +
doc/muxers.texi | 6 ++
libavformat/Makefile | 2 +
libavformat/allformats.c | 2 +
From: Antoine SOULIER
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for
test purpose. This is the format implemented here.
---
Changelog| 1 +
doc/muxers.texi | 6 ++
libavformat/Makefile | 2 +
libavformat/allformats.c | 2 +
From: Antoine SOULIER
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for
test purpose. This is the format implemented here.
---
Changelog| 1 +
doc/muxers.texi | 6 ++
libavformat/Makefile | 2 +
libavformat/allformats.c | 2 +
From: Antoine SOULIER
Use the packet duration field to invalid last samples of the last frame.
---
libavcodec/liblc3dec.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/libavcodec/liblc3dec.c b/libavcodec/liblc3dec.c
index 90da28679b..d250ace38a 100644
---
.
On Thu, Apr 4, 2024, 9:30 AM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Antoine Soulier via ffmpeg-devel:
> > A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for
> > test purpose. This is the format implemented here.
> >
> &g
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for
test purpose. This is the format implemented here.
Signed-off-by: Antoine Soulier
---
Changelog| 1 +
doc/muxers.texi | 6 ++
libavformat/Makefile | 2 +
libavformat/allformats.c | 2 +
The LC3 audio codec is the default codec of Bluetooth LE audio.
This is a wrapper over the liblc3 library (https://github.com/google/liblc3).
Signed-off-by: Antoine Soulier
---
Changelog | 4 +
configure | 6 ++
doc/encoders.texi | 57 +++
f the encoder adds extra frames at the end).
On Sat, Mar 30, 2024 at 4:46 AM Paul B Mahol wrote:
>
>
> On Fri, Mar 29, 2024 at 6:30 PM Antoine Soulier via ffmpeg-devel <
> ffmpeg-devel@ffmpeg.org> wrote:
>
>> A file format is described in Bluetooth SIG LC3 and ETSI T
With free licensed code, I don't think that will happen; the core algorithm
is the same.
LC3 is like a subset of LC3plus, but also adds 7.5ms frame duration.
I acknowledged the use of only one Codec Id, because it makes sense to me
to distinguish both as different profiles / feature sets.
You're right, I was not aware at all.
I have pushed a patch that does the job.
PTAL, thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for
test purpose. This is the format implemented here.
Signed-off-by: Antoine Soulier
---
Changelog| 1 +
doc/muxers.texi | 6 ++
libavformat/Makefile | 2 +
libavformat/allformats.c | 2 +
The LC3 audio codec is the default codec of Bluetooth LE audio.
This is a wrapper over the liblc3 library (https://github.com/google/liblc3).
Signed-off-by: Antoine Soulier
---
Changelog | 4 +
configure | 6 ++
doc/encoders.texi | 57
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for
test purpose. This is the format implemented here.
Signed-off-by: Antoine Soulier
---
Changelog| 1 +
doc/muxers.texi | 6 ++
libavformat/Makefile | 2 +
libavformat/allformats.c | 2 +
The LC3 audio codec is the default codec of Bluetooth LE audio.
This is a wrapper over the liblc3 library (https://github.com/google/liblc3).
Signed-off-by: Antoine Soulier
---
Changelog | 4 +
configure | 6 ++
doc/encoders.texi | 57
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for
test purpose. This is the format implemented here.
Signed-off-by: Antoine Soulier
---
Changelog| 1 +
doc/muxers.texi | 6 ++
libavformat/Makefile | 2 +
libavformat/allformats.c | 2 +
The LC3 audio codec is the default codec of Bluetooth LE audio.
This is a wrapper over the liblc3 library (https://github.com/google/liblc3).
Signed-off-by: Antoine Soulier
---
Changelog | 4 +
configure | 6 ++
doc/encoders.texi | 57
ports seeking.
>
> The proposed solution here is sub-optimal.
>
> On Wed, Mar 27, 2024 at 11:22 PM Antoine Soulier via ffmpeg-devel <
> ffmpeg-devel@ffmpeg.org> wrote:
>
>> A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for
>> test purpose.
Signed-off-by: Antoine Soulier
---
Changelog | 1 +
1 file changed, 1 insertion(+)
diff --git a/Changelog b/Changelog
index 934241a965..2282f8ca76 100644
--- a/Changelog
+++ b/Changelog
@@ -37,6 +37,7 @@ version :
- Support PacketTypeMetadata of PacketType in enhanced flv format
- ffplay with
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for
test purpose. This is the format implemented here.
Signed-off-by: Antoine Soulier
---
doc/muxers.texi | 6 ++
libavformat/Makefile | 2 +
libavformat/allformats.c | 2 +
libavformat/lc3dec.c | 135
The LC3 audio codec is the default codec of Bluetooth LE audio.
This is a wrapper over the liblc3 library (https://github.com/google/liblc3).
Signed-off-by: Antoine Soulier
---
doc/encoders.texi | 57
doc/general_contents.texi | 11 ++-
libavcodec/Makefile | 2 +
Signed-off-by: Antoine Soulier
---
configure | 6 ++
1 file changed, 6 insertions(+)
diff --git a/configure b/configure
index 2a1d22310b..4262b96117 100755
--- a/configure
+++ b/configure
@@ -244,6 +244,7 @@ External library support:
--enable-libjxl enable JPEG XL de/encoding
>
> Does this function do anything else than frame_us * srate_hz / 1000?
Also check the already validated parameters.
Yes, I can safely replace it with "av_scale()".
It seems that lc3 has a fixed blocksize. If so, you should use
> ff_get_encode_buffer().
Technically the codec allows you to
do you need to reset/free the encoder in case of failure? If this is
> the case you need to unset/free here or in the close function
Nothing to do with the encoder in case of failure. It just initializes the
given buffer, and returns it.
BTW, the only failure condition is bad parameters, already
Signed-off-by: Antoine Soulier
---
Changelog | 1 +
1 file changed, 1 insertion(+)
diff --git a/Changelog b/Changelog
index 934241a965..2282f8ca76 100644
--- a/Changelog
+++ b/Changelog
@@ -37,6 +37,7 @@ version :
- Support PacketTypeMetadata of PacketType in enhanced flv format
- ffplay with
Signed-off-by: Antoine Soulier
---
doc/encoders.texi | 57 +++
doc/general_contents.texi | 11 +++-
doc/muxers.texi | 6 +
3 files changed, 73 insertions(+), 1 deletion(-)
diff --git a/doc/encoders.texi b/doc/encoders.texi
index
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for
test purpose. This is the format implemented here.
Signed-off-by: Antoine Soulier
---
libavformat/Makefile | 2 +
libavformat/allformats.c | 2 +
libavformat/lc3dec.c | 137
The LC3 audio codec is the default codec of Bluetooth LE audio.
This is a wrapper over the liblc3 library (https://github.com/google/liblc3).
Signed-off-by: Antoine Soulier
---
libavcodec/Makefile | 2 +
libavcodec/allcodecs.c | 2 +
libavcodec/codec_desc.c | 7 ++
Signed-off-by: Antoine Soulier
---
configure | 6 ++
1 file changed, 6 insertions(+)
diff --git a/configure b/configure
index 2a1d22310b..4262b96117 100755
--- a/configure
+++ b/configure
@@ -244,6 +244,7 @@ External library support:
--enable-libjxl enable JPEG XL de/encoding
Mar 26, 2024 at 11:28 AM Andreas Rheinhardt <
andreas.rheinha...@outlook.com> wrote:
> Antoine Soulier via ffmpeg-devel:
> > The LC3 audio codec is the default codec of Bluetooth LE audio.
> > This is a wrapper over the liblc3 library (
> https://github.com/google/liblc3
Thanks for your review.
I am not sure to understand "1e3f might be replaced by a symbolic
constant/macro".
It's for a conversion from microseconds to milliseconds (standard unit used
for the frame duration).
It's not a magical constant, I do some greps and it looks like such
constant "1000.f" are
Compared with the C implementation of KissFFT (it's the only one I tested
on ARM M4).
Yes, there is no SIMD on x86. This was not the main target.
Was mainly made for ARM M4 (for BLE devices Nordic Semi / Zephyr), and ARM
Neon (Android).
By the way, this does not change a lot, the FFT/MDCT on
Arf, sorry for that. I used `git send-email -s`, perhaps it's the source of
the double signed-off.
On Tue, Mar 26, 2024 at 10:32 AM Stefano Sabatini
wrote:
> On date Tuesday 2024-03-26 16:47:35 +, ffmpeg-devel Mailing List wrote:
>
> > Signed-off-by: Antoine Soulier
> > Signed-off-by:
What do you mean by sub-optimal?
It's stacked by prime factors, and unrolled for FFT3 and FF5.
The butterfly implementations of FFT3 and FF5, gives me slightly slower
computation. FFT5 is done first, so it takes advantage of sin()/cos()
values of 0 or 1.
There are also no reordering steps (this
Signed-off-by: Antoine Soulier
Signed-off-by: Antoine SOULIER
---
Changelog | 1 +
1 file changed, 1 insertion(+)
diff --git a/Changelog b/Changelog
index c6e8f6bcaf..fb08ee2f81 100644
--- a/Changelog
+++ b/Changelog
@@ -2,6 +2,7 @@ Entries are sorted chronologically from oldest to youngest
Signed-off-by: Antoine Soulier
Signed-off-by: Antoine SOULIER
---
doc/encoders.texi | 57 +++
doc/general_contents.texi | 12 -
doc/muxers.texi | 4 +++
3 files changed, 72 insertions(+), 1 deletion(-)
diff --git
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for
test purpose. This is the format implemented here.
Signed-off-by: Antoine Soulier
Signed-off-by: Antoine SOULIER
---
libavformat/Makefile | 3 +
libavformat/allformats.c | 3 +
libavformat/lc3dec.c | 140
The LC3 audio codec is the default codec of Bluetooth LE audio.
This is a wrapper over the liblc3 library (https://github.com/google/liblc3).
Signed-off-by: Antoine Soulier
Signed-off-by: Antoine SOULIER
---
libavcodec/Makefile | 3 +
libavcodec/allcodecs.c | 3 +
Signed-off-by: Antoine Soulier
Signed-off-by: Antoine SOULIER
---
configure | 7 +++
1 file changed, 7 insertions(+)
diff --git a/configure b/configure
index 343edb38ab..eb8ff81a11 100755
--- a/configure
+++ b/configure
@@ -244,6 +244,7 @@ External library support:
--enable-libjxl
Signed-off-by: Antoine Soulier
Signed-off-by: Antoine SOULIER
---
MAINTAINERS | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index dd633f37e8..d07512fc0c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -188,6 +188,7 @@ Codecs:
libdavs2.c
Signed-off-by: Antoine Soulier
Signed-off-by: Antoine SOULIER
---
Changelog | 1 +
1 file changed, 1 insertion(+)
diff --git a/Changelog b/Changelog
index c6e8f6bcaf..fb08ee2f81 100644
--- a/Changelog
+++ b/Changelog
@@ -2,6 +2,7 @@ Entries are sorted chronologically from oldest to youngest
Signed-off-by: Antoine Soulier
Signed-off-by: Antoine SOULIER
---
configure | 7 +++
1 file changed, 7 insertions(+)
diff --git a/configure b/configure
index 343edb38ab..eb8ff81a11 100755
--- a/configure
+++ b/configure
@@ -244,6 +244,7 @@ External library support:
--enable-libjxl
Signed-off-by: Antoine Soulier
Signed-off-by: Antoine SOULIER
---
doc/encoders.texi | 57 +++
doc/general_contents.texi | 12 -
doc/muxers.texi | 4 +++
3 files changed, 72 insertions(+), 1 deletion(-)
diff --git
A file format is described in Bluetooth SIG LC3 and ETSI TS 103 634, for
test purpose. This is the format implemented here.
Signed-off-by: Antoine Soulier
Signed-off-by: Antoine SOULIER
---
libavformat/Makefile | 3 +
libavformat/allformats.c | 3 +
libavformat/lc3dec.c | 140
The LC3 audio codec is the default codec of Bluetooth LE audio.
This is a wrapper over the liblc3 library (https://github.com/google/liblc3).
Signed-off-by: Antoine Soulier
Signed-off-by: Antoine SOULIER
---
libavcodec/Makefile | 3 +
libavcodec/allcodecs.c | 3 +
47 matches
Mail list logo
